René's URL Explorer Experiment


Title: Update patchcheck upstream remote verification behavior by kattni · Pull Request #135806 · python/cpython · GitHub

Open Graph Title: Update patchcheck upstream remote verification behavior by kattni · Pull Request #135806 · python/cpython

X Title: Update patchcheck upstream remote verification behavior by kattni · Pull Request #135806 · python/cpython

Description: Currently, if you run patchcheck without a remote named upstream or origin, it fails with the following error: TypeError: can only concatenate str (not "NoneType") to str I ran into this during my first contribution, and it required viewing the source code for patchcheck to figure out what the issue was. To avoid this for others in the future, I have updated the patchcheck get_git_upstream_remote() method to be more robust. The following changes have been implemented: It now checks git remote -v. It looks for remote URLs that include python/cpython and (fetch). In the event that only one is found, it returns the name of that remote, regardless of the name. In the event that multiple options are found, it looks for upstream, origin, and python, in that order, and returns the first one it finds. In the event that none are found, it returns an informative error, including a link to the section of the Dev Guide relevant to creating an upstream remote, and lists the available fetch remotes. Discussed with @ncoghlan prior to submitting this PR.

Open Graph Description: Currently, if you run patchcheck without a remote named upstream or origin, it fails with the following error: TypeError: can only concatenate str (not "NoneType") to str I ran into this...

X Description: Currently, if you run patchcheck without a remote named upstream or origin, it fails with the following error: TypeError: can only concatenate str (not "NoneType") to str I ran i...

Opengraph URL: https://github.com/python/cpython/pull/135806

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2caf1a09-8487-a25a-48dd-67ec2412b3fe
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id995E:380435:EDDABF:12BD581:6B0238C5
html-safe-nonce8c642aae41e44e529f08bffd21f3efe9cc629e420909e302da21b345979b8989
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OTVFOjM4MDQzNTpFRERBQkY6MTJCRDU4MTo2QjAyMzhDNSIsInZpc2l0b3JfaWQiOiIzNDY4OTM1MDkyNjYyMDU3MTU3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaccd23f6d41032053f8b0dd606fb69a159443c89215bfdfed2dbb0a9c88f04f3f4
hovercard-subject-tagpull_request:2609461052
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/135806/files
twitter:imagehttps://avatars.githubusercontent.com/u/7865090?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/7865090?s=400&v=4
og:image:altCurrently, if you run patchcheck without a remote named upstream or origin, it fails with the following error: TypeError: can only concatenate str (not "NoneType") to str I ran into this...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/135806/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135806%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135806%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/135806/files
Reloadhttps://github.com/python/cpython/pull/135806/files
Reloadhttps://github.com/python/cpython/pull/135806/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ncoghlanhttps://github.com/ncoghlan
python:mainhttps://github.com/python/cpython/tree/main
kattni:update-patchcheck-remote-behaviorhttps://github.com/kattni/cpython/tree/update-patchcheck-remote-behavior
Conversation 6 https://github.com/python/cpython/pull/135806
Commits 3 https://github.com/python/cpython/pull/135806/commits
Checks 0 https://github.com/python/cpython/pull/135806/checks
Files changed 2 https://github.com/python/cpython/pull/135806/files
Update patchcheck upstream remote verification behavior https://github.com/python/cpython/pull/135806/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/135806/files
1423b68 Update patchcheck remote check behavior. kattni Jun 22, 2025 https://github.com/python/cpython/pull/135806/commits/1423b68ee243d6dfbca2ff7c5482c8c7204b4285
a26f332 Merge branch 'main' into update-patchcheck-remote-behavior kattni Jun 22, 2025 https://github.com/python/cpython/pull/135806/commits/a26f332d6b6ea8136fbf6f27fb731d5ae3661da6
e7f64ed Update ACKS ncoghlan Jun 22, 2025 https://github.com/python/cpython/pull/135806/commits/e7f64ed21fa6ac8632bacdf212a023b6e2c9f49d
Clear filters https://github.com/python/cpython/pull/135806/files
Please reload this pagehttps://github.com/python/cpython/pull/135806/files
Please reload this pagehttps://github.com/python/cpython/pull/135806/files
ACKS https://github.com/python/cpython/pull/135806/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
patchcheck.py https://github.com/python/cpython/pull/135806/files#diff-4c263270a6983ed3f357e3fb5c28352dd3e34d217a215b0319e3a6a26cf8d585
Misc/ACKShttps://github.com/python/cpython/pull/135806/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
View file https://github.com/kattni/cpython/blob/e7f64ed21fa6ac8632bacdf212a023b6e2c9f49d/Misc/ACKS
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/135806/{{ revealButtonHref }}
https://github.com/python/cpython/pull/135806/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
https://github.com/python/cpython/pull/135806/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L76
Tools/patchcheck/patchcheck.pyhttps://github.com/python/cpython/pull/135806/files#diff-4c263270a6983ed3f357e3fb5c28352dd3e34d217a215b0319e3a6a26cf8d585
View file https://github.com/kattni/cpython/blob/e7f64ed21fa6ac8632bacdf212a023b6e2c9f49d/Tools/patchcheck/patchcheck.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/135806/{{ revealButtonHref }}
https://github.com/python/cpython/pull/135806/files#diff-4c263270a6983ed3f357e3fb5c28352dd3e34d217a215b0319e3a6a26cf8d585
https://github.com/python/cpython/pull/135806/files#diff-4c263270a6983ed3f357e3fb5c28352dd3e34d217a215b0319e3a6a26cf8d585
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.