René's URL Explorer Experiment


Title: GH-90117: Check for `list` and `tuple` before `MappingView` in `pprint` by brandtbucher · Pull Request #135779 · python/cpython · GitHub

Open Graph Title: GH-90117: Check for `list` and `tuple` before `MappingView` in `pprint` by brandtbucher · Pull Request #135779 · python/cpython

X Title: GH-90117: Check for `list` and `tuple` before `MappingView` in `pprint` by brandtbucher · Pull Request #135779 · python/cpython

Description: GH-30135 added an expensive ABC subclass check for an uncommon case (MappingView) before fast subclass checks for 2 common cases (list and tuple), resulting in a ~10% performance regression for our pprint benchmarks. There's also some evidence that this may have also made our PGO profile worse on some builds, since test_pprint is part of the profiling task (so we're spending a good chunk of that time hitting the newly-added ABC subclass-checking machinery). This just switches the order of the branches so the cheap, common case is checked before the expensive, uncommon one. Issue: gh-90117

Open Graph Description: GH-30135 added an expensive ABC subclass check for an uncommon case (MappingView) before fast subclass checks for 2 common cases (list and tuple), resulting in a ~10% performance regression for our...

X Description: GH-30135 added an expensive ABC subclass check for an uncommon case (MappingView) before fast subclass checks for 2 common cases (list and tuple), resulting in a ~10% performance regression for our...

Opengraph URL: https://github.com/python/cpython/pull/135779

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2615c8c1-f825-a9f2-2bb5-f9b81502d4f3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9EFA:2463C6:6856A0:8B93FA:6B003721
html-safe-nonce46d1135ea58534568382f47b6293a668dd9bac2287c495a703815285cb6185ee
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RUZBOjI0NjNDNjo2ODU2QTA6OEI5M0ZBOjZCMDAzNzIxIiwidmlzaXRvcl9pZCI6IjYwMTQ4MDE3MzA3MzcyODg5OTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4623f97718f5161d8c43b50a9a633f737f314a2a4bd3456ce18aad99e6526aff
hovercard-subject-tagpull_request:2608606635
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/135779/files
twitter:imagehttps://avatars.githubusercontent.com/u/40968415?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40968415?s=400&v=4
og:image:altGH-30135 added an expensive ABC subclass check for an uncommon case (MappingView) before fast subclass checks for 2 common cases (list and tuple), resulting in a ~10% performance regression for our...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/135779/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135779%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135779%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/135779/files
Reloadhttps://github.com/python/cpython/pull/135779/files
Reloadhttps://github.com/python/cpython/pull/135779/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
brandtbucherhttps://github.com/brandtbucher
python:mainhttps://github.com/python/cpython/tree/main
brandtbucher:faster-pprinthttps://github.com/brandtbucher/cpython/tree/faster-pprint
Conversation 0 https://github.com/python/cpython/pull/135779
Commits 2 https://github.com/python/cpython/pull/135779/commits
Checks 0 https://github.com/python/cpython/pull/135779/checks
Files changed https://github.com/python/cpython/pull/135779/files
Please reload this pagehttps://github.com/python/cpython/pull/135779/files
GH-90117: Check for list and tuple before MappingView in pprint https://github.com/python/cpython/pull/135779/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/135779/files
ccfdf31 Check for lists and tuples before MappingViews brandtbucher Jun 17, 2025 https://github.com/python/cpython/pull/135779/commits/ccfdf31de01fa33b26346ca2aa1351204fe853a7
f5b35f4 blurb add brandtbucher Jun 21, 2025 https://github.com/python/cpython/pull/135779/commits/f5b35f418c2cbd130e0bcb7b5f7a730a12038dcd
Clear filters https://github.com/python/cpython/pull/135779/files
Please reload this pagehttps://github.com/python/cpython/pull/135779/files
Please reload this pagehttps://github.com/python/cpython/pull/135779/files
pprint.py https://github.com/python/cpython/pull/135779/files#diff-2de5df6eb7096f61fad8ce401b98985b3e0f1c0710f82120b52b94df45f753be
2025-06-20-17-06-59.gh-issue-90117.GYWVrn.rst https://github.com/python/cpython/pull/135779/files#diff-454a9daea2e72fbbfdacdd54e39bab2b9aaa7f954b6f5e2dd98e54da726fa015
Lib/pprint.pyhttps://github.com/python/cpython/pull/135779/files#diff-2de5df6eb7096f61fad8ce401b98985b3e0f1c0710f82120b52b94df45f753be
View file https://github.com/brandtbucher/cpython/blob/f5b35f418c2cbd130e0bcb7b5f7a730a12038dcd/Lib/pprint.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/135779/{{ revealButtonHref }}
https://github.com/python/cpython/pull/135779/files#diff-2de5df6eb7096f61fad8ce401b98985b3e0f1c0710f82120b52b94df45f753be
https://github.com/python/cpython/pull/135779/files#diff-2de5df6eb7096f61fad8ce401b98985b3e0f1c0710f82120b52b94df45f753be
https://github.com/python/cpython/pull/135779/files#diff-2de5df6eb7096f61fad8ce401b98985b3e0f1c0710f82120b52b94df45f753be
https://github.com/python/cpython/pull/135779/files#diff-2de5df6eb7096f61fad8ce401b98985b3e0f1c0710f82120b52b94df45f753be
Misc/NEWS.d/next/Library/2025-06-20-17-06-59.gh-issue-90117.GYWVrn.rsthttps://github.com/python/cpython/pull/135779/files#diff-454a9daea2e72fbbfdacdd54e39bab2b9aaa7f954b6f5e2dd98e54da726fa015
View file https://github.com/brandtbucher/cpython/blob/f5b35f418c2cbd130e0bcb7b5f7a730a12038dcd/Misc/NEWS.d/next/Library/2025-06-20-17-06-59.gh-issue-90117.GYWVrn.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/135779/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.