René's URL Explorer Experiment


Title: GH-90117: Check for `list` and `tuple` before `MappingView` in `pprint` by brandtbucher · Pull Request #135779 · python/cpython · GitHub

Open Graph Title: GH-90117: Check for `list` and `tuple` before `MappingView` in `pprint` by brandtbucher · Pull Request #135779 · python/cpython

X Title: GH-90117: Check for `list` and `tuple` before `MappingView` in `pprint` by brandtbucher · Pull Request #135779 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: GH-30135 added an expensive ABC subclass check for an uncommon case (MappingView) before fast subclass checks for 2 common cases (list and tuple), resulting in a ~10% performance regression for our...

X Description: GH-30135 added an expensive ABC subclass check for an uncommon case (MappingView) before fast subclass checks for 2 common cases (list and tuple), resulting in a ~10% performance regression for our...

Opengraph URL: https://github.com/python/cpython/pull/135779

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e70572f5-2a0d-f8f3-1f22-6bfa00140006
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB4C2:106F5D:5C76B0:7BF32C:6B0033D4
html-safe-noncec7cb859d47d8713141fe7897acbae7f2c1c88ceee0e67d837c574fc31a76f9ba
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNEMyOjEwNkY1RDo1Qzc2QjA6N0JGMzJDOjZCMDAzM0Q0IiwidmlzaXRvcl9pZCI6IjIyODc2Mjg3NzE5NjYwNzE3NjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca340257bbc3a696f80f5d005cc913595324840b585d0130a08050f91a9c7cd7c
hovercard-subject-tagpull_request:2608606635
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/135779/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f6ce638d64b8b7ff428e08e852e04c8a658fe9835f104bf3c668a1843a4fb3a7/python/cpython/pull/135779
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f6ce638d64b8b7ff428e08e852e04c8a658fe9835f104bf3c668a1843a4fb3a7/python/cpython/pull/135779
og:image:altGH-30135 added an expensive ABC subclass check for an uncommon case (MappingView) before fast subclass checks for 2 common cases (list and tuple), resulting in a ~10% performance regression for our...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebrandtbucher
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/135779#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135779
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135779
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/135779
Reloadhttps://github.com/python/cpython/pull/135779
Reloadhttps://github.com/python/cpython/pull/135779
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
brandtbucherhttps://github.com/brandtbucher
python:mainhttps://github.com/python/cpython/tree/main
brandtbucher:faster-pprinthttps://github.com/brandtbucher/cpython/tree/faster-pprint
Conversationhttps://github.com/python/cpython/pull/135779
Commits2 (2)https://github.com/python/cpython/pull/135779/commits
Checkshttps://github.com/python/cpython/pull/135779/checks
Files changedhttps://github.com/python/cpython/pull/135779/files
GH-90117: Check for list and tuple before MappingView in pprinthttps://github.com/python/cpython/pull/135779#top
brandtbucherhttps://github.com/brandtbucher
python:mainhttps://github.com/python/cpython/tree/main
brandtbucher:faster-pprinthttps://github.com/brandtbucher/cpython/tree/faster-pprint
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Jun 21, 2025https://github.com/python/cpython/pull/135779#issue-3164579613
Please reload this pagehttps://github.com/python/cpython/pull/135779
GH-30135https://github.com/python/cpython/pull/30135
~10% performance regressionhttps://github.com/faster-cpython/benchmarking-public/blob/main/results/bm-20250520-3.15.0a0-c7f8e70/bm-20250520-linux-x86_64-python-c7f8e706e116d7986da4-3.15.0a0-c7f8e70-vs-base.svg
Teach pprint about dict views #90117https://github.com/python/cpython/issues/90117
Please reload this pagehttps://github.com/python/cpython/pull/135779
brandtbucherhttps://github.com/brandtbucher
June 17, 2025 11:24https://github.com/python/cpython/pull/135779#commits-pushed-ccfdf31
https://github.com/brandtbucher
Check for lists and tuples before MappingViewshttps://github.com/python/cpython/pull/135779/commits/ccfdf31de01fa33b26346ca2aa1351204fe853a7
ccfdf31https://github.com/python/cpython/pull/135779/commits/ccfdf31de01fa33b26346ca2aa1351204fe853a7
https://github.com/brandtbucher
blurb addhttps://github.com/python/cpython/pull/135779/commits/f5b35f418c2cbd130e0bcb7b5f7a730a12038dcd
f5b35f4https://github.com/python/cpython/pull/135779/commits/f5b35f418c2cbd130e0bcb7b5f7a730a12038dcd
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
gpsheadhttps://github.com/gpshead
June 21, 2025 00:12https://github.com/python/cpython/pull/135779#event-18254752745
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Jun 21, 2025https://github.com/python/cpython/pull/135779#event-18254752766
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
performance https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Aperformance
stdlib https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astdlib
Jun 21, 2025https://github.com/python/cpython/pull/135779#event-18254752829
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 21, 2025https://github.com/python/cpython/pull/135779#event-18254753002
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jun 21, 2025 https://github.com/python/cpython/pull/135779#ref-issue-1199070375
Teach pprint about dict views #90117 https://github.com/python/cpython/issues/90117
https://github.com/tomasr8
tomasr8https://github.com/tomasr8
Jun 21, 2025 https://github.com/python/cpython/pull/135779#pullrequestreview-2947721502
View reviewed changes https://github.com/python/cpython/pull/135779/files/f5b35f418c2cbd130e0bcb7b5f7a730a12038dcd
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 21, 2025https://github.com/python/cpython/pull/135779#event-18256636601
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
ee0e22chttps://github.com/python/cpython/commit/ee0e22c088ce5483d4bacd5457d4feb5886bb58a
Jun 24, 2025https://github.com/python/cpython/pull/135779#event-18303121711
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jun 24, 2025https://github.com/python/cpython/pull/135779#event-18303122322
AndPuQinghttps://github.com/AndPuQing
Jul 11, 2025 https://github.com/python/cpython/pull/135779#ref-commit-f49487f
https://github.com/brandtbucher
https://github.com/AndPuQing
pythonGH-90117https://github.com/python/cpython/issues/90117
: Check for list and tuple before MappingView in pprint (https://github.com/AndPuQing/cpython/commit/f49487fdee69d19230a729af8089f77d337c16a2
…https://github.com/python/cpython/pull/135779
f49487fhttps://github.com/AndPuQing/cpython/commit/f49487fdee69d19230a729af8089f77d337c16a2
…pythonGH-135779https://github.com/python/cpython/pull/135779
Pranjal095https://github.com/Pranjal095
Jul 12, 2025 https://github.com/python/cpython/pull/135779#ref-commit-656168f
https://github.com/brandtbucher
https://github.com/Pranjal095
pythonGH-90117https://github.com/python/cpython/issues/90117
: Check for list and tuple before MappingView in pprint (https://github.com/Pranjal095/cpython/commit/656168fcb09f6982d8c8d15ed8cff84fc64f2c89
…https://github.com/python/cpython/pull/135779
656168fhttps://github.com/Pranjal095/cpython/commit/656168fcb09f6982d8c8d15ed8cff84fc64f2c89
…pythonGH-135779https://github.com/python/cpython/pull/135779
taegyunkimhttps://github.com/taegyunkim
Aug 4, 2025 https://github.com/python/cpython/pull/135779#ref-commit-163abc6
https://github.com/brandtbucher
https://github.com/taegyunkim
pythonGH-90117https://github.com/python/cpython/issues/90117
: Check for list and tuple before MappingView in pprint (https://github.com/taegyunkim/cpython/commit/163abc6dda66e6e75ef562ba0386753c75dbedef
…https://github.com/python/cpython/pull/135779
163abc6https://github.com/taegyunkim/cpython/commit/163abc6dda66e6e75ef562ba0386753c75dbedef
…pythonGH-135779https://github.com/python/cpython/pull/135779
Agent-Hellboyhttps://github.com/Agent-Hellboy
Aug 19, 2025 https://github.com/python/cpython/pull/135779#ref-commit-1cdfd9b
https://github.com/brandtbucher
https://github.com/Agent-Hellboy
pythonGH-90117https://github.com/python/cpython/issues/90117
: Check for list and tuple before MappingView in pprint (https://github.com/Agent-Hellboy/cpython/commit/1cdfd9b1c2a9403c6a387b1d4f407ba9c570699d
…https://github.com/python/cpython/pull/135779
1cdfd9bhttps://github.com/Agent-Hellboy/cpython/commit/1cdfd9b1c2a9403c6a387b1d4f407ba9c570699d
…pythonGH-135779https://github.com/python/cpython/pull/135779
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135779
https://github.com/tomasr8
tomasr8 https://github.com/tomasr8
https://github.com/python/cpython/pull/135779/files/f5b35f418c2cbd130e0bcb7b5f7a730a12038dcd
https://github.com/gpshead
gpshead https://github.com/gpshead
Please reload this pagehttps://github.com/python/cpython/pull/135779
https://github.com/brandtbucher
brandtbucher https://github.com/brandtbucher
performance https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Aperformance
stdlib https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astdlib
Please reload this pagehttps://github.com/python/cpython/pull/135779
https://github.com/brandtbucher
https://github.com/tomasr8
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.