René's URL Explorer Experiment


Title: gh-135532: simplify handling of HACL* errors in `_hmac` by picnixz · Pull Request #135740 · python/cpython · GitHub

Open Graph Title: gh-135532: simplify handling of HACL* errors in `_hmac` by picnixz · Pull Request #135740 · python/cpython

X Title: gh-135532: simplify handling of HACL* errors in `_hmac` by picnixz · Pull Request #135740 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: When I first wrote this module, I wanted to be as pedantic as possible. However, the code became overly complex and having a better traceback when getting Hacl_Streaming_Types_InvalidAlgorithm is n...

X Description: When I first wrote this module, I wanted to be as pedantic as possible. However, the code became overly complex and having a better traceback when getting Hacl_Streaming_Types_InvalidAlgorithm is n...

Opengraph URL: https://github.com/python/cpython/pull/135740

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:870543ff-1516-6d6d-2c26-7b021a7dab20
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9B40:19AA62:3AD6E15:4AABADA:6B01FDDC
html-safe-nonce4009de1ddb428ef703db065d7b3c1f4f40db4bf61f49cc66be39f61b0c11651c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QjQwOjE5QUE2MjozQUQ2RTE1OjRBQUJBREE6NkIwMUZEREMiLCJ2aXNpdG9yX2lkIjoiMTczMjE4MTA3ODQzODk2ODc5NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4f9d30b2cc936d40c95db301d1ae3650f2fcda7ae8ced69e3ab0a4c742b5a3eb
hovercard-subject-tagpull_request:2606574444
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/135740/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/44a2e66701f6ef497e170ba85028c7847e321f9966ab7b1f8aaa5d96f55eb5ea/python/cpython/pull/135740
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/44a2e66701f6ef497e170ba85028c7847e321f9966ab7b1f8aaa5d96f55eb5ea/python/cpython/pull/135740
og:image:altWhen I first wrote this module, I wanted to be as pedantic as possible. However, the code became overly complex and having a better traceback when getting Hacl_Streaming_Types_InvalidAlgorithm is n...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepicnixz
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/135740#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135740
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135740
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/135740
Reloadhttps://github.com/python/cpython/pull/135740
Reloadhttps://github.com/python/cpython/pull/135740
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
picnixzhttps://github.com/picnixz
python:mainhttps://github.com/python/cpython/tree/main
picnixz:refactor/hmac/convert-hacl-errno-135532https://github.com/picnixz/cpython/tree/refactor/hmac/convert-hacl-errno-135532
Conversationhttps://github.com/python/cpython/pull/135740
Commits1 (1)https://github.com/python/cpython/pull/135740/commits
Checkshttps://github.com/python/cpython/pull/135740/checks
Files changedhttps://github.com/python/cpython/pull/135740/files
gh-135532: simplify handling of HACL* errors in _hmachttps://github.com/python/cpython/pull/135740#top
picnixzhttps://github.com/picnixz
python:mainhttps://github.com/python/cpython/tree/main
picnixz:refactor/hmac/convert-hacl-errno-135532https://github.com/picnixz/cpython/tree/refactor/hmac/convert-hacl-errno-135532
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Jun 20, 2025https://github.com/python/cpython/pull/135740#issue-3162324427
Please reload this pagehttps://github.com/python/cpython/pull/135740
Rewrite & cleanup HACL*-based extension modules #135532https://github.com/python/cpython/issues/135532
Please reload this pagehttps://github.com/python/cpython/pull/135740
https://github.com/picnixz
simplify _hacl_convert_errnohttps://github.com/python/cpython/pull/135740/commits/b7a132f498cac7d9cab41eccb775c22850994634
b7a132fhttps://github.com/python/cpython/pull/135740/commits/b7a132f498cac7d9cab41eccb775c22850994634
https://github.com/picnixz
picnixzhttps://github.com/picnixz
gpsheadhttps://github.com/gpshead
code ownerhttps://github.com/python/cpython/blob/b53b0c14da58b73955b8989e4a9ce19ea67db7a3/.github/CODEOWNERS#L118
June 20, 2025 08:11https://github.com/python/cpython/pull/135740#event-18241649956
https://github.com/picnixz
picnixzhttps://github.com/picnixz
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Jun 20, 2025https://github.com/python/cpython/pull/135740#event-18241649997
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 20, 2025https://github.com/python/cpython/pull/135740#event-18241650703
https://github.com/picnixz
picnixzhttps://github.com/picnixz
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 20, 2025https://github.com/python/cpython/pull/135740#event-18241650902
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jun 20, 2025 https://github.com/python/cpython/pull/135740#ref-issue-3147263747
Rewrite & cleanup HACL*-based extension modules #135532 https://github.com/python/cpython/issues/135532
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Jun 20, 2025https://github.com/python/cpython/pull/135740#issuecomment-2990230536
Please reload this pagehttps://github.com/python/cpython/pull/135740
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jun 20, 2025https://github.com/python/cpython/pull/135740#issuecomment-2990230651
@picnixzhttps://github.com/picnixz
b7a132fhttps://github.com/python/cpython/commit/b7a132f498cac7d9cab41eccb775c22850994634
https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135740%2Fmergehttps://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135740%2Fmerge
Please reload this pagehttps://github.com/python/cpython/pull/135740
https://github.com/picnixz
picnixzhttps://github.com/picnixz
2dbada1https://github.com/python/cpython/commit/2dbada179f1c7cfcfffceac4ac91902154b5a356
Jun 20, 2025https://github.com/python/cpython/pull/135740#event-18242395723
https://github.com/picnixz
picnixzhttps://github.com/picnixz
June 20, 2025 08:57https://github.com/python/cpython/pull/135740#event-18242397220
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Jun 20, 2025https://github.com/python/cpython/pull/135740#issuecomment-2990342820
@picnixzhttps://github.com/picnixz
Please reload this pagehttps://github.com/python/cpython/pull/135740
miss-islingtonhttps://github.com/miss-islington
Jun 20, 2025 https://github.com/python/cpython/pull/135740#ref-commit-fdad74d
https://github.com/picnixz
https://github.com/miss-islington
pythongh-135532https://github.com/python/cpython/issues/135532
: simplify handling of HACL* errors inhttps://github.com/miss-islington/cpython/commit/fdad74d74ceedec39e39c23a1e5397f4ecfbbaab
_hmachttps://github.com/miss-islington/cpython/commit/fdad74d74ceedec39e39c23a1e5397f4ecfbbaab
(https://github.com/miss-islington/cpython/commit/fdad74d74ceedec39e39c23a1e5397f4ecfbbaab
python…https://github.com/python/cpython/pull/135740
fdad74dhttps://github.com/miss-islington/cpython/commit/fdad74d74ceedec39e39c23a1e5397f4ecfbbaab
…GH-135740https://github.com/python/cpython/pull/135740
2dbada1https://github.com/miss-islington/cpython/commit/2dbada179f1c7cfcfffceac4ac91902154b5a356
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jun 20, 2025https://github.com/python/cpython/pull/135740#issuecomment-2990343545
GH-135743https://github.com/python/cpython/pull/135743
3.14 branchhttps://github.com/python/cpython/tree/3.14
Please reload this pagehttps://github.com/python/cpython/pull/135740
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
Jun 20, 2025https://github.com/python/cpython/pull/135740#event-18242400227
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jun 20, 2025https://github.com/python/cpython/pull/135740#issuecomment-2990376209
2dbada1https://github.com/python/cpython/commit/2dbada179f1c7cfcfffceac4ac91902154b5a356
the buildbot page in the devguidehttps://devguide.python.org/buildbots/
https://buildbot.python.org/#/builders/125/builds/7834https://buildbot.python.org/#/builders/125/builds/7834
2dbada1https://github.com/python/cpython/commit/2dbada179f1c7cfcfffceac4ac91902154b5a356
https://buildbot.python.org/#/builders/125/builds/7834https://buildbot.python.org/#/builders/125/builds/7834
Please reload this pagehttps://github.com/python/cpython/pull/135740
picnixzhttps://github.com/picnixz
Jun 20, 2025 https://github.com/python/cpython/pull/135740#ref-commit-d057cb4
https://github.com/miss-islington
https://github.com/picnixz
[3.14]https://github.com/python/cpython/commit/d057cb40ffb05c2b78c7af62d63b22fa586086b1
gh-135532https://github.com/python/cpython/issues/135532
: simplify handling of HACL* errors inhttps://github.com/python/cpython/commit/d057cb40ffb05c2b78c7af62d63b22fa586086b1
_hmachttps://github.com/python/cpython/commit/d057cb40ffb05c2b78c7af62d63b22fa586086b1
(https://github.com/python/cpython/commit/d057cb40ffb05c2b78c7af62d63b22fa586086b1
GH-13…https://github.com/python/cpython/pull/135740
d057cb4https://github.com/python/cpython/commit/d057cb40ffb05c2b78c7af62d63b22fa586086b1
…5740https://github.com/python/cpython/pull/135740
#135743https://github.com/python/cpython/pull/135743
gh-135532https://github.com/python/cpython/issues/135532
GH-135740https://github.com/python/cpython/pull/135740
2dbada1https://github.com/python/cpython/commit/2dbada179f1c7cfcfffceac4ac91902154b5a356
Pranjal095https://github.com/Pranjal095
Jul 12, 2025 https://github.com/python/cpython/pull/135740#ref-commit-7a55bd3
https://github.com/picnixz
https://github.com/Pranjal095
pythongh-135532https://github.com/python/cpython/issues/135532
: simplify handling of HACL* errors inhttps://github.com/Pranjal095/cpython/commit/7a55bd3900a441815fa8df09c2ab4d37c48ce83f
_hmachttps://github.com/Pranjal095/cpython/commit/7a55bd3900a441815fa8df09c2ab4d37c48ce83f
(https://github.com/Pranjal095/cpython/commit/7a55bd3900a441815fa8df09c2ab4d37c48ce83f
python…https://github.com/python/cpython/pull/135740
7a55bd3https://github.com/Pranjal095/cpython/commit/7a55bd3900a441815fa8df09c2ab4d37c48ce83f
…#135740https://github.com/python/cpython/pull/135740
taegyunkimhttps://github.com/taegyunkim
Aug 4, 2025 https://github.com/python/cpython/pull/135740#ref-commit-0a9b1bb
https://github.com/picnixz
https://github.com/taegyunkim
pythongh-135532https://github.com/python/cpython/issues/135532
: simplify handling of HACL* errors inhttps://github.com/taegyunkim/cpython/commit/0a9b1bb2caa96516b17e86d6d9076ab9267a9485
_hmachttps://github.com/taegyunkim/cpython/commit/0a9b1bb2caa96516b17e86d6d9076ab9267a9485
(https://github.com/taegyunkim/cpython/commit/0a9b1bb2caa96516b17e86d6d9076ab9267a9485
python…https://github.com/python/cpython/pull/135740
0a9b1bbhttps://github.com/taegyunkim/cpython/commit/0a9b1bb2caa96516b17e86d6d9076ab9267a9485
…#135740https://github.com/python/cpython/pull/135740
Agent-Hellboyhttps://github.com/Agent-Hellboy
Aug 19, 2025 https://github.com/python/cpython/pull/135740#ref-commit-100306b
https://github.com/picnixz
https://github.com/Agent-Hellboy
pythongh-135532https://github.com/python/cpython/issues/135532
: simplify handling of HACL* errors inhttps://github.com/Agent-Hellboy/cpython/commit/100306b67e08b0d3328a5974ce498849e0a7a5c9
_hmachttps://github.com/Agent-Hellboy/cpython/commit/100306b67e08b0d3328a5974ce498849e0a7a5c9
(https://github.com/Agent-Hellboy/cpython/commit/100306b67e08b0d3328a5974ce498849e0a7a5c9
python…https://github.com/python/cpython/pull/135740
100306bhttps://github.com/Agent-Hellboy/cpython/commit/100306b67e08b0d3328a5974ce498849e0a7a5c9
…#135740https://github.com/python/cpython/pull/135740
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135740
https://github.com/gpshead
gpshead https://github.com/gpshead
Please reload this pagehttps://github.com/python/cpython/pull/135740
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/135740
https://github.com/picnixz
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.