René's URL Explorer Experiment


Title: gh-135698: Fix Cross-interpreter Queue.full() With Negative/Default max_size by ericsnowcurrently · Pull Request #135724 · python/cpython · GitHub

Open Graph Title: gh-135698: Fix Cross-interpreter Queue.full() With Negative/Default max_size by ericsnowcurrently · Pull Request #135724 · python/cpython

X Title: gh-135698: Fix Cross-interpreter Queue.full() With Negative/Default max_size by ericsnowcurrently · Pull Request #135724 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: We weren't handling non-positive maxsize values (including the default) properly in Queue.full(). This change fixes that and adjusts an associated assert. Issue: Abort in _interpqueuesmodule...

X Description: We weren't handling non-positive maxsize values (including the default) properly in Queue.full(). This change fixes that and adjusts an associated assert. Issue: Abort in _interpqueuesmo...

Opengraph URL: https://github.com/python/cpython/pull/135724

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2df0ff9a-381b-2085-c6d8-b4171b5b82da
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDF60:A70A9:1ED7CC4:289C90C:6B0232F4
html-safe-nonce1fd4e74175e4dfbf6d009885537e94762f3fc6914cfdc1290cd8d86fb289e40a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjYwOkE3MEE5OjFFRDdDQzQ6Mjg5QzkwQzo2QjAyMzJGNCIsInZpc2l0b3JfaWQiOiI3NjYxMzY3NzAyMzk2NzQ0NDM3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac9b792b50b31cfb1950fca10a1fcf269ea58e136f7df081b58349cf1e6863b84b
hovercard-subject-tagpull_request:2605250203
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/135724/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8eff2d7a2de1136595da6bc7b2924b8edf6f51179336e374558c46c004362005/python/cpython/pull/135724
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8eff2d7a2de1136595da6bc7b2924b8edf6f51179336e374558c46c004362005/python/cpython/pull/135724
og:image:altWe weren't handling non-positive maxsize values (including the default) properly in Queue.full(). This change fixes that and adjusts an associated assert. Issue: Abort in _interpqueuesmodule...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameericsnowcurrently
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/135724#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135724
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135724
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/135724
Reloadhttps://github.com/python/cpython/pull/135724
Reloadhttps://github.com/python/cpython/pull/135724
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:mainhttps://github.com/python/cpython/tree/main
ericsnowcurrently:fix-queue-is-fullhttps://github.com/ericsnowcurrently/cpython/tree/fix-queue-is-full
Conversationhttps://github.com/python/cpython/pull/135724
Commits2 (2)https://github.com/python/cpython/pull/135724/commits
Checkshttps://github.com/python/cpython/pull/135724/checks
Files changedhttps://github.com/python/cpython/pull/135724/files
gh-135698: Fix Cross-interpreter Queue.full() With Negative/Default max_sizehttps://github.com/python/cpython/pull/135724#top
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:mainhttps://github.com/python/cpython/tree/main
ericsnowcurrently:fix-queue-is-fullhttps://github.com/ericsnowcurrently/cpython/tree/fix-queue-is-full
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Jun 19, 2025https://github.com/python/cpython/pull/135724#issue-3160805254
Please reload this pagehttps://github.com/python/cpython/pull/135724
Abort in _interpqueuesmodule due to queue being created with negative maxsize #135698https://github.com/python/cpython/issues/135698
Please reload this pagehttps://github.com/python/cpython/pull/135724
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
June 19, 2025 09:54https://github.com/python/cpython/pull/135724#commits-pushed-6d77dca
https://github.com/ericsnowcurrently
Test queue.full() with no max size.https://github.com/python/cpython/pull/135724/commits/6d77dcaed4f53c2166cb77c88930b7d12c74f4fb
6d77dcahttps://github.com/python/cpython/pull/135724/commits/6d77dcaed4f53c2166cb77c88930b7d12c74f4fb
https://github.com/ericsnowcurrently
Fix queues.is_full().https://github.com/python/cpython/pull/135724/commits/ca0c988f3e1f15a6fed396bab54bde2d2fa5ea6b
ca0c988https://github.com/python/cpython/pull/135724/commits/ca0c988f3e1f15a6fed396bab54bde2d2fa5ea6b
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
Jun 19, 2025https://github.com/python/cpython/pull/135724#event-18233323444
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 19, 2025https://github.com/python/cpython/pull/135724#event-18233323952
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jun 19, 2025 https://github.com/python/cpython/pull/135724#ref-issue-3158693719
Abort in _interpqueuesmodule due to queue being created with negative maxsize #135698 https://github.com/python/cpython/issues/135698
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Jun 19, 2025 https://github.com/python/cpython/pull/135724#ref-pullrequest-3159670111
gh-135698: Fix _interpqueues.create(): max_size >= 0 #135703 https://github.com/python/cpython/pull/135703
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
c5ea8e8https://github.com/python/cpython/commit/c5ea8e8e8fc725f39ed23ff6259b3cc157a0785f
Jun 20, 2025https://github.com/python/cpython/pull/135724#event-18253277453
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Jun 20, 2025https://github.com/python/cpython/pull/135724#issuecomment-2992701182
@ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Please reload this pagehttps://github.com/python/cpython/pull/135724
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 20, 2025https://github.com/python/cpython/pull/135724#event-18253277863
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
June 20, 2025 20:26https://github.com/python/cpython/pull/135724#event-18253278535
miss-islingtonhttps://github.com/miss-islington
Jun 20, 2025 https://github.com/python/cpython/pull/135724#ref-commit-22ad2f8
https://github.com/ericsnowcurrently
https://github.com/miss-islington
pythongh-135698https://github.com/python/cpython/issues/135698
: Fix Cross-interpreter Queue.full() With Negative/Def…https://github.com/miss-islington/cpython/commit/22ad2f869e6cd83612fd69dc0e8cb7ddaad0da04
22ad2f8https://github.com/miss-islington/cpython/commit/22ad2f869e6cd83612fd69dc0e8cb7ddaad0da04
pythongh-135724https://github.com/python/cpython/pull/135724
c5ea8e8https://github.com/miss-islington/cpython/commit/c5ea8e8e8fc725f39ed23ff6259b3cc157a0785f
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jun 20, 2025https://github.com/python/cpython/pull/135724#issuecomment-2992701402
GH-135775https://github.com/python/cpython/pull/135775
3.14 branchhttps://github.com/python/cpython/tree/3.14
Please reload this pagehttps://github.com/python/cpython/pull/135724
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Jun 20, 2025https://github.com/python/cpython/pull/135724#issuecomment-2992701418
@ericsnowcurrentlyhttps://github.com/ericsnowcurrently
cherry_pickerhttps://pypi.org/project/cherry-picker/
Please reload this pagehttps://github.com/python/cpython/pull/135724
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
Jun 20, 2025https://github.com/python/cpython/pull/135724#event-18253279378
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Jun 20, 2025https://github.com/python/cpython/pull/135724#event-18253279464
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Jun 20, 2025 https://github.com/python/cpython/pull/135724#ref-commit-35b90e8
https://github.com/miss-islington
https://github.com/ericsnowcurrently
[3.14]https://github.com/python/cpython/commit/35b90e8bec9cb93d10a8d08ee8c5af3096da8937
gh-135698https://github.com/python/cpython/issues/135698
: Fix Cross-interpreter Queue.full() With Negative/De…https://github.com/python/cpython/commit/35b90e8bec9cb93d10a8d08ee8c5af3096da8937
35b90e8https://github.com/python/cpython/commit/35b90e8bec9cb93d10a8d08ee8c5af3096da8937
gh-135775https://github.com/python/cpython/pull/135775
c5ea8e8https://github.com/python/cpython/commit/c5ea8e8e8fc725f39ed23ff6259b3cc157a0785f
gh-135724https://github.com/python/cpython/pull/135724
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Jun 20, 2025 https://github.com/python/cpython/pull/135724#ref-commit-efcecd9
https://github.com/ericsnowcurrently
pythongh-135698https://github.com/python/cpython/issues/135698
: Fix Cross-interpreter Queue.full() With Negative/Def…https://github.com/ericsnowcurrently/cpython/commit/efcecd93aaea089598722c013aa2f0523a7d2583
efcecd9https://github.com/ericsnowcurrently/cpython/commit/efcecd93aaea089598722c013aa2f0523a7d2583
pythongh-135724https://github.com/python/cpython/pull/135724
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Jun 20, 2025 https://github.com/python/cpython/pull/135724#ref-pullrequest-3164510318
[3.13] gh-135698: Fix Cross-interpreter Queue.full() With Negative/Default max_size #135778 https://github.com/python/cpython/pull/135778
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Jun 21, 2025 https://github.com/python/cpython/pull/135724#pullrequestreview-2947963215
View reviewed changes https://github.com/python/cpython/pull/135724/files/ca0c988f3e1f15a6fed396bab54bde2d2fa5ea6b
Modules/_interpqueuesmodule.chttps://github.com/python/cpython/pull/135724/files/ca0c988f3e1f15a6fed396bab54bde2d2fa5ea6b#diff-1ab0cbc8fae26c3998a1ce3a8ebc7d23759c881f33f783c9c5382b27e886e731
serhiy-storchakahttps://github.com/serhiy-storchaka
Jun 21, 2025https://github.com/python/cpython/pull/135724#discussion_r2160139436
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/135724
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Jun 23, 2025https://github.com/python/cpython/pull/135724#discussion_r2162395237
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/135724
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Jun 23, 2025 https://github.com/python/cpython/pull/135724#ref-commit-666795a
https://github.com/ericsnowcurrently
[3.13]https://github.com/python/cpython/commit/666795ae34ccb912127d47fd091dcf5513dff94c
gh-135698https://github.com/python/cpython/issues/135698
: Fix Cross-interpreter Queue.full() With Negative/De…https://github.com/python/cpython/commit/666795ae34ccb912127d47fd091dcf5513dff94c
666795ahttps://github.com/python/cpython/commit/666795ae34ccb912127d47fd091dcf5513dff94c
gh-135778https://github.com/python/cpython/pull/135778
c5ea8e8https://github.com/python/cpython/commit/c5ea8e8e8fc725f39ed23ff6259b3cc157a0785f
gh-135724https://github.com/python/cpython/pull/135724
Pranjal095https://github.com/Pranjal095
Jul 12, 2025 https://github.com/python/cpython/pull/135724#ref-commit-6096098
https://github.com/ericsnowcurrently
https://github.com/Pranjal095
pythongh-135698https://github.com/python/cpython/issues/135698
: Fix Cross-interpreter Queue.full() With Negative/Def…https://github.com/Pranjal095/cpython/commit/6096098ccb528ee84a2a09fe62a419ea6c4b536f
6096098https://github.com/Pranjal095/cpython/commit/6096098ccb528ee84a2a09fe62a419ea6c4b536f
pythongh-135724https://github.com/python/cpython/pull/135724
taegyunkimhttps://github.com/taegyunkim
Aug 4, 2025 https://github.com/python/cpython/pull/135724#ref-commit-725b6d3
https://github.com/ericsnowcurrently
https://github.com/taegyunkim
pythongh-135698https://github.com/python/cpython/issues/135698
: Fix Cross-interpreter Queue.full() With Negative/Def…https://github.com/taegyunkim/cpython/commit/725b6d33a3064982aac3efa50c95a6109aa0cf7a
725b6d3https://github.com/taegyunkim/cpython/commit/725b6d33a3064982aac3efa50c95a6109aa0cf7a
pythongh-135724https://github.com/python/cpython/pull/135724
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 14, 2025https://github.com/python/cpython/pull/135724#issuecomment-3189411364
@ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Please reload this pagehttps://github.com/python/cpython/pull/135724
https://github.com/encukou
encukouhttps://github.com/encukou
Aug 15, 2025https://github.com/python/cpython/pull/135724#issuecomment-3191257293
GH-135778https://github.com/python/cpython/pull/135778
Please reload this pagehttps://github.com/python/cpython/pull/135724
https://github.com/encukou
encukouhttps://github.com/encukou
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
Aug 15, 2025https://github.com/python/cpython/pull/135724#event-19174660918
Agent-Hellboyhttps://github.com/Agent-Hellboy
Aug 19, 2025 https://github.com/python/cpython/pull/135724#ref-commit-7208004
https://github.com/ericsnowcurrently
https://github.com/Agent-Hellboy
pythongh-135698https://github.com/python/cpython/issues/135698
: Fix Cross-interpreter Queue.full() With Negative/Def…https://github.com/Agent-Hellboy/cpython/commit/7208004cf07d8c8ffc63f2b1f8336bbc6717fe32
7208004https://github.com/Agent-Hellboy/cpython/commit/7208004cf07d8c8ffc63f2b1f8336bbc6717fe32
pythongh-135724https://github.com/python/cpython/pull/135724
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135724
https://github.com/serhiy-storchaka
serhiy-storchaka https://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/135724/files/ca0c988f3e1f15a6fed396bab54bde2d2fa5ea6b
Please reload this pagehttps://github.com/python/cpython/pull/135724
https://github.com/ericsnowcurrently
ericsnowcurrently https://github.com/ericsnowcurrently
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/135724
https://github.com/ericsnowcurrently
https://github.com/serhiy-storchaka
https://github.com/encukou
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.