René's URL Explorer Experiment


Title: gh-133982: Use implementation-specific open in test_fileio OtherFileTests by cmaloney · Pull Request #135364 · python/cpython · GitHub

Open Graph Title: gh-133982: Use implementation-specific open in test_fileio OtherFileTests by cmaloney · Pull Request #135364 · python/cpython

X Title: gh-133982: Use implementation-specific open in test_fileio OtherFileTests by cmaloney · Pull Request #135364 · python/cpython

Description: The tests around unicode filenames use both FileIO directly and open so kept using open for them / validates that unicode filenames passed through open() match behavior of FileIO called directly with an encoded name. For the append tests it looks like FileIO directly is closer to what was intended, there is test_io that has append tests around self.open directly, this is test_fileio so intent I think was to test FileIO directly. Issue: gh-133982

Open Graph Description: The tests around unicode filenames use both FileIO directly and open so kept using open for them / validates that unicode filenames passed through open() match behavior of FileIO called directly wi...

X Description: The tests around unicode filenames use both FileIO directly and open so kept using open for them / validates that unicode filenames passed through open() match behavior of FileIO called directly wi...

Opengraph URL: https://github.com/python/cpython/pull/135364

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:94b55ba9-6b51-a590-9af6-6710f588eabf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAD4C:238281:2C99B23:3C4CCE6:6A53BAD8
html-safe-noncea70109c7ca34ad27c0a549135eb0ae4122976eb69f74cd186addc58c5d9a247d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRDRDOjIzODI4MToyQzk5QjIzOjNDNENDRTY6NkE1M0JBRDgiLCJ2aXNpdG9yX2lkIjoiMTcyODYxNTI5MzQ5OTE5NDA3MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6bd1ce2d3c29bedcca66f5283abf9fecb8681db01a8bdb80d95ecf719e4ac7af
hovercard-subject-tagpull_request:2582399831
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/135364/files
twitter:imagehttps://avatars.githubusercontent.com/u/751088?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/751088?s=400&v=4
og:image:altThe tests around unicode filenames use both FileIO directly and open so kept using open for them / validates that unicode filenames passed through open() match behavior of FileIO called directly wi...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/135364/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135364%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135364%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/135364/files
Reloadhttps://github.com/python/cpython/pull/135364/files
Reloadhttps://github.com/python/cpython/pull/135364/files
Please reload this pagehttps://github.com/python/cpython/pull/135364/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/135364/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ZeroIntensityhttps://github.com/ZeroIntensity
python:mainhttps://github.com/python/cpython/tree/main
cmaloney:fileio_otherfiletestshttps://github.com/cmaloney/cpython/tree/fileio_otherfiletests
Conversation 12 https://github.com/python/cpython/pull/135364
Commits 2 https://github.com/python/cpython/pull/135364/commits
Checks 45 https://github.com/python/cpython/pull/135364/checks
Files changed 1 https://github.com/python/cpython/pull/135364/files
gh-133982: Use implementation-specific open in test_fileio OtherFileTests https://github.com/python/cpython/pull/135364/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/135364/files
9e705f1 gh-133982: Use implementation-specific open in test_fileio OtherFileT… cmaloney Jun 10, 2025 https://github.com/python/cpython/pull/135364/commits/9e705f184afece797cb183587ad6bc8f9d19976b
e69fba0 Merge branch 'main' into fileio_otherfiletests ZeroIntensity Jun 30, 2025 https://github.com/python/cpython/pull/135364/commits/e69fba0b76e3ad435f791c42e47f0532bc000c08
Clear filters https://github.com/python/cpython/pull/135364/files
Please reload this pagehttps://github.com/python/cpython/pull/135364/files
Please reload this pagehttps://github.com/python/cpython/pull/135364/files
Lib/test/test_fileio.pyhttps://github.com/python/cpython/pull/135364/files#diff-9e4e996538d19d31fb952db09daf88fc86a89ad514956236de114ad1d3fff0dd
View file https://github.com/cmaloney/cpython/blob/e69fba0b76e3ad435f791c42e47f0532bc000c08/Lib/test/test_fileio.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/135364/{{ revealButtonHref }}
https://github.com/python/cpython/pull/135364/files#diff-9e4e996538d19d31fb952db09daf88fc86a89ad514956236de114ad1d3fff0dd
https://github.com/python/cpython/pull/135364/files#diff-9e4e996538d19d31fb952db09daf88fc86a89ad514956236de114ad1d3fff0dd
https://github.com/python/cpython/pull/135364/files#diff-9e4e996538d19d31fb952db09daf88fc86a89ad514956236de114ad1d3fff0dd
https://github.com/python/cpython/pull/135364/files#diff-9e4e996538d19d31fb952db09daf88fc86a89ad514956236de114ad1d3fff0dd
https://github.com/python/cpython/pull/135364/files#diff-9e4e996538d19d31fb952db09daf88fc86a89ad514956236de114ad1d3fff0dd
https://github.com/python/cpython/pull/135364/files#diff-9e4e996538d19d31fb952db09daf88fc86a89ad514956236de114ad1d3fff0dd
https://github.com/python/cpython/pull/135364/files#diff-9e4e996538d19d31fb952db09daf88fc86a89ad514956236de114ad1d3fff0dd
https://github.com/python/cpython/pull/135364/files#diff-9e4e996538d19d31fb952db09daf88fc86a89ad514956236de114ad1d3fff0dd
Please reload this pagehttps://github.com/python/cpython/pull/135364/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.