René's URL Explorer Experiment


Title: [3.14] gh-116738: Make _heapq module thread-safe (GH-135036) by miss-islington · Pull Request #135309 · python/cpython · GitHub

Open Graph Title: [3.14] gh-116738: Make _heapq module thread-safe (GH-135036) by miss-islington · Pull Request #135309 · python/cpython

X Title: [3.14] gh-116738: Make _heapq module thread-safe (GH-135036) by miss-islington · Pull Request #135309 · python/cpython

Description: Use critical sections to make heapq methods that update the heap thread-safe when the GIL is disabled. (cherry picked from commit a58026a) Co-authored-by: Alper alperyoney@fb.com Co-authored-by: mpage mpage@meta.com Issue: gh-116738

Open Graph Description: Use critical sections to make heapq methods that update the heap thread-safe when the GIL is disabled. (cherry picked from commit a58026a) Co-authored-by: Alper alperyoney@fb.com Co-authored-by: m...

X Description: Use critical sections to make heapq methods that update the heap thread-safe when the GIL is disabled. (cherry picked from commit a58026a) Co-authored-by: Alper alperyoney@fb.com Co-authored-by: m...

Opengraph URL: https://github.com/python/cpython/pull/135309

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e88adf1b-c909-233f-a1e7-8309428af6e2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB05E:31006B:1279F56:18BD103:696AD88A
html-safe-nonce1ba59b7c841e77fa7a958642730c618222a5361454bfa1164801d11e4a75d14a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDVFOjMxMDA2QjoxMjc5RjU2OjE4QkQxMDM6Njk2QUQ4OEEiLCJ2aXNpdG9yX2lkIjoiNDcwNzExNDkzMjE3ODE4MDIzNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb30e255a33501f7336f014480d8ece91234e1b7cf014be852ad9ab66c62202de
hovercard-subject-tagpull_request:2579062802
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/135309/files
twitter:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
og:image:altUse critical sections to make heapq methods that update the heap thread-safe when the GIL is disabled. (cherry picked from commit a58026a) Co-authored-by: Alper alperyoney@fb.com Co-authored-by: m...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release524a93f2c1f36522a3b4be4c110467ee4172245d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/135309/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135309%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135309%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/135309/files
Reloadhttps://github.com/python/cpython/pull/135309/files
Reloadhttps://github.com/python/cpython/pull/135309/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/135309/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/135309/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
colesburyhttps://github.com/colesbury
python:3.14https://github.com/python/cpython/tree/3.14
miss-islington:backport-a58026a-3.14https://github.com/miss-islington/cpython/tree/backport-a58026a-3.14
Conversation 0 https://github.com/python/cpython/pull/135309
Commits 1 https://github.com/python/cpython/pull/135309/commits
Checks 46 https://github.com/python/cpython/pull/135309/checks
Files changed 4 https://github.com/python/cpython/pull/135309/files
[3.14] gh-116738: Make _heapq module thread-safe (GH-135036) https://github.com/python/cpython/pull/135309/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/135309/files
cece3b8 gh-116738: Make _heapq module thread-safe (GH-135036) yoney Jun 9, 2025 https://github.com/python/cpython/pull/135309/commits/cece3b878ccdd7dee96a8499518b7f7e9d3a9958
Clear filters https://github.com/python/cpython/pull/135309/files
Please reload this pagehttps://github.com/python/cpython/pull/135309/files
Please reload this pagehttps://github.com/python/cpython/pull/135309/files
test_heapq.py https://github.com/python/cpython/pull/135309/files#diff-8ab1a596991d49a57e651a9df3754493a733c5ae44bf31154824eb886bbad9ba
2025-06-02-13-57-40.gh-issue-116738.ycJsL8.rst https://github.com/python/cpython/pull/135309/files#diff-d6a47781375121615cdd8290388351214726039f1990b1247689a0bd542152df
_heapqmodule.c https://github.com/python/cpython/pull/135309/files#diff-034663931c4f60e79a35df8dd3ccfd52dd3e8b89cc4ba85b70b68ef8b5bcee59
_heapqmodule.c.h https://github.com/python/cpython/pull/135309/files#diff-99142925c7d0d63af91ea8230ea4304c253fc4b24a37ba5d1a74f41ca79b14f6
https://github.com/python/cpython/blob/3.14/.github/CODEOWNERS#L245
Lib/test/test_free_threading/test_heapq.pyhttps://github.com/python/cpython/pull/135309/files#diff-8ab1a596991d49a57e651a9df3754493a733c5ae44bf31154824eb886bbad9ba
View file https://github.com/miss-islington/cpython/blob/cece3b878ccdd7dee96a8499518b7f7e9d3a9958/Lib/test/test_free_threading/test_heapq.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/135309/{{ revealButtonHref }}
Misc/NEWS.d/next/Core_and_Builtins/2025-06-02-13-57-40.gh-issue-116738.ycJsL8.rsthttps://github.com/python/cpython/pull/135309/files#diff-d6a47781375121615cdd8290388351214726039f1990b1247689a0bd542152df
View file https://github.com/miss-islington/cpython/blob/cece3b878ccdd7dee96a8499518b7f7e9d3a9958/Misc/NEWS.d/next/Core_and_Builtins/2025-06-02-13-57-40.gh-issue-116738.ycJsL8.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/135309/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/135309/files
Please reload this pagehttps://github.com/python/cpython/pull/135309/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.