René's URL Explorer Experiment


Title: [3.14] gh-116738: Make _heapq module thread-safe (GH-135036) by miss-islington · Pull Request #135309 · python/cpython · GitHub

Open Graph Title: [3.14] gh-116738: Make _heapq module thread-safe (GH-135036) by miss-islington · Pull Request #135309 · python/cpython

X Title: [3.14] gh-116738: Make _heapq module thread-safe (GH-135036) by miss-islington · Pull Request #135309 · python/cpython

Description: Use critical sections to make heapq methods that update the heap thread-safe when the GIL is disabled. (cherry picked from commit a58026a) Co-authored-by: Alper alperyoney@fb.com Co-authored-by: m...

Open Graph Description: Use critical sections to make heapq methods that update the heap thread-safe when the GIL is disabled. (cherry picked from commit a58026a) Co-authored-by: Alper alperyoney@fb.com Co-authored-by: m...

X Description: Use critical sections to make heapq methods that update the heap thread-safe when the GIL is disabled. (cherry picked from commit a58026a) Co-authored-by: Alper alperyoney@fb.com Co-authored-by: m...

Mail addresses
alperyoney@fb.com
mpage@meta.com

Opengraph URL: https://github.com/python/cpython/pull/135309

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1830abbf-41cb-9763-0e32-eda85461dc36
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAEFC:30E6E5:1BAA374:25D7EFE:696ABB60
html-safe-nonce90acb70fd57d312d9662acd3fb19d94508d4ca094ab2e755cacdd4388a1908e9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRUZDOjMwRTZFNToxQkFBMzc0OjI1RDdFRkU6Njk2QUJCNjAiLCJ2aXNpdG9yX2lkIjoiNzcxOTk4OTUxNzcxOTYxNjM1MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3177c7ecc71056064b933f1af271d1a7c142da9a3bd647c117afe432a43d8285
hovercard-subject-tagpull_request:2579062802
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/135309/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0ce3efe9675a8c57ad5b8ef71ac3266c8e470ff9fe348b0832b3e8585fd33269/python/cpython/pull/135309
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0ce3efe9675a8c57ad5b8ef71ac3266c8e470ff9fe348b0832b3e8585fd33269/python/cpython/pull/135309
og:image:altUse critical sections to make heapq methods that update the heap thread-safe when the GIL is disabled. (cherry picked from commit a58026a) Co-authored-by: Alper alperyoney@fb.com Co-authored-by: m...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemiss-islington
hostnamegithub.com
expected-hostnamegithub.com
None46ce962e0e18113ea447391b6ace8b02d4d2861e57b4fbab3658698f73d8855b
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release30300f30bb3949de255e84a146706a3bdb5c19c9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/135309#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135309
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135309
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/135309
Reloadhttps://github.com/python/cpython/pull/135309
Reloadhttps://github.com/python/cpython/pull/135309
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/135309
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/135309
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/135309#issue-comment-box
colesburyhttps://github.com/colesbury
python:3.14https://github.com/python/cpython/tree/3.14
miss-islington:backport-a58026a-3.14https://github.com/miss-islington/cpython/tree/backport-a58026a-3.14
[3.14] gh-116738: Make _heapq module thread-safe (GH-135036) https://github.com/python/cpython/pull/135309#top
colesburyhttps://github.com/colesbury
python:3.14https://github.com/python/cpython/tree/3.14
miss-islington:backport-a58026a-3.14https://github.com/miss-islington/cpython/tree/backport-a58026a-3.14
Conversation 0 https://github.com/python/cpython/pull/135309
Commits 1 https://github.com/python/cpython/pull/135309/commits
Checks 46 https://github.com/python/cpython/pull/135309/checks
Files changed 4 https://github.com/python/cpython/pull/135309/files
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Jun 9, 2025https://github.com/python/cpython/pull/135309#issue-3131029730
Please reload this pagehttps://github.com/python/cpython/pull/135309
a58026ahttps://github.com/python/cpython/commit/a58026a5e3da9ca2d09ef51aa90fe217f9a975ec
Audit all built-in modules for thread safety #116738https://github.com/python/cpython/issues/116738
Please reload this pagehttps://github.com/python/cpython/pull/135309
https://github.com/yoney
https://github.com/mpage
https://github.com/miss-islington
pythongh-116738https://github.com/python/cpython/issues/116738
: Make _heapq module thread-safe (https://github.com/python/cpython/pull/135309/commits/cece3b878ccdd7dee96a8499518b7f7e9d3a9958
pythonGH-135036https://github.com/python/cpython/pull/135036
)https://github.com/python/cpython/pull/135309/commits/cece3b878ccdd7dee96a8499518b7f7e9d3a9958
cece3b8https://github.com/python/cpython/pull/135309/commits/cece3b878ccdd7dee96a8499518b7f7e9d3a9958
a58026ahttps://github.com/miss-islington/cpython/commit/a58026a5e3da9ca2d09ef51aa90fe217f9a975ec
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
rhettingerhttps://github.com/rhettinger
code ownerhttps://github.com/python/cpython/blob/8b35651853e8dec10d8a227f52a49ddd1a748904/.github/CODEOWNERS#L239
June 9, 2025 17:57https://github.com/python/cpython/pull/135309#event-18060029332
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jun 9, 2025https://github.com/python/cpython/pull/135309#event-18060030759
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jun 9, 2025 https://github.com/python/cpython/pull/135309#ref-pullrequest-3110774884
gh-116738: Make _heapq module thread-safe #135036 https://github.com/python/cpython/pull/135036
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
topic-free-threading https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-free-threading
Jun 9, 2025https://github.com/python/cpython/pull/135309#event-18060031377
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jun 9, 2025 https://github.com/python/cpython/pull/135309#ref-issue-2184479275
Audit all built-in modules for thread safety #116738 https://github.com/python/cpython/issues/116738
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Jun 16, 2025 https://github.com/python/cpython/pull/135309#pullrequestreview-2932929271
View reviewed changes https://github.com/python/cpython/pull/135309/files/cece3b878ccdd7dee96a8499518b7f7e9d3a9958
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jun 16, 2025https://github.com/python/cpython/pull/135309#event-18175066767
https://github.com/colesbury
colesburyhttps://github.com/colesbury
964c29dhttps://github.com/python/cpython/commit/964c29d28137bc9cd4ad011c1da8bc5ca127eaa3
Jun 16, 2025https://github.com/python/cpython/pull/135309#event-18175072418
Please reload this pagehttps://github.com/python/cpython/pull/135309
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jun 16, 2025https://github.com/python/cpython/pull/135309#event-18175073118
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
January 2, 2026 18:05https://github.com/python/cpython/pull/135309#event-21830318631
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135309
https://github.com/colesbury
colesbury https://github.com/colesbury
https://github.com/python/cpython/pull/135309/files/cece3b878ccdd7dee96a8499518b7f7e9d3a9958
https://github.com/rhettinger
rhettinger https://github.com/rhettinger
topic-free-threading https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-free-threading
Please reload this pagehttps://github.com/python/cpython/pull/135309
https://github.com/miss-islington
https://github.com/colesbury
https://github.com/yoney
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.