René's URL Explorer Experiment


Title: [3.14] GH-135171: Fix generator expressions one last time (hopefully) by markshannon · Pull Request #135225 · python/cpython · GitHub

Open Graph Title: [3.14] GH-135171: Fix generator expressions one last time (hopefully) by markshannon · Pull Request #135225 · python/cpython

X Title: [3.14] GH-135171: Fix generator expressions one last time (hopefully) by markshannon · Pull Request #135225 · python/cpython

Description: This PR adds a NULL check for tp_iternext to FOR_ITER to prevent the crash in #125038. It then moves GET_ITER back to generation expression creation, thus fixing #135171 and avoids re-introducing #...

Open Graph Description: This PR adds a NULL check for tp_iternext to FOR_ITER to prevent the crash in #125038. It then moves GET_ITER back to generation expression creation, thus fixing #135171 and avoids re-introducing #...

X Description: This PR adds a NULL check for tp_iternext to FOR_ITER to prevent the crash in #125038. It then moves GET_ITER back to generation expression creation, thus fixing #135171 and avoids re-introducing #...

Opengraph URL: https://github.com/python/cpython/pull/135225

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fb47bd55-ac70-8e55-d7d9-021019b85e2e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBFFC:1B7E6F:2085DDD:2CA45A5:696AB78D
html-safe-nonce479cef1ec44e7cf6038ac3d73e4c6b1f161cf458ad322fb13d65f3c26e453ef7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRkZDOjFCN0U2RjoyMDg1REREOjJDQTQ1QTU6Njk2QUI3OEQiLCJ2aXNpdG9yX2lkIjoiNDc1MDg0NzY0MDgzODI4NjIxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace2271196a3f781a1b6b58c06324ddf14831b5c241f9d3e301aa62ac72e1b14fa
hovercard-subject-tagpull_request:2574043940
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/135225/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a387c289ed2e6ef7e8769b183619de2b90cf6b5fbf84c5b3837fd860dca1b9d3/python/cpython/pull/135225
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a387c289ed2e6ef7e8769b183619de2b90cf6b5fbf84c5b3837fd860dca1b9d3/python/cpython/pull/135225
og:image:altThis PR adds a NULL check for tp_iternext to FOR_ITER to prevent the crash in #125038. It then moves GET_ITER back to generation expression creation, thus fixing #135171 and avoids re-introducing #...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemarkshannon
hostnamegithub.com
expected-hostnamegithub.com
None4fa1799b6a53c2d30c950d74230781bef9e7f61138c72c7727e4b83f0743752b
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release41f276818bd204c4a30a0281fb3c576298d9474c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/135225#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135225
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135225
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/135225
Reloadhttps://github.com/python/cpython/pull/135225
Reloadhttps://github.com/python/cpython/pull/135225
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/135225
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/135225
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/135225#issue-comment-box
markshannonhttps://github.com/markshannon
python:3.14https://github.com/python/cpython/tree/3.14
faster-cpython:fix-gen-expr-yet-againhttps://github.com/faster-cpython/cpython/tree/fix-gen-expr-yet-again
[3.14] GH-135171: Fix generator expressions one last time (hopefully) https://github.com/python/cpython/pull/135225#top
markshannonhttps://github.com/markshannon
python:3.14https://github.com/python/cpython/tree/3.14
faster-cpython:fix-gen-expr-yet-againhttps://github.com/faster-cpython/cpython/tree/fix-gen-expr-yet-again
Conversation 8 https://github.com/python/cpython/pull/135225
Commits 6 https://github.com/python/cpython/pull/135225/commits
Checks 63 https://github.com/python/cpython/pull/135225/checks
Files changed https://github.com/python/cpython/pull/135225/files
Please reload this pagehttps://github.com/python/cpython/pull/135225
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/markshannon
markshannonhttps://github.com/markshannon
Jun 6, 2025https://github.com/python/cpython/pull/135225#issue-3125400282
Please reload this pagehttps://github.com/python/cpython/pull/135225
#125038https://github.com/python/cpython/issues/125038
#135171https://github.com/python/cpython/issues/135171
#127682https://github.com/python/cpython/issues/127682
@hugovkhttps://github.com/hugovk
@Yhg1shttps://github.com/Yhg1s
Generator expression behavior changed in 3.13.4 - it does not throw exception anymore #135171https://github.com/python/cpython/issues/135171
Please reload this pagehttps://github.com/python/cpython/pull/135225
markshannonhttps://github.com/markshannon
June 6, 2025 16:26https://github.com/python/cpython/pull/135225#commits-pushed-c011b5b
https://github.com/markshannon
Add NULL check to FOR_ITERhttps://github.com/python/cpython/pull/135225/commits/c011b5b47370481e789fd170c8763e412783e052
c011b5bhttps://github.com/python/cpython/pull/135225/commits/c011b5b47370481e789fd170c8763e412783e052
https://github.com/markshannon
Move GET_ITER back to genexpr creationhttps://github.com/python/cpython/pull/135225/commits/225e36abcd87214c8114ce3d348363612514ffd7
225e36ahttps://github.com/python/cpython/pull/135225/commits/225e36abcd87214c8114ce3d348363612514ffd7
https://github.com/markshannon
Fix up test generators to handle different behavior of gen exprs and …https://github.com/python/cpython/pull/135225/commits/4bdd75e6ab1b881587757f1639e44460d43219e1
4bdd75ehttps://github.com/python/cpython/pull/135225/commits/4bdd75e6ab1b881587757f1639e44460d43219e1
https://github.com/markshannon
Fix up test_dishttps://github.com/python/cpython/pull/135225/commits/fe8ca4b87a819c129552cc580de497707c5385de
fe8ca4bhttps://github.com/python/cpython/pull/135225/commits/fe8ca4b87a819c129552cc580de497707c5385de
https://github.com/markshannon
markshannonhttps://github.com/markshannon
iritkatrielhttps://github.com/iritkatriel
code ownerhttps://github.com/python/cpython/blob/88b5784fc0362e147e1ac6eaca0584acce5228b9/.github/CODEOWNERS#L40
June 6, 2025 17:20https://github.com/python/cpython/pull/135225#event-18026282355
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 6, 2025https://github.com/python/cpython/pull/135225#event-18026282926
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jun 6, 2025 https://github.com/python/cpython/pull/135225#ref-issue-3120633848
Generator expression behavior changed in 3.13.4 - it does not throw exception anymore #135171 https://github.com/python/cpython/issues/135171
https://github.com/markshannon
markshannonhttps://github.com/markshannon
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 6, 2025https://github.com/python/cpython/pull/135225#event-18026284375
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Jun 6, 2025https://github.com/python/cpython/pull/135225#issuecomment-2949990900
Please reload this pagehttps://github.com/python/cpython/pull/135225
https://github.com/markshannon
Add newshttps://github.com/python/cpython/pull/135225/commits/a96a192bd8263b6c159bd26dadbd7a9afb0479f3
a96a192https://github.com/python/cpython/pull/135225/commits/a96a192bd8263b6c159bd26dadbd7a9afb0479f3
https://github.com/markshannon
markshannonhttps://github.com/markshannon
Jun 6, 2025https://github.com/python/cpython/pull/135225#issuecomment-2950028653
Please reload this pagehttps://github.com/python/cpython/pull/135225
https://github.com/markshannon
Add back genexpr testhttps://github.com/python/cpython/pull/135225/commits/0d47bea07f23fbb91c01d119aa2745c6460a2584
0d47beahttps://github.com/python/cpython/pull/135225/commits/0d47bea07f23fbb91c01d119aa2745c6460a2584
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Jun 7, 2025https://github.com/python/cpython/pull/135225#issuecomment-2951772836
Please reload this pagehttps://github.com/python/cpython/pull/135225
https://github.com/efimov-mikhail
efimov-mikhailhttps://github.com/efimov-mikhail
Jun 7, 2025 https://github.com/python/cpython/pull/135225#pullrequestreview-2907891298
View reviewed changes https://github.com/python/cpython/pull/135225/files/0d47bea07f23fbb91c01d119aa2745c6460a2584
efimov-mikhailhttps://github.com/efimov-mikhail
https://github.com/python/cpython/pull/135225#pullrequestreview-2907891298
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/135225
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 7, 2025https://github.com/python/cpython/pull/135225#event-18040046252
https://github.com/Roman513
Roman513https://github.com/Roman513
Jun 8, 2025 https://github.com/python/cpython/pull/135225#ref-issue-2754335362
Defining iterator in a separate class no longer works in 3.13 #128161 https://github.com/python/cpython/issues/128161
https://github.com/markshannon
markshannonhttps://github.com/markshannon
a5274cdhttps://github.com/python/cpython/commit/a5274cd2158a0c7eaa6f54b4e74f8b4e92195e5e
Jun 9, 2025https://github.com/python/cpython/pull/135225#event-18052818649
Please reload this pagehttps://github.com/python/cpython/pull/135225
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Jun 9, 2025https://github.com/python/cpython/pull/135225#issuecomment-2955313107
@markshannonhttps://github.com/markshannon
Please reload this pagehttps://github.com/python/cpython/pull/135225
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 9, 2025https://github.com/python/cpython/pull/135225#event-18052819292
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Jun 9, 2025https://github.com/python/cpython/pull/135225#issuecomment-2955313263
@markshannonhttps://github.com/markshannon
cherry_pickerhttps://pypi.org/project/cherry-picker/
Please reload this pagehttps://github.com/python/cpython/pull/135225
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
markshannonhttps://github.com/markshannon
Jun 9, 2025https://github.com/python/cpython/pull/135225#event-18052820315
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jun 9, 2025https://github.com/python/cpython/pull/135225#issuecomment-2957085038
GH-135293https://github.com/python/cpython/pull/135293
3.13 branchhttps://github.com/python/cpython/tree/3.13
Please reload this pagehttps://github.com/python/cpython/pull/135225
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
Jun 9, 2025https://github.com/python/cpython/pull/135225#event-18063166011
https://github.com/efimov-mikhail
efimov-mikhailhttps://github.com/efimov-mikhail
Jun 10, 2025 https://github.com/python/cpython/pull/135225#ref-pullrequest-3133871284
[3.14] GH-135171: Revert async generator expressions behavior #135352 https://github.com/python/cpython/pull/135352
Yhg1shttps://github.com/Yhg1s
Jun 11, 2025 https://github.com/python/cpython/pull/135225#ref-commit-32d1d4a
https://github.com/Yhg1s
Reapply tests and the crash fix added inhttps://github.com/Yhg1s/cpython/commit/32d1d4a6124921c7a2a0676155b2663093427612
pythongh-135225https://github.com/python/cpython/pull/135225
and rolled b…https://github.com/Yhg1s/cpython/commit/32d1d4a6124921c7a2a0676155b2663093427612
32d1d4ahttps://github.com/Yhg1s/cpython/commit/32d1d4a6124921c7a2a0676155b2663093427612
https://github.com/efimov-mikhail
efimov-mikhailhttps://github.com/efimov-mikhail
Jun 11, 2025 https://github.com/python/cpython/pull/135225#ref-pullrequest-3137549575
[3.13] GH-135171: Roll back fix for GH-125038 as it's not suitable for 3.13 #135403 https://github.com/python/cpython/pull/135403
https://github.com/ThadCash187
ThadCash187https://github.com/ThadCash187
Jul 15, 2025 https://github.com/python/cpython/pull/135225#pullrequestreview-3018655455
View reviewed changes https://github.com/python/cpython/pull/135225/files/0d47bea07f23fbb91c01d119aa2745c6460a2584
Lib/test/test_dis.pyhttps://github.com/python/cpython/pull/135225/files/0d47bea07f23fbb91c01d119aa2745c6460a2584#diff-fd7b118a01a9695dfa16eea9381d3c7b0652e1b7b55f51ff052a1f620d175642
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135225
Please reload this pagehttps://github.com/python/cpython/pull/135225
https://github.com/AA-Turner
AA-Turnerhttps://github.com/AA-Turner
Aug 11, 2025 https://github.com/python/cpython/pull/135225#ref-issue-3305426083
Stack overflow error from recursion with 3.14.0rc1 on MacOS #137573 https://github.com/python/cpython/issues/137573
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135225
https://github.com/efimov-mikhail
efimov-mikhail https://github.com/efimov-mikhail
https://github.com/python/cpython/pull/135225/files/0d47bea07f23fbb91c01d119aa2745c6460a2584
https://github.com/iritkatriel
iritkatriel https://github.com/iritkatriel
https://github.com/ThadCash187
ThadCash187 https://github.com/ThadCash187
https://github.com/python/cpython/pull/135225/files/0d47bea07f23fbb91c01d119aa2745c6460a2584
https://github.com/markshannon
markshannon https://github.com/markshannon
Please reload this pagehttps://github.com/python/cpython/pull/135225
https://github.com/markshannon
https://github.com/serhiy-storchaka
https://github.com/efimov-mikhail
https://github.com/ThadCash187
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.