René's URL Explorer Experiment


Title: gh-116738: Inline append for local PyList by yoney · Pull Request #135196 · python/cpython · GitHub

Open Graph Title: gh-116738: Inline append for local PyList by yoney · Pull Request #135196 · python/cpython

X Title: gh-116738: Inline append for local PyList by yoney · Pull Request #135196 · python/cpython

Description: Append items to the local list in a loop without a lock. Appending to the list without a lock can improve performance, but testing grp.getgrall() produced noisy results, making it difficult to determine any improvement. Running a micro benchmark with a function that adds over 100K items to the list using _PyList_AppendTakeRef() instead of PyList_Append() showed about a 35% performance improvement. cc: @mpage @colesbury Issue: gh-116738

Open Graph Description: Append items to the local list in a loop without a lock. Appending to the list without a lock can improve performance, but testing grp.getgrall() produced noisy results, making it difficult to dete...

X Description: Append items to the local list in a loop without a lock. Appending to the list without a lock can improve performance, but testing grp.getgrall() produced noisy results, making it difficult to dete...

Opengraph URL: https://github.com/python/cpython/pull/135196

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0601b73e-d078-0997-eaad-1ec974214896
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAF60:2BBD61:1B204BA:23F7677:696AF3CD
html-safe-nonce0e907ce47809a65ffa771204114c677adc4cb16dfdc053d6924a4c89ea130bea
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjYwOjJCQkQ2MToxQjIwNEJBOjIzRjc2Nzc6Njk2QUYzQ0QiLCJ2aXNpdG9yX2lkIjoiODcwOTA1OTUyMzIyMjYzMTM3MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4c8c10dee50b9b44b2a20b7c5ed8018691c48be909f72201a7c6eb5bd4321f43
hovercard-subject-tagpull_request:2571997253
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/135196/files
twitter:imagehttps://avatars.githubusercontent.com/u/2095011?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/2095011?s=400&v=4
og:image:altAppend items to the local list in a loop without a lock. Appending to the list without a lock can improve performance, but testing grp.getgrall() produced noisy results, making it difficult to dete...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/135196/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135196%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135196%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/135196/files
Reloadhttps://github.com/python/cpython/pull/135196/files
Reloadhttps://github.com/python/cpython/pull/135196/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/135196/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/135196/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
yoneyhttps://github.com/yoney
python:mainhttps://github.com/python/cpython/tree/main
yoney:ft_grpmodulehttps://github.com/yoney/cpython/tree/ft_grpmodule
Conversation 13 https://github.com/python/cpython/pull/135196
Commits 4 https://github.com/python/cpython/pull/135196/commits
Checks 34 https://github.com/python/cpython/pull/135196/checks
Files changed https://github.com/python/cpython/pull/135196/files
Please reload this pagehttps://github.com/python/cpython/pull/135196/files
gh-116738: Inline append for local PyList https://github.com/python/cpython/pull/135196/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/135196/files
70ba3ab gh-116738: Inline append for local PyList yoney Jun 5, 2025 https://github.com/python/cpython/pull/135196/commits/70ba3abd0c3c354e7e1214b70ab129c9e27b89a4
d47b85c gh-116738: Assert list is uniquely referenced yoney Jun 10, 2025 https://github.com/python/cpython/pull/135196/commits/d47b85cb96aab8b05918f94719d86c1a02350091
cf5d8ec gh-116738: Let _PyList_AppendTakeRef() steal the reference yoney Jun 10, 2025 https://github.com/python/cpython/pull/135196/commits/cf5d8ec8a604b40fab080697e0c6fb84c3f48de9
9db2605 Merge branch 'main' into ft_grpmodule mpage Jun 11, 2025 https://github.com/python/cpython/pull/135196/commits/9db2605aaecc74183d54e3a53063a6d5c3c1689a
Clear filters https://github.com/python/cpython/pull/135196/files
Please reload this pagehttps://github.com/python/cpython/pull/135196/files
Please reload this pagehttps://github.com/python/cpython/pull/135196/files
Modules/grpmodule.chttps://github.com/python/cpython/pull/135196/files#diff-d930482a13f06d943cffe3b4e253cea42d5759209d472603d6cccb28aadbf243
View file https://github.com/yoney/cpython/blob/9db2605aaecc74183d54e3a53063a6d5c3c1689a/Modules/grpmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/135196/{{ revealButtonHref }}
https://github.com/python/cpython/pull/135196/files#diff-d930482a13f06d943cffe3b4e253cea42d5759209d472603d6cccb28aadbf243
https://github.com/python/cpython/pull/135196/files#diff-d930482a13f06d943cffe3b4e253cea42d5759209d472603d6cccb28aadbf243
https://github.com/python/cpython/pull/135196/files#diff-d930482a13f06d943cffe3b4e253cea42d5759209d472603d6cccb28aadbf243
kumaraditya303https://github.com/kumaraditya303
Jun 11, 2025https://github.com/python/cpython/pull/135196/files#r2140663254
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/135196/files
Please reload this pagehttps://github.com/python/cpython/pull/135196/files
https://github.com/python/cpython/pull/135196/files#diff-d930482a13f06d943cffe3b4e253cea42d5759209d472603d6cccb28aadbf243
Please reload this pagehttps://github.com/python/cpython/pull/135196/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.