René's URL Explorer Experiment


Title: gh-116738: Make _heapq module thread-safe by yoney · Pull Request #135036 · python/cpython · GitHub

Open Graph Title: gh-116738: Make _heapq module thread-safe by yoney · Pull Request #135036 · python/cpython

X Title: gh-116738: Make _heapq module thread-safe by yoney · Pull Request #135036 · python/cpython

Description: This uses critical sections to make heapq methods that update the heap thread-safe when the GIL is disabled. This is accomplished by using the @critical_section clinic directive. cc: @mpage @colesb...

Open Graph Description: This uses critical sections to make heapq methods that update the heap thread-safe when the GIL is disabled. This is accomplished by using the @critical_section clinic directive. cc: @mpage @colesb...

X Description: This uses critical sections to make heapq methods that update the heap thread-safe when the GIL is disabled. This is accomplished by using the @critical_section clinic directive. cc: @mpage @colesb...

Opengraph URL: https://github.com/python/cpython/pull/135036

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e46bb0d6-31cb-dd6e-e33b-5d0410ac49d7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD614:22F52E:1358780:1A85233:696A9F1F
html-safe-noncec05bfa4e593dfecb2de21d5b0d3f8047081aeb4bf9465cfae505f8f4d98e9446
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENjE0OjIyRjUyRToxMzU4NzgwOjFBODUyMzM6Njk2QTlGMUYiLCJ2aXNpdG9yX2lkIjoiMzY3NjE3NjMxODQ1ODQwNDY0MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3badaec017178f6bb8c7bb57a090bcfe41017fd731b7f6ae9759b8b6c72458ba
hovercard-subject-tagpull_request:2561184796
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/135036/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/93974a010d4e1504416b9ae9e7ef8723f2f44c4a5617b2be901ee5d35340414c/python/cpython/pull/135036
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/93974a010d4e1504416b9ae9e7ef8723f2f44c4a5617b2be901ee5d35340414c/python/cpython/pull/135036
og:image:altThis uses critical sections to make heapq methods that update the heap thread-safe when the GIL is disabled. This is accomplished by using the @critical_section clinic directive. cc: @mpage @colesb...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameyoney
hostnamegithub.com
expected-hostnamegithub.com
Nonea51f97dbb9326f71c08ecb61577457d543c602124d1a2672871258ef37ac5261
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4bd0eac606c70914085176ef312ebdcd97a8cdf1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/135036#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135036
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135036
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/135036
Reloadhttps://github.com/python/cpython/pull/135036
Reloadhttps://github.com/python/cpython/pull/135036
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/135036
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/135036
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/135036#issue-comment-box
mpagehttps://github.com/mpage
python:mainhttps://github.com/python/cpython/tree/main
yoney:ft_heapqhttps://github.com/yoney/cpython/tree/ft_heapq
gh-116738: Make _heapq module thread-safe https://github.com/python/cpython/pull/135036#top
mpagehttps://github.com/mpage
python:mainhttps://github.com/python/cpython/tree/main
yoney:ft_heapqhttps://github.com/yoney/cpython/tree/ft_heapq
Conversation 42 https://github.com/python/cpython/pull/135036
Commits 11 https://github.com/python/cpython/pull/135036/commits
Checks 39 https://github.com/python/cpython/pull/135036/checks
Files changed https://github.com/python/cpython/pull/135036/files
Please reload this pagehttps://github.com/python/cpython/pull/135036
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/yoney
yoneyhttps://github.com/yoney
Jun 2, 2025https://github.com/python/cpython/pull/135036#issue-3110774884
Please reload this pagehttps://github.com/python/cpython/pull/135036
@mpagehttps://github.com/mpage
@colesburyhttps://github.com/colesbury
Audit all built-in modules for thread safety #116738https://github.com/python/cpython/issues/116738
Please reload this pagehttps://github.com/python/cpython/pull/135036
https://github.com/yoney
pythongh-116738https://github.com/python/cpython/issues/116738
: Make _heapq module thread-safehttps://github.com/python/cpython/pull/135036/commits/ec3cade6608c3cdec39a0afa2961ac19fe41c78e
ec3cadehttps://github.com/python/cpython/pull/135036/commits/ec3cade6608c3cdec39a0afa2961ac19fe41c78e
https://github.com/apps/python-cla-bot
python-cla-bothttps://github.com/apps/python-cla-bot
Jun 2, 2025https://github.com/python/cpython/pull/135036#issuecomment-2931405039
Please reload this pagehttps://github.com/python/cpython/pull/135036
https://cla.python.org/
Please reload this pagehttps://github.com/python/cpython/pull/135036
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jun 2, 2025 https://github.com/python/cpython/pull/135036#ref-issue-2184479275
Audit all built-in modules for thread safety #116738 https://github.com/python/cpython/issues/116738
https://github.com/colesbury
colesburyhttps://github.com/colesbury
colesburyhttps://github.com/colesbury
mpagehttps://github.com/mpage
June 2, 2025 16:06https://github.com/python/cpython/pull/135036#event-17937826103
https://github.com/StanFromIreland
StanFromIrelandhttps://github.com/StanFromIreland
Jun 2, 2025 https://github.com/python/cpython/pull/135036#pullrequestreview-2889219668
View reviewed changes https://github.com/python/cpython/pull/135036/files/ec3cade6608c3cdec39a0afa2961ac19fe41c78e
StanFromIrelandhttps://github.com/StanFromIreland
Please reload this pagehttps://github.com/python/cpython/pull/135036
https://github.com/python/cpython/pull/135036#pullrequestreview-2889219668
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
cpython/Lib/test/test_heapq.pyhttps://github.com/python/cpython/blob/055827528fa50c9a7707792f5fe264c4e20c07e9/Lib/test/test_heapq.py#L106-L116
0558275https://github.com/python/cpython/commit/055827528fa50c9a7707792f5fe264c4e20c07e9
Please reload this pagehttps://github.com/python/cpython/pull/135036
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
topic-free-threading https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-free-threading
Jun 2, 2025https://github.com/python/cpython/pull/135036#event-17939039886
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
June 2, 2025 17:10https://github.com/python/cpython/pull/135036#event-17939046448
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
Jun 2, 2025 https://github.com/python/cpython/pull/135036#pullrequestreview-2889307643
View reviewed changes https://github.com/python/cpython/pull/135036/files/ec3cade6608c3cdec39a0afa2961ac19fe41c78e
ZeroIntensityhttps://github.com/ZeroIntensity
https://github.com/python/cpython/pull/135036#pullrequestreview-2889307643
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/135036
Modules/_heapqmodule.chttps://github.com/python/cpython/pull/135036/files/ec3cade6608c3cdec39a0afa2961ac19fe41c78e#diff-034663931c4f60e79a35df8dd3ccfd52dd3e8b89cc4ba85b70b68ef8b5bcee59
Please reload this pagehttps://github.com/python/cpython/pull/135036
https://github.com/yoney
yoneyhttps://github.com/yoney
June 2, 2025 17:38https://github.com/python/cpython/pull/135036#event-17939577604
https://github.com/yoney
yoneyhttps://github.com/yoney
rhettingerhttps://github.com/rhettinger
code ownerhttps://github.com/python/cpython/blob/44fb7c361cb24dcf9989a7a1cfee4f6aad5c81aa/.github/CODEOWNERS#L239
June 2, 2025 17:38https://github.com/python/cpython/pull/135036#event-17939577759
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jun 2, 2025https://github.com/python/cpython/pull/135036#event-17939578550
https://github.com/colesbury
colesburyhttps://github.com/colesbury
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
Jun 2, 2025https://github.com/python/cpython/pull/135036#event-17941279872
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Jun 2, 2025https://github.com/python/cpython/pull/135036#issuecomment-2932105931
@yoneyhttps://github.com/yoney
blurbhttps://github.com/python/blurb?tab=readme-ov-file#blurb
blurb-ithttps://blurb-it.herokuapp.com/
Please reload this pagehttps://github.com/python/cpython/pull/135036
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
Jun 2, 2025https://github.com/python/cpython/pull/135036#issuecomment-2932341614
Please reload this pagehttps://github.com/python/cpython/pull/135036
https://github.com/yoney
pythongh-116738https://github.com/python/cpython/issues/116738
: Add news entry in Misc/NEWS/nexthttps://github.com/python/cpython/pull/135036/commits/01b2be4c2d6577415a1e9f1ed0b10d568e76b532
01b2be4https://github.com/python/cpython/pull/135036/commits/01b2be4c2d6577415a1e9f1ed0b10d568e76b532
https://github.com/yoney
yoneyhttps://github.com/yoney
Jun 2, 2025https://github.com/python/cpython/pull/135036#issuecomment-2932507960
@ZeroIntensityhttps://github.com/ZeroIntensity
Please reload this pagehttps://github.com/python/cpython/pull/135036
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
Jun 2, 2025 https://github.com/python/cpython/pull/135036#pullrequestreview-2890199320
View reviewed changes https://github.com/python/cpython/pull/135036/files/01b2be4c2d6577415a1e9f1ed0b10d568e76b532
ZeroIntensityhttps://github.com/ZeroIntensity
https://github.com/python/cpython/pull/135036#pullrequestreview-2890199320
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/135036
Lib/test/test_free_threading/test_heapq.pyhttps://github.com/python/cpython/pull/135036/files/01b2be4c2d6577415a1e9f1ed0b10d568e76b532#diff-8ab1a596991d49a57e651a9df3754493a733c5ae44bf31154824eb886bbad9ba
Please reload this pagehttps://github.com/python/cpython/pull/135036
Lib/test/test_free_threading/test_heapq.pyhttps://github.com/python/cpython/pull/135036/files/01b2be4c2d6577415a1e9f1ed0b10d568e76b532#diff-8ab1a596991d49a57e651a9df3754493a733c5ae44bf31154824eb886bbad9ba
Please reload this pagehttps://github.com/python/cpython/pull/135036
Lib/test/test_free_threading/test_heapq.pyhttps://github.com/python/cpython/pull/135036/files/01b2be4c2d6577415a1e9f1ed0b10d568e76b532#diff-8ab1a596991d49a57e651a9df3754493a733c5ae44bf31154824eb886bbad9ba
Please reload this pagehttps://github.com/python/cpython/pull/135036
Lib/test/test_free_threading/test_heapq.pyhttps://github.com/python/cpython/pull/135036/files/01b2be4c2d6577415a1e9f1ed0b10d568e76b532#diff-8ab1a596991d49a57e651a9df3754493a733c5ae44bf31154824eb886bbad9ba
Please reload this pagehttps://github.com/python/cpython/pull/135036
Misc/NEWS.d/next/Core_and_Builtins/2025-06-02-13-57-40.gh-issue-116738.ycJsL8.rsthttps://github.com/python/cpython/pull/135036/files/01b2be4c2d6577415a1e9f1ed0b10d568e76b532#diff-d6a47781375121615cdd8290388351214726039f1990b1247689a0bd542152df
Please reload this pagehttps://github.com/python/cpython/pull/135036
https://github.com/rhettinger
rhettingerhttps://github.com/rhettinger
June 3, 2025 05:20https://github.com/python/cpython/pull/135036#event-17948440931
https://github.com/mpage
mpagehttps://github.com/mpage
Jun 3, 2025 https://github.com/python/cpython/pull/135036#pullrequestreview-2893565242
View reviewed changes https://github.com/python/cpython/pull/135036/files/01b2be4c2d6577415a1e9f1ed0b10d568e76b532
Modules/_heapqmodule.chttps://github.com/python/cpython/pull/135036/files/01b2be4c2d6577415a1e9f1ed0b10d568e76b532#diff-034663931c4f60e79a35df8dd3ccfd52dd3e8b89cc4ba85b70b68ef8b5bcee59
Please reload this pagehttps://github.com/python/cpython/pull/135036
yoneyhttps://github.com/yoney
June 3, 2025 13:05https://github.com/python/cpython/pull/135036#commits-pushed-68f3a26
https://github.com/yoney
pythongh-116738https://github.com/python/cpython/issues/116738
: Address the review commentshttps://github.com/python/cpython/pull/135036/commits/68f3a266cdbb5239d8d9ad2ef12112998b301459
68f3a26https://github.com/python/cpython/pull/135036/commits/68f3a266cdbb5239d8d9ad2ef12112998b301459
https://github.com/yoney
pythongh-116738https://github.com/python/cpython/issues/116738
: Address the review commentshttps://github.com/python/cpython/pull/135036/commits/41d145ad5c8bd756783b350bd0ff2ef10858cd87
41d145ahttps://github.com/python/cpython/pull/135036/commits/41d145ad5c8bd756783b350bd0ff2ef10858cd87
https://github.com/yoney
yoneyhttps://github.com/yoney
Jun 3, 2025https://github.com/python/cpython/pull/135036#issuecomment-2937289610
@StanFromIrelandhttps://github.com/StanFromIreland
Please reload this pagehttps://github.com/python/cpython/pull/135036
https://github.com/StanFromIreland
StanFromIrelandhttps://github.com/StanFromIreland
Jun 4, 2025 https://github.com/python/cpython/pull/135036#pullrequestreview-2896267257
View reviewed changes https://github.com/python/cpython/pull/135036/files/41d145ad5c8bd756783b350bd0ff2ef10858cd87
Lib/test/test_free_threading/test_heapq.pyhttps://github.com/python/cpython/pull/135036/files/41d145ad5c8bd756783b350bd0ff2ef10858cd87#diff-8ab1a596991d49a57e651a9df3754493a733c5ae44bf31154824eb886bbad9ba
Please reload this pagehttps://github.com/python/cpython/pull/135036
https://github.com/yoney
pythongh-116738https://github.com/python/cpython/issues/116738
: Remove type hintshttps://github.com/python/cpython/pull/135036/commits/a22da8f9af597d36b5e320f7dccd9d3973fc9f1e
a22da8fhttps://github.com/python/cpython/pull/135036/commits/a22da8f9af597d36b5e320f7dccd9d3973fc9f1e
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
Jun 5, 2025 https://github.com/python/cpython/pull/135036#pullrequestreview-2898591652
View reviewed changes https://github.com/python/cpython/pull/135036/files/a22da8f9af597d36b5e320f7dccd9d3973fc9f1e
ZeroIntensityhttps://github.com/ZeroIntensity
https://github.com/python/cpython/pull/135036#pullrequestreview-2898591652
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/135036
Lib/test/test_free_threading/test_heapq.pyhttps://github.com/python/cpython/pull/135036/files/a22da8f9af597d36b5e320f7dccd9d3973fc9f1e#diff-8ab1a596991d49a57e651a9df3754493a733c5ae44bf31154824eb886bbad9ba
Please reload this pagehttps://github.com/python/cpython/pull/135036
Lib/test/test_free_threading/test_heapq.pyhttps://github.com/python/cpython/pull/135036/files/a22da8f9af597d36b5e320f7dccd9d3973fc9f1e#diff-8ab1a596991d49a57e651a9df3754493a733c5ae44bf31154824eb886bbad9ba
Please reload this pagehttps://github.com/python/cpython/pull/135036
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jun 5, 2025https://github.com/python/cpython/pull/135036#event-17991415656
https://github.com/yoney
pythongh-116738https://github.com/python/cpython/issues/116738
: Address the review commentshttps://github.com/python/cpython/pull/135036/commits/75a1d3a5d429d34c578660cbf354a7a470728562
75a1d3ahttps://github.com/python/cpython/pull/135036/commits/75a1d3a5d429d34c578660cbf354a7a470728562
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
Jun 5, 2025 https://github.com/python/cpython/pull/135036#pullrequestreview-2901068705
View reviewed changes https://github.com/python/cpython/pull/135036/files/75a1d3a5d429d34c578660cbf354a7a470728562
Modules/_heapqmodule.chttps://github.com/python/cpython/pull/135036/files/75a1d3a5d429d34c578660cbf354a7a470728562#diff-034663931c4f60e79a35df8dd3ccfd52dd3e8b89cc4ba85b70b68ef8b5bcee59
ZeroIntensityhttps://github.com/ZeroIntensity
Jun 5, 2025https://github.com/python/cpython/pull/135036#discussion_r2129293615
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/135036
yoneyhttps://github.com/yoney
Jun 5, 2025https://github.com/python/cpython/pull/135036#discussion_r2129396008
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/135036
mpagehttps://github.com/mpage
Jun 5, 2025https://github.com/python/cpython/pull/135036#discussion_r2129428183
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/135036
ZeroIntensityhttps://github.com/ZeroIntensity
Jun 5, 2025https://github.com/python/cpython/pull/135036#discussion_r2130112054
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/135036
mpagehttps://github.com/mpage
Jun 5, 2025https://github.com/python/cpython/pull/135036#discussion_r2130266292
Please reload this pagehttps://github.com/python/cpython/pull/135036
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/135036
yoneyhttps://github.com/yoney
Jun 5, 2025https://github.com/python/cpython/pull/135036#discussion_r2130508033
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@mpagehttps://github.com/mpage
@ZeroIntensityhttps://github.com/ZeroIntensity
Please reload this pagehttps://github.com/python/cpython/pull/135036
https://github.com/mpage
mpagehttps://github.com/mpage
Jun 5, 2025 https://github.com/python/cpython/pull/135036#pullrequestreview-2901120036
View reviewed changes https://github.com/python/cpython/pull/135036/files/75a1d3a5d429d34c578660cbf354a7a470728562
Lib/test/test_free_threading/test_heapq.pyhttps://github.com/python/cpython/pull/135036/files/75a1d3a5d429d34c578660cbf354a7a470728562#diff-8ab1a596991d49a57e651a9df3754493a733c5ae44bf31154824eb886bbad9ba
Please reload this pagehttps://github.com/python/cpython/pull/135036
Modules/_heapqmodule.chttps://github.com/python/cpython/pull/135036/files/75a1d3a5d429d34c578660cbf354a7a470728562#diff-034663931c4f60e79a35df8dd3ccfd52dd3e8b89cc4ba85b70b68ef8b5bcee59
mpagehttps://github.com/mpage
Jun 5, 2025https://github.com/python/cpython/pull/135036#discussion_r2129428183
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/135036
Modules/_heapqmodule.chttps://github.com/python/cpython/pull/135036/files/75a1d3a5d429d34c578660cbf354a7a470728562#diff-034663931c4f60e79a35df8dd3ccfd52dd3e8b89cc4ba85b70b68ef8b5bcee59
Please reload this pagehttps://github.com/python/cpython/pull/135036
yoneyhttps://github.com/yoney
June 5, 2025 14:29https://github.com/python/cpython/pull/135036#commits-pushed-e8138be
https://github.com/yoney
pythongh-116738https://github.com/python/cpython/issues/116738
: Add NULL check for the item arg in heappush()https://github.com/python/cpython/pull/135036/commits/e8138be42a97cd63511773e42c76d390b4d84bc4
e8138behttps://github.com/python/cpython/pull/135036/commits/e8138be42a97cd63511773e42c76d390b4d84bc4
https://github.com/yoney
pythongh-116738https://github.com/python/cpython/issues/116738
: Fix typohttps://github.com/python/cpython/pull/135036/commits/3f0968925d303caa7dacde714883b65bb486d479
3f09689https://github.com/python/cpython/pull/135036/commits/3f0968925d303caa7dacde714883b65bb486d479
https://github.com/yoney
pythongh-116738https://github.com/python/cpython/issues/116738
: Use invariant checks from heapq testhttps://github.com/python/cpython/pull/135036/commits/7ffdb6d091bf3dd3c0c0baeed32b209839224bc0
7ffdb6dhttps://github.com/python/cpython/pull/135036/commits/7ffdb6d091bf3dd3c0c0baeed32b209839224bc0
https://github.com/mpage
mpagehttps://github.com/mpage
Jun 6, 2025 https://github.com/python/cpython/pull/135036#pullrequestreview-2905482098
View reviewed changes https://github.com/python/cpython/pull/135036/files/7ffdb6d091bf3dd3c0c0baeed32b209839224bc0
mpagehttps://github.com/mpage
https://github.com/python/cpython/pull/135036#pullrequestreview-2905482098
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/135036
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 6, 2025https://github.com/python/cpython/pull/135036#event-18025853115
https://github.com/mikeshardmind
mikeshardmindhttps://github.com/mikeshardmind
Jun 8, 2025 https://github.com/python/cpython/pull/135036#ref-issue-3128722943
Native code due to freethreading mikeshardmind/async-utils#21 https://github.com/mikeshardmind/async-utils/issues/21
https://github.com/yoney
pythongh-116738https://github.com/python/cpython/issues/116738
: Remove forgotten type hinthttps://github.com/python/cpython/pull/135036/commits/c2225a5599f1b588011704ee896b361f20fc1341
c2225a5https://github.com/python/cpython/pull/135036/commits/c2225a5599f1b588011704ee896b361f20fc1341
https://github.com/yoney
yoneyhttps://github.com/yoney
Jun 9, 2025https://github.com/python/cpython/pull/135036#issuecomment-2956154258
Please reload this pagehttps://github.com/python/cpython/pull/135036
https://github.com/mpage
Merge branch 'main' into ft_heapqhttps://github.com/python/cpython/pull/135036/commits/a196a00bcfad7b94f113ffa385023feb6e670a73
a196a00https://github.com/python/cpython/pull/135036/commits/a196a00bcfad7b94f113ffa385023feb6e670a73
https://github.com/mpage
mpagehttps://github.com/mpage
a58026ahttps://github.com/python/cpython/commit/a58026a5e3da9ca2d09ef51aa90fe217f9a975ec
Jun 9, 2025https://github.com/python/cpython/pull/135036#event-18060026575
Please reload this pagehttps://github.com/python/cpython/pull/135036
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jun 9, 2025https://github.com/python/cpython/pull/135036#event-18060027282
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Jun 9, 2025https://github.com/python/cpython/pull/135036#issuecomment-2956525589
@yoneyhttps://github.com/yoney
@mpagehttps://github.com/mpage
Please reload this pagehttps://github.com/python/cpython/pull/135036
miss-islingtonhttps://github.com/miss-islington
Jun 9, 2025 https://github.com/python/cpython/pull/135036#ref-commit-cece3b8
https://github.com/yoney
https://github.com/mpage
https://github.com/miss-islington
pythongh-116738https://github.com/python/cpython/issues/116738
: Make _heapq module thread-safe (https://github.com/miss-islington/cpython/commit/cece3b878ccdd7dee96a8499518b7f7e9d3a9958
pythonGH-135036https://github.com/python/cpython/pull/135036
)https://github.com/miss-islington/cpython/commit/cece3b878ccdd7dee96a8499518b7f7e9d3a9958
cece3b8https://github.com/miss-islington/cpython/commit/cece3b878ccdd7dee96a8499518b7f7e9d3a9958
a58026ahttps://github.com/miss-islington/cpython/commit/a58026a5e3da9ca2d09ef51aa90fe217f9a975ec
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jun 9, 2025https://github.com/python/cpython/pull/135036#issuecomment-2956526280
GH-135309https://github.com/python/cpython/pull/135309
3.14 branchhttps://github.com/python/cpython/tree/3.14
Please reload this pagehttps://github.com/python/cpython/pull/135036
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
Jun 9, 2025https://github.com/python/cpython/pull/135036#event-18060031215
https://github.com/yoney
yoneyhttps://github.com/yoney
June 16, 2025 05:59https://github.com/python/cpython/pull/135036#event-18162598532
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
Jun 16, 2025 https://github.com/python/cpython/pull/135036#ref-issue-3149281015
data race between lock free list reads and heapq #135557 https://github.com/python/cpython/issues/135557
colesburyhttps://github.com/colesbury
Jun 16, 2025 https://github.com/python/cpython/pull/135036#ref-commit-964c29d
https://github.com/miss-islington
https://github.com/yoney
https://github.com/mpage
[3.14]https://github.com/python/cpython/commit/964c29d28137bc9cd4ad011c1da8bc5ca127eaa3
gh-116738https://github.com/python/cpython/issues/116738
: Make _heapq module thread-safe (https://github.com/python/cpython/commit/964c29d28137bc9cd4ad011c1da8bc5ca127eaa3
GH-135036https://github.com/python/cpython/pull/135036
) (https://github.com/python/cpython/commit/964c29d28137bc9cd4ad011c1da8bc5ca127eaa3
gh-135309https://github.com/python/cpython/pull/135309
)https://github.com/python/cpython/commit/964c29d28137bc9cd4ad011c1da8bc5ca127eaa3
964c29dhttps://github.com/python/cpython/commit/964c29d28137bc9cd4ad011c1da8bc5ca127eaa3
a58026ahttps://github.com/python/cpython/commit/a58026a5e3da9ca2d09ef51aa90fe217f9a975ec
lkollarhttps://github.com/lkollar
Jun 19, 2025 https://github.com/python/cpython/pull/135036#ref-commit-1c5f6b1
https://github.com/yoney
https://github.com/mpage
https://github.com/lkollar
pythongh-116738https://github.com/python/cpython/issues/116738
: Make _heapq module thread-safe (https://github.com/lkollar/cpython/commit/1c5f6b1574f0b70d70cb251bcca1763d62fad693
python#135036https://github.com/python/cpython/pull/135036
)https://github.com/lkollar/cpython/commit/1c5f6b1574f0b70d70cb251bcca1763d62fad693
1c5f6b1https://github.com/lkollar/cpython/commit/1c5f6b1574f0b70d70cb251bcca1763d62fad693
Pranjal095https://github.com/Pranjal095
Jul 12, 2025 https://github.com/python/cpython/pull/135036#ref-commit-da8c56f
https://github.com/yoney
https://github.com/mpage
https://github.com/Pranjal095
pythongh-116738https://github.com/python/cpython/issues/116738
: Make _heapq module thread-safe (https://github.com/Pranjal095/cpython/commit/da8c56fdb6996e4afd024bb43180cb4381bdab91
python#135036https://github.com/python/cpython/pull/135036
)https://github.com/Pranjal095/cpython/commit/da8c56fdb6996e4afd024bb43180cb4381bdab91
da8c56fhttps://github.com/Pranjal095/cpython/commit/da8c56fdb6996e4afd024bb43180cb4381bdab91
taegyunkimhttps://github.com/taegyunkim
Aug 4, 2025 https://github.com/python/cpython/pull/135036#ref-commit-621b723
https://github.com/yoney
https://github.com/mpage
https://github.com/taegyunkim
pythongh-116738https://github.com/python/cpython/issues/116738
: Make _heapq module thread-safe (https://github.com/taegyunkim/cpython/commit/621b723c53ab29f37e322c92857ed72973ace5ea
python#135036https://github.com/python/cpython/pull/135036
)https://github.com/taegyunkim/cpython/commit/621b723c53ab29f37e322c92857ed72973ace5ea
621b723https://github.com/taegyunkim/cpython/commit/621b723c53ab29f37e322c92857ed72973ace5ea
Agent-Hellboyhttps://github.com/Agent-Hellboy
Aug 19, 2025 https://github.com/python/cpython/pull/135036#ref-commit-2afb521
https://github.com/yoney
https://github.com/mpage
https://github.com/Agent-Hellboy
pythongh-116738https://github.com/python/cpython/issues/116738
: Make _heapq module thread-safe (https://github.com/Agent-Hellboy/cpython/commit/2afb521235e74a75e9d15a40941b1a314ae6c4e4
python#135036https://github.com/python/cpython/pull/135036
)https://github.com/Agent-Hellboy/cpython/commit/2afb521235e74a75e9d15a40941b1a314ae6c4e4
2afb521https://github.com/Agent-Hellboy/cpython/commit/2afb521235e74a75e9d15a40941b1a314ae6c4e4
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135036
https://github.com/ZeroIntensity
ZeroIntensity https://github.com/ZeroIntensity
https://github.com/python/cpython/pull/135036/files/75a1d3a5d429d34c578660cbf354a7a470728562
https://github.com/AlexWaygood
AlexWaygood https://github.com/AlexWaygood
https://github.com/python/cpython/pull/135036/files/01b2be4c2d6577415a1e9f1ed0b10d568e76b532
https://github.com/StanFromIreland
StanFromIreland https://github.com/StanFromIreland
https://github.com/python/cpython/pull/135036/files/41d145ad5c8bd756783b350bd0ff2ef10858cd87
https://github.com/mpage
mpage https://github.com/mpage
https://github.com/python/cpython/pull/135036/files/7ffdb6d091bf3dd3c0c0baeed32b209839224bc0
https://github.com/colesbury
colesbury https://github.com/colesbury
topic-free-threading https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-free-threading
Please reload this pagehttps://github.com/python/cpython/pull/135036
https://github.com/yoney
https://github.com/colesbury
https://github.com/ZeroIntensity
https://github.com/mpage
https://github.com/AlexWaygood
https://github.com/StanFromIreland
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.