René's URL Explorer Experiment


Title: bpo-28134: Auto-detect socket values from file descriptor by tiran · Pull Request #1349 · python/cpython · GitHub

Open Graph Title: bpo-28134: Auto-detect socket values from file descriptor by tiran · Pull Request #1349 · python/cpython

X Title: bpo-28134: Auto-detect socket values from file descriptor by tiran · Pull Request #1349 · python/cpython

Description: Fix socket(fileno=fd) by auto-detecting the socket's family, type, and proto from the file descriptor. The auto-detection can be overruled by passing in family, type, and proto explicitly. Without the fix, all socket except for TCP/IP over IPv4 are basically broken: >>> s = socket.create_connection(('www.python.org', 443)) >>> s >>> socket.socket(fileno=s.fileno()) Signed-off-by: Christian Heimes christian@python.org https://bugs.python.org/issue28134

Open Graph Description: Fix socket(fileno=fd) by auto-detecting the socket's family, type, and proto from the file descriptor. The auto-detection can be overruled by passing in family, type, and proto explicitly. With...

X Description: Fix socket(fileno=fd) by auto-detecting the socket's family, type, and proto from the file descriptor. The auto-detection can be overruled by passing in family, type, and proto explicitly. ...

Opengraph URL: https://github.com/python/cpython/pull/1349

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3abfdc50-1b6f-62f8-73c1-9bf8495f08f8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB760:10E65B:160E486:1D88193:6A5051B4
html-safe-nonce178b886942289ee35832a7d70359922ea9a70f369110a5669b423f2ad80081e2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNzYwOjEwRTY1QjoxNjBFNDg2OjFEODgxOTM6NkE1MDUxQjQiLCJ2aXNpdG9yX2lkIjoiMzMyNzcwNzkxNzg5Mzc4Mzk4OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6b8491d0d98b61a1b0d6c9928bf44bf0af98852135db33a148d6f16ace0d71fc
hovercard-subject-tagpull_request:118215603
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/1349/files
twitter:imagehttps://avatars.githubusercontent.com/u/444071?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/444071?s=400&v=4
og:image:altFix socket(fileno=fd) by auto-detecting the socket's family, type, and proto from the file descriptor. The auto-detection can be overruled by passing in family, type, and proto explicitly. With...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5741a45fe07e5f377d0d4c524a92e3056acc51bb
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/1349/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F1349%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F1349%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/1349/files
Reloadhttps://github.com/python/cpython/pull/1349/files
Reloadhttps://github.com/python/cpython/pull/1349/files
Please reload this pagehttps://github.com/python/cpython/pull/1349/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/1349/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
tiranhttps://github.com/tiran
python:masterhttps://github.com/python/cpython/tree/master
tiran:bpo-28134-socket-fdhttps://github.com/tiran/cpython/tree/bpo-28134-socket-fd
Conversation 16 https://github.com/python/cpython/pull/1349
Commits 1 https://github.com/python/cpython/pull/1349/commits
Checks 0 https://github.com/python/cpython/pull/1349/checks
Files changed https://github.com/python/cpython/pull/1349/files
Please reload this pagehttps://github.com/python/cpython/pull/1349/files
bpo-28134: Auto-detect socket values from file descriptor https://github.com/python/cpython/pull/1349/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/1349/files
28b925f bpo-28134: Auto-detect socket values from file descriptor tiran Apr 28, 2017 https://github.com/python/cpython/pull/1349/commits/28b925fbce2a6f22dbf43b5bcf8046d5890e3cb6
Clear filters https://github.com/python/cpython/pull/1349/files
Please reload this pagehttps://github.com/python/cpython/pull/1349/files
Please reload this pagehttps://github.com/python/cpython/pull/1349/files
socket.rst https://github.com/python/cpython/pull/1349/files#diff-e9e93d6b76a8a1cf0825d557b12e7ce3e67081cad650063eee520b81fd651943
socket.py https://github.com/python/cpython/pull/1349/files#diff-081d33d48e9390350bb1ef860c52de799d1647b58e33b07173ae2549532cbfbe
_test_multiprocessing.py https://github.com/python/cpython/pull/1349/files#diff-c3db62f7c1928499afd71830c22c8bb8f56843a4533cecf69137973d73c489fc
test_socket.py https://github.com/python/cpython/pull/1349/files#diff-ce79808e12f7a252c1747c23ba11810d4dc22ce0af4b9419bac647ad3a2a8389
2017-12-24-20-01-09.bpo-28134.HJ8Beb.rst https://github.com/python/cpython/pull/1349/files#diff-dd6c4b6f61cf7915481fc80f5c6bb0d90fdfeb24da5ac7bd107e33ec66786d08
socketmodule.c https://github.com/python/cpython/pull/1349/files#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29
Doc/library/socket.rsthttps://github.com/python/cpython/pull/1349/files#diff-e9e93d6b76a8a1cf0825d557b12e7ce3e67081cad650063eee520b81fd651943
View file https://github.com/tiran/cpython/blob/28b925fbce2a6f22dbf43b5bcf8046d5890e3cb6/Doc/library/socket.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/1349/{{ revealButtonHref }}
https://github.com/python/cpython/pull/1349/files#diff-e9e93d6b76a8a1cf0825d557b12e7ce3e67081cad650063eee520b81fd651943
https://github.com/python/cpython/pull/1349/files#diff-e9e93d6b76a8a1cf0825d557b12e7ce3e67081cad650063eee520b81fd651943
Lib/socket.pyhttps://github.com/python/cpython/pull/1349/files#diff-081d33d48e9390350bb1ef860c52de799d1647b58e33b07173ae2549532cbfbe
View file https://github.com/tiran/cpython/blob/28b925fbce2a6f22dbf43b5bcf8046d5890e3cb6/Lib/socket.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/1349/{{ revealButtonHref }}
https://github.com/python/cpython/pull/1349/files#diff-081d33d48e9390350bb1ef860c52de799d1647b58e33b07173ae2549532cbfbe
tiranhttps://github.com/tiran
Apr 28, 2017https://github.com/python/cpython/pull/1349/files#r114000144
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1349/files
vadmiumhttps://github.com/vadmium
Apr 29, 2017https://github.com/python/cpython/pull/1349/files#r114043434
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1349/files
gpsheadhttps://github.com/gpshead
Sep 5, 2017https://github.com/python/cpython/pull/1349/files#r137059066
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1349/files
https://github.com/python/cpython/pull/1349/files#diff-081d33d48e9390350bb1ef860c52de799d1647b58e33b07173ae2549532cbfbe
Lib/test/_test_multiprocessing.pyhttps://github.com/python/cpython/pull/1349/files#diff-c3db62f7c1928499afd71830c22c8bb8f56843a4533cecf69137973d73c489fc
View file https://github.com/tiran/cpython/blob/28b925fbce2a6f22dbf43b5bcf8046d5890e3cb6/Lib/test/_test_multiprocessing.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/1349/{{ revealButtonHref }}
https://github.com/python/cpython/pull/1349/files#diff-c3db62f7c1928499afd71830c22c8bb8f56843a4533cecf69137973d73c489fc
gpsheadhttps://github.com/gpshead
Sep 5, 2017https://github.com/python/cpython/pull/1349/files#r137058956
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1349/files
https://github.com/python/cpython/pull/1349/files#diff-c3db62f7c1928499afd71830c22c8bb8f56843a4533cecf69137973d73c489fc
Lib/test/test_socket.pyhttps://github.com/python/cpython/pull/1349/files#diff-ce79808e12f7a252c1747c23ba11810d4dc22ce0af4b9419bac647ad3a2a8389
View file https://github.com/tiran/cpython/blob/28b925fbce2a6f22dbf43b5bcf8046d5890e3cb6/Lib/test/test_socket.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/1349/{{ revealButtonHref }}
https://github.com/python/cpython/pull/1349/files#diff-ce79808e12f7a252c1747c23ba11810d4dc22ce0af4b9419bac647ad3a2a8389
https://github.com/python/cpython/pull/1349/files#diff-ce79808e12f7a252c1747c23ba11810d4dc22ce0af4b9419bac647ad3a2a8389
https://github.com/python/cpython/pull/1349/files#diff-ce79808e12f7a252c1747c23ba11810d4dc22ce0af4b9419bac647ad3a2a8389
https://github.com/python/cpython/pull/1349/files#diff-ce79808e12f7a252c1747c23ba11810d4dc22ce0af4b9419bac647ad3a2a8389
https://github.com/python/cpython/pull/1349/files#diff-ce79808e12f7a252c1747c23ba11810d4dc22ce0af4b9419bac647ad3a2a8389
https://github.com/python/cpython/pull/1349/files#diff-ce79808e12f7a252c1747c23ba11810d4dc22ce0af4b9419bac647ad3a2a8389
https://github.com/python/cpython/pull/1349/files#diff-ce79808e12f7a252c1747c23ba11810d4dc22ce0af4b9419bac647ad3a2a8389
Misc/NEWS.d/next/Library/2017-12-24-20-01-09.bpo-28134.HJ8Beb.rsthttps://github.com/python/cpython/pull/1349/files#diff-dd6c4b6f61cf7915481fc80f5c6bb0d90fdfeb24da5ac7bd107e33ec66786d08
View file https://github.com/tiran/cpython/blob/28b925fbce2a6f22dbf43b5bcf8046d5890e3cb6/Misc/NEWS.d/next/Library/2017-12-24-20-01-09.bpo-28134.HJ8Beb.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/1349/{{ revealButtonHref }}
Modules/socketmodule.chttps://github.com/python/cpython/pull/1349/files#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29
View file https://github.com/tiran/cpython/blob/28b925fbce2a6f22dbf43b5bcf8046d5890e3cb6/Modules/socketmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/1349/{{ revealButtonHref }}
https://github.com/python/cpython/pull/1349/files#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29
https://github.com/python/cpython/pull/1349/files#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29
https://github.com/python/cpython/pull/1349/files#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29
https://github.com/python/cpython/pull/1349/files#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29
https://github.com/python/cpython/pull/1349/files#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29
https://github.com/python/cpython/pull/1349/files#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29
gpsheadhttps://github.com/gpshead
Sep 5, 2017https://github.com/python/cpython/pull/1349/files#r137063800
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1349/files
https://github.com/python/cpython/pull/1349/files#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.