René's URL Explorer Experiment


Title: [3.14] gh-132775: Always Set __builtins__ In _PyFunction_FromXIData() (gh-134758) by miss-islington · Pull Request #134794 · python/cpython · GitHub

Open Graph Title: [3.14] gh-132775: Always Set __builtins__ In _PyFunction_FromXIData() (gh-134758) by miss-islington · Pull Request #134794 · python/cpython

X Title: [3.14] gh-132775: Always Set __builtins__ In _PyFunction_FromXIData() (gh-134758) by miss-islington · Pull Request #134794 · python/cpython

Description: This is a small follow-up to gh-133481. There's a corner case in the behavior of PyImport_ImportModuleAttrString(), where it expects builtins to be set if globals is set. (cherry picked from commi...

Open Graph Description: This is a small follow-up to gh-133481. There's a corner case in the behavior of PyImport_ImportModuleAttrString(), where it expects builtins to be set if globals is set. (cherry picked from c...

X Description: This is a small follow-up to gh-133481. There's a corner case in the behavior of PyImport_ImportModuleAttrString(), where it expects builtins to be set if globals is set. (cherry picked fr...

Mail addresses
ericsnowcurrently@gmail.com

Opengraph URL: https://github.com/python/cpython/pull/134794

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:688fd99a-4754-234d-667d-6530f9083506
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE868:33F365:9FA1C9:CCC965:696B21F2
html-safe-nonce320ed45fc78762cc31527836653d5eb20b2968d3cf0e429070d0e35840af7d23
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODY4OjMzRjM2NTo5RkExQzk6Q0NDOTY1OjY5NkIyMUYyIiwidmlzaXRvcl9pZCI6IjE4MDk1MDY4NDkyNzA3MzUzNDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2f4959df2aad848e80ec4acae056150e2aeb79e52d3e853d3f27acf8f9e7b54a
hovercard-subject-tagpull_request:2546902296
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/134794/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e95db09b54cc28e8e2aa4d1c5d5332390bc48bf04f6662c015d294c6f653ca88/python/cpython/pull/134794
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e95db09b54cc28e8e2aa4d1c5d5332390bc48bf04f6662c015d294c6f653ca88/python/cpython/pull/134794
og:image:altThis is a small follow-up to gh-133481. There's a corner case in the behavior of PyImport_ImportModuleAttrString(), where it expects builtins to be set if globals is set. (cherry picked from c...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemiss-islington
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/134794#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F134794
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F134794
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/134794
Reloadhttps://github.com/python/cpython/pull/134794
Reloadhttps://github.com/python/cpython/pull/134794
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/134794
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/134794
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/134794#issue-comment-box
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:3.14https://github.com/python/cpython/tree/3.14
miss-islington:backport-9b5e800-3.14https://github.com/miss-islington/cpython/tree/backport-9b5e800-3.14
[3.14] gh-132775: Always Set __builtins__ In _PyFunction_FromXIData() (gh-134758) https://github.com/python/cpython/pull/134794#top
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:3.14https://github.com/python/cpython/tree/3.14
miss-islington:backport-9b5e800-3.14https://github.com/miss-islington/cpython/tree/backport-9b5e800-3.14
Conversation 0 https://github.com/python/cpython/pull/134794
Commits 1 https://github.com/python/cpython/pull/134794/commits
Checks 41 https://github.com/python/cpython/pull/134794/checks
Files changed https://github.com/python/cpython/pull/134794/files
Please reload this pagehttps://github.com/python/cpython/pull/134794
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
May 27, 2025https://github.com/python/cpython/pull/134794#issue-3094391648
Please reload this pagehttps://github.com/python/cpython/pull/134794
gh-133481https://github.com/python/cpython/pull/133481
9b5e800https://github.com/python/cpython/commit/9b5e80000ee179eb028841709f10dac9af7c36e7
Improvements to test.support.interpreters.Interpreter #132775https://github.com/python/cpython/issues/132775
Please reload this pagehttps://github.com/python/cpython/pull/134794
https://github.com/ericsnowcurrently
https://github.com/miss-islington
pythongh-132775https://github.com/python/cpython/issues/132775
: Always Set __builtins__ In _PyFunction_FromXIData() (https://github.com/python/cpython/pull/134794/commits/99872b1d92813c518601f936ed9e6204ad25bc4c
p…https://github.com/python/cpython/pull/134758
99872b1https://github.com/python/cpython/pull/134794/commits/99872b1d92813c518601f936ed9e6204ad25bc4c
…ythongh-134758https://github.com/python/cpython/pull/134758
pythongh-133481https://github.com/python/cpython/pull/133481
9b5e800https://github.com/miss-islington/cpython/commit/9b5e80000ee179eb028841709f10dac9af7c36e7
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
code ownerhttps://github.com/python/cpython/blob/00122c8b2ab7c402daa144bb498e3a4f33254055/.github/CODEOWNERS#L283
May 27, 2025 15:42https://github.com/python/cpython/pull/134794#event-17833395120
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
May 27, 2025 https://github.com/python/cpython/pull/134794#ref-issue-3008765764
Improvements to test.support.interpreters.Interpreter #132775 https://github.com/python/cpython/issues/132775
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
May 27, 2025https://github.com/python/cpython/pull/134794#event-17833397847
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
May 27, 2025 https://github.com/python/cpython/pull/134794#ref-pullrequest-3092165068
gh-132775: Always Set __builtins__ In _PyFunction_FromXIData() #134758 https://github.com/python/cpython/pull/134758
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
May 27, 2025https://github.com/python/cpython/pull/134794#event-17833398122
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
May 27, 2025 15:48https://github.com/python/cpython/pull/134794#event-17833508055
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
6493395https://github.com/python/cpython/commit/6493395f4b69c561db14fdb5c10a819fda52138d
May 27, 2025https://github.com/python/cpython/pull/134794#event-17833882105
Please reload this pagehttps://github.com/python/cpython/pull/134794
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
May 27, 2025https://github.com/python/cpython/pull/134794#event-17833883128
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
January 2, 2026 16:58https://github.com/python/cpython/pull/134794#event-21829575962
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F134794
https://github.com/ericsnowcurrently
ericsnowcurrently https://github.com/ericsnowcurrently
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/134794
https://github.com/miss-islington
https://github.com/ericsnowcurrently
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.