René's URL Explorer Experiment


Title: [3.14] GH-128161: Remove redundant GET_ITER from list comprehension code by markshannon · Pull Request #134778 · python/cpython · GitHub

Open Graph Title: [3.14] GH-128161: Remove redundant GET_ITER from list comprehension code by markshannon · Pull Request #134778 · python/cpython

X Title: [3.14] GH-128161: Remove redundant GET_ITER from list comprehension code by markshannon · Pull Request #134778 · python/cpython

Description: Issue: Defining iterator in a separate class no longer works in 3.13 #128161

Open Graph Description: Issue: Defining iterator in a separate class no longer works in 3.13 #128161

X Description: Issue: Defining iterator in a separate class no longer works in 3.13 #128161

Opengraph URL: https://github.com/python/cpython/pull/134778

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c8e8f679-8f2e-00c1-89ac-d89e3787c424
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA512:378C0F:23881E8:30B4ABA:696AC8A2
html-safe-noncef7078e0c681065c670c040ed5a9fd4fffedb014e172ab5e8b3691536679662a9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTEyOjM3OEMwRjoyMzg4MUU4OjMwQjRBQkE6Njk2QUM4QTIiLCJ2aXNpdG9yX2lkIjoiMTg1MjcwODA1MjY5NTQzNTQyNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb9d37a687eeffa65d375a769b3f074bb8fb0e7b42891d18fb573045ae0f5c8f8
hovercard-subject-tagpull_request:2545732247
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/134778/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/41989a8f7bbc0f3fbae0d5e73a97cbc3ef2397075e10f200ac292390884195d1/python/cpython/pull/134778
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/41989a8f7bbc0f3fbae0d5e73a97cbc3ef2397075e10f200ac292390884195d1/python/cpython/pull/134778
og:image:altIssue: Defining iterator in a separate class no longer works in 3.13 #128161
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemarkshannon
hostnamegithub.com
expected-hostnamegithub.com
Nonec785f4ce187e9e7331257791b36ddee01625bb8e292a9b4fe2c16d4c006abf5d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec718a376fcf780eb22089171adb84a543f660bf7
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/134778#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F134778
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F134778
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/134778
Reloadhttps://github.com/python/cpython/pull/134778
Reloadhttps://github.com/python/cpython/pull/134778
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/134778
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/134778
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/134778#issue-comment-box
markshannonhttps://github.com/markshannon
python:3.14https://github.com/python/cpython/tree/3.14
faster-cpython:dedup-getiter-listcomphttps://github.com/faster-cpython/cpython/tree/dedup-getiter-listcomp
[3.14] GH-128161: Remove redundant GET_ITER from list comprehension code https://github.com/python/cpython/pull/134778#top
markshannonhttps://github.com/markshannon
python:3.14https://github.com/python/cpython/tree/3.14
faster-cpython:dedup-getiter-listcomphttps://github.com/faster-cpython/cpython/tree/dedup-getiter-listcomp
Conversation 8 https://github.com/python/cpython/pull/134778
Commits 3 https://github.com/python/cpython/pull/134778/commits
Checks 42 https://github.com/python/cpython/pull/134778/checks
Files changed 4 https://github.com/python/cpython/pull/134778/files
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/markshannon
markshannonhttps://github.com/markshannon
May 27, 2025https://github.com/python/cpython/pull/134778#issue-3093082047
Please reload this pagehttps://github.com/python/cpython/pull/134778
Defining iterator in a separate class no longer works in 3.13 #128161https://github.com/python/cpython/issues/128161
Please reload this pagehttps://github.com/python/cpython/pull/134778
https://github.com/markshannon
markshannonhttps://github.com/markshannon
iritkatrielhttps://github.com/iritkatriel
code ownerhttps://github.com/python/cpython/blob/b6e624a3fcd94600cbc1062cd13b0abbe56f0c25/.github/CODEOWNERS#L40
May 27, 2025 08:21https://github.com/python/cpython/pull/134778#event-17825532953
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 27, 2025https://github.com/python/cpython/pull/134778#event-17825534901
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
May 27, 2025 https://github.com/python/cpython/pull/134778#ref-issue-2754335362
Defining iterator in a separate class no longer works in 3.13 #128161 https://github.com/python/cpython/issues/128161
https://github.com/markshannon
markshannonhttps://github.com/markshannon
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 27, 2025https://github.com/python/cpython/pull/134778#event-17825539094
https://github.com/markshannon
Remove redundant GET_ITER from list comprehension codehttps://github.com/python/cpython/pull/134778/commits/0e39bd3b293f7be1dbee4ec0edce47f696dba355
0e39bd3https://github.com/python/cpython/pull/134778/commits/0e39bd3b293f7be1dbee4ec0edce47f696dba355
https://github.com/markshannon
markshannonhttps://github.com/markshannon
force-pushedhttps://github.com/python/cpython/compare/e3d638be0ba48e00e90c5f0ea4c76aa10468ac40..0e39bd3b293f7be1dbee4ec0edce47f696dba355
e3d638bhttps://github.com/python/cpython/commit/e3d638be0ba48e00e90c5f0ea4c76aa10468ac40
0e39bd3https://github.com/python/cpython/commit/0e39bd3b293f7be1dbee4ec0edce47f696dba355
Compare https://github.com/python/cpython/compare/e3d638be0ba48e00e90c5f0ea4c76aa10468ac40..0e39bd3b293f7be1dbee4ec0edce47f696dba355
May 27, 2025 09:00https://github.com/python/cpython/pull/134778#event-17826213056
https://github.com/markshannon
markshannonhttps://github.com/markshannon
May 27, 2025https://github.com/python/cpython/pull/134778#issuecomment-2911878821
#132555https://github.com/python/cpython/pull/132555
Please reload this pagehttps://github.com/python/cpython/pull/134778
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
May 27, 2025 https://github.com/python/cpython/pull/134778#pullrequestreview-2870443841
View reviewed changes https://github.com/python/cpython/pull/134778/files/0e39bd3b293f7be1dbee4ec0edce47f696dba355
Lib/test/test_listcomps.pyhttps://github.com/python/cpython/pull/134778/files/0e39bd3b293f7be1dbee4ec0edce47f696dba355#diff-6f30ce607962fa738e784af87142b4bb73d48160a1f354eea2cbf31a5bcb310a
Please reload this pagehttps://github.com/python/cpython/pull/134778
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
May 27, 2025https://github.com/python/cpython/pull/134778#issuecomment-2911922081
#128161https://github.com/python/cpython/issues/128161
Please reload this pagehttps://github.com/python/cpython/pull/134778
https://github.com/markshannon
markshannonhttps://github.com/markshannon
May 27, 2025https://github.com/python/cpython/pull/134778#issuecomment-2911968966
#128161https://github.com/python/cpython/issues/128161
Please reload this pagehttps://github.com/python/cpython/pull/134778
markshannonhttps://github.com/markshannon
May 27, 2025 11:29https://github.com/python/cpython/pull/134778#commits-pushed-7a05f9a
https://github.com/markshannon
Add test for async list comprehensionhttps://github.com/python/cpython/pull/134778/commits/7a05f9aa9874ac8737d9bdb4a0c522452fd7eef5
7a05f9ahttps://github.com/python/cpython/pull/134778/commits/7a05f9aa9874ac8737d9bdb4a0c522452fd7eef5
https://github.com/markshannon
Fix whitespacehttps://github.com/python/cpython/pull/134778/commits/76ac2992033b43994aedb60b69e9e0e9616f9197
76ac299https://github.com/python/cpython/pull/134778/commits/76ac2992033b43994aedb60b69e9e0e9616f9197
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
May 27, 2025 https://github.com/python/cpython/pull/134778#pullrequestreview-2870643760
View reviewed changes https://github.com/python/cpython/pull/134778/files/76ac2992033b43994aedb60b69e9e0e9616f9197
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
May 27, 2025https://github.com/python/cpython/pull/134778#event-17828369437
https://github.com/markshannon
markshannonhttps://github.com/markshannon
00122c8https://github.com/python/cpython/commit/00122c8b2ab7c402daa144bb498e3a4f33254055
May 27, 2025https://github.com/python/cpython/pull/134778#event-17828655356
Please reload this pagehttps://github.com/python/cpython/pull/134778
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
May 27, 2025https://github.com/python/cpython/pull/134778#event-17828656231
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
May 27, 2025https://github.com/python/cpython/pull/134778#issuecomment-2912169828
@markshannonhttps://github.com/markshannon
Please reload this pagehttps://github.com/python/cpython/pull/134778
https://github.com/markshannon
markshannonhttps://github.com/markshannon
May 27, 2025 11:29https://github.com/python/cpython/pull/134778#event-17828656546
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
May 27, 2025https://github.com/python/cpython/pull/134778#issuecomment-2912169994
@markshannonhttps://github.com/markshannon
cherry_pickerhttps://pypi.org/project/cherry-picker/
Please reload this pagehttps://github.com/python/cpython/pull/134778
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
markshannonhttps://github.com/markshannon
May 27, 2025https://github.com/python/cpython/pull/134778#event-17828657219
markshannonhttps://github.com/markshannon
May 27, 2025 https://github.com/python/cpython/pull/134778#ref-commit-9000bd4
https://github.com/markshannon
[3.14]https://github.com/faster-cpython/cpython/commit/9000bd4321946d74720ab86c16a916f10f257aed
pythonGH-128161https://github.com/python/cpython/issues/128161
: Remove redundant GET_ITER from list comprehen…https://github.com/faster-cpython/cpython/commit/9000bd4321946d74720ab86c16a916f10f257aed
9000bd4https://github.com/faster-cpython/cpython/commit/9000bd4321946d74720ab86c16a916f10f257aed
pythonGH-134778https://github.com/python/cpython/pull/134778
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
May 27, 2025https://github.com/python/cpython/pull/134778#issuecomment-2912438904
GH-134788https://github.com/python/cpython/pull/134788
3.13 branchhttps://github.com/python/cpython/tree/3.13
Please reload this pagehttps://github.com/python/cpython/pull/134778
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
May 27, 2025https://github.com/python/cpython/pull/134778#event-17830217148
markshannonhttps://github.com/markshannon
May 27, 2025 https://github.com/python/cpython/pull/134778#ref-commit-814ac0d
https://github.com/markshannon
[3.13]https://github.com/python/cpython/commit/814ac0d58789fd544855a6c1afb9d89a690a0c3b
gh-128161https://github.com/python/cpython/issues/128161
: Remove redundant GET_ITER from list comprehension c…https://github.com/python/cpython/commit/814ac0d58789fd544855a6c1afb9d89a690a0c3b
814ac0dhttps://github.com/python/cpython/commit/814ac0d58789fd544855a6c1afb9d89a690a0c3b
GH-134778https://github.com/python/cpython/pull/134778
GH-134788https://github.com/python/cpython/pull/134788
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F134778
https://github.com/iritkatriel
iritkatriel https://github.com/iritkatriel
https://github.com/python/cpython/pull/134778/files/76ac2992033b43994aedb60b69e9e0e9616f9197
https://github.com/markshannon
markshannon https://github.com/markshannon
Please reload this pagehttps://github.com/python/cpython/pull/134778
https://github.com/markshannon
https://github.com/iritkatriel
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.