René's URL Explorer Experiment


Title: gh-132775: Always Set __builtins__ In _PyFunction_FromXIData() by ericsnowcurrently · Pull Request #134758 · python/cpython · GitHub

Open Graph Title: gh-132775: Always Set __builtins__ In _PyFunction_FromXIData() by ericsnowcurrently · Pull Request #134758 · python/cpython

X Title: gh-132775: Always Set __builtins__ In _PyFunction_FromXIData() by ericsnowcurrently · Pull Request #134758 · python/cpython

Description: This is a small follow-up to gh-133481. There's a corner case in the behavior of PyImport_ImportModuleAttrString() where it expects __builtins__ to be set if __globals__ is set. Issue: Improveme...

Open Graph Description: This is a small follow-up to gh-133481. There's a corner case in the behavior of PyImport_ImportModuleAttrString() where it expects __builtins__ to be set if __globals__ is set. Issue: Impro...

X Description: This is a small follow-up to gh-133481. There's a corner case in the behavior of PyImport_ImportModuleAttrString() where it expects __builtins__ to be set if __globals__ is set. Issue: I...

Opengraph URL: https://github.com/python/cpython/pull/134758

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e4f81df9-6eeb-afdd-7a5b-4ce46e56dd4e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC5F0:1D81B0:10BBBDB:170806F:696A9803
html-safe-nonceaf792928516678ba6f204677e0e8095a664a6047ad99b2674c9fe969792cfd65
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNUYwOjFEODFCMDoxMEJCQkRCOjE3MDgwNkY6Njk2QTk4MDMiLCJ2aXNpdG9yX2lkIjoiMzQ4ODAwMDU3MjcyMTM3MTEzOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0a9f4ba7723cccbf96f4fde2b5c209969cec81f6794130a2a2234b349ca6eb66
hovercard-subject-tagpull_request:2544924886
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/134758/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1d13663129ff9907bee7c0b01c7a2f4d98bb359fd23fdaecd805e844df5bc188/python/cpython/pull/134758
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1d13663129ff9907bee7c0b01c7a2f4d98bb359fd23fdaecd805e844df5bc188/python/cpython/pull/134758
og:image:altThis is a small follow-up to gh-133481. There's a corner case in the behavior of PyImport_ImportModuleAttrString() where it expects __builtins__ to be set if __globals__ is set. Issue: Impro...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameericsnowcurrently
hostnamegithub.com
expected-hostnamegithub.com
Nonec0d8175e41e0e55b9e984c935b24b808cabab919dd3174aa45dac3ef503ed1af
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release99aab454e5ddc8df30805fb76c114c3008a15842
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/134758#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F134758
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F134758
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/134758
Reloadhttps://github.com/python/cpython/pull/134758
Reloadhttps://github.com/python/cpython/pull/134758
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/134758
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/134758
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/134758#issue-comment-box
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:mainhttps://github.com/python/cpython/tree/main
ericsnowcurrently:fix-missing-builtinshttps://github.com/ericsnowcurrently/cpython/tree/fix-missing-builtins
gh-132775: Always Set __builtins__ In _PyFunction_FromXIData() https://github.com/python/cpython/pull/134758#top
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:mainhttps://github.com/python/cpython/tree/main
ericsnowcurrently:fix-missing-builtinshttps://github.com/ericsnowcurrently/cpython/tree/fix-missing-builtins
Conversation 9 https://github.com/python/cpython/pull/134758
Commits 3 https://github.com/python/cpython/pull/134758/commits
Checks 38 https://github.com/python/cpython/pull/134758/checks
Files changed https://github.com/python/cpython/pull/134758/files
Please reload this pagehttps://github.com/python/cpython/pull/134758
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
May 26, 2025https://github.com/python/cpython/pull/134758#issue-3092165068
Please reload this pagehttps://github.com/python/cpython/pull/134758
gh-133481https://github.com/python/cpython/pull/133481
Improvements to test.support.interpreters.Interpreter #132775https://github.com/python/cpython/issues/132775
Please reload this pagehttps://github.com/python/cpython/pull/134758
https://github.com/ericsnowcurrently
Always set __builtins__ in _PyFunction_FromXIData().https://github.com/python/cpython/pull/134758/commits/d3a8365ba1607f1d25f152257413b5904f1df6cf
d3a8365https://github.com/python/cpython/pull/134758/commits/d3a8365ba1607f1d25f152257413b5904f1df6cf
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
May 26, 2025https://github.com/python/cpython/pull/134758#event-17819993632
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
May 26, 2025 https://github.com/python/cpython/pull/134758#ref-issue-3008765764
Improvements to test.support.interpreters.Interpreter #132775 https://github.com/python/cpython/issues/132775
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 26, 2025https://github.com/python/cpython/pull/134758#event-17819993975
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
May 27, 2025 https://github.com/python/cpython/pull/134758#pullrequestreview-2869278183
View reviewed changes https://github.com/python/cpython/pull/134758/files/d3a8365ba1607f1d25f152257413b5904f1df6cf
Python/crossinterp_data_lookup.hhttps://github.com/python/cpython/pull/134758/files/d3a8365ba1607f1d25f152257413b5904f1df6cf#diff-559fd54a9a40c9901d050fe3ba65d3c0a29744a3e3977a89bd97fc59d8a98e64
Please reload this pagehttps://github.com/python/cpython/pull/134758
Python/crossinterp_data_lookup.hhttps://github.com/python/cpython/pull/134758/files/d3a8365ba1607f1d25f152257413b5904f1df6cf#diff-559fd54a9a40c9901d050fe3ba65d3c0a29744a3e3977a89bd97fc59d8a98e64
Please reload this pagehttps://github.com/python/cpython/pull/134758
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
May 27, 2025 09:14https://github.com/python/cpython/pull/134758#commits-pushed-6c8da8d
https://github.com/ericsnowcurrently
Add a missing decref.https://github.com/python/cpython/pull/134758/commits/6c8da8d399db58f02edd1f2f3a3c4e54d4ff53d2
6c8da8dhttps://github.com/python/cpython/pull/134758/commits/6c8da8d399db58f02edd1f2f3a3c4e54d4ff53d2
https://github.com/ericsnowcurrently
Use a static str for "__builtins__".https://github.com/python/cpython/pull/134758/commits/f254ec7fe2807bbfccc5051c893fc3be4b5fa353
f254ec7https://github.com/python/cpython/pull/134758/commits/f254ec7fe2807bbfccc5051c893fc3be4b5fa353
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
May 27, 2025 15:17https://github.com/python/cpython/pull/134758#event-17832953480
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
May 27, 2025 https://github.com/python/cpython/pull/134758#pullrequestreview-2871535760
View reviewed changes https://github.com/python/cpython/pull/134758/files/f254ec7fe2807bbfccc5051c893fc3be4b5fa353
ZeroIntensityhttps://github.com/ZeroIntensity
https://github.com/python/cpython/pull/134758#pullrequestreview-2871535760
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/134758
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
9b5e800https://github.com/python/cpython/commit/9b5e80000ee179eb028841709f10dac9af7c36e7
May 27, 2025https://github.com/python/cpython/pull/134758#event-17833392898
Please reload this pagehttps://github.com/python/cpython/pull/134758
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 27, 2025https://github.com/python/cpython/pull/134758#event-17833393828
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
May 27, 2025https://github.com/python/cpython/pull/134758#issuecomment-2913064837
@ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Please reload this pagehttps://github.com/python/cpython/pull/134758
miss-islingtonhttps://github.com/miss-islington
May 27, 2025 https://github.com/python/cpython/pull/134758#ref-commit-99872b1
https://github.com/ericsnowcurrently
https://github.com/miss-islington
pythongh-132775https://github.com/python/cpython/issues/132775
: Always Set __builtins__ In _PyFunction_FromXIData() (https://github.com/miss-islington/cpython/commit/99872b1d92813c518601f936ed9e6204ad25bc4c
p…https://github.com/python/cpython/pull/134758
99872b1https://github.com/miss-islington/cpython/commit/99872b1d92813c518601f936ed9e6204ad25bc4c
…ythongh-134758https://github.com/python/cpython/pull/134758
pythongh-133481https://github.com/python/cpython/pull/133481
9b5e800https://github.com/miss-islington/cpython/commit/9b5e80000ee179eb028841709f10dac9af7c36e7
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
May 27, 2025https://github.com/python/cpython/pull/134758#issuecomment-2913065334
GH-134794https://github.com/python/cpython/pull/134794
3.14 branchhttps://github.com/python/cpython/tree/3.14
Please reload this pagehttps://github.com/python/cpython/pull/134758
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
May 27, 2025https://github.com/python/cpython/pull/134758#event-17833397432
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
May 27, 2025 15:47https://github.com/python/cpython/pull/134758#event-17833490921
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
May 27, 2025 https://github.com/python/cpython/pull/134758#ref-commit-6493395
https://github.com/miss-islington
https://github.com/ericsnowcurrently
[3.14]https://github.com/python/cpython/commit/6493395f4b69c561db14fdb5c10a819fda52138d
gh-132775https://github.com/python/cpython/issues/132775
: Always Set __builtins__ In _PyFunction_FromXIData() (https://github.com/python/cpython/commit/6493395f4b69c561db14fdb5c10a819fda52138d
…https://github.com/python/cpython/pull/134794
6493395https://github.com/python/cpython/commit/6493395f4b69c561db14fdb5c10a819fda52138d
…gh-134794https://github.com/python/cpython/pull/134794
gh-133481https://github.com/python/cpython/pull/133481
9b5e800https://github.com/python/cpython/commit/9b5e80000ee179eb028841709f10dac9af7c36e7
gh-134758https://github.com/python/cpython/pull/134758
Pranjal095https://github.com/Pranjal095
Jul 12, 2025 https://github.com/python/cpython/pull/134758#ref-commit-5d23925
https://github.com/ericsnowcurrently
https://github.com/Pranjal095
pythongh-132775https://github.com/python/cpython/issues/132775
: Always Set __builtins__ In _PyFunction_FromXIData() (https://github.com/Pranjal095/cpython/commit/5d23925bf1d1e75e703eb2dd4060584c170a9d12
p…https://github.com/python/cpython/pull/134758
5d23925https://github.com/Pranjal095/cpython/commit/5d23925bf1d1e75e703eb2dd4060584c170a9d12
…ythongh-134758https://github.com/python/cpython/pull/134758
pythongh-133481https://github.com/python/cpython/pull/133481
taegyunkimhttps://github.com/taegyunkim
Aug 4, 2025 https://github.com/python/cpython/pull/134758#ref-commit-6e294e1
https://github.com/ericsnowcurrently
https://github.com/taegyunkim
pythongh-132775https://github.com/python/cpython/issues/132775
: Always Set __builtins__ In _PyFunction_FromXIData() (https://github.com/taegyunkim/cpython/commit/6e294e1680db1b4ef7dbf381ec55140bde89cfdf
p…https://github.com/python/cpython/pull/134758
6e294e1https://github.com/taegyunkim/cpython/commit/6e294e1680db1b4ef7dbf381ec55140bde89cfdf
…ythongh-134758https://github.com/python/cpython/pull/134758
pythongh-133481https://github.com/python/cpython/pull/133481
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F134758
https://github.com/ZeroIntensity
ZeroIntensity https://github.com/ZeroIntensity
https://github.com/python/cpython/pull/134758/files/f254ec7fe2807bbfccc5051c893fc3be4b5fa353
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/134758
https://github.com/ericsnowcurrently
https://github.com/ZeroIntensity
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.