Title: gh-134644: handle exceptions set in `PyOS_Readline` by duaneg · Pull Request #134645 · python/cpython · GitHub
Open Graph Title: gh-134644: handle exceptions set in `PyOS_Readline` by duaneg · Pull Request #134645 · python/cpython
X Title: gh-134644: handle exceptions set in `PyOS_Readline` by duaneg · Pull Request #134645 · python/cpython
Description: The builtin input calls PyOS_Readline but seems to assume it does not set exceptions: if the call fails it checks signals and runs handlers if any are pending, which will cause an assertion failure if an exception has already been set. Fix this by only checking signals if an exception has not already been set. Issue: gh-134644
Open Graph Description: The builtin input calls PyOS_Readline but seems to assume it does not set exceptions: if the call fails it checks signals and runs handlers if any are pending, which will cause an assertion failure...
X Description: The builtin input calls PyOS_Readline but seems to assume it does not set exceptions: if the call fails it checks signals and runs handlers if any are pending, which will cause an assertion failure...
Opengraph URL: https://github.com/python/cpython/pull/134645
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:1ca97e3f-f07e-c5e2-35e6-c7380f11f019 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A084:2FB483:530385B:74D2EA7:6A5726E8 |
| html-safe-nonce | 81ca70ba7f71aa2df69f5756fe97d2af04ce4da52b8bf1998b0c754512962c11 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMDg0OjJGQjQ4Mzo1MzAzODVCOjc0RDJFQTc6NkE1NzI2RTgiLCJ2aXNpdG9yX2lkIjoiODU3NjIwMjMwNzczMzQ5NzU3NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 175163e98c93b8507f75b1626aafea741fc9d99bea70461b6d7cad399d6ec8b0 |
| hovercard-subject-tag | pull_request:2542213441 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/134645/files |
| twitter:image | https://avatars.githubusercontent.com/u/713786?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/713786?s=400&v=4 |
| og:image:alt | The builtin input calls PyOS_Readline but seems to assume it does not set exceptions: if the call fails it checks signals and runs handlers if any are pending, which will cause an assertion failure... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4e7a7296a3830877cf21a6ad2a972c9e618a48915e03966cf0c53eb08e5aad98 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2576d1f0198cf1588faf2edf27f1ed120903be10 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width