René's URL Explorer Experiment

Title: gh-51067: Add `remove()` and `repack()` to `ZipFile` by danny0838 · Pull Request #134627 · python/cpython · GitHub

Open Graph Title: gh-51067: Add `remove()` and `repack()` to `ZipFile` by danny0838 · Pull Request #134627 · python/cpython

X Title: gh-51067: Add `remove()` and `repack()` to `ZipFile` by danny0838 · Pull Request #134627 · python/cpython

Description: This is a revised version of PR #103033, implementing two new methods in zipfile.ZipFile: remove() and repack(), as suggested in this comment. Features ZipFile.remove(zinfo_or_arcname) Removes a file entry (by providing a str path or ZipInfo) from the central directory. If there are multiple file entries with the same path, only one is removed when a str path is provided. Returns the removed ZipInfo instance. Supported in modes: 'a', 'w', 'x'. ZipFile.repack(removed=None) Physically removes stale local file entry data that is no longer referenced by the central directory. Shrinks the archive file size. If removed is passed (as a sequence of removed ZipInfos), only their corresponding local file entry data are removed. Only supported in mode 'a'. Rationales Heuristics Used in repack() Since repack() does not immediately clean up removed entries at the time a remove() is called, the header information of removed file entries may be missing, and thus it can be technically difficult to determine whether certain stale bytes are really previously removed files and safe to remove. While local file entries begin with the magic signature PK\x03\x04, this alone is not a reliable indicator. For instance, a self-extracting ZIP file may contain executable code before the actual archive, which could coincidentally include such a signature, especially if it embeds ZIP-based content. To safely reclaim space, repack() assumes that in a normal ZIP file, local file entries are stored consecutively: File entries must not overlap. If any entry’s data overlaps with the next, a BadZipFile error is raised and no changes are made. There should be no extra bytes between entries (or between the last entry and the central directory): Data before the first referenced entry is removed only when it appears to be a sequence of consecutive entries with no extra following bytes; extra preceeding bytes are preserved. Data between referenced entries is removed only when it appears to be a sequence of consecutive entries with no extra preceding bytes; extra following bytes are preserved. Check the doc in the source code of _ZipRepacker.repack() (which is internally called by ZipFile.repack()) for more details. Supported Modes There has been opinions that a repacking should support mode 'w' and 'x' (e. g. #51067 (comment)). This is NOT introduced since such modes do not truncate the file at the end of writing, and won't really shrink the file size after a removal has been made. Although we do can change the behavior for the existing API, some further care has to be made because mode 'w' and 'x' may be used on an unseekable file and will be broken by such change. OTOH, mode 'a' is not expected to work with an unseekable file since an initial seek is made immediately when it is opened. Issue: gh-51067 📚 Documentation preview 📚: https://cpython-previews--134627.org.readthedocs.build/

Open Graph Description: This is a revised version of PR #103033, implementing two new methods in zipfile.ZipFile: remove() and repack(), as suggested in this comment. Features ZipFile.remove(zinfo_or_arcname) Removes a f...

X Description: This is a revised version of PR #103033, implementing two new methods in zipfile.ZipFile: remove() and repack(), as suggested in this comment. Features ZipFile.remove(zinfo_or_arcname) Removes a f...

Opengraph URL: https://github.com/python/cpython/pull/134627

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width