René's URL Explorer Experiment


Title: [3.14] gh-133982: Run unclosed file test on all io implementations (gh-134165) by miss-islington · Pull Request #134433 · python/cpython · GitHub

Open Graph Title: [3.14] gh-133982: Run unclosed file test on all io implementations (gh-134165) by miss-islington · Pull Request #134433 · python/cpython

X Title: [3.14] gh-133982: Run unclosed file test on all io implementations (gh-134165) by miss-islington · Pull Request #134433 · python/cpython

Description: Update test_io _check_warn_on_dealloc to use self. to dispatch to different I/O implementations. Update the _pyio implementation to match expected behavior, using the same _dealloc_warn design as the C implementation uses to report the topmost __del__ object. The FileIO one now matches all the others, so can use IOBase. There was a missing check on closing (self._fd must be valid), add that check (cherry picked from commit 5b0e827) Co-authored-by: Cody Maloney cmaloney@users.noreply.github.com Issue: gh-133982

Open Graph Description: Update test_io _check_warn_on_dealloc to use self. to dispatch to different I/O implementations. Update the _pyio implementation to match expected behavior, using the same _dealloc_warn design as t...

X Description: Update test_io _check_warn_on_dealloc to use self. to dispatch to different I/O implementations. Update the _pyio implementation to match expected behavior, using the same _dealloc_warn design as t...

Opengraph URL: https://github.com/python/cpython/pull/134433

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5731f537-bc41-5570-1ac1-62cde5e5d24e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD70:356616:17554C4:1FE16EB:6A546CE5
html-safe-nonce64ae26b683ef7b3fd882aa689653a813de5c2af050dd735695d85c12018192a0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDcwOjM1NjYxNjoxNzU1NEM0OjFGRTE2RUI6NkE1NDZDRTUiLCJ2aXNpdG9yX2lkIjoiODAxOTUwNzY2NDk0MDk4NTU3MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3cdf64f9b20b19a5a66871af49a0d62e39924edff28038b51a32f4b8609da131
hovercard-subject-tagpull_request:2534651071
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/134433/files
twitter:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
og:image:altUpdate test_io _check_warn_on_dealloc to use self. to dispatch to different I/O implementations. Update the _pyio implementation to match expected behavior, using the same _dealloc_warn design as t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release6d28624802c2f7d9500239dd6870ed7031b7353b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/134433/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F134433%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F134433%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/134433/files
Reloadhttps://github.com/python/cpython/pull/134433/files
Reloadhttps://github.com/python/cpython/pull/134433/files
Please reload this pagehttps://github.com/python/cpython/pull/134433/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/134433/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ambvhttps://github.com/ambv
python:3.14https://github.com/python/cpython/tree/3.14
miss-islington:backport-5b0e827-3.14https://github.com/miss-islington/cpython/tree/backport-5b0e827-3.14
Conversation 0 https://github.com/python/cpython/pull/134433
Commits 1 https://github.com/python/cpython/pull/134433/commits
Checks 0 https://github.com/python/cpython/pull/134433/checks
Files changed https://github.com/python/cpython/pull/134433/files
Please reload this pagehttps://github.com/python/cpython/pull/134433/files
[3.14] gh-133982: Run unclosed file test on all io implementations (gh-134165) https://github.com/python/cpython/pull/134433/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/134433/files
0b27e08 gh-133982: Run unclosed file test on all io implementations (gh-134165) cmaloney May 21, 2025 https://github.com/python/cpython/pull/134433/commits/0b27e081a833cdd00612e54c10b2d56862d982f0
Clear filters https://github.com/python/cpython/pull/134433/files
Please reload this pagehttps://github.com/python/cpython/pull/134433/files
Please reload this pagehttps://github.com/python/cpython/pull/134433/files
_pyio.py https://github.com/python/cpython/pull/134433/files#diff-bcdfa9cbb0764d7959cda48f9084d79785f87c5ad7460f27ba2678b0bda76e38
test_io.py https://github.com/python/cpython/pull/134433/files#diff-c6987f6d27855daad275cfbf05fb3684c53fc82ff7146cd157e5838f9ad5f57f
2025-05-17-20-23-57.gh-issue-133982.smS7au.rst https://github.com/python/cpython/pull/134433/files#diff-aa1d1134af7fa267d3309be643895c499ee2f76fc467d0523470212d451380a1
Lib/_pyio.pyhttps://github.com/python/cpython/pull/134433/files#diff-bcdfa9cbb0764d7959cda48f9084d79785f87c5ad7460f27ba2678b0bda76e38
View file https://github.com/miss-islington/cpython/blob/0b27e081a833cdd00612e54c10b2d56862d982f0/Lib/_pyio.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/134433/{{ revealButtonHref }}
https://github.com/python/cpython/pull/134433/files#diff-bcdfa9cbb0764d7959cda48f9084d79785f87c5ad7460f27ba2678b0bda76e38
https://github.com/python/cpython/pull/134433/files#diff-bcdfa9cbb0764d7959cda48f9084d79785f87c5ad7460f27ba2678b0bda76e38
https://github.com/python/cpython/pull/134433/files#diff-bcdfa9cbb0764d7959cda48f9084d79785f87c5ad7460f27ba2678b0bda76e38
https://github.com/python/cpython/pull/134433/files#diff-bcdfa9cbb0764d7959cda48f9084d79785f87c5ad7460f27ba2678b0bda76e38
https://github.com/python/cpython/pull/134433/files#diff-bcdfa9cbb0764d7959cda48f9084d79785f87c5ad7460f27ba2678b0bda76e38
https://github.com/python/cpython/pull/134433/files#diff-bcdfa9cbb0764d7959cda48f9084d79785f87c5ad7460f27ba2678b0bda76e38
https://github.com/python/cpython/pull/134433/files#diff-bcdfa9cbb0764d7959cda48f9084d79785f87c5ad7460f27ba2678b0bda76e38
https://github.com/python/cpython/pull/134433/files#diff-bcdfa9cbb0764d7959cda48f9084d79785f87c5ad7460f27ba2678b0bda76e38
https://github.com/python/cpython/pull/134433/files#diff-bcdfa9cbb0764d7959cda48f9084d79785f87c5ad7460f27ba2678b0bda76e38
https://github.com/python/cpython/pull/134433/files#diff-bcdfa9cbb0764d7959cda48f9084d79785f87c5ad7460f27ba2678b0bda76e38
Lib/test/test_io.pyhttps://github.com/python/cpython/pull/134433/files#diff-c6987f6d27855daad275cfbf05fb3684c53fc82ff7146cd157e5838f9ad5f57f
View file https://github.com/miss-islington/cpython/blob/0b27e081a833cdd00612e54c10b2d56862d982f0/Lib/test/test_io.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/134433/{{ revealButtonHref }}
https://github.com/python/cpython/pull/134433/files#diff-c6987f6d27855daad275cfbf05fb3684c53fc82ff7146cd157e5838f9ad5f57f
https://github.com/python/cpython/pull/134433/files#diff-c6987f6d27855daad275cfbf05fb3684c53fc82ff7146cd157e5838f9ad5f57f
https://github.com/python/cpython/pull/134433/files#diff-c6987f6d27855daad275cfbf05fb3684c53fc82ff7146cd157e5838f9ad5f57f
https://github.com/python/cpython/pull/134433/files#diff-c6987f6d27855daad275cfbf05fb3684c53fc82ff7146cd157e5838f9ad5f57f
Misc/NEWS.d/next/Library/2025-05-17-20-23-57.gh-issue-133982.smS7au.rsthttps://github.com/python/cpython/pull/134433/files#diff-aa1d1134af7fa267d3309be643895c499ee2f76fc467d0523470212d451380a1
View file https://github.com/miss-islington/cpython/blob/0b27e081a833cdd00612e54c10b2d56862d982f0/Misc/NEWS.d/next/Library/2025-05-17-20-23-57.gh-issue-133982.smS7au.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/134433/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.