| route-pattern | /:user_id/:repository/pull/*id(.:format) |
| route-controller | pull_requests |
| route-action | show |
| fetch-nonce | v2:82047a1f-43be-1409-5bd0-3acc8018e30c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C6EE:166D49:15E67EB:1E361FC:696A98E7 |
| html-safe-nonce | 267e2108a2b7012caced7f5e80aa6a283ecb87bb7314c730b0799a8e68064625 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNkVFOjE2NkQ0OToxNUU2N0VCOjFFMzYxRkM6Njk2QTk4RTciLCJ2aXNpdG9yX2lkIjoiODg1NDgwOTYyMzY5Njg5ODMxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | f87634c4827c858eadd5680c215ee790cca6c5d2cb6568efd33ceb63f90fc59f |
| hovercard-subject-tag | pull_request:2534642400 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/134432 |
| twitter:image | https://opengraph.githubassets.com/e0cf4d731019dda03dc8a1f3d0b16d614353fd03e39372279e0d2295deb95252/python/cpython/pull/134432 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e0cf4d731019dda03dc8a1f3d0b16d614353fd03e39372279e0d2295deb95252/python/cpython/pull/134432 |
| og:image:alt | This PR refactors shared code between _zstd.train_dict and _zstd.finalize_dict, related to verifying and getting the size and number of samples.
Issue: Implement PEP 784 - Adding Zstandard to the... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | emmatyping |
| hostname | github.com |
| expected-hostname | github.com |
| None | c0d8175e41e0e55b9e984c935b24b808cabab919dd3174aa45dac3ef503ed1af |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 99aab454e5ddc8df30805fb76c114c3008a15842 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/134432#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F134432 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F134432 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/134432 |
| Reload | https://github.com/python/cpython/pull/134432 |
| Reload | https://github.com/python/cpython/pull/134432 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/134432 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/134432 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/134432#issue-comment-box |
| gpshead | https://github.com/gpshead |
| python:main | https://github.com/python/cpython/tree/main |
| emmatyping:zstd-refactor-dict-code | https://github.com/emmatyping/cpython/tree/zstd-refactor-dict-code |
|
gh-132983: Refactor shared code in train_dict and finalize_dict
| https://github.com/python/cpython/pull/134432#top |
| gpshead | https://github.com/gpshead |
| python:main | https://github.com/python/cpython/tree/main |
| emmatyping:zstd-refactor-dict-code | https://github.com/emmatyping/cpython/tree/zstd-refactor-dict-code |
|
Conversation
2
| https://github.com/python/cpython/pull/134432 |
|
Commits
1
| https://github.com/python/cpython/pull/134432/commits |
|
Checks
48
| https://github.com/python/cpython/pull/134432/checks |
|
Files changed
| https://github.com/python/cpython/pull/134432/files |
| Please reload this page | https://github.com/python/cpython/pull/134432 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/emmatyping |
| emmatyping | https://github.com/emmatyping |
| May 21, 2025 | https://github.com/python/cpython/pull/134432#issue-3080501536 |
| Please reload this page | https://github.com/python/cpython/pull/134432 |
| Implement PEP 784 - Adding Zstandard to the Python standard library #132983 | https://github.com/python/cpython/issues/132983 |
| Please reload this page | https://github.com/python/cpython/pull/134432 |
|
| https://github.com/emmatyping |
| Refactor shared code in train_dict and finalize_dict | https://github.com/python/cpython/pull/134432/commits/15e754c59dc4e68308b243f065c0bb781401a11f |
| 15e754c | https://github.com/python/cpython/pull/134432/commits/15e754c59dc4e68308b243f065c0bb781401a11f |
| https://github.com/emmatyping |
| emmatyping | https://github.com/emmatyping |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
|
needs backport to 3.14
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22 |
| May 21, 2025 | https://github.com/python/cpython/pull/134432#event-17755457963 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| May 21, 2025 | https://github.com/python/cpython/pull/134432#event-17755459710 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
May 21, 2025
| https://github.com/python/cpython/pull/134432#ref-issue-3021300364 |
|
Implement PEP 784 - Adding Zstandard to the Python standard library
#132983
| https://github.com/python/cpython/issues/132983 |
| https://github.com/gpshead |
| gpshead | https://github.com/gpshead |
|
May 21, 2025
| https://github.com/python/cpython/pull/134432#pullrequestreview-2858320058 |
|
View reviewed changes
| https://github.com/python/cpython/pull/134432/files/15e754c59dc4e68308b243f065c0bb781401a11f |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| May 21, 2025 | https://github.com/python/cpython/pull/134432#event-17756712335 |
| https://github.com/gpshead |
| gpshead | https://github.com/gpshead |
| c64a214 | https://github.com/python/cpython/commit/c64a21454b3c139af9e88941a286885fc4828a7e |
| May 21, 2025 | https://github.com/python/cpython/pull/134432#event-17756717660 |
| Please reload this page | https://github.com/python/cpython/pull/134432 |
| https://github.com/apps/miss-islington-app |
| miss-islington-app | https://github.com/apps/miss-islington-app |
| May 21, 2025 | https://github.com/python/cpython/pull/134432#issuecomment-2898460887 |
| @emmatyping | https://github.com/emmatyping |
| @gpshead | https://github.com/gpshead |
| Please reload this page | https://github.com/python/cpython/pull/134432 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| May 21, 2025 | https://github.com/python/cpython/pull/134432#event-17756718725 |
| miss-islington | https://github.com/miss-islington |
|
May 21, 2025
| https://github.com/python/cpython/pull/134432#ref-commit-24c6f25 |
|
| https://github.com/emmatyping |
|
| https://github.com/miss-islington |
| pythongh-132983 | https://github.com/python/cpython/issues/132983 |
| : Refactor shared code in train_dict and finalize_dict ( | https://github.com/miss-islington/cpython/commit/24c6f25273246735879ca15e474340f1f8e5735e |
| … | https://github.com/python/cpython/pull/134432 |
| 24c6f25 | https://github.com/miss-islington/cpython/commit/24c6f25273246735879ca15e474340f1f8e5735e |
| …pythonGH-134432 | https://github.com/python/cpython/pull/134432 |
| c64a214 | https://github.com/miss-islington/cpython/commit/c64a21454b3c139af9e88941a286885fc4828a7e |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
| May 21, 2025 | https://github.com/python/cpython/pull/134432#issuecomment-2898461513 |
| GH-134442 | https://github.com/python/cpython/pull/134442 |
| 3.14 branch | https://github.com/python/cpython/tree/3.14 |
| Please reload this page | https://github.com/python/cpython/pull/134432 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
needs backport to 3.14
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22 |
| May 21, 2025 | https://github.com/python/cpython/pull/134432#event-17756722283 |
| gpshead | https://github.com/gpshead |
|
May 21, 2025
| https://github.com/python/cpython/pull/134432#ref-commit-cdc92cd |
|
| https://github.com/miss-islington |
|
| https://github.com/emmatyping |
| [3.14] | https://github.com/python/cpython/commit/cdc92cd9fc17f6e06c51584cde2ab6cf21f188d4 |
| gh-132983 | https://github.com/python/cpython/issues/132983 |
| : Refactor shared code in train_dict and finalize_dict ( | https://github.com/python/cpython/commit/cdc92cd9fc17f6e06c51584cde2ab6cf21f188d4 |
| cdc92cd | https://github.com/python/cpython/commit/cdc92cd9fc17f6e06c51584cde2ab6cf21f188d4 |
| GH-134432 | https://github.com/python/cpython/pull/134432 |
| #134442 | https://github.com/python/cpython/pull/134442 |
| gh-132983 | https://github.com/python/cpython/issues/132983 |
| GH-134432 | https://github.com/python/cpython/pull/134432 |
| c64a214 | https://github.com/python/cpython/commit/c64a21454b3c139af9e88941a286885fc4828a7e |
| lkollar | https://github.com/lkollar |
|
May 26, 2025
| https://github.com/python/cpython/pull/134432#ref-commit-76647d2 |
|
| https://github.com/emmatyping |
|
| https://github.com/lkollar |
| pythongh-132983 | https://github.com/python/cpython/issues/132983 |
| : Refactor shared code in train_dict and finalize_dict ( | https://github.com/lkollar/cpython/commit/76647d2830f6f06ea8ff51ec85b89761e1d08587 |
| … | https://github.com/python/cpython/pull/134432 |
| 76647d2 | https://github.com/lkollar/cpython/commit/76647d2830f6f06ea8ff51ec85b89761e1d08587 |
| …pythonGH-134432 | https://github.com/python/cpython/pull/134432 |
| Pranjal095 | https://github.com/Pranjal095 |
|
Jul 12, 2025
| https://github.com/python/cpython/pull/134432#ref-commit-c2cb04b |
|
| https://github.com/emmatyping |
|
| https://github.com/Pranjal095 |
| pythongh-132983 | https://github.com/python/cpython/issues/132983 |
| : Refactor shared code in train_dict and finalize_dict ( | https://github.com/Pranjal095/cpython/commit/c2cb04b728c4cc1277dda82be6bfed7fb06c142f |
| … | https://github.com/python/cpython/pull/134432 |
| c2cb04b | https://github.com/Pranjal095/cpython/commit/c2cb04b728c4cc1277dda82be6bfed7fb06c142f |
| …pythonGH-134432 | https://github.com/python/cpython/pull/134432 |
| taegyunkim | https://github.com/taegyunkim |
|
Aug 4, 2025
| https://github.com/python/cpython/pull/134432#ref-commit-c267e74 |
|
| https://github.com/emmatyping |
|
| https://github.com/taegyunkim |
| pythongh-132983 | https://github.com/python/cpython/issues/132983 |
| : Refactor shared code in train_dict and finalize_dict ( | https://github.com/taegyunkim/cpython/commit/c267e7432033d650e4684014ed043e849e04477f |
| … | https://github.com/python/cpython/pull/134432 |
| c267e74 | https://github.com/taegyunkim/cpython/commit/c267e7432033d650e4684014ed043e849e04477f |
| …pythonGH-134432 | https://github.com/python/cpython/pull/134432 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F134432 |
|
| https://github.com/gpshead |
|
gpshead
| https://github.com/gpshead |
|
| https://github.com/python/cpython/pull/134432/files/15e754c59dc4e68308b243f065c0bb781401a11f |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Please reload this page | https://github.com/python/cpython/pull/134432 |
|
| https://github.com/emmatyping |
|
| https://github.com/gpshead |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |