René's URL Explorer Experiment


Title: gh-134079: Add `addCleanup`, `enterContext` and `doCleanups` to `unittest.subTest` and tests by ArunRawat404 · Pull Request #134318 · python/cpython · GitHub

Open Graph Title: gh-134079: Add `addCleanup`, `enterContext` and `doCleanups` to `unittest.subTest` and tests by ArunRawat404 · Pull Request #134318 · python/cpython

X Title: gh-134079: Add `addCleanup`, `enterContext` and `doCleanups` to `unittest.subTest` and tests by ArunRawat404 · Pull Request #134318 · python/cpython

Description: Summary gh-134079: Add addCleanup, enterContext and doCleanups to unittest.subTest and add corresponding tests Description This PR implements support for addCleanup, enterContext, and doCleanups in unittest.subTest() contexts, as discussed in issue-134079. This enables users to register cleanups or use context managers inside a with self.subTest(): block, similar to how it's done in TestCase Tests Added tests in test_runner.py to validate: Cleanup order (LIFO) Cleanup on failure enterContext() behavior on success/failure Exception safety in context manager entry and exit I'm still learning the internals of CPython and writing tests, so please don't hesitate to suggest improvements. I'd really appreciate any feedback.

Open Graph Description: Summary gh-134079: Add addCleanup, enterContext and doCleanups to unittest.subTest and add corresponding tests Description This PR implements support for addCleanup, enterContext, and doCleanups i...

X Description: Summary gh-134079: Add addCleanup, enterContext and doCleanups to unittest.subTest and add corresponding tests Description This PR implements support for addCleanup, enterContext, and doCleanups i...

Opengraph URL: https://github.com/python/cpython/pull/134318

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6198f7fe-10d7-7a2f-9eb6-357b34c88797
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9572:399E4B:1333AC1:1984DF1:6B012194
html-safe-nonce9351b38f067e05089e1e2ae907582d333ed43b4c27d43fcff7e44f86cbea9344
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NTcyOjM5OUU0QjoxMzMzQUMxOjE5ODRERjE6NkIwMTIxOTQiLCJ2aXNpdG9yX2lkIjoiMTk2MDM2ODI3MTM1NDA0NDgyMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4892640d66e04fa5a7044a348145593c65388fbec2455a69f87ea681f6b61ea8
hovercard-subject-tagpull_request:2530750871
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/134318/files
twitter:imagehttps://avatars.githubusercontent.com/u/88387461?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/88387461?s=400&v=4
og:image:altSummary gh-134079: Add addCleanup, enterContext and doCleanups to unittest.subTest and add corresponding tests Description This PR implements support for addCleanup, enterContext, and doCleanups i...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/134318/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F134318%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F134318%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/134318/files
Reloadhttps://github.com/python/cpython/pull/134318/files
Reloadhttps://github.com/python/cpython/pull/134318/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ArunRawat404https://github.com/ArunRawat404
python:mainhttps://github.com/python/cpython/tree/main
ArunRawat404:fix-issue-134079https://github.com/ArunRawat404/cpython/tree/fix-issue-134079
Conversation 16 https://github.com/python/cpython/pull/134318
Commits 4 https://github.com/python/cpython/pull/134318/commits
Checks 0 https://github.com/python/cpython/pull/134318/checks
Files changed https://github.com/python/cpython/pull/134318/files
Please reload this pagehttps://github.com/python/cpython/pull/134318/files
gh-134079: Add addCleanup, enterContext and doCleanups to unittest.subTest and tests https://github.com/python/cpython/pull/134318/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/134318/files
d12ab40 feat: add _SubTestCleanupHelper for managing cleanups/context in subTest ArunRawat404 May 18, 2025 https://github.com/python/cpython/pull/134318/commits/d12ab40b2f8d8151c68b083d96829ab32e9d80bf
0edd1be test: add unit tests for subTest cleanup and context manager behavior ArunRawat404 May 19, 2025 https://github.com/python/cpython/pull/134318/commits/0edd1bed6991be4197ab0d2b47ce6cc87f217b8d
c9aad93 fix: update some basic code ArunRawat404 May 22, 2025 https://github.com/python/cpython/pull/134318/commits/c9aad9395e06186d0fcffe5d4173d8b2a5a97f33
f09d6f4 Add NEWS entry ArunRawat404 May 22, 2025 https://github.com/python/cpython/pull/134318/commits/f09d6f4a2ed3c5dc86dc6a5a1724ecacdf04f233
Clear filters https://github.com/python/cpython/pull/134318/files
Please reload this pagehttps://github.com/python/cpython/pull/134318/files
Please reload this pagehttps://github.com/python/cpython/pull/134318/files
test_runner.py https://github.com/python/cpython/pull/134318/files#diff-085ab71730e438937a5559aaea58cd1f06adfc941755bc081eab632f6b76dad4
case.py https://github.com/python/cpython/pull/134318/files#diff-c6fe1ffe930def48a6adf1fa99b974737bac586fdacccacd1474e7b2f11370eb
2025-05-22-18-45-14.gh-issue-134079.n89xN5.rst https://github.com/python/cpython/pull/134318/files#diff-2027a468c6023ab176f1592b1a77fe5111e84987bb1c735bf8bbcf40c2878f93
Lib/test/test_unittest/test_runner.pyhttps://github.com/python/cpython/pull/134318/files#diff-085ab71730e438937a5559aaea58cd1f06adfc941755bc081eab632f6b76dad4
View file https://github.com/python/cpython/blob/f09d6f4a2ed3c5dc86dc6a5a1724ecacdf04f233/Lib/test/test_unittest/test_runner.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/134318/{{ revealButtonHref }}
https://github.com/python/cpython/pull/134318/files#diff-085ab71730e438937a5559aaea58cd1f06adfc941755bc081eab632f6b76dad4
encukouhttps://github.com/encukou
May 29, 2025https://github.com/python/cpython/pull/134318/files#r2113813842
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/134318/files
Lib/unittest/case.pyhttps://github.com/python/cpython/pull/134318/files#diff-c6fe1ffe930def48a6adf1fa99b974737bac586fdacccacd1474e7b2f11370eb
View file https://github.com/python/cpython/blob/f09d6f4a2ed3c5dc86dc6a5a1724ecacdf04f233/Lib/unittest/case.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/134318/{{ revealButtonHref }}
https://github.com/python/cpython/pull/134318/files#diff-c6fe1ffe930def48a6adf1fa99b974737bac586fdacccacd1474e7b2f11370eb
https://github.com/python/cpython/pull/134318/files#diff-c6fe1ffe930def48a6adf1fa99b974737bac586fdacccacd1474e7b2f11370eb
https://github.com/python/cpython/pull/134318/files#diff-c6fe1ffe930def48a6adf1fa99b974737bac586fdacccacd1474e7b2f11370eb
https://github.com/python/cpython/pull/134318/files#diff-c6fe1ffe930def48a6adf1fa99b974737bac586fdacccacd1474e7b2f11370eb
encukouhttps://github.com/encukou
May 29, 2025https://github.com/python/cpython/pull/134318/files#r2113814734
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/134318/files
encukouhttps://github.com/encukou
May 29, 2025https://github.com/python/cpython/pull/134318/files#r2113814857
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/134318/files
encukouhttps://github.com/encukou
May 29, 2025https://github.com/python/cpython/pull/134318/files#r2113814929
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/134318/files
encukouhttps://github.com/encukou
May 29, 2025https://github.com/python/cpython/pull/134318/files#r2113814990
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/134318/files
Misc/NEWS.d/next/Library/2025-05-22-18-45-14.gh-issue-134079.n89xN5.rsthttps://github.com/python/cpython/pull/134318/files#diff-2027a468c6023ab176f1592b1a77fe5111e84987bb1c735bf8bbcf40c2878f93
View file https://github.com/python/cpython/blob/f09d6f4a2ed3c5dc86dc6a5a1724ecacdf04f233/Misc/NEWS.d/next/Library/2025-05-22-18-45-14.gh-issue-134079.n89xN5.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/134318/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.