René's URL Explorer Experiment


Title: gh-133885: Use locks instead of critical sections for _zstd by emmatyping · Pull Request #134289 · python/cpython · GitHub

Open Graph Title: gh-133885: Use locks instead of critical sections for _zstd by emmatyping · Pull Request #134289 · python/cpython

X Title: gh-133885: Use locks instead of critical sections for _zstd by emmatyping · Pull Request #134289 · python/cpython

Description: Move from using critical sections to locks for the (de)compression methods. Since the methods allow other threads to run, we should use a lock rather than a critical section. I'm not totally sure about the removal of the critical sections in the _get_(C|D)Dict function, but it should be safe to yield to other threads in an initializer as the values cannot be modified (ZstdDicts are immutable). Issue: gh-133885

Open Graph Description: Move from using critical sections to locks for the (de)compression methods. Since the methods allow other threads to run, we should use a lock rather than a critical section. I'm not totally su...

X Description: Move from using critical sections to locks for the (de)compression methods. Since the methods allow other threads to run, we should use a lock rather than a critical section. I'm not totall...

Opengraph URL: https://github.com/python/cpython/pull/134289

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c82b08e9-27b5-afeb-0c0e-e40d018bd72b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA056:2A0D62:CCB78E:11AF624:696A8CD8
html-safe-nonce677a6cc5d5b360486ea147ea5d9088b7bc72803240bec78066dcc354c96c8c16
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMDU2OjJBMEQ2MjpDQ0I3OEU6MTFBRjYyNDo2OTZBOENEOCIsInZpc2l0b3JfaWQiOiI2OTY3NTAxMjUzMDcxNTA2NjQ4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd6d2071499ef52573205eb064f099b79ab44aa73ea5fac0803f2323e84d4530c
hovercard-subject-tagpull_request:2529846072
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/134289/files
twitter:imagehttps://avatars.githubusercontent.com/u/9504279?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/9504279?s=400&v=4
og:image:altMove from using critical sections to locks for the (de)compression methods. Since the methods allow other threads to run, we should use a lock rather than a critical section. I'm not totally su...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned2aa6dedd7d97fa651b17c40401f2605f309df5ca5fb659bf0554cf34f1de825
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec1dbca8981c5e3d6a69bce2f1d289e732b86241d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/134289/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F134289%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F134289%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/134289/files
Reloadhttps://github.com/python/cpython/pull/134289/files
Reloadhttps://github.com/python/cpython/pull/134289/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/134289/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/134289/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
colesburyhttps://github.com/colesbury
python:mainhttps://github.com/python/cpython/tree/main
emmatyping:zstd-mutex-lockshttps://github.com/emmatyping/cpython/tree/zstd-mutex-locks
Conversation 66 https://github.com/python/cpython/pull/134289
Commits 18 https://github.com/python/cpython/pull/134289/commits
Checks 46 https://github.com/python/cpython/pull/134289/checks
Files changed https://github.com/python/cpython/pull/134289/files
Please reload this pagehttps://github.com/python/cpython/pull/134289/files
gh-133885: Use locks instead of critical sections for _zstd https://github.com/python/cpython/pull/134289/files#top
Show all changes 18 commits https://github.com/python/cpython/pull/134289/files
daa5f43 Use locks instead of critical sections emmatyping May 19, 2025 https://github.com/python/cpython/pull/134289/commits/daa5f438523ff7ce6b7510342e36607d3a526bee
0d14dc2 Remove one more critical section emmatyping May 19, 2025 https://github.com/python/cpython/pull/134289/commits/0d14dc26e8c41c6612e7b854319ffe3433f3137e
1b68e1e Make capsule management threadsafe emmatyping May 20, 2025 https://github.com/python/cpython/pull/134289/commits/1b68e1e098e201c6666e4fb2bcf48cf06678db94
f6602f4 Add a test for sharing a dictionary across threads emmatyping May 20, 2025 https://github.com/python/cpython/pull/134289/commits/f6602f4b5a15d4e2c8b7536fc2202d8d27c858c3
d8854c5 Move lock check in dealloc to an assert emmatyping May 20, 2025 https://github.com/python/cpython/pull/134289/commits/d8854c53a2ef11b73b96748f34124f5d93ea0d22
02fc2b3 Run threading checks on GIL builds too emmatyping May 20, 2025 https://github.com/python/cpython/pull/134289/commits/02fc2b3e8ecba886c9e42dccef792ec913a2499f
edbf444 Remove extra blank line emmatyping May 20, 2025 https://github.com/python/cpython/pull/134289/commits/edbf444b6b289af6c1e766380efd59c8ec3cf10a
bf287cf Remove extraneous whitespace emmatyping May 20, 2025 https://github.com/python/cpython/pull/134289/commits/bf287cfaf35ae17d1d579e241f5e799101e02cc8
005d1a0 Remove unused includes emmatyping May 21, 2025 https://github.com/python/cpython/pull/134289/commits/005d1a06ba8cd1fcef01f4fbcc57b010657f0f7e
84c5b30 Revert "Remove unused includes" emmatyping May 21, 2025 https://github.com/python/cpython/pull/134289/commits/84c5b3065f22cd4156bab9cd3f18ec8e3af421b6
ec31019 Put locks around ZstdDict usage emmatyping May 21, 2025 https://github.com/python/cpython/pull/134289/commits/ec310194c1149f6bf4263bb6a45897e7d909c412
2dbed4e Add tests for sharing all types of ZstdDict emmatyping May 21, 2025 https://github.com/python/cpython/pull/134289/commits/2dbed4eb8baa05ca7fa06a87509e896a24aff62c
afdabd5 Remove @critical_section emmatyping May 21, 2025 https://github.com/python/cpython/pull/134289/commits/afdabd5408890315414873eac393a6ff6216549d
d8d48c2 Add missing include emmatyping May 21, 2025 https://github.com/python/cpython/pull/134289/commits/d8d48c2deb75374d754806a698c0a995f10c1d41
d142aa8 Updates based on Sam's review emmatyping May 21, 2025 https://github.com/python/cpython/pull/134289/commits/d142aa849f56972b20a8df1e588b5dd540d7276c
43d3dea Pass NULL to PyDict_SetDefaultRef emmatyping May 22, 2025 https://github.com/python/cpython/pull/134289/commits/43d3dea9e9b20a4d6918608b09a4bc05747b95c3
93dec23 Put locks around relevant functions and use PyDict_GetItemRef emmatyping May 23, 2025 https://github.com/python/cpython/pull/134289/commits/93dec23d0e408df618c2c942b0181edd6bcd6f8d
69a755b Remove unused decref emmatyping May 23, 2025 https://github.com/python/cpython/pull/134289/commits/69a755bd828ed2729a3a622d3a92c353de90b184
Clear filters https://github.com/python/cpython/pull/134289/files
Please reload this pagehttps://github.com/python/cpython/pull/134289/files
Please reload this pagehttps://github.com/python/cpython/pull/134289/files
test_zstd.py https://github.com/python/cpython/pull/134289/files#diff-d347ebfcbcfd73ae33135b08623594cc45342d42b774fbbc80e508176f860d5d
decompressor.c.h https://github.com/python/cpython/pull/134289/files#diff-3728db4945d3c59d2b506fcd41fa4eedd3b1b829e859b71133c7cbd605179f5d
zstddict.c.h https://github.com/python/cpython/pull/134289/files#diff-db60f99b9abee38ad912fb35ed4623cf780e8558a39f11b269e98af0ac89c7b5
compressor.c https://github.com/python/cpython/pull/134289/files#diff-e7579a24d7495a5e7ec25e3834af991e480cacbf1a955ad78ab08148d9304e7d
decompressor.c https://github.com/python/cpython/pull/134289/files#diff-5b717a4e417388ae310008129390ff165e9273f8183293709512e4c4feaa4889
zstddict.c https://github.com/python/cpython/pull/134289/files#diff-843cde9ff156cba804a82b9a5fadf094807d73eeda82de08188bcf594ac5be3b
zstddict.h https://github.com/python/cpython/pull/134289/files#diff-a25430223b9c036e3830f96f4c25ebf6c34066384661d489c8a0cb97fc122e8d
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L628
Lib/test/test_zstd.pyhttps://github.com/python/cpython/pull/134289/files#diff-d347ebfcbcfd73ae33135b08623594cc45342d42b774fbbc80e508176f860d5d
View file https://github.com/emmatyping/cpython/blob/69a755bd828ed2729a3a622d3a92c353de90b184/Lib/test/test_zstd.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/134289/{{ revealButtonHref }}
https://github.com/python/cpython/pull/134289/files#diff-d347ebfcbcfd73ae33135b08623594cc45342d42b774fbbc80e508176f860d5d
https://github.com/python/cpython/pull/134289/files#diff-d347ebfcbcfd73ae33135b08623594cc45342d42b774fbbc80e508176f860d5d
https://github.com/python/cpython/pull/134289/files#diff-d347ebfcbcfd73ae33135b08623594cc45342d42b774fbbc80e508176f860d5d
https://github.com/python/cpython/pull/134289/files#diff-d347ebfcbcfd73ae33135b08623594cc45342d42b774fbbc80e508176f860d5d
https://github.com/python/cpython/pull/134289/files#diff-d347ebfcbcfd73ae33135b08623594cc45342d42b774fbbc80e508176f860d5d
https://github.com/python/cpython/pull/134289/files#diff-d347ebfcbcfd73ae33135b08623594cc45342d42b774fbbc80e508176f860d5d
Modules/_zstd/clinic/decompressor.c.hhttps://github.com/python/cpython/pull/134289/files#diff-3728db4945d3c59d2b506fcd41fa4eedd3b1b829e859b71133c7cbd605179f5d
View file https://github.com/emmatyping/cpython/blob/69a755bd828ed2729a3a622d3a92c353de90b184/Modules/_zstd/clinic/decompressor.c.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/134289/files
Modules/_zstd/clinic/zstddict.c.hhttps://github.com/python/cpython/pull/134289/files#diff-db60f99b9abee38ad912fb35ed4623cf780e8558a39f11b269e98af0ac89c7b5
View file https://github.com/emmatyping/cpython/blob/69a755bd828ed2729a3a622d3a92c353de90b184/Modules/_zstd/clinic/zstddict.c.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/134289/files
Please reload this pagehttps://github.com/python/cpython/pull/134289/files
Please reload this pagehttps://github.com/python/cpython/pull/134289/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.