René's URL Explorer Experiment


Title: gh-133885: Use locks instead of critical sections for _zstd by emmatyping · Pull Request #134289 · python/cpython · GitHub

Open Graph Title: gh-133885: Use locks instead of critical sections for _zstd by emmatyping · Pull Request #134289 · python/cpython

X Title: gh-133885: Use locks instead of critical sections for _zstd by emmatyping · Pull Request #134289 · python/cpython

Description: Move from using critical sections to locks for the (de)compression methods. Since the methods allow other threads to run, we should use a lock rather than a critical section. I'm not totally sure a...

Open Graph Description: Move from using critical sections to locks for the (de)compression methods. Since the methods allow other threads to run, we should use a lock rather than a critical section. I'm not totally su...

X Description: Move from using critical sections to locks for the (de)compression methods. Since the methods allow other threads to run, we should use a lock rather than a critical section. I'm not totall...

Opengraph URL: https://github.com/python/cpython/pull/134289

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:bc0d4471-66fd-3846-b89f-fe109b6c11f0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCC52:ECDF9:6773C:90DF6:696A69C9
html-safe-nonce9ab5b366932094b4e9c1102e806cb82fb278b8d1df3c991202d956dcb5fc2b7b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzUyOkVDREY5OjY3NzNDOjkwREY2OjY5NkE2OUM5IiwidmlzaXRvcl9pZCI6IjQwOTgxODM1OTQ0OTQxNDA4OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8847aacd6fc42bce1ac951dd581d4ce46e7f9192ec35d5a74a01f0c3ca513952
hovercard-subject-tagpull_request:2529846072
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/134289/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8304d149ac6a648fcd66442130630ebd7456ee8f0e5bf9e5bf109d196463c8a2/python/cpython/pull/134289
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8304d149ac6a648fcd66442130630ebd7456ee8f0e5bf9e5bf109d196463c8a2/python/cpython/pull/134289
og:image:altMove from using critical sections to locks for the (de)compression methods. Since the methods allow other threads to run, we should use a lock rather than a critical section. I'm not totally su...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameemmatyping
hostnamegithub.com
expected-hostnamegithub.com
None6fea32d5b7276b841b7a803796d9715bc6cfb31ed549fdf9de2948ac25d12ba6
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef2d9f6432a5a115ec709295ae70623f33bb80aee
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/134289#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F134289
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F134289
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/134289
Reloadhttps://github.com/python/cpython/pull/134289
Reloadhttps://github.com/python/cpython/pull/134289
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/134289
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/134289
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/134289#issue-comment-box
colesburyhttps://github.com/colesbury
python:mainhttps://github.com/python/cpython/tree/main
emmatyping:zstd-mutex-lockshttps://github.com/emmatyping/cpython/tree/zstd-mutex-locks
gh-133885: Use locks instead of critical sections for _zstd https://github.com/python/cpython/pull/134289#top
colesburyhttps://github.com/colesbury
python:mainhttps://github.com/python/cpython/tree/main
emmatyping:zstd-mutex-lockshttps://github.com/emmatyping/cpython/tree/zstd-mutex-locks
Conversation 66 https://github.com/python/cpython/pull/134289
Commits 18 https://github.com/python/cpython/pull/134289/commits
Checks 46 https://github.com/python/cpython/pull/134289/checks
Files changed https://github.com/python/cpython/pull/134289/files
Please reload this pagehttps://github.com/python/cpython/pull/134289
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/emmatyping
emmatypinghttps://github.com/emmatyping
May 19, 2025https://github.com/python/cpython/pull/134289#issue-3075089537
Please reload this pagehttps://github.com/python/cpython/pull/134289
test_zstd failed on ubuntu with free-threading #133885https://github.com/python/cpython/issues/133885
Please reload this pagehttps://github.com/python/cpython/pull/134289
emmatypinghttps://github.com/emmatyping
May 19, 2025 17:28https://github.com/python/cpython/pull/134289#commits-pushed-daa5f43
https://github.com/emmatyping
Use locks instead of critical sectionshttps://github.com/python/cpython/pull/134289/commits/daa5f438523ff7ce6b7510342e36607d3a526bee
daa5f43https://github.com/python/cpython/pull/134289/commits/daa5f438523ff7ce6b7510342e36607d3a526bee
https://github.com/emmatyping
Remove one more critical sectionhttps://github.com/python/cpython/pull/134289/commits/0d14dc26e8c41c6612e7b854319ffe3433f3137e
0d14dc2https://github.com/python/cpython/pull/134289/commits/0d14dc26e8c41c6612e7b854319ffe3433f3137e
https://github.com/emmatyping
emmatypinghttps://github.com/emmatyping
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
May 19, 2025https://github.com/python/cpython/pull/134289#event-17722566930
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
May 19, 2025 https://github.com/python/cpython/pull/134289#ref-issue-3054885684
test_zstd failed on ubuntu with free-threading #133885 https://github.com/python/cpython/issues/133885
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
May 19, 2025https://github.com/python/cpython/pull/134289#event-17722567643
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
May 20, 2025 https://github.com/python/cpython/pull/134289#pullrequestreview-2852489353
View reviewed changes https://github.com/python/cpython/pull/134289/files/0d14dc26e8c41c6612e7b854319ffe3433f3137e
ZeroIntensityhttps://github.com/ZeroIntensity
https://github.com/python/cpython/pull/134289#pullrequestreview-2852489353
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/134289
Modules/_zstd/compressor.chttps://github.com/python/cpython/pull/134289/files/0d14dc26e8c41c6612e7b854319ffe3433f3137e#diff-e7579a24d7495a5e7ec25e3834af991e480cacbf1a955ad78ab08148d9304e7d
Please reload this pagehttps://github.com/python/cpython/pull/134289
https://github.com/colesbury
colesburyhttps://github.com/colesbury
May 20, 2025 17:52https://github.com/python/cpython/pull/134289#event-17739219614
https://github.com/colesbury
colesburyhttps://github.com/colesbury
May 20, 2025 https://github.com/python/cpython/pull/134289#pullrequestreview-2855138572
View reviewed changes https://github.com/python/cpython/pull/134289/files/0d14dc26e8c41c6612e7b854319ffe3433f3137e
Modules/_zstd/compressor.chttps://github.com/python/cpython/pull/134289/files/0d14dc26e8c41c6612e7b854319ffe3433f3137e#diff-e7579a24d7495a5e7ec25e3834af991e480cacbf1a955ad78ab08148d9304e7d
Please reload this pagehttps://github.com/python/cpython/pull/134289
Lib/test/test_zstd.pyhttps://github.com/python/cpython/pull/134289/files/0d14dc26e8c41c6612e7b854319ffe3433f3137e#diff-d347ebfcbcfd73ae33135b08623594cc45342d42b774fbbc80e508176f860d5d
Please reload this pagehttps://github.com/python/cpython/pull/134289
Modules/_zstd/compressor.chttps://github.com/python/cpython/pull/134289/files/0d14dc26e8c41c6612e7b854319ffe3433f3137e#diff-e7579a24d7495a5e7ec25e3834af991e480cacbf1a955ad78ab08148d9304e7d
Please reload this pagehttps://github.com/python/cpython/pull/134289
Modules/_zstd/compressor.chttps://github.com/python/cpython/pull/134289/files/0d14dc26e8c41c6612e7b854319ffe3433f3137e#diff-e7579a24d7495a5e7ec25e3834af991e480cacbf1a955ad78ab08148d9304e7d
Please reload this pagehttps://github.com/python/cpython/pull/134289
https://github.com/colesbury
colesburyhttps://github.com/colesbury
May 20, 2025https://github.com/python/cpython/pull/134289#issuecomment-2895401280
@ZeroIntensityhttps://github.com/ZeroIntensity
Please reload this pagehttps://github.com/python/cpython/pull/134289
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
May 20, 2025https://github.com/python/cpython/pull/134289#issuecomment-2895467302
Please reload this pagehttps://github.com/python/cpython/pull/134289
https://github.com/colesbury
colesburyhttps://github.com/colesbury
May 20, 2025https://github.com/python/cpython/pull/134289#issuecomment-2895490525
@ZeroIntensityhttps://github.com/ZeroIntensity
Please reload this pagehttps://github.com/python/cpython/pull/134289
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
May 20, 2025https://github.com/python/cpython/pull/134289#issuecomment-2895502824
Please reload this pagehttps://github.com/python/cpython/pull/134289
emmatypinghttps://github.com/emmatyping
May 20, 2025 17:28https://github.com/python/cpython/pull/134289#commits-pushed-1b68e1e
https://github.com/emmatyping
Make capsule management threadsafehttps://github.com/python/cpython/pull/134289/commits/1b68e1e098e201c6666e4fb2bcf48cf06678db94
1b68e1ehttps://github.com/python/cpython/pull/134289/commits/1b68e1e098e201c6666e4fb2bcf48cf06678db94
https://github.com/emmatyping
Add a test for sharing a dictionary across threadshttps://github.com/python/cpython/pull/134289/commits/f6602f4b5a15d4e2c8b7536fc2202d8d27c858c3
f6602f4https://github.com/python/cpython/pull/134289/commits/f6602f4b5a15d4e2c8b7536fc2202d8d27c858c3
https://github.com/emmatyping
Move lock check in dealloc to an asserthttps://github.com/python/cpython/pull/134289/commits/d8854c53a2ef11b73b96748f34124f5d93ea0d22
d8854c5https://github.com/python/cpython/pull/134289/commits/d8854c53a2ef11b73b96748f34124f5d93ea0d22
https://github.com/emmatyping
Run threading checks on GIL builds toohttps://github.com/python/cpython/pull/134289/commits/02fc2b3e8ecba886c9e42dccef792ec913a2499f
02fc2b3https://github.com/python/cpython/pull/134289/commits/02fc2b3e8ecba886c9e42dccef792ec913a2499f
https://github.com/emmatyping
Remove extra blank linehttps://github.com/python/cpython/pull/134289/commits/edbf444b6b289af6c1e766380efd59c8ec3cf10a
edbf444https://github.com/python/cpython/pull/134289/commits/edbf444b6b289af6c1e766380efd59c8ec3cf10a
https://github.com/emmatyping
Remove extraneous whitespacehttps://github.com/python/cpython/pull/134289/commits/bf287cfaf35ae17d1d579e241f5e799101e02cc8
bf287cfhttps://github.com/python/cpython/pull/134289/commits/bf287cfaf35ae17d1d579e241f5e799101e02cc8
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
May 21, 2025 https://github.com/python/cpython/pull/134289#pullrequestreview-2855946900
View reviewed changes https://github.com/python/cpython/pull/134289/files/bf287cfaf35ae17d1d579e241f5e799101e02cc8
ZeroIntensityhttps://github.com/ZeroIntensity
https://github.com/python/cpython/pull/134289#pullrequestreview-2855946900
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/134289
Lib/test/test_zstd.pyhttps://github.com/python/cpython/pull/134289/files/bf287cfaf35ae17d1d579e241f5e799101e02cc8#diff-d347ebfcbcfd73ae33135b08623594cc45342d42b774fbbc80e508176f860d5d
Please reload this pagehttps://github.com/python/cpython/pull/134289
Modules/_zstd/decompressor.chttps://github.com/python/cpython/pull/134289/files/bf287cfaf35ae17d1d579e241f5e799101e02cc8#diff-5b717a4e417388ae310008129390ff165e9273f8183293709512e4c4feaa4889
Please reload this pagehttps://github.com/python/cpython/pull/134289
Modules/_zstd/decompressor.chttps://github.com/python/cpython/pull/134289/files/bf287cfaf35ae17d1d579e241f5e799101e02cc8#diff-5b717a4e417388ae310008129390ff165e9273f8183293709512e4c4feaa4889
Please reload this pagehttps://github.com/python/cpython/pull/134289
emmatypinghttps://github.com/emmatyping
May 21, 2025 00:10https://github.com/python/cpython/pull/134289#commits-pushed-005d1a0
https://github.com/emmatyping
Remove unused includeshttps://github.com/python/cpython/pull/134289/commits/005d1a06ba8cd1fcef01f4fbcc57b010657f0f7e
005d1a0https://github.com/python/cpython/pull/134289/commits/005d1a06ba8cd1fcef01f4fbcc57b010657f0f7e
https://github.com/emmatyping
Revert "Remove unused includes"https://github.com/python/cpython/pull/134289/commits/84c5b3065f22cd4156bab9cd3f18ec8e3af421b6
84c5b30https://github.com/python/cpython/pull/134289/commits/84c5b3065f22cd4156bab9cd3f18ec8e3af421b6
005d1a0https://github.com/emmatyping/cpython/commit/005d1a06ba8cd1fcef01f4fbcc57b010657f0f7e
https://github.com/dpdani
dpdanihttps://github.com/dpdani
May 21, 2025https://github.com/python/cpython/pull/134289#issuecomment-2897320013
Please reload this pagehttps://github.com/python/cpython/pull/134289
https://github.com/emmatyping
emmatypinghttps://github.com/emmatyping
May 21, 2025https://github.com/python/cpython/pull/134289#issuecomment-2897882176
Please reload this pagehttps://github.com/python/cpython/pull/134289
emmatypinghttps://github.com/emmatyping
May 21, 2025 09:46https://github.com/python/cpython/pull/134289#commits-pushed-ec31019
https://github.com/emmatyping
Put locks around ZstdDict usagehttps://github.com/python/cpython/pull/134289/commits/ec310194c1149f6bf4263bb6a45897e7d909c412
ec31019https://github.com/python/cpython/pull/134289/commits/ec310194c1149f6bf4263bb6a45897e7d909c412
https://github.com/emmatyping
Add tests for sharing all types of ZstdDicthttps://github.com/python/cpython/pull/134289/commits/2dbed4eb8baa05ca7fa06a87509e896a24aff62c
2dbed4ehttps://github.com/python/cpython/pull/134289/commits/2dbed4eb8baa05ca7fa06a87509e896a24aff62c
https://github.com/emmatyping
Remove @critical_sectionhttps://github.com/python/cpython/pull/134289/commits/afdabd5408890315414873eac393a6ff6216549d
afdabd5https://github.com/python/cpython/pull/134289/commits/afdabd5408890315414873eac393a6ff6216549d
https://github.com/emmatyping
Add missing includehttps://github.com/python/cpython/pull/134289/commits/d8d48c2deb75374d754806a698c0a995f10c1d41
d8d48c2https://github.com/python/cpython/pull/134289/commits/d8d48c2deb75374d754806a698c0a995f10c1d41
https://github.com/dpdani
dpdanihttps://github.com/dpdani
May 21, 2025https://github.com/python/cpython/pull/134289#issuecomment-2898726391
Please reload this pagehttps://github.com/python/cpython/pull/134289
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
May 21, 2025https://github.com/python/cpython/pull/134289#issuecomment-2898824853
Please reload this pagehttps://github.com/python/cpython/pull/134289
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
May 22, 2025 https://github.com/python/cpython/pull/134289#pullrequestreview-2859484266
View reviewed changes https://github.com/python/cpython/pull/134289/files/d142aa849f56972b20a8df1e588b5dd540d7276c
ZeroIntensityhttps://github.com/ZeroIntensity
https://github.com/python/cpython/pull/134289#pullrequestreview-2859484266
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/134289
Modules/_zstd/compressor.chttps://github.com/python/cpython/pull/134289/files/d142aa849f56972b20a8df1e588b5dd540d7276c#diff-e7579a24d7495a5e7ec25e3834af991e480cacbf1a955ad78ab08148d9304e7d
Please reload this pagehttps://github.com/python/cpython/pull/134289
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
May 22, 2025 https://github.com/python/cpython/pull/134289#pullrequestreview-2860754411
View reviewed changes https://github.com/python/cpython/pull/134289/files/d142aa849f56972b20a8df1e588b5dd540d7276c
Modules/_zstd/compressor.chttps://github.com/python/cpython/pull/134289/files/d142aa849f56972b20a8df1e588b5dd540d7276c#diff-e7579a24d7495a5e7ec25e3834af991e480cacbf1a955ad78ab08148d9304e7d
Please reload this pagehttps://github.com/python/cpython/pull/134289
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
May 22, 2025 https://github.com/python/cpython/pull/134289#pullrequestreview-2860761347
View reviewed changes https://github.com/python/cpython/pull/134289/files/d142aa849f56972b20a8df1e588b5dd540d7276c
Modules/_zstd/compressor.chttps://github.com/python/cpython/pull/134289/files/d142aa849f56972b20a8df1e588b5dd540d7276c#diff-e7579a24d7495a5e7ec25e3834af991e480cacbf1a955ad78ab08148d9304e7d
Please reload this pagehttps://github.com/python/cpython/pull/134289
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
May 22, 2025 https://github.com/python/cpython/pull/134289#pullrequestreview-2860761629
View reviewed changes https://github.com/python/cpython/pull/134289/files/d142aa849f56972b20a8df1e588b5dd540d7276c
Modules/_zstd/compressor.chttps://github.com/python/cpython/pull/134289/files/d142aa849f56972b20a8df1e588b5dd540d7276c#diff-e7579a24d7495a5e7ec25e3834af991e480cacbf1a955ad78ab08148d9304e7d
Please reload this pagehttps://github.com/python/cpython/pull/134289
emmatypinghttps://github.com/emmatyping
May 22, 2025 14:27https://github.com/python/cpython/pull/134289#commits-pushed-43d3dea
https://github.com/emmatyping
https://github.com/kumaraditya303
Pass NULL to PyDict_SetDefaultRefhttps://github.com/python/cpython/pull/134289/commits/43d3dea9e9b20a4d6918608b09a4bc05747b95c3
43d3deahttps://github.com/python/cpython/pull/134289/commits/43d3dea9e9b20a4d6918608b09a4bc05747b95c3
https://github.com/emmatyping
Put locks around relevant functions and use PyDict_GetItemRefhttps://github.com/python/cpython/pull/134289/commits/93dec23d0e408df618c2c942b0181edd6bcd6f8d
93dec23https://github.com/python/cpython/pull/134289/commits/93dec23d0e408df618c2c942b0181edd6bcd6f8d
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
May 23, 2025 https://github.com/python/cpython/pull/134289#pullrequestreview-2862880888
View reviewed changes https://github.com/python/cpython/pull/134289/files/93dec23d0e408df618c2c942b0181edd6bcd6f8d
Modules/_zstd/compressor.chttps://github.com/python/cpython/pull/134289/files/93dec23d0e408df618c2c942b0181edd6bcd6f8d#diff-e7579a24d7495a5e7ec25e3834af991e480cacbf1a955ad78ab08148d9304e7d
Please reload this pagehttps://github.com/python/cpython/pull/134289
https://github.com/emmatyping
Remove unused decrefhttps://github.com/python/cpython/pull/134289/commits/69a755bd828ed2729a3a622d3a92c353de90b184
69a755bhttps://github.com/python/cpython/pull/134289/commits/69a755bd828ed2729a3a622d3a92c353de90b184
https://github.com/emmatyping
emmatypinghttps://github.com/emmatyping
May 23, 2025https://github.com/python/cpython/pull/134289#issuecomment-2902959230
Please reload this pagehttps://github.com/python/cpython/pull/134289
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
May 23, 2025https://github.com/python/cpython/pull/134289#issuecomment-2902959303
@emmatypinghttps://github.com/emmatyping
69a755bhttps://github.com/python/cpython/commit/69a755bd828ed2729a3a622d3a92c353de90b184
https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134289%2Fmergehttps://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134289%2Fmerge
Please reload this pagehttps://github.com/python/cpython/pull/134289
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
May 23, 2025 https://github.com/python/cpython/pull/134289#pullrequestreview-2862895429
View reviewed changes https://github.com/python/cpython/pull/134289/files/69a755bd828ed2729a3a622d3a92c353de90b184
ZeroIntensityhttps://github.com/ZeroIntensity
https://github.com/python/cpython/pull/134289#pullrequestreview-2862895429
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/134289
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
May 23, 2025https://github.com/python/cpython/pull/134289#event-17781476449
https://github.com/emmatyping
emmatypinghttps://github.com/emmatyping
May 23, 2025https://github.com/python/cpython/pull/134289#issuecomment-2902988734
Please reload this pagehttps://github.com/python/cpython/pull/134289
https://github.com/emmatyping
emmatypinghttps://github.com/emmatyping
May 23, 2025https://github.com/python/cpython/pull/134289#issuecomment-2902989744
Please reload this pagehttps://github.com/python/cpython/pull/134289
https://github.com/emmatyping
emmatypinghttps://github.com/emmatyping
May 23, 2025https://github.com/python/cpython/pull/134289#issuecomment-2903036374
#134557https://github.com/python/cpython/issues/134557
Please reload this pagehttps://github.com/python/cpython/pull/134289
https://github.com/colesbury
colesburyhttps://github.com/colesbury
May 23, 2025 https://github.com/python/cpython/pull/134289#pullrequestreview-2863027105
View reviewed changes https://github.com/python/cpython/pull/134289/files/69a755bd828ed2729a3a622d3a92c353de90b184
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 23, 2025https://github.com/python/cpython/pull/134289#event-17782407293
https://github.com/colesbury
colesburyhttps://github.com/colesbury
8dbc119https://github.com/python/cpython/commit/8dbc11971974a725dc8a11c0dc65d8f6fcb4d902
May 23, 2025https://github.com/python/cpython/pull/134289#event-17782551437
Please reload this pagehttps://github.com/python/cpython/pull/134289
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
May 23, 2025https://github.com/python/cpython/pull/134289#issuecomment-2903143212
@emmatypinghttps://github.com/emmatyping
@colesburyhttps://github.com/colesbury
Please reload this pagehttps://github.com/python/cpython/pull/134289
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
May 23, 2025https://github.com/python/cpython/pull/134289#event-17782551718
miss-islingtonhttps://github.com/miss-islington
May 23, 2025 https://github.com/python/cpython/pull/134289#ref-commit-03cee3f
https://github.com/emmatyping
https://github.com/miss-islington
pythongh-133885https://github.com/python/cpython/issues/133885
: Use locks instead of critical sections for _zstd (https://github.com/miss-islington/cpython/commit/03cee3f9a9db3afa27ca48172826838f9e8abc4c
py…https://github.com/python/cpython/pull/134289
03cee3fhttps://github.com/miss-islington/cpython/commit/03cee3f9a9db3afa27ca48172826838f9e8abc4c
…thongh-134289https://github.com/python/cpython/pull/134289
8dbc119https://github.com/miss-islington/cpython/commit/8dbc11971974a725dc8a11c0dc65d8f6fcb4d902
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
May 23, 2025https://github.com/python/cpython/pull/134289#issuecomment-2903143444
GH-134560https://github.com/python/cpython/pull/134560
3.14 branchhttps://github.com/python/cpython/tree/3.14
Please reload this pagehttps://github.com/python/cpython/pull/134289
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
May 23, 2025https://github.com/python/cpython/pull/134289#event-17782552869
https://github.com/emmatyping
emmatypinghttps://github.com/emmatyping
May 23, 2025https://github.com/python/cpython/pull/134289#issuecomment-2903196182
Please reload this pagehttps://github.com/python/cpython/pull/134289
colesburyhttps://github.com/colesbury
May 23, 2025 https://github.com/python/cpython/pull/134289#ref-commit-8167594
https://github.com/miss-islington
https://github.com/emmatyping
[3.14]https://github.com/python/cpython/commit/81675941fb51f09b89ba46bce237222a87ea60f6
gh-133885https://github.com/python/cpython/issues/133885
: Use locks instead of critical sections for _zstd (https://github.com/python/cpython/commit/81675941fb51f09b89ba46bce237222a87ea60f6
g…https://github.com/python/cpython/pull/134289
8167594https://github.com/python/cpython/commit/81675941fb51f09b89ba46bce237222a87ea60f6
…h-134289https://github.com/python/cpython/pull/134289
gh-134560https://github.com/python/cpython/pull/134560
8dbc119https://github.com/python/cpython/commit/8dbc11971974a725dc8a11c0dc65d8f6fcb4d902
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
May 28, 2025 https://github.com/python/cpython/pull/134289#ref-pullrequest-3077729053
gh-134009: Expose PyMutex_IsLocked in the public C API #134365 https://github.com/python/cpython/pull/134365
Pranjal095https://github.com/Pranjal095
Jul 12, 2025 https://github.com/python/cpython/pull/134289#ref-commit-46b0f13
https://github.com/emmatyping
https://github.com/Pranjal095
pythongh-133885https://github.com/python/cpython/issues/133885
: Use locks instead of critical sections for _zstd (https://github.com/Pranjal095/cpython/commit/46b0f13c35a844f9e844de2293bad13fe4f763d3
py…https://github.com/python/cpython/pull/134289
46b0f13https://github.com/Pranjal095/cpython/commit/46b0f13c35a844f9e844de2293bad13fe4f763d3
…thongh-134289https://github.com/python/cpython/pull/134289
taegyunkimhttps://github.com/taegyunkim
Aug 4, 2025 https://github.com/python/cpython/pull/134289#ref-commit-563547e
https://github.com/emmatyping
https://github.com/taegyunkim
pythongh-133885https://github.com/python/cpython/issues/133885
: Use locks instead of critical sections for _zstd (https://github.com/taegyunkim/cpython/commit/563547e45781b4968239cff64e8140ae4eeddda4
py…https://github.com/python/cpython/pull/134289
563547ehttps://github.com/taegyunkim/cpython/commit/563547e45781b4968239cff64e8140ae4eeddda4
…thongh-134289https://github.com/python/cpython/pull/134289
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F134289
https://github.com/kumaraditya303
kumaraditya303 https://github.com/kumaraditya303
https://github.com/python/cpython/pull/134289/files/d142aa849f56972b20a8df1e588b5dd540d7276c
https://github.com/colesbury
colesbury https://github.com/colesbury
https://github.com/python/cpython/pull/134289/files/69a755bd828ed2729a3a622d3a92c353de90b184
https://github.com/ZeroIntensity
ZeroIntensity https://github.com/ZeroIntensity
https://github.com/python/cpython/pull/134289/files/69a755bd828ed2729a3a622d3a92c353de90b184
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/134289
https://github.com/emmatyping
https://github.com/colesbury
https://github.com/ZeroIntensity
https://github.com/dpdani
https://github.com/bedevere-bot
https://github.com/kumaraditya303
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.