René's URL Explorer Experiment


Title: gh-134261: ZipFile - Don't rely on local time for reproducible builds & tests by ctrlaltf2 · Pull Request #134264 · python/cpython · GitHub

Open Graph Title: gh-134261: ZipFile - Don't rely on local time for reproducible builds & tests by ctrlaltf2 · Pull Request #134264 · python/cpython

X Title: gh-134261: ZipFile - Don't rely on local time for reproducible builds & tests by ctrlaltf2 · Pull Request #134264 · python/cpython

Description: See #134261 for issue background and technical detail on causes. This solves the issue by using gmtime whenever SOURCE_DATE_EPOCH is involved, to prevent pulling in system timezone information when performing time calculations. Issue: gh-134261

Open Graph Description: See #134261 for issue background and technical detail on causes. This solves the issue by using gmtime whenever SOURCE_DATE_EPOCH is involved, to prevent pulling in system timezone information when...

X Description: See #134261 for issue background and technical detail on causes. This solves the issue by using gmtime whenever SOURCE_DATE_EPOCH is involved, to prevent pulling in system timezone information when...

Opengraph URL: https://github.com/python/cpython/pull/134264

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2011280b-3aec-0381-2f92-2d0e34dd1102
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC128:26AD97:D4B506:11D4BBF:6A528B91
html-safe-noncef9e4f3b31feae5cc62ca448e664dd21e424370bb5cf4764607a93959bfcf0c77
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTI4OjI2QUQ5NzpENEI1MDY6MTFENEJCRjo2QTUyOEI5MSIsInZpc2l0b3JfaWQiOiIxNDgyODE3MjA0NTM2MzA4NjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac68b8cab7e2d9f6ba868984fa675eeb632e4f8c404936920c28c9acc7e6a72dfd
hovercard-subject-tagpull_request:2529458287
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/134264/files
twitter:imagehttps://avatars.githubusercontent.com/u/23644849?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/23644849?s=400&v=4
og:image:altSee #134261 for issue background and technical detail on causes. This solves the issue by using gmtime whenever SOURCE_DATE_EPOCH is involved, to prevent pulling in system timezone information when...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/134264/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F134264%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F134264%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/134264/files
Reloadhttps://github.com/python/cpython/pull/134264/files
Reloadhttps://github.com/python/cpython/pull/134264/files
Please reload this pagehttps://github.com/python/cpython/pull/134264/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/134264/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
jaracohttps://github.com/jaraco
python:mainhttps://github.com/python/cpython/tree/main
ctrlaltf2:mainhttps://github.com/ctrlaltf2/cpython/tree/main
Conversation 22 https://github.com/python/cpython/pull/134264
Commits 9 https://github.com/python/cpython/pull/134264/commits
Checks 59 https://github.com/python/cpython/pull/134264/checks
Files changed https://github.com/python/cpython/pull/134264/files
Please reload this pagehttps://github.com/python/cpython/pull/134264/files
gh-134261: ZipFile - Don't rely on local time for reproducible builds & tests https://github.com/python/cpython/pull/134264/files#top
Show all changes 9 commits https://github.com/python/cpython/pull/134264/files
4c389c9 gh-134261: Don't rely on local time for reproducible builds & tests ctrlaltf2 May 19, 2025 https://github.com/python/cpython/pull/134264/commits/4c389c901276ab1c6a649ffaed5c4767e1c9caba
e0fcc2d 📜🤖 Added by blurb_it. blurb-it[bot] May 19, 2025 https://github.com/python/cpython/pull/134264/commits/e0fcc2d0eb4e83a43a16df242f1c0c5cf6871495
6fda35b Merge branch 'main' into main emmatyping May 27, 2025 https://github.com/python/cpython/pull/134264/commits/6fda35b98d6636b3c68cd7086a8932f20ec5086d
f7c52b8 Materialize the expected value for the timestamp. jaraco May 19, 2026 https://github.com/python/cpython/pull/134264/commits/f7c52b8c71c641d8e0d45b343e33bc6bbdbe79de
06f66b3 Correct stable timestamp. jaraco May 19, 2026 https://github.com/python/cpython/pull/134264/commits/06f66b327d3173ae7c58f034239380c42efa74bf
5c09422 Seems a second gets lost during the zip file creation. jaraco May 19, 2026 https://github.com/python/cpython/pull/134264/commits/5c094226fda0372a61c46198b905684ab5e225c8
66499d3 Implement a proper timestamp comparison with tolerance. jaraco May 19, 2026 https://github.com/python/cpython/pull/134264/commits/66499d30ebd46e1e1a4582d3bc64082edc286a6e
d649130 Merge branch 'main' into ctrlaltf2/main jaraco May 19, 2026 https://github.com/python/cpython/pull/134264/commits/d649130c00785023a24707fb0c1da6a0d872be1f
0f962dc Nicer blurb message. jaraco May 19, 2026 https://github.com/python/cpython/pull/134264/commits/0f962dc8601f31d7b9e1be6745a7cf7c4d5ef94e
Clear filters https://github.com/python/cpython/pull/134264/files
Please reload this pagehttps://github.com/python/cpython/pull/134264/files
Please reload this pagehttps://github.com/python/cpython/pull/134264/files
test_core.py https://github.com/python/cpython/pull/134264/files#diff-3f7f7f9e251efe3ca7872e540c7840c85d508fc11150926df502ced996b98e9f
__init__.py https://github.com/python/cpython/pull/134264/files#diff-7629293618f2b3cf8ae7daf98526226fa12f047d71645a05497e6687aae10c76
2025-05-19-21-08-25.gh-issue-134261.ravGYm.rst https://github.com/python/cpython/pull/134264/files#diff-e3c6d52c0a66b166aef05bd9dfe3a5d1f4aa5cf68a5cffec05e988efef249972
Lib/test/test_zipfile/test_core.pyhttps://github.com/python/cpython/pull/134264/files#diff-3f7f7f9e251efe3ca7872e540c7840c85d508fc11150926df502ced996b98e9f
View file https://github.com/ctrlaltf2/cpython/blob/0f962dc8601f31d7b9e1be6745a7cf7c4d5ef94e/Lib/test/test_zipfile/test_core.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/134264/{{ revealButtonHref }}
https://github.com/python/cpython/pull/134264/files#diff-3f7f7f9e251efe3ca7872e540c7840c85d508fc11150926df502ced996b98e9f
https://github.com/python/cpython/pull/134264/files#diff-3f7f7f9e251efe3ca7872e540c7840c85d508fc11150926df502ced996b98e9f
https://github.com/python/cpython/pull/134264/files#diff-3f7f7f9e251efe3ca7872e540c7840c85d508fc11150926df502ced996b98e9f
Lib/zipfile/__init__.pyhttps://github.com/python/cpython/pull/134264/files#diff-7629293618f2b3cf8ae7daf98526226fa12f047d71645a05497e6687aae10c76
View file https://github.com/ctrlaltf2/cpython/blob/0f962dc8601f31d7b9e1be6745a7cf7c4d5ef94e/Lib/zipfile/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/134264/{{ revealButtonHref }}
https://github.com/python/cpython/pull/134264/files#diff-7629293618f2b3cf8ae7daf98526226fa12f047d71645a05497e6687aae10c76
https://github.com/python/cpython/pull/134264/files#diff-7629293618f2b3cf8ae7daf98526226fa12f047d71645a05497e6687aae10c76
Misc/NEWS.d/next/Library/2025-05-19-21-08-25.gh-issue-134261.ravGYm.rsthttps://github.com/python/cpython/pull/134264/files#diff-e3c6d52c0a66b166aef05bd9dfe3a5d1f4aa5cf68a5cffec05e988efef249972
View file https://github.com/ctrlaltf2/cpython/blob/0f962dc8601f31d7b9e1be6745a7cf7c4d5ef94e/Misc/NEWS.d/next/Library/2025-05-19-21-08-25.gh-issue-134261.ravGYm.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/134264/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/134264/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.