René's URL Explorer Experiment


Title: gh-133885: Disallow sharing zstd (de)compressor contexts by emmatyping · Pull Request #134253 · python/cpython · GitHub

Open Graph Title: gh-133885: Disallow sharing zstd (de)compressor contexts by emmatyping · Pull Request #134253 · python/cpython

X Title: gh-133885: Disallow sharing zstd (de)compressor contexts by emmatyping · Pull Request #134253 · python/cpython

Description: It is not possible to share Zstandard objects across thread boundaries. To resolve this, we check if the object was created on the current thread and raise a RuntimeError if it is not. Wasn't totally sure what exception to raise to communicate the issue, so if RuntimeError isn't correct, please suggestion another option. The tests are updated to ensure that the error is raised if a (de)compression context is shared across threads. (as requested, cc @ngoldbaum ) Issue: gh-133885

Open Graph Description: It is not possible to share Zstandard objects across thread boundaries. To resolve this, we check if the object was created on the current thread and raise a RuntimeError if it is not. Wasn't t...

X Description: It is not possible to share Zstandard objects across thread boundaries. To resolve this, we check if the object was created on the current thread and raise a RuntimeError if it is not. Wasn&#39...

Opengraph URL: https://github.com/python/cpython/pull/134253

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:94f7ed9f-39cd-ee2a-d954-3a0ff5d50247
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDB98:2A0D62:156BF77:1D83826:696AA505
html-safe-noncef097231e6b75b5807537815b69ce202fe67cf6ed47dba03eeabb05cbb54eba16
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjk4OjJBMEQ2MjoxNTZCRjc3OjFEODM4MjY6Njk2QUE1MDUiLCJ2aXNpdG9yX2lkIjoiMTM1MTEzMzk3MjIwNzkzNjc3MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacec45cb3b8a62423596566bce1cf239484242ad87c8be2c61c3c534f26f2f3e84
hovercard-subject-tagpull_request:2529243469
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/134253/files
twitter:imagehttps://avatars.githubusercontent.com/u/9504279?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/9504279?s=400&v=4
og:image:altIt is not possible to share Zstandard objects across thread boundaries. To resolve this, we check if the object was created on the current thread and raise a RuntimeError if it is not. Wasn't t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonea51f97dbb9326f71c08ecb61577457d543c602124d1a2672871258ef37ac5261
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4bd0eac606c70914085176ef312ebdcd97a8cdf1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/134253/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F134253%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F134253%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/134253/files
Reloadhttps://github.com/python/cpython/pull/134253/files
Reloadhttps://github.com/python/cpython/pull/134253/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/134253/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/134253/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
emmatypinghttps://github.com/emmatyping
python:mainhttps://github.com/python/cpython/tree/main
emmatyping:zstd-unsharable-de-compressorhttps://github.com/emmatyping/cpython/tree/zstd-unsharable-de-compressor
Conversation 2 https://github.com/python/cpython/pull/134253
Commits 2 https://github.com/python/cpython/pull/134253/commits
Checks 68 https://github.com/python/cpython/pull/134253/checks
Files changed https://github.com/python/cpython/pull/134253/files
Please reload this pagehttps://github.com/python/cpython/pull/134253/files
gh-133885: Disallow sharing zstd (de)compressor contexts https://github.com/python/cpython/pull/134253/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/134253/files
1c3071d Disallow sharing zstd (de)compressor contexts emmatyping May 19, 2025 https://github.com/python/cpython/pull/134253/commits/1c3071dc523e803bc9f5f8dad21f79a9c8617535
8620ea3 Merge branch 'main' into zstd-unsharable-de-compressor emmatyping May 19, 2025 https://github.com/python/cpython/pull/134253/commits/8620ea361a8298e037204b59ef132ec1f1a2c7ac
Clear filters https://github.com/python/cpython/pull/134253/files
Please reload this pagehttps://github.com/python/cpython/pull/134253/files
Please reload this pagehttps://github.com/python/cpython/pull/134253/files
test_zstd.py https://github.com/python/cpython/pull/134253/files#diff-d347ebfcbcfd73ae33135b08623594cc45342d42b774fbbc80e508176f860d5d
_zstdmodule.h https://github.com/python/cpython/pull/134253/files#diff-5c04313fdb99f2a2d018d3f01f8fd653bb8d55ccb796ec5eefb735ac12f14833
compressor.c https://github.com/python/cpython/pull/134253/files#diff-e7579a24d7495a5e7ec25e3834af991e480cacbf1a955ad78ab08148d9304e7d
decompressor.c https://github.com/python/cpython/pull/134253/files#diff-5b717a4e417388ae310008129390ff165e9273f8183293709512e4c4feaa4889
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L628
Lib/test/test_zstd.pyhttps://github.com/python/cpython/pull/134253/files#diff-d347ebfcbcfd73ae33135b08623594cc45342d42b774fbbc80e508176f860d5d
View file https://github.com/emmatyping/cpython/blob/8620ea361a8298e037204b59ef132ec1f1a2c7ac/Lib/test/test_zstd.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/134253/{{ revealButtonHref }}
https://github.com/python/cpython/pull/134253/files#diff-d347ebfcbcfd73ae33135b08623594cc45342d42b774fbbc80e508176f860d5d
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L629
Modules/_zstd/_zstdmodule.hhttps://github.com/python/cpython/pull/134253/files#diff-5c04313fdb99f2a2d018d3f01f8fd653bb8d55ccb796ec5eefb735ac12f14833
View file https://github.com/emmatyping/cpython/blob/8620ea361a8298e037204b59ef132ec1f1a2c7ac/Modules/_zstd/_zstdmodule.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/134253/{{ revealButtonHref }}
https://github.com/python/cpython/pull/134253/files#diff-5c04313fdb99f2a2d018d3f01f8fd653bb8d55ccb796ec5eefb735ac12f14833
gpsheadhttps://github.com/gpshead
May 19, 2025https://github.com/python/cpython/pull/134253/files#r2096340813
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/134253/files
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L629
Modules/_zstd/compressor.chttps://github.com/python/cpython/pull/134253/files#diff-e7579a24d7495a5e7ec25e3834af991e480cacbf1a955ad78ab08148d9304e7d
View file https://github.com/emmatyping/cpython/blob/8620ea361a8298e037204b59ef132ec1f1a2c7ac/Modules/_zstd/compressor.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/134253/{{ revealButtonHref }}
https://github.com/python/cpython/pull/134253/files#diff-e7579a24d7495a5e7ec25e3834af991e480cacbf1a955ad78ab08148d9304e7d
https://github.com/python/cpython/pull/134253/files#diff-e7579a24d7495a5e7ec25e3834af991e480cacbf1a955ad78ab08148d9304e7d
https://github.com/python/cpython/pull/134253/files#diff-e7579a24d7495a5e7ec25e3834af991e480cacbf1a955ad78ab08148d9304e7d
https://github.com/python/cpython/pull/134253/files#diff-e7579a24d7495a5e7ec25e3834af991e480cacbf1a955ad78ab08148d9304e7d
https://github.com/python/cpython/pull/134253/files#diff-e7579a24d7495a5e7ec25e3834af991e480cacbf1a955ad78ab08148d9304e7d
https://github.com/python/cpython/pull/134253/files#diff-e7579a24d7495a5e7ec25e3834af991e480cacbf1a955ad78ab08148d9304e7d
https://github.com/python/cpython/pull/134253/files#diff-e7579a24d7495a5e7ec25e3834af991e480cacbf1a955ad78ab08148d9304e7d
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L629
Modules/_zstd/decompressor.chttps://github.com/python/cpython/pull/134253/files#diff-5b717a4e417388ae310008129390ff165e9273f8183293709512e4c4feaa4889
View file https://github.com/emmatyping/cpython/blob/8620ea361a8298e037204b59ef132ec1f1a2c7ac/Modules/_zstd/decompressor.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/134253/{{ revealButtonHref }}
https://github.com/python/cpython/pull/134253/files#diff-5b717a4e417388ae310008129390ff165e9273f8183293709512e4c4feaa4889
https://github.com/python/cpython/pull/134253/files#diff-5b717a4e417388ae310008129390ff165e9273f8183293709512e4c4feaa4889
https://github.com/python/cpython/pull/134253/files#diff-5b717a4e417388ae310008129390ff165e9273f8183293709512e4c4feaa4889
https://github.com/python/cpython/pull/134253/files#diff-5b717a4e417388ae310008129390ff165e9273f8183293709512e4c4feaa4889
Please reload this pagehttps://github.com/python/cpython/pull/134253/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.