René's URL Explorer Experiment


Title: gh-133982: Run unclosed file test on all io implementations by cmaloney · Pull Request #134165 · python/cpython · GitHub

Open Graph Title: gh-133982: Run unclosed file test on all io implementations by cmaloney · Pull Request #134165 · python/cpython

X Title: gh-133982: Run unclosed file test on all io implementations by cmaloney · Pull Request #134165 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Update test_io _check_warn_on_dealloc to use self. to dispatch to different I/O implementations. Update the _pyio implementation to match expected behavior, using the same _dealloc_warn design as t...

X Description: Update test_io _check_warn_on_dealloc to use self. to dispatch to different I/O implementations. Update the _pyio implementation to match expected behavior, using the same _dealloc_warn design as t...

Opengraph URL: https://github.com/python/cpython/pull/134165

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0e27e8d7-ed37-fb63-5540-dbc7b54d50a0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE88A:3A796C:186ED36:2165BD3:6A536600
html-safe-nonce6d09b9289f73fa4bd6c14396af7f264eb917e0124491bf65e55f23e9992349da
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODhBOjNBNzk2QzoxODZFRDM2OjIxNjVCRDM6NkE1MzY2MDAiLCJ2aXNpdG9yX2lkIjoiMjQ4MzQ0MDk4MjQyODk2ODQ0OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb62a7791fa8bd3b7448480fa44ec488d9f4994163ba2e38a9282ecac57298858
hovercard-subject-tagpull_request:2526444751
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/134165/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/03f576822dd7faa8432c9563c5457b41e9670a4a9e229c2a0c94d24b899cdcb6/python/cpython/pull/134165
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/03f576822dd7faa8432c9563c5457b41e9670a4a9e229c2a0c94d24b899cdcb6/python/cpython/pull/134165
og:image:altUpdate test_io _check_warn_on_dealloc to use self. to dispatch to different I/O implementations. Update the _pyio implementation to match expected behavior, using the same _dealloc_warn design as t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecmaloney
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/134165#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F134165
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F134165
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/134165
Reloadhttps://github.com/python/cpython/pull/134165
Reloadhttps://github.com/python/cpython/pull/134165
Please reload this pagehttps://github.com/python/cpython/pull/134165
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/134165
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
ambvhttps://github.com/ambv
python:mainhttps://github.com/python/cpython/tree/main
cmaloney:pyio_dealloc_warn2https://github.com/cmaloney/cpython/tree/pyio_dealloc_warn2
Conversationhttps://github.com/python/cpython/pull/134165
Commits2 (2)https://github.com/python/cpython/pull/134165/commits
Checkshttps://github.com/python/cpython/pull/134165/checks
Files changedhttps://github.com/python/cpython/pull/134165/files
gh-133982: Run unclosed file test on all io implementationshttps://github.com/python/cpython/pull/134165#top
ambvhttps://github.com/ambv
python:mainhttps://github.com/python/cpython/tree/main
cmaloney:pyio_dealloc_warn2https://github.com/cmaloney/cpython/tree/pyio_dealloc_warn2
https://github.com/cmaloney
cmaloneyhttps://github.com/cmaloney
May 18, 2025https://github.com/python/cpython/pull/134165#issue-3071199319
Please reload this pagehttps://github.com/python/cpython/pull/134165
Use implemenation-specific I/O open / constructors in tests #133982https://github.com/python/cpython/issues/133982
Please reload this pagehttps://github.com/python/cpython/pull/134165
https://github.com/cmaloney
pythongh-133982https://github.com/python/cpython/issues/133982
: Run unclosed file test on all io implementationshttps://github.com/python/cpython/pull/134165/commits/cd3b196382b3849391f8b1b556683ff15ff8e0b9
cd3b196https://github.com/python/cpython/pull/134165/commits/cd3b196382b3849391f8b1b556683ff15ff8e0b9
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
May 18, 2025https://github.com/python/cpython/pull/134165#event-17700870488
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
May 18, 2025 https://github.com/python/cpython/pull/134165#ref-issue-3061059639
Use implemenation-specific I/O open / constructors in tests #133982 https://github.com/python/cpython/issues/133982
https://github.com/cmaloney
Rely on IOBase __del__ implementation in FileIOhttps://github.com/python/cpython/pull/134165/commits/704bf460f2891d02f102238a6b27e3c1e7e40060
704bf46https://github.com/python/cpython/pull/134165/commits/704bf460f2891d02f102238a6b27e3c1e7e40060
https://github.com/ambv
ambvhttps://github.com/ambv
5b0e827https://github.com/python/cpython/commit/5b0e82752120a5dc66ce6ee778751d71ba2c33b2
May 21, 2025https://github.com/python/cpython/pull/134165#event-17755514519
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
May 21, 2025https://github.com/python/cpython/pull/134165#event-17755515533
https://github.com/ambv
ambvhttps://github.com/ambv
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
May 21, 2025https://github.com/python/cpython/pull/134165#event-17755516645
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
May 21, 2025https://github.com/python/cpython/pull/134165#issuecomment-2898253863
@cmaloneyhttps://github.com/cmaloney
@ambvhttps://github.com/ambv
Please reload this pagehttps://github.com/python/cpython/pull/134165
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
May 21, 2025https://github.com/python/cpython/pull/134165#issuecomment-2898253873
@cmaloneyhttps://github.com/cmaloney
@ambvhttps://github.com/ambv
Please reload this pagehttps://github.com/python/cpython/pull/134165
miss-islingtonhttps://github.com/miss-islington
May 21, 2025 https://github.com/python/cpython/pull/134165#ref-commit-0b27e08
https://github.com/cmaloney
https://github.com/miss-islington
pythongh-133982https://github.com/python/cpython/issues/133982
: Run unclosed file test on all io implementations (https://github.com/miss-islington/cpython/commit/0b27e081a833cdd00612e54c10b2d56862d982f0
py…https://github.com/python/cpython/pull/134165
0b27e08https://github.com/miss-islington/cpython/commit/0b27e081a833cdd00612e54c10b2d56862d982f0
…thongh-134165https://github.com/python/cpython/pull/134165
5b0e827https://github.com/miss-islington/cpython/commit/5b0e82752120a5dc66ce6ee778751d71ba2c33b2
miss-islingtonhttps://github.com/miss-islington
May 21, 2025 https://github.com/python/cpython/pull/134165#ref-commit-4f82e8d
https://github.com/cmaloney
https://github.com/miss-islington
pythongh-133982https://github.com/python/cpython/issues/133982
: Run unclosed file test on all io implementations (https://github.com/miss-islington/cpython/commit/4f82e8d97b9af80f0e89a5cd621f76784f31aa96
py…https://github.com/python/cpython/pull/134165
4f82e8dhttps://github.com/miss-islington/cpython/commit/4f82e8d97b9af80f0e89a5cd621f76784f31aa96
…thongh-134165https://github.com/python/cpython/pull/134165
5b0e827https://github.com/miss-islington/cpython/commit/5b0e82752120a5dc66ce6ee778751d71ba2c33b2
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
May 21, 2025https://github.com/python/cpython/pull/134165#issuecomment-2898254465
GH-134433https://github.com/python/cpython/pull/134433
3.14 branchhttps://github.com/python/cpython/tree/3.14
Please reload this pagehttps://github.com/python/cpython/pull/134165
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
May 21, 2025https://github.com/python/cpython/pull/134165#event-17755520663
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
May 21, 2025https://github.com/python/cpython/pull/134165#issuecomment-2898254695
GH-134434https://github.com/python/cpython/pull/134434
3.13 branchhttps://github.com/python/cpython/tree/3.13
Please reload this pagehttps://github.com/python/cpython/pull/134165
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
May 21, 2025https://github.com/python/cpython/pull/134165#event-17755521764
https://github.com/cmaloney
cmaloneyhttps://github.com/cmaloney
May 21, 2025 15:17https://github.com/python/cpython/pull/134165#event-17756001183
ambvhttps://github.com/ambv
May 21, 2025 https://github.com/python/cpython/pull/134165#ref-commit-fade04e
https://github.com/miss-islington
https://github.com/cmaloney
[3.14]https://github.com/python/cpython/commit/fade04e0f441be0ea3ec0ef99dd0af8113df9ed8
gh-133982https://github.com/python/cpython/issues/133982
: Run unclosed file test on all io implementations (https://github.com/python/cpython/commit/fade04e0f441be0ea3ec0ef99dd0af8113df9ed8
g…https://github.com/python/cpython/pull/134165
fade04ehttps://github.com/python/cpython/commit/fade04e0f441be0ea3ec0ef99dd0af8113df9ed8
…h-134165https://github.com/python/cpython/pull/134165
gh-134433https://github.com/python/cpython/pull/134433
5b0e827https://github.com/python/cpython/commit/5b0e82752120a5dc66ce6ee778751d71ba2c33b2
ambvhttps://github.com/ambv
May 21, 2025 https://github.com/python/cpython/pull/134165#ref-commit-e1e8533
https://github.com/miss-islington
https://github.com/cmaloney
[3.13]https://github.com/python/cpython/commit/e1e8533a5d2ded9ba14e6129abf0fad8305def75
gh-133982https://github.com/python/cpython/issues/133982
: Run unclosed file test on all io implementations (https://github.com/python/cpython/commit/e1e8533a5d2ded9ba14e6129abf0fad8305def75
g…https://github.com/python/cpython/pull/134165
e1e8533https://github.com/python/cpython/commit/e1e8533a5d2ded9ba14e6129abf0fad8305def75
…h-134165https://github.com/python/cpython/pull/134165
gh-134434https://github.com/python/cpython/pull/134434
5b0e827https://github.com/python/cpython/commit/5b0e82752120a5dc66ce6ee778751d71ba2c33b2
lkollarhttps://github.com/lkollar
May 26, 2025 https://github.com/python/cpython/pull/134165#ref-commit-53b4cf7
https://github.com/cmaloney
https://github.com/lkollar
pythongh-133982https://github.com/python/cpython/issues/133982
: Run unclosed file test on all io implementations (https://github.com/lkollar/cpython/commit/53b4cf7a5ce9136096dd9510bff147305a1acc6d
py…https://github.com/python/cpython/pull/134165
53b4cf7https://github.com/lkollar/cpython/commit/53b4cf7a5ce9136096dd9510bff147305a1acc6d
…thongh-134165https://github.com/python/cpython/pull/134165
Pranjal095https://github.com/Pranjal095
Jul 12, 2025 https://github.com/python/cpython/pull/134165#ref-commit-2963d90
https://github.com/cmaloney
https://github.com/Pranjal095
pythongh-133982https://github.com/python/cpython/issues/133982
: Run unclosed file test on all io implementations (https://github.com/Pranjal095/cpython/commit/2963d90dd05ccb0ea674ce399f921c1864ccaedf
py…https://github.com/python/cpython/pull/134165
2963d90https://github.com/Pranjal095/cpython/commit/2963d90dd05ccb0ea674ce399f921c1864ccaedf
…thongh-134165https://github.com/python/cpython/pull/134165
taegyunkimhttps://github.com/taegyunkim
Aug 4, 2025 https://github.com/python/cpython/pull/134165#ref-commit-87d8510
https://github.com/cmaloney
https://github.com/taegyunkim
pythongh-133982https://github.com/python/cpython/issues/133982
: Run unclosed file test on all io implementations (https://github.com/taegyunkim/cpython/commit/87d8510391a475c317d208b577842fbda951b63d
py…https://github.com/python/cpython/pull/134165
87d8510https://github.com/taegyunkim/cpython/commit/87d8510391a475c317d208b577842fbda951b63d
…thongh-134165https://github.com/python/cpython/pull/134165
gostak-ddhttps://github.com/gostak-dd
Jun 2, 2026 https://github.com/python/cpython/pull/134165#ref-commit-3d0011e
https://github.com/cmaloney
https://github.com/gostak-dd
pythongh-133982https://github.com/python/cpython/issues/133982
: Run unclosed file test on all io implementations (https://github.com/gostak-dd/cpython/commit/3d0011e12343d9a7783479f81e9d66033cb3d78f
py…https://github.com/python/cpython/pull/134165
3d0011ehttps://github.com/gostak-dd/cpython/commit/3d0011e12343d9a7783479f81e9d66033cb3d78f
…thongh-134165https://github.com/python/cpython/pull/134165
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F134165
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Please reload this pagehttps://github.com/python/cpython/pull/134165
https://github.com/cmaloney
https://github.com/ambv
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.