René's URL Explorer Experiment


Title: [3.14] gh-132641: fix race in `lru_cache` under free-threading (GH-133787) by miss-islington · Pull Request #133979 · python/cpython · GitHub

Open Graph Title: [3.14] gh-132641: fix race in `lru_cache` under free-threading (GH-133787) by miss-islington · Pull Request #133979 · python/cpython

X Title: [3.14] gh-132641: fix race in `lru_cache` under free-threading (GH-133787) by miss-islington · Pull Request #133979 · python/cpython

Description: Fix race in lru_cache by acquiring critical section on the cache object itself and call the lock held variant of dict functions to modify the underlying dict. (cherry picked from commit 9ad0c7b) Co-authored-by: Peter Hawkins phawkins@google.com Issue: gh-132641

Open Graph Description: Fix race in lru_cache by acquiring critical section on the cache object itself and call the lock held variant of dict functions to modify the underlying dict. (cherry picked from commit 9ad0c7b) Co...

X Description: Fix race in lru_cache by acquiring critical section on the cache object itself and call the lock held variant of dict functions to modify the underlying dict. (cherry picked from commit 9ad0c7b) Co...

Opengraph URL: https://github.com/python/cpython/pull/133979

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1356cd90-8da2-28f9-4165-7723599841ed
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA1B6:3B07B3:1297E6D:174AE8A:6B024A97
html-safe-nonce6d711833795c1143bdffbc479471a4b3e0dc18ce475a535de240babd1849f03d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMUI2OjNCMDdCMzoxMjk3RTZEOjE3NEFFOEE6NkIwMjRBOTciLCJ2aXNpdG9yX2lkIjoiNTE4ODYxNTM0NDg2ODE4MjY3OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac217684290bf01d0906e81f00e471d764c78dbff6b933e7627a1adac6297f7a9c
hovercard-subject-tagpull_request:2517266339
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/133979/files
twitter:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
og:image:altFix race in lru_cache by acquiring critical section on the cache object itself and call the lock held variant of dict functions to modify the underlying dict. (cherry picked from commit 9ad0c7b) Co...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/133979/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133979%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133979%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/133979/files
Reloadhttps://github.com/python/cpython/pull/133979/files
Reloadhttps://github.com/python/cpython/pull/133979/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
kumaraditya303https://github.com/kumaraditya303
python:3.14https://github.com/python/cpython/tree/3.14
miss-islington:backport-9ad0c7b-3.14https://github.com/miss-islington/cpython/tree/backport-9ad0c7b-3.14
Conversation 0 https://github.com/python/cpython/pull/133979
Commits 1 https://github.com/python/cpython/pull/133979/commits
Checks 0 https://github.com/python/cpython/pull/133979/checks
Files changed https://github.com/python/cpython/pull/133979/files
Please reload this pagehttps://github.com/python/cpython/pull/133979/files
[3.14] gh-132641: fix race in lru_cache under free-threading (GH-133787) https://github.com/python/cpython/pull/133979/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/133979/files
1594c26 gh-132641: fix race in `lru_cache` under free-threading (GH-133787) hawkinsp May 13, 2025 https://github.com/python/cpython/pull/133979/commits/1594c26b8d9daf352921327804220c68ba255f29
Clear filters https://github.com/python/cpython/pull/133979/files
Please reload this pagehttps://github.com/python/cpython/pull/133979/files
Please reload this pagehttps://github.com/python/cpython/pull/133979/files
pycore_dict.h https://github.com/python/cpython/pull/133979/files#diff-47692c69ef97b2d7cf05ad8e0fa2024b575af96abf9bbc5486f71156ab67ede4
test_functools.py https://github.com/python/cpython/pull/133979/files#diff-3eb5a6d77f0c1af332fdb7c6a1bf554670eeae42d0709aeac4ad2f16722f3cd4
2025-05-09-20-59-24.gh-issue-132641.3qTw44.rst https://github.com/python/cpython/pull/133979/files#diff-d9de735f860416426e050c54798e5c434e8e4fda409308b1b6e2bb251ca1acec
_functoolsmodule.c https://github.com/python/cpython/pull/133979/files#diff-d1deea0fb29260d389bac1b24c3ec3631e843d177e85c0e93d5cf50966dee630
dictobject.c https://github.com/python/cpython/pull/133979/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
Include/internal/pycore_dict.hhttps://github.com/python/cpython/pull/133979/files#diff-47692c69ef97b2d7cf05ad8e0fa2024b575af96abf9bbc5486f71156ab67ede4
View file https://github.com/miss-islington/cpython/blob/1594c26b8d9daf352921327804220c68ba255f29/Include/internal/pycore_dict.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/133979/{{ revealButtonHref }}
https://github.com/python/cpython/pull/133979/files#diff-47692c69ef97b2d7cf05ad8e0fa2024b575af96abf9bbc5486f71156ab67ede4
https://github.com/python/cpython/pull/133979/files#diff-47692c69ef97b2d7cf05ad8e0fa2024b575af96abf9bbc5486f71156ab67ede4
https://github.com/python/cpython/blob/3.14/.github/CODEOWNERS#L249
Lib/test/test_free_threading/test_functools.pyhttps://github.com/python/cpython/pull/133979/files#diff-3eb5a6d77f0c1af332fdb7c6a1bf554670eeae42d0709aeac4ad2f16722f3cd4
View file https://github.com/miss-islington/cpython/blob/1594c26b8d9daf352921327804220c68ba255f29/Lib/test/test_free_threading/test_functools.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/133979/{{ revealButtonHref }}
Misc/NEWS.d/next/Library/2025-05-09-20-59-24.gh-issue-132641.3qTw44.rsthttps://github.com/python/cpython/pull/133979/files#diff-d9de735f860416426e050c54798e5c434e8e4fda409308b1b6e2bb251ca1acec
View file https://github.com/miss-islington/cpython/blob/1594c26b8d9daf352921327804220c68ba255f29/Misc/NEWS.d/next/Library/2025-05-09-20-59-24.gh-issue-132641.3qTw44.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/133979/{{ revealButtonHref }}
https://github.com/python/cpython/blob/3.14/.github/CODEOWNERS#L249
Modules/_functoolsmodule.chttps://github.com/python/cpython/pull/133979/files#diff-d1deea0fb29260d389bac1b24c3ec3631e843d177e85c0e93d5cf50966dee630
View file https://github.com/miss-islington/cpython/blob/1594c26b8d9daf352921327804220c68ba255f29/Modules/_functoolsmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/133979/{{ revealButtonHref }}
https://github.com/python/cpython/pull/133979/files#diff-d1deea0fb29260d389bac1b24c3ec3631e843d177e85c0e93d5cf50966dee630
https://github.com/python/cpython/pull/133979/files#diff-d1deea0fb29260d389bac1b24c3ec3631e843d177e85c0e93d5cf50966dee630
https://github.com/python/cpython/pull/133979/files#diff-d1deea0fb29260d389bac1b24c3ec3631e843d177e85c0e93d5cf50966dee630
https://github.com/python/cpython/pull/133979/files#diff-d1deea0fb29260d389bac1b24c3ec3631e843d177e85c0e93d5cf50966dee630
https://github.com/python/cpython/pull/133979/files#diff-d1deea0fb29260d389bac1b24c3ec3631e843d177e85c0e93d5cf50966dee630
https://github.com/python/cpython/pull/133979/files#diff-d1deea0fb29260d389bac1b24c3ec3631e843d177e85c0e93d5cf50966dee630
https://github.com/python/cpython/blob/3.14/.github/CODEOWNERS#L38
Objects/dictobject.chttps://github.com/python/cpython/pull/133979/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
View file https://github.com/miss-islington/cpython/blob/1594c26b8d9daf352921327804220c68ba255f29/Objects/dictobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/133979/{{ revealButtonHref }}
https://github.com/python/cpython/pull/133979/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
https://github.com/python/cpython/pull/133979/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.