René's URL Explorer Experiment


Title: Fixes #133895 by abhigyan631 · Pull Request #133923 · python/cpython · GitHub

Open Graph Title: Fixes #133895 by abhigyan631 · Pull Request #133923 · python/cpython

X Title: Fixes #133895 by abhigyan631 · Pull Request #133923 · python/cpython

Description: This PR modifies the error handling in math and cmath modules to include the computed result value when raising ValueError and OverflowError exceptions. This is particularly useful for applications that need to adhere to C99 Annex G recommendations. Changes made: - Modified is_error() in mathmodule.c to include computed result value - Modified math_error() in cmathmodule.c to include computed result value - Added tests to verify the changes

Open Graph Description: This PR modifies the error handling in math and cmath modules to include the computed result value when raising ValueError and OverflowError exceptions. This is particularly useful for applications...

X Description: This PR modifies the error handling in math and cmath modules to include the computed result value when raising ValueError and OverflowError exceptions. This is particularly useful for applications...

Opengraph URL: https://github.com/python/cpython/pull/133923

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9b816691-67d3-80a1-f6f7-397d381e24ec
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD144:1A7CA7:B07E48:E974FC:6A531D41
html-safe-nonceb74e55f8328cb843cb5d8f4a6b7862d256526abd69926b53f121025d84dd78b5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMTQ0OjFBN0NBNzpCMDdFNDg6RTk3NEZDOjZBNTMxRDQxIiwidmlzaXRvcl9pZCI6IjgyNzI1Mzk3NjYxOTQ2NDIyNDEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac76fe458ed84badfaa8804fba4d84c52fbb422ffefbe008b97d4762efcde30524
hovercard-subject-tagpull_request:2513646101
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/133923/files
twitter:imagehttps://avatars.githubusercontent.com/u/101783480?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/101783480?s=400&v=4
og:image:altThis PR modifies the error handling in math and cmath modules to include the computed result value when raising ValueError and OverflowError exceptions. This is particularly useful for applications...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/133923/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133923%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133923%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/133923/files
Reloadhttps://github.com/python/cpython/pull/133923/files
Reloadhttps://github.com/python/cpython/pull/133923/files
Please reload this pagehttps://github.com/python/cpython/pull/133923/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/133923/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
abhigyan631https://github.com/abhigyan631
python:mainhttps://github.com/python/cpython/tree/main
abhigyan631:fix-math-errorshttps://github.com/abhigyan631/cpython/tree/fix-math-errors
Conversation 5 https://github.com/python/cpython/pull/133923
Commits 2 https://github.com/python/cpython/pull/133923/commits
Checks 0 https://github.com/python/cpython/pull/133923/checks
Files changed https://github.com/python/cpython/pull/133923/files
Please reload this pagehttps://github.com/python/cpython/pull/133923/files
Fixes #133895 https://github.com/python/cpython/pull/133923/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/133923/files
e883928 gh-133895: Include computed result value in math and cmath error exce… abhigyan631 May 12, 2025 https://github.com/python/cpython/pull/133923/commits/e8839283bab1f07aa81f7ea5e61252662545da9e
6575fb8 Merge branch 'main' into fix-math-errors abhigyan631 May 12, 2025 https://github.com/python/cpython/pull/133923/commits/6575fb888d5e9beaeef80531abd746bc31c41aaf
Clear filters https://github.com/python/cpython/pull/133923/files
Please reload this pagehttps://github.com/python/cpython/pull/133923/files
Please reload this pagehttps://github.com/python/cpython/pull/133923/files
test_math_errors.py https://github.com/python/cpython/pull/133923/files#diff-f1079ec3edf9fe2e1cb224943db93f450d4714239b2d584453497e58586f5f7c
cmathmodule.c https://github.com/python/cpython/pull/133923/files#diff-cd2894d4ca90afe093b0f2d91876c388821ba40f1454d3d4cc6dc7af69d8aedd
mathmodule.c https://github.com/python/cpython/pull/133923/files#diff-5b1186dfcc44670529aa53cb728a1c005f58f38324c24787a49f22cec36841c7
Lib/test/test_math_errors.pyhttps://github.com/python/cpython/pull/133923/files#diff-f1079ec3edf9fe2e1cb224943db93f450d4714239b2d584453497e58586f5f7c
View file https://github.com/abhigyan631/cpython/blob/6575fb888d5e9beaeef80531abd746bc31c41aaf/Lib/test/test_math_errors.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/133923/{{ revealButtonHref }}
Modules/cmathmodule.chttps://github.com/python/cpython/pull/133923/files#diff-cd2894d4ca90afe093b0f2d91876c388821ba40f1454d3d4cc6dc7af69d8aedd
View file https://github.com/abhigyan631/cpython/blob/6575fb888d5e9beaeef80531abd746bc31c41aaf/Modules/cmathmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/133923/{{ revealButtonHref }}
https://github.com/python/cpython/pull/133923/files#diff-cd2894d4ca90afe093b0f2d91876c388821ba40f1454d3d4cc6dc7af69d8aedd
https://github.com/python/cpython/pull/133923/files#diff-cd2894d4ca90afe093b0f2d91876c388821ba40f1454d3d4cc6dc7af69d8aedd
https://github.com/python/cpython/pull/133923/files#diff-cd2894d4ca90afe093b0f2d91876c388821ba40f1454d3d4cc6dc7af69d8aedd
https://github.com/python/cpython/pull/133923/files#diff-cd2894d4ca90afe093b0f2d91876c388821ba40f1454d3d4cc6dc7af69d8aedd
https://github.com/python/cpython/pull/133923/files#diff-cd2894d4ca90afe093b0f2d91876c388821ba40f1454d3d4cc6dc7af69d8aedd
https://github.com/python/cpython/pull/133923/files#diff-cd2894d4ca90afe093b0f2d91876c388821ba40f1454d3d4cc6dc7af69d8aedd
https://github.com/python/cpython/pull/133923/files#diff-cd2894d4ca90afe093b0f2d91876c388821ba40f1454d3d4cc6dc7af69d8aedd
Modules/mathmodule.chttps://github.com/python/cpython/pull/133923/files#diff-5b1186dfcc44670529aa53cb728a1c005f58f38324c24787a49f22cec36841c7
View file https://github.com/abhigyan631/cpython/blob/6575fb888d5e9beaeef80531abd746bc31c41aaf/Modules/mathmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/133923/{{ revealButtonHref }}
https://github.com/python/cpython/pull/133923/files#diff-5b1186dfcc44670529aa53cb728a1c005f58f38324c24787a49f22cec36841c7
https://github.com/python/cpython/pull/133923/files#diff-5b1186dfcc44670529aa53cb728a1c005f58f38324c24787a49f22cec36841c7
https://github.com/python/cpython/pull/133923/files#diff-5b1186dfcc44670529aa53cb728a1c005f58f38324c24787a49f22cec36841c7
https://github.com/python/cpython/pull/133923/files#diff-5b1186dfcc44670529aa53cb728a1c005f58f38324c24787a49f22cec36841c7
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.