René's URL Explorer Experiment


Title: gh-133701: Fix incorrect `__annotations__` on TypedDict defined under PEP 563 by JelleZijlstra · Pull Request #133772 · python/cpython · GitHub

Open Graph Title: gh-133701: Fix incorrect `__annotations__` on TypedDict defined under PEP 563 by JelleZijlstra · Pull Request #133772 · python/cpython

X Title: gh-133701: Fix incorrect `__annotations__` on TypedDict defined under PEP 563 by JelleZijlstra · Pull Request #133772 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Issue: multi-level hierarchies of TypedDict no longer return superclass elements in __annotations__ as of 3.14.0b1 when future annotations enabled #133701

X Description: Issue: multi-level hierarchies of TypedDict no longer return superclass elements in __annotations__ as of 3.14.0b1 when future annotations enabled #133701

Opengraph URL: https://github.com/python/cpython/pull/133772

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/*id(.:format)
route-controllerpull_requests
route-actionshow
fetch-noncev2:901a5d01-1f44-54d2-2fa1-7610f653f10d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id80FA:1BEF18:26892C3:343EF73:6B0039A1
html-safe-nonce2298de0b0f8986025a5b48dbad9efd9fc3dde9013da8bfccbcf1aa73af935173
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MEZBOjFCRUYxODoyNjg5MkMzOjM0M0VGNzM6NkIwMDM5QTEiLCJ2aXNpdG9yX2lkIjoiMTc1NTg3MTcxODYxMTYzMDQ5NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5bbd0e9cfccb024a2a26f593aec03323979aa7ff9e68751d148b60a9e4aa495b
hovercard-subject-tagpull_request:2510008534
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/133772
twitter:imagehttps://opengraph.githubassets.com/0bb8d62aab5b57ba8f352d1b415f176e11cab6d867683aa22e8f4f928d4bd5de/python/cpython/pull/133772
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0bb8d62aab5b57ba8f352d1b415f176e11cab6d867683aa22e8f4f928d4bd5de/python/cpython/pull/133772
og:image:altIssue: multi-level hierarchies of TypedDict no longer return superclass elements in __annotations__ as of 3.14.0b1 when future annotations enabled #133701
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJelleZijlstra
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/133772#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133772
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133772
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/133772
Reloadhttps://github.com/python/cpython/pull/133772
Reloadhttps://github.com/python/cpython/pull/133772
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
JelleZijlstrahttps://github.com/JelleZijlstra
python:mainhttps://github.com/python/cpython/tree/main
JelleZijlstra:td-inherithttps://github.com/JelleZijlstra/cpython/tree/td-inherit
Conversationhttps://github.com/python/cpython/pull/133772
Commits1 (1)https://github.com/python/cpython/pull/133772/commits
Checkshttps://github.com/python/cpython/pull/133772/checks
Files changedhttps://github.com/python/cpython/pull/133772/files
gh-133701: Fix incorrect __annotations__ on TypedDict defined under PEP 563https://github.com/python/cpython/pull/133772#top
JelleZijlstrahttps://github.com/JelleZijlstra
python:mainhttps://github.com/python/cpython/tree/main
JelleZijlstra:td-inherithttps://github.com/JelleZijlstra/cpython/tree/td-inherit
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
May 9, 2025https://github.com/python/cpython/pull/133772#issue-3052569259
Please reload this pagehttps://github.com/python/cpython/pull/133772
multi-level hierarchies of TypedDict no longer return superclass elements in __annotations__ as of 3.14.0b1 when future annotations enabled #133701https://github.com/python/cpython/issues/133701
Please reload this pagehttps://github.com/python/cpython/pull/133772
https://github.com/JelleZijlstra
pythongh-133701https://github.com/python/cpython/issues/133701
: Fix incorrecthttps://github.com/python/cpython/pull/133772/commits/b3c854c8694cf3a2e4607793d323244654d0b803
__annotations__https://github.com/python/cpython/pull/133772/commits/b3c854c8694cf3a2e4607793d323244654d0b803
on TypedDict defined…https://github.com/python/cpython/pull/133772/commits/b3c854c8694cf3a2e4607793d323244654d0b803
b3c854chttps://github.com/python/cpython/pull/133772/commits/b3c854c8694cf3a2e4607793d323244654d0b803
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
AlexWaygoodhttps://github.com/AlexWaygood
code ownerhttps://github.com/python/cpython/blob/6d9ec4e9d70a8a04000398e0a3fb2ca279e81657/.github/CODEOWNERS#L251
May 9, 2025 15:50https://github.com/python/cpython/pull/133772#event-17593347574
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
May 9, 2025 https://github.com/python/cpython/pull/133772#ref-issue-3049872036
multi-level hierarchies of TypedDict no longer return superclass elements in __annotations__ as of 3.14.0b1 when future annotations enabled #133701 https://github.com/python/cpython/issues/133701
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 9, 2025https://github.com/python/cpython/pull/133772#event-17593349430
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
May 9, 2025https://github.com/python/cpython/pull/133772#event-17593355676
surprising new behavior in inspect/annotationlib get_annotations as of 3.14.0b1, not in 3.14.0a7. intended change? #133684 https://github.com/python/cpython/issues/133684
assigning to __annotations__ has no effect in 3.14.0b1 under from __future__ import annotations #133778 https://github.com/python/cpython/issues/133778
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
9836503https://github.com/python/cpython/commit/9836503b48e047db117b3bef3a812c40ed3e988a
May 14, 2025https://github.com/python/cpython/pull/133772#event-17653714364
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
May 14, 2025https://github.com/python/cpython/pull/133772#issuecomment-2880238483
@JelleZijlstrahttps://github.com/JelleZijlstra
Please reload this pagehttps://github.com/python/cpython/pull/133772
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 14, 2025https://github.com/python/cpython/pull/133772#event-17653715239
miss-islingtonhttps://github.com/miss-islington
May 14, 2025 https://github.com/python/cpython/pull/133772#ref-commit-f570053
https://github.com/JelleZijlstra
https://github.com/miss-islington
pythongh-133701https://github.com/python/cpython/issues/133701
: Fix incorrecthttps://github.com/miss-islington/cpython/commit/f5700534d7bee2a3fd7789c30f7099fa31d9f2ec
__annotations__https://github.com/miss-islington/cpython/commit/f5700534d7bee2a3fd7789c30f7099fa31d9f2ec
on TypedDict defined…https://github.com/miss-islington/cpython/commit/f5700534d7bee2a3fd7789c30f7099fa31d9f2ec
f570053https://github.com/miss-islington/cpython/commit/f5700534d7bee2a3fd7789c30f7099fa31d9f2ec
pythonGH-133772https://github.com/python/cpython/pull/133772
9836503https://github.com/miss-islington/cpython/commit/9836503b48e047db117b3bef3a812c40ed3e988a
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
May 14, 2025https://github.com/python/cpython/pull/133772#issuecomment-2880239088
GH-134003https://github.com/python/cpython/pull/134003
3.14 branchhttps://github.com/python/cpython/tree/3.14
Please reload this pagehttps://github.com/python/cpython/pull/133772
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
May 14, 2025https://github.com/python/cpython/pull/133772#event-17653719364
JelleZijlstrahttps://github.com/JelleZijlstra
May 14, 2025 https://github.com/python/cpython/pull/133772#ref-commit-d6cb8fa
https://github.com/miss-islington
https://github.com/JelleZijlstra
[3.14]https://github.com/python/cpython/commit/d6cb8fa86eb3c6e41e532c247a02c1c3df93e744
gh-133701https://github.com/python/cpython/issues/133701
: Fix incorrecthttps://github.com/python/cpython/commit/d6cb8fa86eb3c6e41e532c247a02c1c3df93e744
__annotations__https://github.com/python/cpython/commit/d6cb8fa86eb3c6e41e532c247a02c1c3df93e744
on TypedDict define…https://github.com/python/cpython/commit/d6cb8fa86eb3c6e41e532c247a02c1c3df93e744
d6cb8fahttps://github.com/python/cpython/commit/d6cb8fa86eb3c6e41e532c247a02c1c3df93e744
GH-133772https://github.com/python/cpython/pull/133772
#134003https://github.com/python/cpython/pull/134003
gh-133701https://github.com/python/cpython/issues/133701
GH-133772https://github.com/python/cpython/pull/133772
9836503https://github.com/python/cpython/commit/9836503b48e047db117b3bef3a812c40ed3e988a
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
May 24, 2025 https://github.com/python/cpython/pull/133772#ref-pullrequest-3087849573
More fixes for 3.14 and 3.15 python/typing_extensions#602 https://github.com/python/typing_extensions/pull/602
Pranjal095https://github.com/Pranjal095
Jul 12, 2025 https://github.com/python/cpython/pull/133772#ref-commit-2db0675
https://github.com/JelleZijlstra
https://github.com/Pranjal095
pythongh-133701https://github.com/python/cpython/issues/133701
: Fix incorrecthttps://github.com/Pranjal095/cpython/commit/2db067524e9892604bed650576646626e95c6e0c
__annotations__https://github.com/Pranjal095/cpython/commit/2db067524e9892604bed650576646626e95c6e0c
on TypedDict defined…https://github.com/Pranjal095/cpython/commit/2db067524e9892604bed650576646626e95c6e0c
2db0675https://github.com/Pranjal095/cpython/commit/2db067524e9892604bed650576646626e95c6e0c
python#133772https://github.com/python/cpython/pull/133772
taegyunkimhttps://github.com/taegyunkim
Aug 4, 2025 https://github.com/python/cpython/pull/133772#ref-commit-497193f
https://github.com/JelleZijlstra
https://github.com/taegyunkim
pythongh-133701https://github.com/python/cpython/issues/133701
: Fix incorrecthttps://github.com/taegyunkim/cpython/commit/497193f998a8fe1065d2631a64893d9479ac5c91
__annotations__https://github.com/taegyunkim/cpython/commit/497193f998a8fe1065d2631a64893d9479ac5c91
on TypedDict defined…https://github.com/taegyunkim/cpython/commit/497193f998a8fe1065d2631a64893d9479ac5c91
497193fhttps://github.com/taegyunkim/cpython/commit/497193f998a8fe1065d2631a64893d9479ac5c91
python#133772https://github.com/python/cpython/pull/133772
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133772
https://github.com/AlexWaygood
AlexWaygood https://github.com/AlexWaygood
Please reload this pagehttps://github.com/python/cpython/pull/133772
Please reload this pagehttps://github.com/python/cpython/pull/133772
https://github.com/JelleZijlstra
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.