René's URL Explorer Experiment


Title: gh-132983: Don't allow trailer data in ZstdFile by Rogdham · Pull Request #133736 · python/cpython · GitHub

Open Graph Title: gh-132983: Don't allow trailer data in ZstdFile by Rogdham · Pull Request #133736 · python/cpython

X Title: gh-132983: Don't allow trailer data in ZstdFile by Rogdham · Pull Request #133736 · python/cpython

Description: We previously made sure that an exception is raised when decompressing trailer data with decompress: >>> from compression.zstd import compress, decompress >>> invalid = compress(b'xxx') + b'yyy' >>...

Open Graph Description: We previously made sure that an exception is raised when decompressing trailer data with decompress: >>> from compression.zstd import compress, decompress >>> invalid = compress(b...

X Description: We previously made sure that an exception is raised when decompressing trailer data with decompress: >>> from compression.zstd import compress, decompress >>&...

Opengraph URL: https://github.com/python/cpython/pull/133736

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:31feae88-e3fd-5e07-0efa-121f30974f2f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDD6E:8BCE9:F788D2:156FD5F:696A3FF7
html-safe-nonce2ec5ad130e0a11fcaff586b24a975b0cae8bf05e096d890c307c6bdd857e08b7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDZFOjhCQ0U5OkY3ODhEMjoxNTZGRDVGOjY5NkEzRkY3IiwidmlzaXRvcl9pZCI6IjY2OTA2MTU1ODIwNjA1OTMxNDMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9545e25de9980ec1830c520897115ecbbf18c95a7aac2d0229fd28512abd97c8
hovercard-subject-tagpull_request:2509136913
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/133736/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/189978bafef2aeaf0801363d4dc333d6f08d95619a70e5500f41d15545939595/python/cpython/pull/133736
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/189978bafef2aeaf0801363d4dc333d6f08d95619a70e5500f41d15545939595/python/cpython/pull/133736
og:image:altWe previously made sure that an exception is raised when decompressing trailer data with decompress: >>> from compression.zstd import compress, decompress >>> invalid = compress(b...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameRogdham
hostnamegithub.com
expected-hostnamegithub.com
None321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release13581a31d51edf4a3aca179e10890a4d4f9b6d76
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/133736#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133736
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133736
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/133736
Reloadhttps://github.com/python/cpython/pull/133736
Reloadhttps://github.com/python/cpython/pull/133736
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/133736
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/133736
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/133736#issue-comment-box
AA-Turnerhttps://github.com/AA-Turner
python:mainhttps://github.com/python/cpython/tree/main
Rogdham:zstdfile-trailer-exceptionhttps://github.com/Rogdham/cpython/tree/zstdfile-trailer-exception
gh-132983: Don't allow trailer data in ZstdFile https://github.com/python/cpython/pull/133736#top
AA-Turnerhttps://github.com/AA-Turner
python:mainhttps://github.com/python/cpython/tree/main
Rogdham:zstdfile-trailer-exceptionhttps://github.com/Rogdham/cpython/tree/zstdfile-trailer-exception
Conversation 6 https://github.com/python/cpython/pull/133736
Commits 1 https://github.com/python/cpython/pull/133736/commits
Checks 48 https://github.com/python/cpython/pull/133736/checks
Files changed https://github.com/python/cpython/pull/133736/files
Please reload this pagehttps://github.com/python/cpython/pull/133736
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/Rogdham
Rogdhamhttps://github.com/Rogdham
May 9, 2025https://github.com/python/cpython/pull/133736#issue-3051586860
Please reload this pagehttps://github.com/python/cpython/pull/133736
the Zstandard specificationhttps://github.com/facebook/zstd/blob/dev/doc/zstd_compression_format.md#frames
Implement PEP 784 - Adding Zstandard to the Python standard library #132983https://github.com/python/cpython/issues/132983
Please reload this pagehttps://github.com/python/cpython/pull/133736
https://github.com/Rogdham
ZstdFile: don't allow trailer datahttps://github.com/python/cpython/pull/133736/commits/98d2b867f1e6e09ae9bbe40b1af5551ab82d22fc
98d2b86https://github.com/python/cpython/pull/133736/commits/98d2b867f1e6e09ae9bbe40b1af5551ab82d22fc
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
May 9, 2025 https://github.com/python/cpython/pull/133736#ref-issue-3021300364
Implement PEP 784 - Adding Zstandard to the Python standard library #132983 https://github.com/python/cpython/issues/132983
https://github.com/Rogdham
Rogdhamhttps://github.com/Rogdham
May 9, 2025 09:36https://github.com/python/cpython/pull/133736#event-17587977133
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
May 9, 2025https://github.com/python/cpython/pull/133736#event-17587977794
https://github.com/AA-Turner
AA-Turnerhttps://github.com/AA-Turner
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
May 9, 2025https://github.com/python/cpython/pull/133736#event-17591911428
https://github.com/emmatyping
emmatypinghttps://github.com/emmatyping
May 9, 2025https://github.com/python/cpython/pull/133736#issuecomment-2867488465
Please reload this pagehttps://github.com/python/cpython/pull/133736
https://github.com/Rogdham
Rogdhamhttps://github.com/Rogdham
May 9, 2025https://github.com/python/cpython/pull/133736#issuecomment-2867528086
Please reload this pagehttps://github.com/python/cpython/pull/133736
https://github.com/emmatyping
emmatypinghttps://github.com/emmatyping
May 9, 2025 https://github.com/python/cpython/pull/133736#pullrequestreview-2829326120
View reviewed changes https://github.com/python/cpython/pull/133736/files/98d2b867f1e6e09ae9bbe40b1af5551ab82d22fc
emmatypinghttps://github.com/emmatyping
https://github.com/python/cpython/pull/133736#pullrequestreview-2829326120
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/133736
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
May 9, 2025https://github.com/python/cpython/pull/133736#event-17595169817
https://github.com/emmatyping
emmatypinghttps://github.com/emmatyping
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
May 9, 2025https://github.com/python/cpython/pull/133736#event-17595172775
https://github.com/Rogdham
Rogdhamhttps://github.com/Rogdham
May 9, 2025https://github.com/python/cpython/pull/133736#issuecomment-2867539269
Please reload this pagehttps://github.com/python/cpython/pull/133736
Please reload this pagehttps://github.com/python/cpython/pull/133736
https://github.com/AA-Turner
AA-Turnerhttps://github.com/AA-Turner
50b5370https://github.com/python/cpython/commit/50b53706646cc130dcc71496f4a5bee14e9a1d9a
May 10, 2025https://github.com/python/cpython/pull/133736#event-17599488847
Please reload this pagehttps://github.com/python/cpython/pull/133736
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
May 10, 2025https://github.com/python/cpython/pull/133736#issuecomment-2868238868
@Rogdhamhttps://github.com/Rogdham
@AA-Turnerhttps://github.com/AA-Turner
Please reload this pagehttps://github.com/python/cpython/pull/133736
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 10, 2025https://github.com/python/cpython/pull/133736#event-17599489117
miss-islingtonhttps://github.com/miss-islington
May 10, 2025 https://github.com/python/cpython/pull/133736#ref-commit-0c55b02
https://github.com/Rogdham
https://github.com/miss-islington
pythongh-132983https://github.com/python/cpython/issues/132983
: Don't allow trailer data in ZstdFile (https://github.com/miss-islington/cpython/commit/0c55b023f62d6881d38031f8a334c48bd48140a3
pythonGH-133736https://github.com/python/cpython/pull/133736
)https://github.com/miss-islington/cpython/commit/0c55b023f62d6881d38031f8a334c48bd48140a3
0c55b02https://github.com/miss-islington/cpython/commit/0c55b023f62d6881d38031f8a334c48bd48140a3
50b5370https://github.com/miss-islington/cpython/commit/50b53706646cc130dcc71496f4a5bee14e9a1d9a
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
May 10, 2025https://github.com/python/cpython/pull/133736#issuecomment-2868239003
GH-133799https://github.com/python/cpython/pull/133799
3.14 branchhttps://github.com/python/cpython/tree/3.14
Please reload this pagehttps://github.com/python/cpython/pull/133736
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
May 10, 2025https://github.com/python/cpython/pull/133736#event-17599490381
AA-Turnerhttps://github.com/AA-Turner
May 10, 2025 https://github.com/python/cpython/pull/133736#ref-commit-99ca086
https://github.com/miss-islington
https://github.com/Rogdham
[3.14]https://github.com/python/cpython/commit/99ca086f9120f402e1147b473cee987a40437b96
gh-132983https://github.com/python/cpython/issues/132983
: Don't allow trailer data in ZstdFile (https://github.com/python/cpython/commit/99ca086f9120f402e1147b473cee987a40437b96
GH-133736https://github.com/python/cpython/pull/133736
) (https://github.com/python/cpython/commit/99ca086f9120f402e1147b473cee987a40437b96
#…https://github.com/python/cpython/pull/133799
99ca086https://github.com/python/cpython/commit/99ca086f9120f402e1147b473cee987a40437b96
…133799https://github.com/python/cpython/pull/133799
gh-132983https://github.com/python/cpython/issues/132983
GH-133736https://github.com/python/cpython/pull/133736
50b5370https://github.com/python/cpython/commit/50b53706646cc130dcc71496f4a5bee14e9a1d9a
https://github.com/Rogdham
Rogdhamhttps://github.com/Rogdham
May 10, 2025 06:45https://github.com/python/cpython/pull/133736#event-17600729731
Pranjal095https://github.com/Pranjal095
Jul 12, 2025 https://github.com/python/cpython/pull/133736#ref-commit-3882f69
https://github.com/Rogdham
https://github.com/Pranjal095
pythongh-132983https://github.com/python/cpython/issues/132983
: Don't allow trailer data in ZstdFile (https://github.com/Pranjal095/cpython/commit/3882f69896902d515451fea3341a74a7d3bc16f2
python#133736https://github.com/python/cpython/pull/133736
)https://github.com/Pranjal095/cpython/commit/3882f69896902d515451fea3341a74a7d3bc16f2
3882f69https://github.com/Pranjal095/cpython/commit/3882f69896902d515451fea3341a74a7d3bc16f2
taegyunkimhttps://github.com/taegyunkim
Aug 4, 2025 https://github.com/python/cpython/pull/133736#ref-commit-11bf99d
https://github.com/Rogdham
https://github.com/taegyunkim
pythongh-132983https://github.com/python/cpython/issues/132983
: Don't allow trailer data in ZstdFile (https://github.com/taegyunkim/cpython/commit/11bf99dced5d3b72f37d08a310fab26b1f92e1b4
python#133736https://github.com/python/cpython/pull/133736
)https://github.com/taegyunkim/cpython/commit/11bf99dced5d3b72f37d08a310fab26b1f92e1b4
11bf99dhttps://github.com/taegyunkim/cpython/commit/11bf99dced5d3b72f37d08a310fab26b1f92e1b4
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133736
https://github.com/emmatyping
emmatyping https://github.com/emmatyping
https://github.com/python/cpython/pull/133736/files/98d2b867f1e6e09ae9bbe40b1af5551ab82d22fc
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/133736
https://github.com/Rogdham
https://github.com/emmatyping
https://github.com/AA-Turner
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.