René's URL Explorer Experiment


Title: gh-133581: Fix refleak in AST unparsing by JelleZijlstra · Pull Request #133724 · python/cpython · GitHub

Open Graph Title: gh-133581: Fix refleak in AST unparsing by JelleZijlstra · Pull Request #133724 · python/cpython

X Title: gh-133581: Fix refleak in AST unparsing by JelleZijlstra · Pull Request #133724 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Issue: t-strings: AST unparsing does not reproduce original formatting #133581

X Description: Issue: t-strings: AST unparsing does not reproduce original formatting #133581

Opengraph URL: https://github.com/python/cpython/pull/133724

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3b5221b2-be5f-399d-84a2-f48fefbb341e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9E74:39D6FF:286E967:371BED8:6A53B576
html-safe-nonce313d2bd51acbd2d39f9c58709164d12700daf65b0acf27acd6b0eea25dbda89a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTc0OjM5RDZGRjoyODZFOTY3OjM3MUJFRDg6NkE1M0I1NzYiLCJ2aXNpdG9yX2lkIjoiMTIyODUwMDg5NjMwMTk1NDQyMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac388df813d41fa847e84201ae46609c802e34601b9add29593cb4f8c609436ec5
hovercard-subject-tagpull_request:2508497649
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/133724/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7074edb9b03a30222bb5c160c171021cbdbdf3f7a8e52fedcf406aae534da1b6/python/cpython/pull/133724
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7074edb9b03a30222bb5c160c171021cbdbdf3f7a8e52fedcf406aae534da1b6/python/cpython/pull/133724
og:image:altIssue: t-strings: AST unparsing does not reproduce original formatting #133581
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJelleZijlstra
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/133724#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133724
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133724
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/133724
Reloadhttps://github.com/python/cpython/pull/133724
Reloadhttps://github.com/python/cpython/pull/133724
Please reload this pagehttps://github.com/python/cpython/pull/133724
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/133724
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
lysnikolaouhttps://github.com/lysnikolaou
python:mainhttps://github.com/python/cpython/tree/main
JelleZijlstra:fix-ast-refleakhttps://github.com/JelleZijlstra/cpython/tree/fix-ast-refleak
Conversationhttps://github.com/python/cpython/pull/133724
Commits1 (1)https://github.com/python/cpython/pull/133724/commits
Checkshttps://github.com/python/cpython/pull/133724/checks
Files changedhttps://github.com/python/cpython/pull/133724/files
gh-133581: Fix refleak in AST unparsinghttps://github.com/python/cpython/pull/133724#top
lysnikolaouhttps://github.com/lysnikolaou
python:mainhttps://github.com/python/cpython/tree/main
JelleZijlstra:fix-ast-refleakhttps://github.com/JelleZijlstra/cpython/tree/fix-ast-refleak
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
May 9, 2025https://github.com/python/cpython/pull/133724#issue-3050586689
Please reload this pagehttps://github.com/python/cpython/pull/133724
t-strings: AST unparsing does not reproduce original formatting #133581https://github.com/python/cpython/issues/133581
Please reload this pagehttps://github.com/python/cpython/pull/133724
https://github.com/JelleZijlstra
pythongh-133581https://github.com/python/cpython/issues/133581
: Fix refleak in AST unparsinghttps://github.com/python/cpython/pull/133724/commits/7057e79fe386ff2b68e057cad0fb44a7401f2853
7057e79https://github.com/python/cpython/pull/133724/commits/7057e79fe386ff2b68e057cad0fb44a7401f2853
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
lysnikolaouhttps://github.com/lysnikolaou
May 9, 2025 02:50https://github.com/python/cpython/pull/133724#event-17583606258
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
May 9, 2025 https://github.com/python/cpython/pull/133724#ref-issue-3046210163
t-strings: AST unparsing does not reproduce original formatting #133581 https://github.com/python/cpython/issues/133581
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 9, 2025https://github.com/python/cpython/pull/133724#event-17583606939
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
May 9, 2025 https://github.com/python/cpython/pull/133724#ref-pullrequest-3047610706
gh-133581: Improve AST unparsing of t-strings #133635 https://github.com/python/cpython/pull/133635
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
May 9, 2025https://github.com/python/cpython/pull/133724#event-17583609804
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/lysnikolaou
May 9, 2025 https://github.com/python/cpython/pull/133724#pullrequestreview-2827239234
View reviewed changes https://github.com/python/cpython/pull/133724/files/7057e79fe386ff2b68e057cad0fb44a7401f2853
lysnikolaouhttps://github.com/lysnikolaou
https://github.com/python/cpython/pull/133724#pullrequestreview-2827239234
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@JelleZijlstrahttps://github.com/JelleZijlstra
Please reload this pagehttps://github.com/python/cpython/pull/133724
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 9, 2025https://github.com/python/cpython/pull/133724#event-17585776965
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/lysnikolaou
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
May 9, 2025https://github.com/python/cpython/pull/133724#event-17585781694
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/lysnikolaou
308ceffhttps://github.com/python/cpython/commit/308ceffc6869e3c12665f1ffa68db09a70fb9b58
May 9, 2025https://github.com/python/cpython/pull/133724#event-17585792207
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
May 9, 2025https://github.com/python/cpython/pull/133724#issuecomment-2865401762
@JelleZijlstrahttps://github.com/JelleZijlstra
@lysnikolaouhttps://github.com/lysnikolaou
Please reload this pagehttps://github.com/python/cpython/pull/133724
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
May 9, 2025https://github.com/python/cpython/pull/133724#event-17585792749
miss-islingtonhttps://github.com/miss-islington
May 9, 2025 https://github.com/python/cpython/pull/133724#ref-commit-f02c29d
https://github.com/JelleZijlstra
https://github.com/miss-islington
pythongh-133581https://github.com/python/cpython/issues/133581
: Fix refleak in t-string AST unparsing (https://github.com/miss-islington/cpython/commit/f02c29d06821a04e5c11744f8b25b62da7087dd2
pythonGH-133724https://github.com/python/cpython/pull/133724
)https://github.com/miss-islington/cpython/commit/f02c29d06821a04e5c11744f8b25b62da7087dd2
f02c29dhttps://github.com/miss-islington/cpython/commit/f02c29d06821a04e5c11744f8b25b62da7087dd2
308ceffhttps://github.com/miss-islington/cpython/commit/308ceffc6869e3c12665f1ffa68db09a70fb9b58
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
May 9, 2025https://github.com/python/cpython/pull/133724#issuecomment-2865403951
GH-133731https://github.com/python/cpython/pull/133731
3.14 branchhttps://github.com/python/cpython/tree/3.14
Please reload this pagehttps://github.com/python/cpython/pull/133724
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
May 9, 2025https://github.com/python/cpython/pull/133724#event-17585797604
lysnikolaouhttps://github.com/lysnikolaou
May 9, 2025 https://github.com/python/cpython/pull/133724#ref-commit-92d5677
https://github.com/miss-islington
https://github.com/JelleZijlstra
[3.14]https://github.com/python/cpython/commit/92d56777a1edbbef48581178004c4835bc9fe41d
gh-133581https://github.com/python/cpython/issues/133581
: Fix refleak in t-string AST unparsing (https://github.com/python/cpython/commit/92d56777a1edbbef48581178004c4835bc9fe41d
GH-133724https://github.com/python/cpython/pull/133724
) (https://github.com/python/cpython/commit/92d56777a1edbbef48581178004c4835bc9fe41d
#…https://github.com/python/cpython/pull/133731
92d5677https://github.com/python/cpython/commit/92d56777a1edbbef48581178004c4835bc9fe41d
…133731https://github.com/python/cpython/pull/133731
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
May 9, 2025 13:45https://github.com/python/cpython/pull/133724#event-17591447306
Pranjal095https://github.com/Pranjal095
Jul 12, 2025 https://github.com/python/cpython/pull/133724#ref-commit-0d9037d
https://github.com/JelleZijlstra
https://github.com/Pranjal095
pythongh-133581https://github.com/python/cpython/issues/133581
: Fix refleak in t-string AST unparsing (https://github.com/Pranjal095/cpython/commit/0d9037d2493b37e4d21dc78c2c10d6ae48442a4e
python#133724https://github.com/python/cpython/pull/133724
)https://github.com/Pranjal095/cpython/commit/0d9037d2493b37e4d21dc78c2c10d6ae48442a4e
0d9037dhttps://github.com/Pranjal095/cpython/commit/0d9037d2493b37e4d21dc78c2c10d6ae48442a4e
taegyunkimhttps://github.com/taegyunkim
Aug 4, 2025 https://github.com/python/cpython/pull/133724#ref-commit-53c4dcc
https://github.com/JelleZijlstra
https://github.com/taegyunkim
pythongh-133581https://github.com/python/cpython/issues/133581
: Fix refleak in t-string AST unparsing (https://github.com/taegyunkim/cpython/commit/53c4dccdf062b3c4e41028471601b408d706bc4e
python#133724https://github.com/python/cpython/pull/133724
)https://github.com/taegyunkim/cpython/commit/53c4dccdf062b3c4e41028471601b408d706bc4e
53c4dcchttps://github.com/taegyunkim/cpython/commit/53c4dccdf062b3c4e41028471601b408d706bc4e
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133724
https://github.com/lysnikolaou
lysnikolaou https://github.com/lysnikolaou
https://github.com/python/cpython/pull/133724/files/7057e79fe386ff2b68e057cad0fb44a7401f2853
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/133724
https://github.com/JelleZijlstra
https://github.com/lysnikolaou
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.