René's URL Explorer Experiment


Title: gh-133580: add missing exception in _sys_getwindowsversion_from_kernel32 by maxbachmann · Pull Request #133574 · python/cpython · GitHub

Open Graph Title: gh-133580: add missing exception in _sys_getwindowsversion_from_kernel32 by maxbachmann · Pull Request #133574 · python/cpython

X Title: gh-133580: add missing exception in _sys_getwindowsversion_from_kernel32 by maxbachmann · Pull Request #133574 · python/cpython

Description: This fixes a regression from #102256 where I didn't properly set the exception. This didn't cause issues for me since I wrote this when I was still using Python 3.11 where this was structured diffe...

Open Graph Description: This fixes a regression from #102256 where I didn't properly set the exception. This didn't cause issues for me since I wrote this when I was still using Python 3.11 where this was structur...

X Description: This fixes a regression from #102256 where I didn't properly set the exception. This didn't cause issues for me since I wrote this when I was still using Python 3.11 where this was ...

Opengraph URL: https://github.com/python/cpython/pull/133574

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5fa2c924-85db-c183-e5b9-8b9b66ae067a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD258:2C2C4D:2B0182D:3A161A8:696AE4CE
html-safe-nonce3113c6e109283325208c16e347f76729cb8dc9a3ff0d0d810d91511a39838b06
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjU4OjJDMkM0RDoyQjAxODJEOjNBMTYxQTg6Njk2QUU0Q0UiLCJ2aXNpdG9yX2lkIjoiMjI2OTUwNTIzNDAxNjA2ODgxNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1491d87b01ae19ec2ffd4cc9bfaa284154e33048e321c9b49f7f149e1c10f425
hovercard-subject-tagpull_request:2504247783
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/133574/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4f14a5bbf8647b511dbffca052fdfb3c0781b9c0a879dd33083483fe8b2b2404/python/cpython/pull/133574
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4f14a5bbf8647b511dbffca052fdfb3c0781b9c0a879dd33083483fe8b2b2404/python/cpython/pull/133574
og:image:altThis fixes a regression from #102256 where I didn't properly set the exception. This didn't cause issues for me since I wrote this when I was still using Python 3.11 where this was structur...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemaxbachmann
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3d84d50b3c75fa36755c3cf392edbc09e626f979
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/133574#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133574
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133574
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/133574
Reloadhttps://github.com/python/cpython/pull/133574
Reloadhttps://github.com/python/cpython/pull/133574
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/133574
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/133574
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/133574#issue-comment-box
zoobahttps://github.com/zooba
python:mainhttps://github.com/python/cpython/tree/main
maxbachmann:patch-6https://github.com/maxbachmann/cpython/tree/patch-6
gh-133580: add missing exception in _sys_getwindowsversion_from_kernel32 https://github.com/python/cpython/pull/133574#top
zoobahttps://github.com/zooba
python:mainhttps://github.com/python/cpython/tree/main
maxbachmann:patch-6https://github.com/maxbachmann/cpython/tree/patch-6
Conversation 4 https://github.com/python/cpython/pull/133574
Commits 4 https://github.com/python/cpython/pull/133574/commits
Checks 37 https://github.com/python/cpython/pull/133574/checks
Files changed https://github.com/python/cpython/pull/133574/files
Please reload this pagehttps://github.com/python/cpython/pull/133574
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/maxbachmann
maxbachmannhttps://github.com/maxbachmann
May 7, 2025https://github.com/python/cpython/pull/133574#issue-3045804871
Please reload this pagehttps://github.com/python/cpython/pull/133574
#102256https://github.com/python/cpython/pull/102256
sys.getwindowsversion can fail without setting an exception on some WinAPI partitions #133580https://github.com/python/cpython/issues/133580
Please reload this pagehttps://github.com/python/cpython/pull/133574
https://github.com/maxbachmann
add missing exception in _sys_getwindowsversion_from_kernel32https://github.com/python/cpython/pull/133574/commits/5dc09ad19726475f8e32e3b107dfa012d63e90de
5dc09adhttps://github.com/python/cpython/pull/133574/commits/5dc09ad19726475f8e32e3b107dfa012d63e90de
https://github.com/maxbachmann
maxbachmannhttps://github.com/maxbachmann
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
code ownerhttps://github.com/python/cpython/blob/3dfed230928de0f649061782a36691066a0ef058/.github/CODEOWNERS#L74
May 7, 2025 12:29https://github.com/python/cpython/pull/133574#event-17555412640
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
May 7, 2025https://github.com/python/cpython/pull/133574#event-17555414835
https://github.com/maxbachmann
maxbachmannhttps://github.com/maxbachmann
May 7, 2025https://github.com/python/cpython/pull/133574#event-17556005211
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
May 7, 2025 https://github.com/python/cpython/pull/133574#ref-issue-3045902747
sys.getwindowsversion can fail without setting an exception on some WinAPI partitions #133580 https://github.com/python/cpython/issues/133580
https://github.com/apps/blurb-it
📜🤖 Added by blurb_it.https://github.com/python/cpython/pull/133574/commits/064806d9d777aa13be4e8a26dcbc1587173697ff
064806dhttps://github.com/python/cpython/pull/133574/commits/064806d9d777aa13be4e8a26dcbc1587173697ff
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
OS-windows https://github.com/python/cpython/issues?q=state%3Aopen%20label%3AOS-windows
May 11, 2025https://github.com/python/cpython/pull/133574#event-17606137566
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
May 11, 2025 https://github.com/python/cpython/pull/133574#pullrequestreview-2831452387
View reviewed changes https://github.com/python/cpython/pull/133574/files/064806d9d777aa13be4e8a26dcbc1587173697ff
Misc/NEWS.d/next/Windows/2025-05-07-13-04-22.gh-issue-133580.jBMujJ.rsthttps://github.com/python/cpython/pull/133574/files/064806d9d777aa13be4e8a26dcbc1587173697ff#diff-58a393f348559a73693164586f9654a762cfbb0eefd17ad6abb7b0d71914ec78
Please reload this pagehttps://github.com/python/cpython/pull/133574
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
May 11, 2025https://github.com/python/cpython/pull/133574#event-17606138194
https://github.com/maxbachmann
https://github.com/ZeroIntensity
Update Misc/NEWS.d/next/Windows/2025-05-07-13-04-22.gh-issue-133580.j…https://github.com/python/cpython/pull/133574/commits/5e5552bd3245d298b165ea9f813f75a07c53b8be
5e5552bhttps://github.com/python/cpython/pull/133574/commits/5e5552bd3245d298b165ea9f813f75a07c53b8be
https://github.com/maxbachmann
maxbachmannhttps://github.com/maxbachmann
May 14, 2025 https://github.com/python/cpython/pull/133574#ref-pullrequest-3045253312
gh-133562: disable security descriptor handling on unsupported WinAPI partitions #133563 https://github.com/python/cpython/pull/133563
https://github.com/sergey-miryanov
sergey-miryanovhttps://github.com/sergey-miryanov
May 14, 2025 https://github.com/python/cpython/pull/133574#pullrequestreview-2839479455
View reviewed changes https://github.com/python/cpython/pull/133574/files/5e5552bd3245d298b165ea9f813f75a07c53b8be
Python/sysmodule.chttps://github.com/python/cpython/pull/133574/files/5e5552bd3245d298b165ea9f813f75a07c53b8be#diff-a3a5c73931235f7f344c072dc755d6508e13923db3f5d581c5e88652075871cb
Please reload this pagehttps://github.com/python/cpython/pull/133574
https://github.com/maxbachmann
https://github.com/zooba
Update Python/sysmodule.chttps://github.com/python/cpython/pull/133574/commits/18c9e0241ce4dbfdcd42fdea129c0318f20c28bc
18c9e02https://github.com/python/cpython/pull/133574/commits/18c9e0241ce4dbfdcd42fdea129c0318f20c28bc
https://github.com/zooba
zoobahttps://github.com/zooba
5d118d0https://github.com/python/cpython/commit/5d118d0a922334e47db5159089d74dda21329b74
May 14, 2025https://github.com/python/cpython/pull/133574#event-17653464337
Please reload this pagehttps://github.com/python/cpython/pull/133574
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 14, 2025https://github.com/python/cpython/pull/133574#event-17653465455
Pranjal095https://github.com/Pranjal095
Jul 12, 2025 https://github.com/python/cpython/pull/133574#ref-commit-3eaaffd
https://github.com/maxbachmann
https://github.com/Pranjal095
pythongh-133580https://github.com/python/cpython/issues/133580
: Add missing exception to _sys_getwindowsversion_from…https://github.com/Pranjal095/cpython/commit/3eaaffd803b5d585ee77536e9fbadb774d37afab
3eaaffdhttps://github.com/Pranjal095/cpython/commit/3eaaffd803b5d585ee77536e9fbadb774d37afab
pythonGH-133574https://github.com/python/cpython/pull/133574
taegyunkimhttps://github.com/taegyunkim
Aug 4, 2025 https://github.com/python/cpython/pull/133574#ref-commit-cb077b3
https://github.com/maxbachmann
https://github.com/taegyunkim
pythongh-133580https://github.com/python/cpython/issues/133580
: Add missing exception to _sys_getwindowsversion_from…https://github.com/taegyunkim/cpython/commit/cb077b3f8fa9e7c64b891b278be8ba2d563513be
cb077b3https://github.com/taegyunkim/cpython/commit/cb077b3f8fa9e7c64b891b278be8ba2d563513be
pythonGH-133574https://github.com/python/cpython/pull/133574
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133574
https://github.com/sergey-miryanov
sergey-miryanov https://github.com/sergey-miryanov
https://github.com/python/cpython/pull/133574/files/5e5552bd3245d298b165ea9f813f75a07c53b8be
https://github.com/zooba
zooba https://github.com/zooba
https://github.com/python/cpython/pull/133574/files/5e5552bd3245d298b165ea9f813f75a07c53b8be
https://github.com/ZeroIntensity
ZeroIntensity https://github.com/ZeroIntensity
https://github.com/python/cpython/pull/133574/files/064806d9d777aa13be4e8a26dcbc1587173697ff
https://github.com/ericsnowcurrently
ericsnowcurrently https://github.com/ericsnowcurrently
OS-windows https://github.com/python/cpython/issues?q=state%3Aopen%20label%3AOS-windows
Please reload this pagehttps://github.com/python/cpython/pull/133574
https://github.com/maxbachmann
https://github.com/sergey-miryanov
https://github.com/zooba
https://github.com/ZeroIntensity
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.