René's URL Explorer Experiment


Title: gh-133562: disable security descriptor handling on unsupported WinAPI partitions by maxbachmann · Pull Request #133563 · python/cpython · GitHub

Open Graph Title: gh-133562: disable security descriptor handling on unsupported WinAPI partitions by maxbachmann · Pull Request #133563 · python/cpython

X Title: gh-133562: disable security descriptor handling on unsupported WinAPI partitions by maxbachmann · Pull Request #133563 · python/cpython

Description: @zooba you added the handling for mode 0o700. Is it fine to just ignore this mode, or would we need to error out in this case? Issue: ConvertStringSecurityDescriptorToSecurityDescriptor unsupport...

Open Graph Description: @zooba you added the handling for mode 0o700. Is it fine to just ignore this mode, or would we need to error out in this case? Issue: ConvertStringSecurityDescriptorToSecurityDescriptor unsupport...

X Description: @zooba you added the handling for mode 0o700. Is it fine to just ignore this mode, or would we need to error out in this case? Issue: ConvertStringSecurityDescriptorToSecurityDescriptor unsupport...

Opengraph URL: https://github.com/python/cpython/pull/133563

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:37abd230-bf7e-c9e3-bcc5-5c968eaaa2ec
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD2BC:1A8429:44DB03:5C140F:696B6B48
html-safe-nonce7bc3e3402df60901bcabdd10be5970513a3541be090c91919bbfd5e27d9ceed5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMkJDOjFBODQyOTo0NERCMDM6NUMxNDBGOjY5NkI2QjQ4IiwidmlzaXRvcl9pZCI6IjE0NjkwODE1NDM3NTE5ODU5OTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac93000bb35c6b8863b098b94ccce425f93479ba48bfedee50609a9b5891dabed2
hovercard-subject-tagpull_request:2503753756
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/133563/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5d2ea2d1253984f4bc3a62dabf11dad3d9c6bcc70cf68d0b1a175e026d1e1f44/python/cpython/pull/133563
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5d2ea2d1253984f4bc3a62dabf11dad3d9c6bcc70cf68d0b1a175e026d1e1f44/python/cpython/pull/133563
og:image:alt@zooba you added the handling for mode 0o700. Is it fine to just ignore this mode, or would we need to error out in this case? Issue: ConvertStringSecurityDescriptorToSecurityDescriptor unsupport...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemaxbachmann
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/133563#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133563
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133563
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/133563
Reloadhttps://github.com/python/cpython/pull/133563
Reloadhttps://github.com/python/cpython/pull/133563
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/133563
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/133563
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/133563#issue-comment-box
zoobahttps://github.com/zooba
python:mainhttps://github.com/python/cpython/tree/main
maxbachmann:patch-3https://github.com/maxbachmann/cpython/tree/patch-3
gh-133562: disable security descriptor handling on unsupported WinAPI partitions https://github.com/python/cpython/pull/133563#top
zoobahttps://github.com/zooba
python:mainhttps://github.com/python/cpython/tree/main
maxbachmann:patch-3https://github.com/maxbachmann/cpython/tree/patch-3
Conversation 16 https://github.com/python/cpython/pull/133563
Commits 9 https://github.com/python/cpython/pull/133563/commits
Checks 37 https://github.com/python/cpython/pull/133563/checks
Files changed 2 https://github.com/python/cpython/pull/133563/files
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/maxbachmann
maxbachmannhttps://github.com/maxbachmann
May 7, 2025https://github.com/python/cpython/pull/133563#issue-3045253312
Please reload this pagehttps://github.com/python/cpython/pull/133563
@zoobahttps://github.com/zooba
ConvertStringSecurityDescriptorToSecurityDescriptor unsupported on some WinAPI partitions #133562https://github.com/python/cpython/issues/133562
Please reload this pagehttps://github.com/python/cpython/pull/133563
https://github.com/maxbachmann
disable security descriptor handling on unsupported WinAPI partitionshttps://github.com/python/cpython/pull/133563/commits/078f6911c253d46b7b5b9904b4c81623e18339b4
078f691https://github.com/python/cpython/pull/133563/commits/078f6911c253d46b7b5b9904b4c81623e18339b4
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
May 7, 2025 https://github.com/python/cpython/pull/133563#ref-issue-3045245475
ConvertStringSecurityDescriptorToSecurityDescriptor unsupported on some WinAPI partitions #133562 https://github.com/python/cpython/issues/133562
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
May 7, 2025https://github.com/python/cpython/pull/133563#event-17552213799
blurb-ithttps://github.com/apps/blurb-it
May 7, 2025 09:02https://github.com/python/cpython/pull/133563#commits-pushed-243f377
https://github.com/apps/blurb-it
📜🤖 Added by blurb_it.https://github.com/python/cpython/pull/133563/commits/243f3771cb2920fe0582f156626f715d2330fa16
243f377https://github.com/python/cpython/pull/133563/commits/243f3771cb2920fe0582f156626f715d2330fa16
https://github.com/maxbachmann
fix linter errorhttps://github.com/python/cpython/pull/133563/commits/24aeedf0324952d30236449f3e6cc1d735f313fb
24aeedfhttps://github.com/python/cpython/pull/133563/commits/24aeedf0324952d30236449f3e6cc1d735f313fb
https://github.com/zooba
zoobahttps://github.com/zooba
May 7, 2025https://github.com/python/cpython/pull/133563#issuecomment-2857778747
Please reload this pagehttps://github.com/python/cpython/pull/133563
https://github.com/sergey-miryanov
sergey-miryanovhttps://github.com/sergey-miryanov
May 7, 2025 https://github.com/python/cpython/pull/133563#pullrequestreview-2821031934
View reviewed changes https://github.com/python/cpython/pull/133563/files/24aeedf0324952d30236449f3e6cc1d735f313fb
Modules/posixmodule.chttps://github.com/python/cpython/pull/133563/files/24aeedf0324952d30236449f3e6cc1d735f313fb#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
sergey-miryanovhttps://github.com/sergey-miryanov
May 7, 2025https://github.com/python/cpython/pull/133563#discussion_r2077195462
Please reload this pagehttps://github.com/python/cpython/pull/133563
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/133563
zoobahttps://github.com/zooba
May 7, 2025https://github.com/python/cpython/pull/133563#discussion_r2077204858
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/133563
sergey-miryanovhttps://github.com/sergey-miryanov
May 7, 2025https://github.com/python/cpython/pull/133563#discussion_r2077264906
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/133563
https://github.com/maxbachmann
maxbachmannhttps://github.com/maxbachmann
May 7, 2025https://github.com/python/cpython/pull/133563#issuecomment-2857840871
Please reload this pagehttps://github.com/python/cpython/pull/133563
https://github.com/zooba
zoobahttps://github.com/zooba
May 7, 2025https://github.com/python/cpython/pull/133563#issuecomment-2858006150
Please reload this pagehttps://github.com/python/cpython/pull/133563
Please reload this pagehttps://github.com/python/cpython/pull/133563
https://github.com/maxbachmann
fix guardhttps://github.com/python/cpython/pull/133563/commits/4c98d03943db71959f03b89ac91d339b46ebe945
4c98d03https://github.com/python/cpython/pull/133563/commits/4c98d03943db71959f03b89ac91d339b46ebe945
https://github.com/maxbachmann
maxbachmannhttps://github.com/maxbachmann
May 7, 2025https://github.com/python/cpython/pull/133563#issuecomment-2858089564
Please reload this pagehttps://github.com/python/cpython/pull/133563
https://github.com/maxbachmann
maxbachmannhttps://github.com/maxbachmann
May 7, 2025https://github.com/python/cpython/pull/133563#issuecomment-2858105650
Please reload this pagehttps://github.com/python/cpython/pull/133563
https://github.com/zooba
zoobahttps://github.com/zooba
May 7, 2025https://github.com/python/cpython/pull/133563#issuecomment-2860005871
Please reload this pagehttps://github.com/python/cpython/pull/133563
https://github.com/zooba
zoobahttps://github.com/zooba
May 7, 2025 https://github.com/python/cpython/pull/133563#pullrequestreview-2822982081
View reviewed changes https://github.com/python/cpython/pull/133563/files/4c98d03943db71959f03b89ac91d339b46ebe945
Misc/NEWS.d/next/Library/2025-05-07-09-02-19.gh-issue-133562.lqqNW1.rsthttps://github.com/python/cpython/pull/133563/files/4c98d03943db71959f03b89ac91d339b46ebe945#diff-13f268664fbb86b362ddf4a46edb7e44d8b144fc3199ca65886793403a6e8886
Please reload this pagehttps://github.com/python/cpython/pull/133563
Modules/posixmodule.chttps://github.com/python/cpython/pull/133563/files/4c98d03943db71959f03b89ac91d339b46ebe945#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
Please reload this pagehttps://github.com/python/cpython/pull/133563
maxbachmannhttps://github.com/maxbachmann
May 7, 2025 21:48https://github.com/python/cpython/pull/133563#commits-pushed-e2ee3d0
https://github.com/maxbachmann
https://github.com/zooba
Update Modules/posixmodule.chttps://github.com/python/cpython/pull/133563/commits/e2ee3d030f7f3e7470eefa7128af22bf1eed963b
e2ee3d0https://github.com/python/cpython/pull/133563/commits/e2ee3d030f7f3e7470eefa7128af22bf1eed963b
https://github.com/maxbachmann
https://github.com/zooba
Update Misc/NEWS.d/next/Library/2025-05-07-09-02-19.gh-issue-133562.l…https://github.com/python/cpython/pull/133563/commits/8c37fa1c96f11dc4051d632ed9b3e95e23e1ab15
8c37fa1https://github.com/python/cpython/pull/133563/commits/8c37fa1c96f11dc4051d632ed9b3e95e23e1ab15
https://github.com/maxbachmann
move news entryhttps://github.com/python/cpython/pull/133563/commits/2575d66950010c63231d752b1e0674233825c737
2575d66https://github.com/python/cpython/pull/133563/commits/2575d66950010c63231d752b1e0674233825c737
https://github.com/zooba
zoobahttps://github.com/zooba
May 8, 2025 11:54https://github.com/python/cpython/pull/133563#event-17572712765
https://github.com/maxbachmann
maxbachmannhttps://github.com/maxbachmann
May 9, 2025https://github.com/python/cpython/pull/133563#issuecomment-2865490556
Please reload this pagehttps://github.com/python/cpython/pull/133563
https://github.com/zooba
Merge branch 'main' into patch-3https://github.com/python/cpython/pull/133563/commits/2f3130593186e42a80e1c612ae132199383d38d4
2f31305https://github.com/python/cpython/pull/133563/commits/2f3130593186e42a80e1c612ae132199383d38d4
https://github.com/zooba
zoobahttps://github.com/zooba
May 9, 2025https://github.com/python/cpython/pull/133563#issuecomment-2865724119
Please reload this pagehttps://github.com/python/cpython/pull/133563
https://github.com/maxbachmann
maxbachmannhttps://github.com/maxbachmann
May 14, 2025https://github.com/python/cpython/pull/133563#issuecomment-2879479047
Please reload this pagehttps://github.com/python/cpython/pull/133563
@zoobahttps://github.com/zooba
gh-133580: add missing exception in _sys_getwindowsversion_from_kernel32 #133574https://github.com/python/cpython/pull/133574
gh-133572: Disable error reporting for invalid memory access on unsupported WinAPI partitions #133573https://github.com/python/cpython/pull/133573
gh-133568: only set HAVE_AF_HYPERV on supported WinAPI partitions #133569https://github.com/python/cpython/pull/133569
Please reload this pagehttps://github.com/python/cpython/pull/133563
https://github.com/zooba
zoobahttps://github.com/zooba
May 14, 2025https://github.com/python/cpython/pull/133563#issuecomment-2879778163
Please reload this pagehttps://github.com/python/cpython/pull/133563
https://github.com/zooba
Merge branch 'main' into patch-3https://github.com/python/cpython/pull/133563/commits/c71e24f30e6a2bac9777b916d41924946a9fd614
c71e24fhttps://github.com/python/cpython/pull/133563/commits/c71e24f30e6a2bac9777b916d41924946a9fd614
https://github.com/zooba
zoobahttps://github.com/zooba
e528aefhttps://github.com/python/cpython/commit/e528aef7e2952a11119cf95c9198ad183dc7af7f
May 14, 2025https://github.com/python/cpython/pull/133563#event-17651924658
Please reload this pagehttps://github.com/python/cpython/pull/133563
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
May 14, 2025https://github.com/python/cpython/pull/133563#event-17651925450
Pranjal095https://github.com/Pranjal095
Jul 12, 2025 https://github.com/python/cpython/pull/133563#ref-commit-4313016
https://github.com/maxbachmann
https://github.com/Pranjal095
pythongh-133562https://github.com/python/cpython/issues/133562
: Skip security descriptors on unsupported Windows API…https://github.com/Pranjal095/cpython/commit/43130162870ce39ef4e06198c1f02e99c9bd81f8
4313016https://github.com/Pranjal095/cpython/commit/43130162870ce39ef4e06198c1f02e99c9bd81f8
pythonGH-133563https://github.com/python/cpython/pull/133563
taegyunkimhttps://github.com/taegyunkim
Aug 4, 2025 https://github.com/python/cpython/pull/133563#ref-commit-b7b6b5e
https://github.com/maxbachmann
https://github.com/taegyunkim
pythongh-133562https://github.com/python/cpython/issues/133562
: Skip security descriptors on unsupported Windows API…https://github.com/taegyunkim/cpython/commit/b7b6b5e6219dbc8a4a7eec0688944b8bbb52e2c9
b7b6b5ehttps://github.com/taegyunkim/cpython/commit/b7b6b5e6219dbc8a4a7eec0688944b8bbb52e2c9
pythonGH-133563https://github.com/python/cpython/pull/133563
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133563
https://github.com/sergey-miryanov
sergey-miryanov https://github.com/sergey-miryanov
https://github.com/python/cpython/pull/133563/files/24aeedf0324952d30236449f3e6cc1d735f313fb
https://github.com/zooba
zooba https://github.com/zooba
https://github.com/python/cpython/pull/133563/files/4c98d03943db71959f03b89ac91d339b46ebe945
Please reload this pagehttps://github.com/python/cpython/pull/133563
https://github.com/maxbachmann
https://github.com/zooba
https://github.com/sergey-miryanov
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.