René's URL Explorer Experiment


Title: GH-132983: Remove zstd version check in the header file by AA-Turner · Pull Request #133502 · python/cpython · GitHub

Open Graph Title: GH-132983: Remove zstd version check in the header file by AA-Turner · Pull Request #133502 · python/cpython

X Title: GH-132983: Remove zstd version check in the header file by AA-Turner · Pull Request #133502 · python/cpython

Description: We now have better version detection in autoconf, including detecting the most recent symbol we used. A hard version check in the header file can lead to spurious failures when using zstd versions ...

Open Graph Description: We now have better version detection in autoconf, including detecting the most recent symbol we used. A hard version check in the header file can lead to spurious failures when using zstd versions ...

X Description: We now have better version detection in autoconf, including detecting the most recent symbol we used. A hard version check in the header file can lead to spurious failures when using zstd versions ...

Opengraph URL: https://github.com/python/cpython/pull/133502

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:dcd22287-31d5-7b92-e4c6-2810a52529c7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD8D0:11169F:1B0EE44:238FA77:696AF5C6
html-safe-nonce3ce9cf69d9f7a9f8606131135a0221ed374599e5c66b9311b818fa8ab0ae5d11
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOEQwOjExMTY5RjoxQjBFRTQ0OjIzOEZBNzc6Njk2QUY1QzYiLCJ2aXNpdG9yX2lkIjoiODI2Mzc5MTc2MzkwNjAzMzA5NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace307d00b02af3954884c9a658c56d26d42e39e3099d9acc282d39d72063da306
hovercard-subject-tagpull_request:2501003914
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/133502/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/88c755c3c07a9219d4b8963d0a9c75852243b50ac1bf83fa14f999704783fdaf/python/cpython/pull/133502
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/88c755c3c07a9219d4b8963d0a9c75852243b50ac1bf83fa14f999704783fdaf/python/cpython/pull/133502
og:image:altWe now have better version detection in autoconf, including detecting the most recent symbol we used. A hard version check in the header file can lead to spurious failures when using zstd versions ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAA-Turner
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/133502#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133502
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133502
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/133502
Reloadhttps://github.com/python/cpython/pull/133502
Reloadhttps://github.com/python/cpython/pull/133502
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/133502
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/133502
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/133502#issue-comment-box
hugovkhttps://github.com/hugovk
python:mainhttps://github.com/python/cpython/tree/main
AA-Turner:zstd-rm-version-checkhttps://github.com/AA-Turner/cpython/tree/zstd-rm-version-check
GH-132983: Remove zstd version check in the header file https://github.com/python/cpython/pull/133502#top
hugovkhttps://github.com/hugovk
python:mainhttps://github.com/python/cpython/tree/main
AA-Turner:zstd-rm-version-checkhttps://github.com/AA-Turner/cpython/tree/zstd-rm-version-check
Conversation 22 https://github.com/python/cpython/pull/133502
Commits 2 https://github.com/python/cpython/pull/133502/commits
Checks 40 https://github.com/python/cpython/pull/133502/checks
Files changed https://github.com/python/cpython/pull/133502/files
Please reload this pagehttps://github.com/python/cpython/pull/133502
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/AA-Turner
AA-Turnerhttps://github.com/AA-Turner
May 6, 2025https://github.com/python/cpython/pull/133502#issue-3042159002
Please reload this pagehttps://github.com/python/cpython/pull/133502
Revert "gh-133395: add option for extension modules to specialize BINARY_OP/SUBSCR, apply to arrays (#133396)" #133498https://github.com/python/cpython/pull/133498
gh-132983: Introduce _zstd bindings module #133027https://github.com/python/cpython/pull/133027
Implement PEP 784 - Adding Zstandard to the Python standard library #132983https://github.com/python/cpython/issues/132983
Please reload this pagehttps://github.com/python/cpython/pull/133502
https://github.com/AA-Turner
Remove zstd version check in the header filehttps://github.com/python/cpython/pull/133502/commits/baccfb9af8ff3224765438f08f7c563b09d4c1f3
baccfb9https://github.com/python/cpython/pull/133502/commits/baccfb9af8ff3224765438f08f7c563b09d4c1f3
https://github.com/AA-Turner
AA-Turnerhttps://github.com/AA-Turner
encukouhttps://github.com/encukou
hugovkhttps://github.com/hugovk
May 6, 2025 09:30https://github.com/python/cpython/pull/133502#event-17533809235
https://github.com/AA-Turner
AA-Turnerhttps://github.com/AA-Turner
hugovkhttps://github.com/hugovk
May 6, 2025https://github.com/python/cpython/pull/133502#event-17533809294
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
May 6, 2025 https://github.com/python/cpython/pull/133502#ref-issue-3021300364
Implement PEP 784 - Adding Zstandard to the Python standard library #132983 https://github.com/python/cpython/issues/132983
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 6, 2025https://github.com/python/cpython/pull/133502#event-17533811366
https://github.com/AA-Turner
AA-Turnerhttps://github.com/AA-Turner
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
May 6, 2025https://github.com/python/cpython/pull/133502#event-17533844525
https://github.com/bedevere-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133502
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
May 6, 2025https://github.com/python/cpython/pull/133502#event-17533846654
https://github.com/AA-Turner
AA-Turnerhttps://github.com/AA-Turner
🔨 test-with-refleak-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-refleak-buildbots%22
May 6, 2025https://github.com/python/cpython/pull/133502#event-17533849018
https://github.com/bedevere-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133502
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
🔨 test-with-refleak-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-refleak-buildbots%22
May 6, 2025https://github.com/python/cpython/pull/133502#event-17533849724
https://github.com/AA-Turner
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133502
https://github.com/encukou
encukouhttps://github.com/encukou
May 6, 2025https://github.com/python/cpython/pull/133502#issuecomment-2853935343
Please reload this pagehttps://github.com/python/cpython/pull/133502
https://github.com/AA-Turner
AA-Turnerhttps://github.com/AA-Turner
May 6, 2025https://github.com/python/cpython/pull/133502#issuecomment-2853938908
@encukouhttps://github.com/encukou
@vstinnerhttps://github.com/vstinner
v0.7 (2016) of libzstdhttps://github.com/facebook/zstd/blob/290aaa75212334b18b0ef36c679d4d4a0704acca/lib/dictBuilder/zdict_static.h#L50-L59
Please reload this pagehttps://github.com/python/cpython/pull/133502
https://github.com/AA-Turner
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133502
https://github.com/AA-Turner
AA-Turnerhttps://github.com/AA-Turner
May 6, 2025https://github.com/python/cpython/pull/133502#issuecomment-2853948466
Please reload this pagehttps://github.com/python/cpython/pull/133502
https://github.com/encukou
encukouhttps://github.com/encukou
May 6, 2025https://github.com/python/cpython/pull/133502#issuecomment-2853968875
Please reload this pagehttps://github.com/python/cpython/pull/133502
https://github.com/AA-Turner
Remove fallback symbol detectionhttps://github.com/python/cpython/pull/133502/commits/8b63a9e82a282e7c36f9392562afffc2cece0135
8b63a9ehttps://github.com/python/cpython/pull/133502/commits/8b63a9e82a282e7c36f9392562afffc2cece0135
https://github.com/AA-Turner
AA-Turnerhttps://github.com/AA-Turner
corona10https://github.com/corona10
erlend-aaslandhttps://github.com/erlend-aasland
code ownershttps://github.com/python/cpython/blob/fd37f1a8ad8e244ddccfc76608b02b6e29e30e16/.github/CODEOWNERS#L15
May 6, 2025 10:08https://github.com/python/cpython/pull/133502#event-17534409805
https://github.com/AA-Turner
AA-Turnerhttps://github.com/AA-Turner
🔨 test-with-refleak-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-refleak-buildbots%22
May 6, 2025https://github.com/python/cpython/pull/133502#event-17534414082
https://github.com/bedevere-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133502
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
🔨 test-with-refleak-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-refleak-buildbots%22
May 6, 2025https://github.com/python/cpython/pull/133502#event-17534414663
https://github.com/AA-Turner
AA-Turnerhttps://github.com/AA-Turner
May 6, 2025https://github.com/python/cpython/pull/133502#issuecomment-2854002459
v1.4.4 and earlierhttps://github.com/facebook/zstd/blob/v1.4.4/lib/dictBuilder/zdict.h#L72
facebook/zstd#2111https://github.com/facebook/zstd/pull/2111
Please reload this pagehttps://github.com/python/cpython/pull/133502
https://github.com/hugovk
hugovkhttps://github.com/hugovk
May 6, 2025 https://github.com/python/cpython/pull/133502#ref-pullrequest-3042040631
Revert "gh-133395: add option for extension modules to specialize BINARY_OP/SUBSCR, apply to arrays (#133396)" #133498 https://github.com/python/cpython/pull/133498
https://github.com/AA-Turner
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133502
https://github.com/bedevere-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133502
https://github.com/AA-Turner
AA-Turnerhttps://github.com/AA-Turner
May 6, 2025https://github.com/python/cpython/pull/133502#issuecomment-2854053846
Please reload this pagehttps://github.com/python/cpython/pull/133502
https://github.com/encukou
encukouhttps://github.com/encukou
May 6, 2025https://github.com/python/cpython/pull/133502#issuecomment-2854074316
Please reload this pagehttps://github.com/python/cpython/pull/133502
#133498https://github.com/python/cpython/pull/133498
Please reload this pagehttps://github.com/python/cpython/pull/133502
https://github.com/AA-Turner
AA-Turnerhttps://github.com/AA-Turner
May 6, 2025https://github.com/python/cpython/pull/133502#issuecomment-2854123037
Please reload this pagehttps://github.com/python/cpython/pull/133502
https://github.com/AA-Turner
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133502
https://github.com/bedevere-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133502
https://github.com/hugovk
hugovkhttps://github.com/hugovk
May 6, 2025https://github.com/python/cpython/pull/133502#issuecomment-2854125943
#133497 (comment)https://github.com/python/cpython/pull/133497#issuecomment-2853558829
Please reload this pagehttps://github.com/python/cpython/pull/133502
https://github.com/AA-Turner
AA-Turnerhttps://github.com/AA-Turner
May 6, 2025https://github.com/python/cpython/pull/133502#issuecomment-2854134242
Please reload this pagehttps://github.com/python/cpython/pull/133502
https://github.com/AA-Turner
AA-Turnerhttps://github.com/AA-Turner
May 6, 2025https://github.com/python/cpython/pull/133502#issuecomment-2854136168
buildbot/PPC64LE RHEL8 Refleaks PRhttps://buildbot.python.org/#/builders/353/builds/2085
Please reload this pagehttps://github.com/python/cpython/pull/133502
https://github.com/encukou
encukouhttps://github.com/encukou
May 6, 2025https://github.com/python/cpython/pull/133502#issuecomment-2854295084
unstablehttps://buildbot.python.org/#/builders/480
Please reload this pagehttps://github.com/python/cpython/pull/133502
https://github.com/hugovk
hugovkhttps://github.com/hugovk
May 6, 2025https://github.com/python/cpython/pull/133502#issuecomment-2854322383
Please reload this pagehttps://github.com/python/cpython/pull/133502
https://github.com/hugovk
hugovkhttps://github.com/hugovk
f869190https://github.com/python/cpython/commit/f8691901d734388a776fe3b66a92ee1dcd11c2f1
May 6, 2025https://github.com/python/cpython/pull/133502#event-17536146934
Please reload this pagehttps://github.com/python/cpython/pull/133502
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 6, 2025https://github.com/python/cpython/pull/133502#event-17536147781
https://github.com/emmatyping
emmatypinghttps://github.com/emmatyping
May 7, 2025 https://github.com/python/cpython/pull/133502#ref-pullrequest-3044536192
GH-132983: Support finding libzstd without pkg-config #133550 https://github.com/python/cpython/pull/133550
Pranjal095https://github.com/Pranjal095
Jul 12, 2025 https://github.com/python/cpython/pull/133502#ref-commit-9f74a73
https://github.com/AA-Turner
https://github.com/Pranjal095
pythonGH-132983https://github.com/python/cpython/issues/132983
: Remove zstd version check in the header file (https://github.com/Pranjal095/cpython/commit/9f74a735ac33689138b71154f48bc9090e1dee18
python…https://github.com/python/cpython/pull/133502
9f74a73https://github.com/Pranjal095/cpython/commit/9f74a735ac33689138b71154f48bc9090e1dee18
…#133502https://github.com/python/cpython/pull/133502
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133502
https://github.com/encukou
encukou https://github.com/encukou
https://github.com/hugovk
hugovk https://github.com/hugovk
https://github.com/erlend-aasland
erlend-aasland https://github.com/erlend-aasland
https://github.com/corona10
corona10 https://github.com/corona10
https://github.com/hugovk
hugovk https://github.com/hugovk
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/133502
https://github.com/AA-Turner
https://github.com/bedevere-bot
https://github.com/encukou
https://github.com/hugovk
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.