René's URL Explorer Experiment


Title: gh-82129: Improve annotations for make_dataclass() by JelleZijlstra · Pull Request #133406 · python/cpython · GitHub

Open Graph Title: gh-82129: Improve annotations for make_dataclass() by JelleZijlstra · Pull Request #133406 · python/cpython

X Title: gh-82129: Improve annotations for make_dataclass() by JelleZijlstra · Pull Request #133406 · python/cpython

Description: Closes #82129. Closes #122262. This is on top of @sobolevn's #122262 but jumps through a few more hoops to achieve these goals: The annotations on dataclasses with make_dataclass() are sensible in...

Open Graph Description: Closes #82129. Closes #122262. This is on top of @sobolevn's #122262 but jumps through a few more hoops to achieve these goals: The annotations on dataclasses with make_dataclass() are sensibl...

X Description: Closes #82129. Closes #122262. This is on top of @sobolevn's #122262 but jumps through a few more hoops to achieve these goals: The annotations on dataclasses with make_dataclass() are sen...

Opengraph URL: https://github.com/python/cpython/pull/133406

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ddf077e5-3e15-1c62-e4f5-745da94860d0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAE00:193CDB:21E6AC6:2C45C25:696B4992
html-safe-nonceab7e52066164191c3a79ff1f9e1c0ba5cb037d8f5c26713b08da93c94620e51b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTAwOjE5M0NEQjoyMUU2QUM2OjJDNDVDMjU6Njk2QjQ5OTIiLCJ2aXNpdG9yX2lkIjoiMzA5Mzk0MjEzMzY3Njc4ODExNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac14034f7a38d7b3abb8111ad2045c8d0472cedf49c611c5de4fc32c3534484a68
hovercard-subject-tagpull_request:2497529343
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/133406/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/41f7cb0d33272b6d5012559a511666814fb0662b1faf1e2a17cc13b4f00c6b91/python/cpython/pull/133406
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/41f7cb0d33272b6d5012559a511666814fb0662b1faf1e2a17cc13b4f00c6b91/python/cpython/pull/133406
og:image:altCloses #82129. Closes #122262. This is on top of @sobolevn's #122262 but jumps through a few more hoops to achieve these goals: The annotations on dataclasses with make_dataclass() are sensibl...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJelleZijlstra
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/133406#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133406
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133406
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/133406
Reloadhttps://github.com/python/cpython/pull/133406
Reloadhttps://github.com/python/cpython/pull/133406
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/133406
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/133406
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/133406#issue-comment-box
JelleZijlstrahttps://github.com/JelleZijlstra
python:mainhttps://github.com/python/cpython/tree/main
JelleZijlstra:gh18219-althttps://github.com/JelleZijlstra/cpython/tree/gh18219-alt
gh-82129: Improve annotations for make_dataclass() https://github.com/python/cpython/pull/133406#top
JelleZijlstrahttps://github.com/JelleZijlstra
python:mainhttps://github.com/python/cpython/tree/main
JelleZijlstra:gh18219-althttps://github.com/JelleZijlstra/cpython/tree/gh18219-alt
Conversation 3 https://github.com/python/cpython/pull/133406
Commits 14 https://github.com/python/cpython/pull/133406/commits
Checks 43 https://github.com/python/cpython/pull/133406/checks
Files changed https://github.com/python/cpython/pull/133406/files
Please reload this pagehttps://github.com/python/cpython/pull/133406
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
May 4, 2025https://github.com/python/cpython/pull/133406#issue-3038280061
Please reload this pagehttps://github.com/python/cpython/pull/133406
#82129https://github.com/python/cpython/issues/82129
#122262https://github.com/python/cpython/pull/122262
@sobolevnhttps://github.com/sobolevn
#122262https://github.com/python/cpython/pull/122262
get_type_hints fails if there are un-annotated fields in a dataclass #82129https://github.com/python/cpython/issues/82129
Please reload this pagehttps://github.com/python/cpython/pull/133406
sobolevnhttps://github.com/sobolevn
July 25, 2024 10:17https://github.com/python/cpython/pull/133406#commits-pushed-c2d85b7
https://github.com/sobolevn
pythongh-82128https://github.com/python/cpython/issues/82128
: Providehttps://github.com/python/cpython/pull/133406/commits/c2d85b7b03e472126e0561466c38adf231d0b99b
__annotate__https://github.com/python/cpython/pull/133406/commits/c2d85b7b03e472126e0561466c38adf231d0b99b
method for dataclasses from `m…https://github.com/python/cpython/pull/133406/commits/c2d85b7b03e472126e0561466c38adf231d0b99b
c2d85b7https://github.com/python/cpython/pull/133406/commits/c2d85b7b03e472126e0561466c38adf231d0b99b
https://github.com/sobolevn
Merge branch 'main' into issue-82129-2https://github.com/python/cpython/pull/133406/commits/de409ad3bca29d4e3435b978a2bb16e366d1a81c
de409adhttps://github.com/python/cpython/pull/133406/commits/de409ad3bca29d4e3435b978a2bb16e366d1a81c
https://github.com/sobolevn
Fix NameErrorhttps://github.com/python/cpython/pull/133406/commits/642f8498845592bf8e7197f1aedfd0c894bbe589
642f849https://github.com/python/cpython/pull/133406/commits/642f8498845592bf8e7197f1aedfd0c894bbe589
https://github.com/sobolevn
Merge branch 'main' into issue-82129-2https://github.com/python/cpython/pull/133406/commits/69251ac064f5582b9437e3dbaf60cac53a5e59a4
69251achttps://github.com/python/cpython/pull/133406/commits/69251ac064f5582b9437e3dbaf60cac53a5e59a4
https://github.com/sobolevn
Address reviewhttps://github.com/python/cpython/pull/133406/commits/5ec3a088e2429479438c272f259943eeaf9c2ec9
5ec3a08https://github.com/python/cpython/pull/133406/commits/5ec3a088e2429479438c272f259943eeaf9c2ec9
https://github.com/sobolevn
https://github.com/carljm
Update Misc/NEWS.d/next/Library/2024-09-18-09-15-40.gh-issue-82129.GQ…https://github.com/python/cpython/pull/133406/commits/43caa3fadf83428707b4abded312ceb238c52388
43caa3fhttps://github.com/python/cpython/pull/133406/commits/43caa3fadf83428707b4abded312ceb238c52388
https://github.com/sobolevn
Introduce _ANY_MARKERhttps://github.com/python/cpython/pull/133406/commits/33b279dfcfca200bf8e862b14fffe9997214e371
33b279dhttps://github.com/python/cpython/pull/133406/commits/33b279dfcfca200bf8e862b14fffe9997214e371
https://github.com/sobolevn
Merge branch 'main' into issue-82129-2https://github.com/python/cpython/pull/133406/commits/d5ddb16488d776ad3f6a830173cbb94eb375a934
d5ddb16https://github.com/python/cpython/pull/133406/commits/d5ddb16488d776ad3f6a830173cbb94eb375a934
https://github.com/sobolevn
WIPhttps://github.com/python/cpython/pull/133406/commits/3b26e36e55f85a73866fa0ae04cb190ea6be01de
3b26e36https://github.com/python/cpython/pull/133406/commits/3b26e36e55f85a73866fa0ae04cb190ea6be01de
https://github.com/JelleZijlstra
Merge branch 'main' into issue-82129-2https://github.com/python/cpython/pull/133406/commits/2c4d618a16513f39cf9334669417efb9318e271b
2c4d618https://github.com/python/cpython/pull/133406/commits/2c4d618a16513f39cf9334669417efb9318e271b
https://github.com/JelleZijlstra
althttps://github.com/python/cpython/pull/133406/commits/309da4c011a46d6d56220c3a3ff8d88177c43f66
309da4chttps://github.com/python/cpython/pull/133406/commits/309da4c011a46d6d56220c3a3ff8d88177c43f66
https://github.com/JelleZijlstra
betterhttps://github.com/python/cpython/pull/133406/commits/3d7eb6edb8438414dd6e683377ec57ad9edb7fe6
3d7eb6ehttps://github.com/python/cpython/pull/133406/commits/3d7eb6edb8438414dd6e683377ec57ad9edb7fe6
https://github.com/JelleZijlstra
commenthttps://github.com/python/cpython/pull/133406/commits/95650892fa17fe9edc7497d0e0c2ac001638c9ed
9565089https://github.com/python/cpython/pull/133406/commits/95650892fa17fe9edc7497d0e0c2ac001638c9ed
https://github.com/JelleZijlstra
Merge remote-tracking branch 'upstream/main' into gh18219-althttps://github.com/python/cpython/pull/133406/commits/c013e7b3808f119f68f17faac7ab7c1f8f684fb7
c013e7bhttps://github.com/python/cpython/pull/133406/commits/c013e7b3808f119f68f17faac7ab7c1f8f684fb7
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
May 4, 2025 https://github.com/python/cpython/pull/133406#ref-issue-1199018394
get_type_hints fails if there are un-annotated fields in a dataclass #82129 https://github.com/python/cpython/issues/82129
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
May 4, 2025 https://github.com/python/cpython/pull/133406#pullrequestreview-2813594956
View reviewed changes https://github.com/python/cpython/pull/133406/files/c013e7b3808f119f68f17faac7ab7c1f8f684fb7
Lib/annotationlib.pyhttps://github.com/python/cpython/pull/133406/files/c013e7b3808f119f68f17faac7ab7c1f8f684fb7#diff-55449988e121f54fcc768a9fef3619f9209ae218260193de8f44bef68e13c583
JelleZijlstrahttps://github.com/JelleZijlstra
May 4, 2025https://github.com/python/cpython/pull/133406#discussion_r2072731370
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#133407https://github.com/python/cpython/pull/133407
Please reload this pagehttps://github.com/python/cpython/pull/133406
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
May 4, 2025 https://github.com/python/cpython/pull/133406#pullrequestreview-2813595342
View reviewed changes https://github.com/python/cpython/pull/133406/files/c013e7b3808f119f68f17faac7ab7c1f8f684fb7
sobolevnhttps://github.com/sobolevn
https://github.com/python/cpython/pull/133406#pullrequestreview-2813595342
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/133406
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
May 4, 2025 22:59https://github.com/python/cpython/pull/133406#event-17511775659
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
ericvsmithhttps://github.com/ericvsmith
code ownerhttps://github.com/python/cpython/blob/af5799f3056b0eee61fc09587633500a3690e67e/.github/CODEOWNERS#L242
May 4, 2025 22:59https://github.com/python/cpython/pull/133406#event-17511775667
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 4, 2025https://github.com/python/cpython/pull/133406#event-17511775766
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
sobolevnhttps://github.com/sobolevn
May 4, 2025 23:26https://github.com/python/cpython/pull/133406#event-17511841029
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
May 5, 2025 https://github.com/python/cpython/pull/133406#pullrequestreview-2814006785
View reviewed changes https://github.com/python/cpython/pull/133406/files/c013e7b3808f119f68f17faac7ab7c1f8f684fb7
sobolevnhttps://github.com/sobolevn
https://github.com/python/cpython/pull/133406#pullrequestreview-2814006785
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/133406
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 5, 2025https://github.com/python/cpython/pull/133406#event-17514678411
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
bb5ec6ehttps://github.com/python/cpython/commit/bb5ec6ea6e2fd270882dd9244c7d050882470095
May 5, 2025https://github.com/python/cpython/pull/133406#event-17521597805
Please reload this pagehttps://github.com/python/cpython/pull/133406
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
May 5, 2025https://github.com/python/cpython/pull/133406#event-17521598539
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
May 5, 2025 15:21https://github.com/python/cpython/pull/133406#event-17521599169
Pranjal095https://github.com/Pranjal095
Jul 12, 2025 https://github.com/python/cpython/pull/133406#ref-commit-2e9b8e9
https://github.com/JelleZijlstra
https://github.com/sobolevn
https://github.com/carljm
https://github.com/Pranjal095
pythongh-82129https://github.com/python/cpython/issues/82129
: Improve annotations for make_dataclass() (https://github.com/Pranjal095/cpython/commit/2e9b8e985d80dd87c73ac5cf092b769a1e0fe6d3
python#133406https://github.com/python/cpython/pull/133406
)https://github.com/Pranjal095/cpython/commit/2e9b8e985d80dd87c73ac5cf092b769a1e0fe6d3
2e9b8e9https://github.com/Pranjal095/cpython/commit/2e9b8e985d80dd87c73ac5cf092b769a1e0fe6d3
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133406
https://github.com/sobolevn
sobolevn https://github.com/sobolevn
https://github.com/python/cpython/pull/133406/files/c013e7b3808f119f68f17faac7ab7c1f8f684fb7
https://github.com/ericvsmith
ericvsmith https://github.com/ericvsmith
get_type_hints fails if there are un-annotated fields in a dataclass https://github.com/python/cpython/issues/82129
Please reload this pagehttps://github.com/python/cpython/pull/133406
https://github.com/JelleZijlstra
https://github.com/sobolevn
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.