René's URL Explorer Experiment


Title: gh-124715: Fix method_dealloc(): use PyObject_GC_UnTrack() by vstinner · Pull Request #133199 · python/cpython · GitHub

Open Graph Title: gh-124715: Fix method_dealloc(): use PyObject_GC_UnTrack() by vstinner · Pull Request #133199 · python/cpython

X Title: gh-124715: Fix method_dealloc(): use PyObject_GC_UnTrack() by vstinner · Pull Request #133199 · python/cpython

Description: Replace _PyObject_GC_UNTRACK() with PyObject_GC_UnTrack() to not fail if the method was already untracked. Issue: Not all types have "trashcan" protection and tp_dealloc can overflow stack #124715

Open Graph Description: Replace _PyObject_GC_UNTRACK() with PyObject_GC_UnTrack() to not fail if the method was already untracked. Issue: Not all types have "trashcan" protection and tp_dealloc can overflow s...

X Description: Replace _PyObject_GC_UNTRACK() with PyObject_GC_UnTrack() to not fail if the method was already untracked. Issue: Not all types have "trashcan" protection and tp_dealloc can ov...

Opengraph URL: https://github.com/python/cpython/pull/133199

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f2a07605-0ef5-e26f-8d88-82905953bb4a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC10E:8D103:4C9E4:679BA:696A9DAB
html-safe-nonce4572087c6ccd71458666638d2998ed9bf2b9ba6fd331950c729c354ab2239b77
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTBFOjhEMTAzOjRDOUU0OjY3OUJBOjY5NkE5REFCIiwidmlzaXRvcl9pZCI6IjM0MTA3NTY1MDUwMjU4MTM5MzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca65d46410b071fd908972119f32c1c24c3c7d26de00a54aa37436d71c3851c80
hovercard-subject-tagpull_request:2491179047
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/133199/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2d28b6904efff0b9653f105060683bbb7490e514c4719bb8f01f8baa548d919e/python/cpython/pull/133199
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2d28b6904efff0b9653f105060683bbb7490e514c4719bb8f01f8baa548d919e/python/cpython/pull/133199
og:image:altReplace _PyObject_GC_UNTRACK() with PyObject_GC_UnTrack() to not fail if the method was already untracked. Issue: Not all types have "trashcan" protection and tp_dealloc can overflow s...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevstinner
hostnamegithub.com
expected-hostnamegithub.com
Nonec0d8175e41e0e55b9e984c935b24b808cabab919dd3174aa45dac3ef503ed1af
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release99aab454e5ddc8df30805fb76c114c3008a15842
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/133199#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133199
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133199
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/133199
Reloadhttps://github.com/python/cpython/pull/133199
Reloadhttps://github.com/python/cpython/pull/133199
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/133199
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/133199
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/133199#issue-comment-box
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
vstinner:method_deallochttps://github.com/vstinner/cpython/tree/method_dealloc
gh-124715: Fix method_dealloc(): use PyObject_GC_UnTrack() https://github.com/python/cpython/pull/133199#top
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
vstinner:method_deallochttps://github.com/vstinner/cpython/tree/method_dealloc
Conversation 10 https://github.com/python/cpython/pull/133199
Commits 1 https://github.com/python/cpython/pull/133199/commits
Checks 41 https://github.com/python/cpython/pull/133199/checks
Files changed https://github.com/python/cpython/pull/133199/files
Please reload this pagehttps://github.com/python/cpython/pull/133199
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 30, 2025https://github.com/python/cpython/pull/133199#issue-3030935579
Please reload this pagehttps://github.com/python/cpython/pull/133199
Not all types have "trashcan" protection and tp_dealloc can overflow stack #124715https://github.com/python/cpython/issues/124715
Please reload this pagehttps://github.com/python/cpython/pull/133199
https://github.com/vstinner
pythongh-132280https://github.com/python/cpython/pull/132280
: Fix method_dealloc(): use PyObject_GC_UnTrack()https://github.com/python/cpython/pull/133199/commits/d09167e9a973de07f4f9ac246d5632b3a3e39452
d09167ehttps://github.com/python/cpython/pull/133199/commits/d09167e9a973de07f4f9ac246d5632b3a3e39452
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Apr 30, 2025https://github.com/python/cpython/pull/133199#event-17470960215
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Apr 30, 2025https://github.com/python/cpython/pull/133199#event-17470961164
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 30, 2025https://github.com/python/cpython/pull/133199#event-17470968270
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Apr 30, 2025 https://github.com/python/cpython/pull/133199#ref-issue-2553825335
Not all types have "trashcan" protection and tp_dealloc can overflow stack #124715 https://github.com/python/cpython/issues/124715
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 30, 2025 https://github.com/python/cpython/pull/133199#ref-pullrequest-2980351135
GH-124715: Move trashcan mechanism into Py_Dealloc #132280 https://github.com/python/cpython/pull/132280
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 30, 2025https://github.com/python/cpython/pull/133199#issuecomment-2841617372
Please reload this pagehttps://github.com/python/cpython/pull/133199
#132280 (comment)https://github.com/python/cpython/pull/132280#issuecomment-2841582722
@iritkatrielhttps://github.com/iritkatriel
@markshannonhttps://github.com/markshannon
@naschemehttps://github.com/nascheme
Please reload this pagehttps://github.com/python/cpython/pull/133199
https://github.com/markshannon
markshannonhttps://github.com/markshannon
Apr 30, 2025https://github.com/python/cpython/pull/133199#issuecomment-2841677822
Please reload this pagehttps://github.com/python/cpython/pull/133199
Please reload this pagehttps://github.com/python/cpython/pull/133199
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 30, 2025https://github.com/python/cpython/pull/133199#issuecomment-2841687142
Please reload this pagehttps://github.com/python/cpython/pull/133199
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 30, 2025https://github.com/python/cpython/pull/133199#issuecomment-2841799082
Please reload this pagehttps://github.com/python/cpython/pull/133199
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
May 1, 2025https://github.com/python/cpython/pull/133199#issuecomment-2844670043
Please reload this pagehttps://github.com/python/cpython/pull/133199
https://buildbot.python.org/#/builders/336/builds/6843https://buildbot.python.org/#/builders/336/builds/6843
https://buildbot.python.org/#/builders/234/builds/7548https://buildbot.python.org/#/builders/234/builds/7548
https://buildbot.python.org/#/builders/14/builds/7693https://buildbot.python.org/#/builders/14/builds/7693
https://buildbot.python.org/#/builders/78/builds/9032https://buildbot.python.org/#/builders/78/builds/9032
https://buildbot.python.org/#/builders/441/builds/7851https://buildbot.python.org/#/builders/441/builds/7851
https://buildbot.python.org/#/builders/1654/builds/316https://buildbot.python.org/#/builders/1654/builds/316
Please reload this pagehttps://github.com/python/cpython/pull/133199
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
May 1, 2025https://github.com/python/cpython/pull/133199#issuecomment-2844690960
https://buildbot.python.org/#/builders/441/builds/7851https://buildbot.python.org/#/builders/441/builds/7851
Please reload this pagehttps://github.com/python/cpython/pull/133199
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
662dd29https://github.com/python/cpython/commit/662dd294563ce86980c640ad67e3d460a72c9cb9
May 1, 2025https://github.com/python/cpython/pull/133199#event-17486601474
Please reload this pagehttps://github.com/python/cpython/pull/133199
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
May 1, 2025 11:42https://github.com/python/cpython/pull/133199#event-17486601643
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 1, 2025https://github.com/python/cpython/pull/133199#event-17486601743
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
May 1, 2025https://github.com/python/cpython/pull/133199#issuecomment-2844693575
Please reload this pagehttps://github.com/python/cpython/pull/133199
https://github.com/markshannon
markshannonhttps://github.com/markshannon
May 1, 2025https://github.com/python/cpython/pull/133199#issuecomment-2845140906
Please reload this pagehttps://github.com/python/cpython/pull/133199
Please reload this pagehttps://github.com/python/cpython/pull/133199
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
May 1, 2025https://github.com/python/cpython/pull/133199#issuecomment-2845168333
#133261https://github.com/python/cpython/issues/133261
Please reload this pagehttps://github.com/python/cpython/pull/133199
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
May 1, 2025https://github.com/python/cpython/pull/133199#issuecomment-2845173242
#124715https://github.com/python/cpython/issues/124715
Please reload this pagehttps://github.com/python/cpython/pull/133199
test_frame does crash randomly on Linux (x86-64, ppc64le, s390x) #133261 https://github.com/python/cpython/issues/133261
GH-133261: Make sure that the GC doesn't untrack objects in trashcan #133431 https://github.com/python/cpython/pull/133431
vstinnerhttps://github.com/vstinner
May 5, 2025 https://github.com/python/cpython/pull/133199#ref-commit-7ce29b0
https://github.com/vstinner
Revert "https://github.com/vstinner/cpython/commit/7ce29b08c11cfd0d575a88ced9fcf5555481e13f
pythongh-124715https://github.com/python/cpython/issues/124715
: Fix method_dealloc(): use PyObject_GC_UnTrac…https://github.com/vstinner/cpython/commit/7ce29b08c11cfd0d575a88ced9fcf5555481e13f
7ce29b0https://github.com/vstinner/cpython/commit/7ce29b08c11cfd0d575a88ced9fcf5555481e13f
python#133199https://github.com/python/cpython/pull/133199
662dd29https://github.com/vstinner/cpython/commit/662dd294563ce86980c640ad67e3d460a72c9cb9
f554237https://github.com/vstinner/cpython/commit/f554237b8ef6c60df651ac17eb0ef0c095cef185
vstinnerhttps://github.com/vstinner
May 5, 2025 https://github.com/python/cpython/pull/133199#ref-commit-c336f1c
https://github.com/vstinner
Revert "https://github.com/python/cpython/commit/c336f1c3126203fd6c38050df94e9fe8c0d7f2e2
gh-124715https://github.com/python/cpython/issues/124715
: Fix method_dealloc(): use PyObject_GC_UnTrack() (https://github.com/python/cpython/commit/c336f1c3126203fd6c38050df94e9fe8c0d7f2e2
#…https://github.com/python/cpython/pull/133199
c336f1chttps://github.com/python/cpython/commit/c336f1c3126203fd6c38050df94e9fe8c0d7f2e2
…133199https://github.com/python/cpython/pull/133199
#133434https://github.com/python/cpython/pull/133434
662dd29https://github.com/python/cpython/commit/662dd294563ce86980c640ad67e3d460a72c9cb9
f554237https://github.com/python/cpython/commit/f554237b8ef6c60df651ac17eb0ef0c095cef185
Pranjal095https://github.com/Pranjal095
Jul 12, 2025 https://github.com/python/cpython/pull/133199#ref-commit-ad5f435
https://github.com/vstinner
https://github.com/Pranjal095
Revert "https://github.com/Pranjal095/cpython/commit/ad5f43591531fd4d0a19a2228fa90480c7f047a4
pythongh-124715https://github.com/python/cpython/issues/124715
: Fix method_dealloc(): use PyObject_GC_UnTrac…https://github.com/Pranjal095/cpython/commit/ad5f43591531fd4d0a19a2228fa90480c7f047a4
ad5f435https://github.com/Pranjal095/cpython/commit/ad5f43591531fd4d0a19a2228fa90480c7f047a4
python#133199https://github.com/python/cpython/pull/133199
python#133434https://github.com/python/cpython/pull/133434
662dd29https://github.com/Pranjal095/cpython/commit/662dd294563ce86980c640ad67e3d460a72c9cb9
f554237https://github.com/Pranjal095/cpython/commit/f554237b8ef6c60df651ac17eb0ef0c095cef185
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133199
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/133199
https://github.com/vstinner
https://github.com/markshannon
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.