René's URL Explorer Experiment


Title: gh-87135: test_threading: Wait on thread, not an Event it sets by encukou · Pull Request #133198 · python/cpython · GitHub

Open Graph Title: gh-87135: test_threading: Wait on thread, not an Event it sets by encukou · Pull Request #133198 · python/cpython

X Title: gh-87135: test_threading: Wait on thread, not an Event it sets by encukou · Pull Request #133198 · python/cpython

Description: Sorry for this mistake! When the event is set the thread might not be done yet. This should fix newly-flaky refleak buildbots. This is a fix-up for commit 4ebbfcf Issue: pthread_exit & PyThread_...

Open Graph Description: Sorry for this mistake! When the event is set the thread might not be done yet. This should fix newly-flaky refleak buildbots. This is a fix-up for commit 4ebbfcf Issue: pthread_exit & PyThr...

X Description: Sorry for this mistake! When the event is set the thread might not be done yet. This should fix newly-flaky refleak buildbots. This is a fix-up for commit 4ebbfcf Issue: pthread_exit & P...

Opengraph URL: https://github.com/python/cpython/pull/133198

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0f21f358-bc64-89f9-98ce-af72d36b9467
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA8B6:10503:32D0864:4275944:696B89DA
html-safe-nonce250869fce5b970ba298f1f8a95067f92599f0bf020c9caafc5fafe054be7ef2c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOEI2OjEwNTAzOjMyRDA4NjQ6NDI3NTk0NDo2OTZCODlEQSIsInZpc2l0b3JfaWQiOiIyNTM0MDAzMzYwMzUxODgxNjkwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace0e69b0631bb3152f71cb11dc4c4cd174f07d0a6aba37cd05cb6e4b0f9412d83
hovercard-subject-tagpull_request:2491162768
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/133198/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/04b37f7a98e1e9744cab02ea10420ff242f91cd13f2059554e86a9b5cfa51d03/python/cpython/pull/133198
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/04b37f7a98e1e9744cab02ea10420ff242f91cd13f2059554e86a9b5cfa51d03/python/cpython/pull/133198
og:image:altSorry for this mistake! When the event is set the thread might not be done yet. This should fix newly-flaky refleak buildbots. This is a fix-up for commit 4ebbfcf Issue: pthread_exit & PyThr...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameencukou
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/133198#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133198
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133198
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/133198
Reloadhttps://github.com/python/cpython/pull/133198
Reloadhttps://github.com/python/cpython/pull/133198
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/133198
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/133198
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/133198#issue-comment-box
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
encukou:test_join_finished_daemon_thread_in_finalizationhttps://github.com/encukou/cpython/tree/test_join_finished_daemon_thread_in_finalization
gh-87135: test_threading: Wait on thread, not an Event it sets https://github.com/python/cpython/pull/133198#top
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
encukou:test_join_finished_daemon_thread_in_finalizationhttps://github.com/encukou/cpython/tree/test_join_finished_daemon_thread_in_finalization
Conversation 1 https://github.com/python/cpython/pull/133198
Commits 1 https://github.com/python/cpython/pull/133198/commits
Checks 46 https://github.com/python/cpython/pull/133198/checks
Files changed https://github.com/python/cpython/pull/133198/files
Please reload this pagehttps://github.com/python/cpython/pull/133198
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/encukou
encukouhttps://github.com/encukou
Apr 30, 2025https://github.com/python/cpython/pull/133198#issue-3030917524
Please reload this pagehttps://github.com/python/cpython/pull/133198
4ebbfcfhttps://github.com/python/cpython/commit/4ebbfcf30e0e2d87ff6036d4d1de0f6f0ef7c46a
pthread_exit & PyThread_exit_thread from PyEval_RestoreThread etc. are harmful #87135https://github.com/python/cpython/issues/87135
Please reload this pagehttps://github.com/python/cpython/pull/133198
https://github.com/encukou
pythongh-87135https://github.com/python/cpython/issues/87135
: test_threading: Wait on thread, not an Event it setshttps://github.com/python/cpython/pull/133198/commits/0fd1663385425c925a87eef4a5d1d438f1fc765d
0fd1663https://github.com/python/cpython/pull/133198/commits/0fd1663385425c925a87eef4a5d1d438f1fc765d
4ebbfcfhttps://github.com/encukou/cpython/commit/4ebbfcf30e0e2d87ff6036d4d1de0f6f0ef7c46a
https://github.com/encukou
encukouhttps://github.com/encukou
vstinnerhttps://github.com/vstinner
April 30, 2025 10:54https://github.com/python/cpython/pull/133198#event-17470855742
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
Apr 30, 2025https://github.com/python/cpython/pull/133198#event-17470856502
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Apr 30, 2025 https://github.com/python/cpython/pull/133198#ref-issue-1199051244
pthread_exit & PyThread_exit_thread from PyEval_RestoreThread etc. are harmful #87135 https://github.com/python/cpython/issues/87135
https://github.com/encukou
encukouhttps://github.com/encukou
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Apr 30, 2025https://github.com/python/cpython/pull/133198#event-17470858706
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 30, 2025 https://github.com/python/cpython/pull/133198#pullrequestreview-2806729891
View reviewed changes https://github.com/python/cpython/pull/133198/files/0fd1663385425c925a87eef4a5d1d438f1fc765d
vstinnerhttps://github.com/vstinner
https://github.com/python/cpython/pull/133198#pullrequestreview-2806729891
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/133198
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Apr 30, 2025https://github.com/python/cpython/pull/133198#event-17471217901
https://github.com/encukou
encukouhttps://github.com/encukou
8b26b23https://github.com/python/cpython/commit/8b26b23a9674a02563f28e4cfbef3d3e39876bfe
Apr 30, 2025https://github.com/python/cpython/pull/133198#event-17472811858
Please reload this pagehttps://github.com/python/cpython/pull/133198
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Apr 30, 2025https://github.com/python/cpython/pull/133198#event-17472812694
https://github.com/encukou
encukouhttps://github.com/encukou
April 30, 2025 13:14https://github.com/python/cpython/pull/133198#event-17472813436
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133198
https://github.com/vstinner
vstinner https://github.com/vstinner
https://github.com/python/cpython/pull/133198/files/0fd1663385425c925a87eef4a5d1d438f1fc765d
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
Please reload this pagehttps://github.com/python/cpython/pull/133198
https://github.com/encukou
https://github.com/vstinner
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.