| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:82451492-426d-63a7-11e7-3cbc67223e9b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9F6E:28BD80:5121AC:6C5CBF:6A5595FA |
| html-safe-nonce | 07e4acb30714c9873103a321c20e6355fa908932c1253df10499d18658911efe |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RjZFOjI4QkQ4MDo1MTIxQUM6NkM1Q0JGOjZBNTU5NUZBIiwidmlzaXRvcl9pZCI6IjI4MzYzMzczMjEzNjgzNDU1NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | bec9ba454a2e6531fce9c3d8720efa85329c117487093996d5cb998c4c9620f1 |
| hovercard-subject-tag | pull_request:2490131491 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/133177/files |
| twitter:image | https://avatars.githubusercontent.com/u/690853?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/690853?s=400&v=4 |
| og:image:alt | This is an updated version of GH-131174, which was reverted. I figured the cleanest thing to do is make a new PR.
This is the same as the previous PR with the following additional change. The upda... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b5665c84831ed9ac4fb79519c16c9c5580ba8092fb8bb6e3e72972ec7197348e |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | aa21baa44893467b0b640d0300538f84ca8c475b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/133177/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133177%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133177%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/133177/files |
| Reload | https://github.com/python/cpython/pull/133177/files |
| Reload | https://github.com/python/cpython/pull/133177/files |
| Please reload this page | https://github.com/python/cpython/pull/133177/files |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/133177/files |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
35k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
73.8k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.3k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
0
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| nascheme | https://github.com/nascheme |
| python:main | https://github.com/python/cpython/tree/main |
| nascheme:type-slot-ts-v2 | https://github.com/nascheme/cpython/tree/type-slot-ts-v2 |
|
Conversation
18
| https://github.com/python/cpython/pull/133177 |
|
Commits
24
| https://github.com/python/cpython/pull/133177/commits |
|
Checks
0
| https://github.com/python/cpython/pull/133177/checks |
|
Files changed
| https://github.com/python/cpython/pull/133177/files |
| Please reload this page | https://github.com/python/cpython/pull/133177/files |
|
gh-127266: avoid data races when updating type slots v2
| https://github.com/python/cpython/pull/133177/files#top |
|
Show all changes
24 commits
| https://github.com/python/cpython/pull/133177/files |
|
3094372
gh-127266: avoid data races when updating type slots
nascheme Apr 29, 2025
| https://github.com/python/cpython/pull/133177/commits/3094372e5fc8725c7de13479e4df7a0e6479fc44 |
|
f447ce4
For update_all_slots(), do updates more safely.
nascheme Apr 29, 2025
| https://github.com/python/cpython/pull/133177/commits/f447ce4adf750b9da15011e30eaf8aee3fd7b478 |
|
d511ca6
Avoid "empty structure" compile error.
nascheme Apr 29, 2025
| https://github.com/python/cpython/pull/133177/commits/d511ca6015e8a95c4f0f8c76330a8b57e3e1060c |
|
5e38497
Use apply_slot_updates() for type_setattro().
nascheme Apr 30, 2025
| https://github.com/python/cpython/pull/133177/commits/5e38497b323fdb828d61a0a965841f07086edbcc |
|
e9516c7
Merge 'origin/main' into type-slot-ts-v2
nascheme Apr 30, 2025
| https://github.com/python/cpython/pull/133177/commits/e9516c7a7685f2bd73d005af9a69ab6c52a7a5a2 |
|
8c74a0c
Reduce number of items in test for slot updates.
nascheme Apr 30, 2025
| https://github.com/python/cpython/pull/133177/commits/8c74a0c2e29ca8d4afadca8346eed685811943ca |
|
6cd7644
Add TSAN suppression for _Py_slot_tp_getattr_hook.
nascheme Apr 30, 2025
| https://github.com/python/cpython/pull/133177/commits/6cd7644c99c2980c9f054d6bd77b2d8e39cb0dee |
|
3cb2256
Queue update of tp_flags as well.
nascheme Apr 30, 2025
| https://github.com/python/cpython/pull/133177/commits/3cb225610df2ff9c89b6ec7a27bfc630a1420939 |
|
47e41c9
Performance, skip stop-the-world when possible.
nascheme Apr 30, 2025
| https://github.com/python/cpython/pull/133177/commits/47e41c9896587cbfc5a9c6ad5d37a5b95cf16051 |
|
cb848f1
Merge 'origin/main' into type-slot-ts-v2
nascheme Apr 30, 2025
| https://github.com/python/cpython/pull/133177/commits/cb848f117b0145b386d8f1b4fbc8710248456203 |
|
9859ebf
Always clear version after __bases__ update.
nascheme May 1, 2025
| https://github.com/python/cpython/pull/133177/commits/9859ebf50986977b116d58f98ae81b054f04844c |
|
6c74cac
Merge 'origin/main' into type-slot-ts-v2
nascheme May 1, 2025
| https://github.com/python/cpython/pull/133177/commits/6c74cacf2162924f82552c414f1300d0d12c7be0 |
|
583c435
Add test for assigning __bases__.
nascheme May 1, 2025
| https://github.com/python/cpython/pull/133177/commits/583c435df6179ba6675fa3274bab6bfcfbcf9862 |
|
c01707e
Avoid releasing TYPE_LOCK when stopping the world.
nascheme May 1, 2025
| https://github.com/python/cpython/pull/133177/commits/c01707e839116fb0a87d82ac6d66d1c288888d47 |
|
1b9cad5
Merge 'origin/main' into type-slot-ts-v2
nascheme May 5, 2025
| https://github.com/python/cpython/pull/133177/commits/1b9cad59500bd967c26d8145b911c91e954860d7 |
|
a1c6b05
Add issue number for TSAN suppression.
nascheme May 5, 2025
| https://github.com/python/cpython/pull/133177/commits/a1c6b054e8a73fa658a37fa6431621b058575d9f |
|
3f6222b
Bug fix for type_lock_prevent_release().
nascheme May 5, 2025
| https://github.com/python/cpython/pull/133177/commits/3f6222b70eb3751ff309f9a56d5cbae92b1ac6b9 |
|
6f218fb
Merge 'origin/main' into type-slot-ts-v2
nascheme May 8, 2025
| https://github.com/python/cpython/pull/133177/commits/6f218fb5ced903a936a5f447f89ced776a496331 |
|
2bcf7ba
Add additional assert.
nascheme May 27, 2025
| https://github.com/python/cpython/pull/133177/commits/2bcf7ba6329f54d4162e5444c5f313c9d3cf304e |
|
ddfdbd5
Merge 'origin/main' into type-slot-ts-v2
nascheme May 27, 2025
| https://github.com/python/cpython/pull/133177/commits/ddfdbd5467dedb89268e752cf099369a25fe54c6 |
|
63b7ae4
Revert test_opcache item size change.
nascheme May 27, 2025
| https://github.com/python/cpython/pull/133177/commits/63b7ae41c3b088f9de780c0a1fcd4b8445994374 |
|
1a2fee1
Add comment for new unit test.
nascheme May 27, 2025
| https://github.com/python/cpython/pull/133177/commits/1a2fee1048b292f9b30d491f2cb3d313b9976b7c |
|
c1f3ed5
Fix assert for default build.
nascheme May 27, 2025
| https://github.com/python/cpython/pull/133177/commits/c1f3ed56a21d93d2c66dddfd2268628ab91be715 |
|
41e54e1
Improve function name.
nascheme May 27, 2025
| https://github.com/python/cpython/pull/133177/commits/41e54e11fe92821ff1985ea1564f98c1f5a1b752 |
|
Clear filters
| https://github.com/python/cpython/pull/133177/files |
| Please reload this page | https://github.com/python/cpython/pull/133177/files |
| Please reload this page | https://github.com/python/cpython/pull/133177/files |
|
pycore_interp_structs.h
| https://github.com/python/cpython/pull/133177/files#diff-6075b6142803c1eccc213aa150704fd639443c65311d5999f69a5ea77cb76756 |
|
pycore_object.h
| https://github.com/python/cpython/pull/133177/files#diff-2a12f738a77b362d74a65949b58c37f2affcd15ba8b1c979b63bd00223b8a456 |
|
pycore_typeobject.h
| https://github.com/python/cpython/pull/133177/files#diff-9df981eafa9c743230f2e1513191ba147f0fba63d0c51fb7968c1e7093d9e877 |
|
object.h
| https://github.com/python/cpython/pull/133177/files#diff-87272721a5cf1cd9915d6f503f6a7bbefa2f26c935c7ce83ca78706afd0ad05a |
|
refcount.h
| https://github.com/python/cpython/pull/133177/files#diff-586c6481df97b64cf94363854b92d8e896f8b969f9f160fdb69ba0eae3cdc987 |
|
test_descr.py
| https://github.com/python/cpython/pull/133177/files#diff-6b813570d02ae3544e7e0233ae21d647f8e2dc47486495557e8d16c80460e85b |
|
2025-03-14-13-08-20.gh-issue-127266._tyfBp.rst
| https://github.com/python/cpython/pull/133177/files#diff-0c76f728f1804f73e9803de65856995503deb1b9574137ae77eea74ed73a7592 |
|
typeobject.c
| https://github.com/python/cpython/pull/133177/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872 |
|
ceval.c
| https://github.com/python/cpython/pull/133177/files#diff-c22186367cbe20233e843261998dc027ae5f1f8c0d2e778abfa454ae74cc59de |
|
suppressions_free_threading.txt
| https://github.com/python/cpython/pull/133177/files#diff-e0bd286d26ab448230ebe522b9086f5e93c33327108faff3a3957a34bb605f62 |
| Include/internal/pycore_interp_structs.h | https://github.com/python/cpython/pull/133177/files#diff-6075b6142803c1eccc213aa150704fd639443c65311d5999f69a5ea77cb76756 |
|
View file
| https://github.com/nascheme/cpython/blob/41e54e11fe92821ff1985ea1564f98c1f5a1b752/Include/internal/pycore_interp_structs.h |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/133177/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/133177/files#diff-6075b6142803c1eccc213aa150704fd639443c65311d5999f69a5ea77cb76756 |
|
| https://github.com/python/cpython/pull/133177/files#diff-6075b6142803c1eccc213aa150704fd639443c65311d5999f69a5ea77cb76756 |
| Include/internal/pycore_object.h | https://github.com/python/cpython/pull/133177/files#diff-2a12f738a77b362d74a65949b58c37f2affcd15ba8b1c979b63bd00223b8a456 |
|
View file
| https://github.com/nascheme/cpython/blob/41e54e11fe92821ff1985ea1564f98c1f5a1b752/Include/internal/pycore_object.h |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/133177/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/133177/files#diff-2a12f738a77b362d74a65949b58c37f2affcd15ba8b1c979b63bd00223b8a456 |
|
| https://github.com/python/cpython/pull/133177/files#diff-2a12f738a77b362d74a65949b58c37f2affcd15ba8b1c979b63bd00223b8a456 |
| Include/internal/pycore_typeobject.h | https://github.com/python/cpython/pull/133177/files#diff-9df981eafa9c743230f2e1513191ba147f0fba63d0c51fb7968c1e7093d9e877 |
|
View file
| https://github.com/nascheme/cpython/blob/41e54e11fe92821ff1985ea1564f98c1f5a1b752/Include/internal/pycore_typeobject.h |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/133177/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/133177/files#diff-9df981eafa9c743230f2e1513191ba147f0fba63d0c51fb7968c1e7093d9e877 |
|
| https://github.com/python/cpython/pull/133177/files#diff-9df981eafa9c743230f2e1513191ba147f0fba63d0c51fb7968c1e7093d9e877 |
| Include/object.h | https://github.com/python/cpython/pull/133177/files#diff-87272721a5cf1cd9915d6f503f6a7bbefa2f26c935c7ce83ca78706afd0ad05a |
|
View file
| https://github.com/nascheme/cpython/blob/41e54e11fe92821ff1985ea1564f98c1f5a1b752/Include/object.h |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/133177/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/133177/files#diff-87272721a5cf1cd9915d6f503f6a7bbefa2f26c935c7ce83ca78706afd0ad05a |
|
| https://github.com/python/cpython/pull/133177/files#diff-87272721a5cf1cd9915d6f503f6a7bbefa2f26c935c7ce83ca78706afd0ad05a |
|
| https://github.com/python/cpython/pull/133177/files#diff-87272721a5cf1cd9915d6f503f6a7bbefa2f26c935c7ce83ca78706afd0ad05a |
|
| https://github.com/python/cpython/pull/133177/files#diff-87272721a5cf1cd9915d6f503f6a7bbefa2f26c935c7ce83ca78706afd0ad05a |
| Include/refcount.h | https://github.com/python/cpython/pull/133177/files#diff-586c6481df97b64cf94363854b92d8e896f8b969f9f160fdb69ba0eae3cdc987 |
|
View file
| https://github.com/nascheme/cpython/blob/41e54e11fe92821ff1985ea1564f98c1f5a1b752/Include/refcount.h |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/133177/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/133177/files#diff-586c6481df97b64cf94363854b92d8e896f8b969f9f160fdb69ba0eae3cdc987 |
|
| https://github.com/python/cpython/pull/133177/files#diff-586c6481df97b64cf94363854b92d8e896f8b969f9f160fdb69ba0eae3cdc987 |
| Lib/test/test_descr.py | https://github.com/python/cpython/pull/133177/files#diff-6b813570d02ae3544e7e0233ae21d647f8e2dc47486495557e8d16c80460e85b |
|
View file
| https://github.com/nascheme/cpython/blob/41e54e11fe92821ff1985ea1564f98c1f5a1b752/Lib/test/test_descr.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/133177/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/133177/files#diff-6b813570d02ae3544e7e0233ae21d647f8e2dc47486495557e8d16c80460e85b |
|
| https://github.com/python/cpython/pull/133177/files#diff-6b813570d02ae3544e7e0233ae21d647f8e2dc47486495557e8d16c80460e85b |
| Misc/NEWS.d/next/Core_and_Builtins/2025-03-14-13-08-20.gh-issue-127266._tyfBp.rst | https://github.com/python/cpython/pull/133177/files#diff-0c76f728f1804f73e9803de65856995503deb1b9574137ae77eea74ed73a7592 |
|
View file
| https://github.com/nascheme/cpython/blob/41e54e11fe92821ff1985ea1564f98c1f5a1b752/Misc/NEWS.d/next/Core_and_Builtins/2025-03-14-13-08-20.gh-issue-127266._tyfBp.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/133177/{{ revealButtonHref }} |
| Please reload this page | https://github.com/python/cpython/pull/133177/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |