René's URL Explorer Experiment


Title: gh-127266: avoid data races when updating type slots v2 by nascheme · Pull Request #133177 · python/cpython · GitHub

Open Graph Title: gh-127266: avoid data races when updating type slots v2 by nascheme · Pull Request #133177 · python/cpython

X Title: gh-127266: avoid data races when updating type slots v2 by nascheme · Pull Request #133177 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: This is an updated version of GH-131174, which was reverted. I figured the cleanest thing to do is make a new PR. This is the same as the previous PR with the following additional change. The upda...

X Description: This is an updated version of GH-131174, which was reverted. I figured the cleanest thing to do is make a new PR. This is the same as the previous PR with the following additional change. The upda...

Opengraph URL: https://github.com/python/cpython/pull/133177

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:a51e9c0d-313b-5dcf-512f-fe0960d741da
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id87C6:2A5518:458BF1:5E4208:6A559A08
html-safe-nonce0cdbfaab94c42815dacca535959a794c8a947335f659d949cbba7d017af43cf8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4N0M2OjJBNTUxODo0NThCRjE6NUU0MjA4OjZBNTU5QTA4IiwidmlzaXRvcl9pZCI6IjUxODgzMDU0MjAwMTY3ODU5MjgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac46760246524f25ccf8553377a2d41e89159c2e23adf0b9d75877d08b7500c8ac
hovercard-subject-tagpull_request:2490131491
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/133177/commits
twitter:imagehttps://opengraph.githubassets.com/61708061a7139efa6515d4eebbedf4e7054261f18a993e9fcb9c1275ad47888c/python/cpython/pull/133177
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/61708061a7139efa6515d4eebbedf4e7054261f18a993e9fcb9c1275ad47888c/python/cpython/pull/133177
og:image:altThis is an updated version of GH-131174, which was reverted. I figured the cleanest thing to do is make a new PR. This is the same as the previous PR with the following additional change. The upda...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamenascheme
hostnamegithub.com
expected-hostnamegithub.com
Noneb5665c84831ed9ac4fb79519c16c9c5580ba8092fb8bb6e3e72972ec7197348e
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseaa21baa44893467b0b640d0300538f84ca8c475b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/133177/commits#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133177%2Fcommits
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133177%2Fcommits
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/133177/commits
Reloadhttps://github.com/python/cpython/pull/133177/commits
Reloadhttps://github.com/python/cpython/pull/133177/commits
Please reload this pagehttps://github.com/python/cpython/pull/133177/commits
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/133177/commits
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
naschemehttps://github.com/nascheme
python:mainhttps://github.com/python/cpython/tree/main
nascheme:type-slot-ts-v2https://github.com/nascheme/cpython/tree/type-slot-ts-v2
Conversationhttps://github.com/python/cpython/pull/133177
Commits24 (24)https://github.com/python/cpython/pull/133177/commits
Checkshttps://github.com/python/cpython/pull/133177/checks
Files changedhttps://github.com/python/cpython/pull/133177/files
gh-127266: avoid data races when updating type slots v2https://github.com/python/cpython/pull/133177/commits#top
naschemehttps://github.com/nascheme
python:mainhttps://github.com/python/cpython/tree/main
nascheme:type-slot-ts-v2https://github.com/nascheme/cpython/tree/type-slot-ts-v2
gh-127266: avoid data races when updating type slotshttps://github.com/python/cpython/pull/133177/commits/3094372e5fc8725c7de13479e4df7a0e6479fc44
https://github.com/nascheme
naschemehttps://github.com/python/cpython/commits?author=nascheme
3094372https://github.com/python/cpython/pull/133177/commits/3094372e5fc8725c7de13479e4df7a0e6479fc44
https://github.com/python/cpython/tree/3094372e5fc8725c7de13479e4df7a0e6479fc44
For update_all_slots(), do updates more safely.https://github.com/python/cpython/pull/133177/commits/f447ce4adf750b9da15011e30eaf8aee3fd7b478
https://github.com/nascheme
naschemehttps://github.com/python/cpython/commits?author=nascheme
f447ce4https://github.com/python/cpython/pull/133177/commits/f447ce4adf750b9da15011e30eaf8aee3fd7b478
https://github.com/python/cpython/tree/f447ce4adf750b9da15011e30eaf8aee3fd7b478
Avoid "empty structure" compile error.https://github.com/python/cpython/pull/133177/commits/d511ca6015e8a95c4f0f8c76330a8b57e3e1060c
https://github.com/nascheme
naschemehttps://github.com/python/cpython/commits?author=nascheme
d511ca6https://github.com/python/cpython/pull/133177/commits/d511ca6015e8a95c4f0f8c76330a8b57e3e1060c
https://github.com/python/cpython/tree/d511ca6015e8a95c4f0f8c76330a8b57e3e1060c
Use apply_slot_updates() for type_setattro().https://github.com/python/cpython/pull/133177/commits/5e38497b323fdb828d61a0a965841f07086edbcc
https://github.com/nascheme
naschemehttps://github.com/python/cpython/commits?author=nascheme
5e38497https://github.com/python/cpython/pull/133177/commits/5e38497b323fdb828d61a0a965841f07086edbcc
https://github.com/python/cpython/tree/5e38497b323fdb828d61a0a965841f07086edbcc
Merge 'origin/main' into type-slot-ts-v2https://github.com/python/cpython/pull/133177/commits/e9516c7a7685f2bd73d005af9a69ab6c52a7a5a2
https://github.com/nascheme
naschemehttps://github.com/python/cpython/commits?author=nascheme
e9516c7https://github.com/python/cpython/pull/133177/commits/e9516c7a7685f2bd73d005af9a69ab6c52a7a5a2
https://github.com/python/cpython/tree/e9516c7a7685f2bd73d005af9a69ab6c52a7a5a2
Reduce number of items in test for slot updates.https://github.com/python/cpython/pull/133177/commits/8c74a0c2e29ca8d4afadca8346eed685811943ca
https://github.com/nascheme
naschemehttps://github.com/python/cpython/commits?author=nascheme
8c74a0chttps://github.com/python/cpython/pull/133177/commits/8c74a0c2e29ca8d4afadca8346eed685811943ca
https://github.com/python/cpython/tree/8c74a0c2e29ca8d4afadca8346eed685811943ca
Add TSAN suppression for _Py_slot_tp_getattr_hook.https://github.com/python/cpython/pull/133177/commits/6cd7644c99c2980c9f054d6bd77b2d8e39cb0dee
https://github.com/nascheme
naschemehttps://github.com/python/cpython/commits?author=nascheme
6cd7644https://github.com/python/cpython/pull/133177/commits/6cd7644c99c2980c9f054d6bd77b2d8e39cb0dee
https://github.com/python/cpython/tree/6cd7644c99c2980c9f054d6bd77b2d8e39cb0dee
Queue update of tp_flags as well.https://github.com/python/cpython/pull/133177/commits/3cb225610df2ff9c89b6ec7a27bfc630a1420939
https://github.com/nascheme
naschemehttps://github.com/python/cpython/commits?author=nascheme
3cb2256https://github.com/python/cpython/pull/133177/commits/3cb225610df2ff9c89b6ec7a27bfc630a1420939
https://github.com/python/cpython/tree/3cb225610df2ff9c89b6ec7a27bfc630a1420939
Performance, skip stop-the-world when possible.https://github.com/python/cpython/pull/133177/commits/47e41c9896587cbfc5a9c6ad5d37a5b95cf16051
https://github.com/nascheme
naschemehttps://github.com/python/cpython/commits?author=nascheme
47e41c9https://github.com/python/cpython/pull/133177/commits/47e41c9896587cbfc5a9c6ad5d37a5b95cf16051
https://github.com/python/cpython/tree/47e41c9896587cbfc5a9c6ad5d37a5b95cf16051
Merge 'origin/main' into type-slot-ts-v2https://github.com/python/cpython/pull/133177/commits/cb848f117b0145b386d8f1b4fbc8710248456203
https://github.com/nascheme
naschemehttps://github.com/python/cpython/commits?author=nascheme
cb848f1https://github.com/python/cpython/pull/133177/commits/cb848f117b0145b386d8f1b4fbc8710248456203
https://github.com/python/cpython/tree/cb848f117b0145b386d8f1b4fbc8710248456203
Always clear version after __bases__ update.https://github.com/python/cpython/pull/133177/commits/9859ebf50986977b116d58f98ae81b054f04844c
https://github.com/nascheme
naschemehttps://github.com/python/cpython/commits?author=nascheme
9859ebfhttps://github.com/python/cpython/pull/133177/commits/9859ebf50986977b116d58f98ae81b054f04844c
https://github.com/python/cpython/tree/9859ebf50986977b116d58f98ae81b054f04844c
Merge 'origin/main' into type-slot-ts-v2https://github.com/python/cpython/pull/133177/commits/6c74cacf2162924f82552c414f1300d0d12c7be0
https://github.com/nascheme
naschemehttps://github.com/python/cpython/commits?author=nascheme
6c74cachttps://github.com/python/cpython/pull/133177/commits/6c74cacf2162924f82552c414f1300d0d12c7be0
https://github.com/python/cpython/tree/6c74cacf2162924f82552c414f1300d0d12c7be0
Add test for assigning __bases__.https://github.com/python/cpython/pull/133177/commits/583c435df6179ba6675fa3274bab6bfcfbcf9862
https://github.com/nascheme
naschemehttps://github.com/python/cpython/commits?author=nascheme
583c435https://github.com/python/cpython/pull/133177/commits/583c435df6179ba6675fa3274bab6bfcfbcf9862
https://github.com/python/cpython/tree/583c435df6179ba6675fa3274bab6bfcfbcf9862
Avoid releasing TYPE_LOCK when stopping the world.https://github.com/python/cpython/pull/133177/commits/c01707e839116fb0a87d82ac6d66d1c288888d47
https://github.com/nascheme
naschemehttps://github.com/python/cpython/commits?author=nascheme
c01707ehttps://github.com/python/cpython/pull/133177/commits/c01707e839116fb0a87d82ac6d66d1c288888d47
https://github.com/python/cpython/tree/c01707e839116fb0a87d82ac6d66d1c288888d47
Merge 'origin/main' into type-slot-ts-v2https://github.com/python/cpython/pull/133177/commits/1b9cad59500bd967c26d8145b911c91e954860d7
https://github.com/nascheme
naschemehttps://github.com/python/cpython/commits?author=nascheme
1b9cad5https://github.com/python/cpython/pull/133177/commits/1b9cad59500bd967c26d8145b911c91e954860d7
https://github.com/python/cpython/tree/1b9cad59500bd967c26d8145b911c91e954860d7
Add issue number for TSAN suppression.https://github.com/python/cpython/pull/133177/commits/a1c6b054e8a73fa658a37fa6431621b058575d9f
https://github.com/nascheme
naschemehttps://github.com/python/cpython/commits?author=nascheme
a1c6b05https://github.com/python/cpython/pull/133177/commits/a1c6b054e8a73fa658a37fa6431621b058575d9f
https://github.com/python/cpython/tree/a1c6b054e8a73fa658a37fa6431621b058575d9f
Bug fix for type_lock_prevent_release().https://github.com/python/cpython/pull/133177/commits/3f6222b70eb3751ff309f9a56d5cbae92b1ac6b9
https://github.com/nascheme
naschemehttps://github.com/python/cpython/commits?author=nascheme
3f6222bhttps://github.com/python/cpython/pull/133177/commits/3f6222b70eb3751ff309f9a56d5cbae92b1ac6b9
https://github.com/python/cpython/tree/3f6222b70eb3751ff309f9a56d5cbae92b1ac6b9
Merge 'origin/main' into type-slot-ts-v2https://github.com/python/cpython/pull/133177/commits/6f218fb5ced903a936a5f447f89ced776a496331
https://github.com/nascheme
naschemehttps://github.com/python/cpython/commits?author=nascheme
6f218fbhttps://github.com/python/cpython/pull/133177/commits/6f218fb5ced903a936a5f447f89ced776a496331
https://github.com/python/cpython/tree/6f218fb5ced903a936a5f447f89ced776a496331
Add additional assert.https://github.com/python/cpython/pull/133177/commits/2bcf7ba6329f54d4162e5444c5f313c9d3cf304e
https://github.com/nascheme
naschemehttps://github.com/python/cpython/commits?author=nascheme
2bcf7bahttps://github.com/python/cpython/pull/133177/commits/2bcf7ba6329f54d4162e5444c5f313c9d3cf304e
https://github.com/python/cpython/tree/2bcf7ba6329f54d4162e5444c5f313c9d3cf304e
Merge 'origin/main' into type-slot-ts-v2https://github.com/python/cpython/pull/133177/commits/ddfdbd5467dedb89268e752cf099369a25fe54c6
https://github.com/nascheme
naschemehttps://github.com/python/cpython/commits?author=nascheme
ddfdbd5https://github.com/python/cpython/pull/133177/commits/ddfdbd5467dedb89268e752cf099369a25fe54c6
https://github.com/python/cpython/tree/ddfdbd5467dedb89268e752cf099369a25fe54c6
Revert test_opcache item size change.https://github.com/python/cpython/pull/133177/commits/63b7ae41c3b088f9de780c0a1fcd4b8445994374
https://github.com/nascheme
naschemehttps://github.com/python/cpython/commits?author=nascheme
63b7ae4https://github.com/python/cpython/pull/133177/commits/63b7ae41c3b088f9de780c0a1fcd4b8445994374
https://github.com/python/cpython/tree/63b7ae41c3b088f9de780c0a1fcd4b8445994374
Add comment for new unit test.https://github.com/python/cpython/pull/133177/commits/1a2fee1048b292f9b30d491f2cb3d313b9976b7c
https://github.com/nascheme
naschemehttps://github.com/python/cpython/commits?author=nascheme
1a2fee1https://github.com/python/cpython/pull/133177/commits/1a2fee1048b292f9b30d491f2cb3d313b9976b7c
https://github.com/python/cpython/tree/1a2fee1048b292f9b30d491f2cb3d313b9976b7c
Fix assert for default build.https://github.com/python/cpython/pull/133177/commits/c1f3ed56a21d93d2c66dddfd2268628ab91be715
https://github.com/nascheme
naschemehttps://github.com/python/cpython/commits?author=nascheme
c1f3ed5https://github.com/python/cpython/pull/133177/commits/c1f3ed56a21d93d2c66dddfd2268628ab91be715
https://github.com/python/cpython/tree/c1f3ed56a21d93d2c66dddfd2268628ab91be715
Improve function name.https://github.com/python/cpython/pull/133177/commits/41e54e11fe92821ff1985ea1564f98c1f5a1b752
https://github.com/nascheme
naschemehttps://github.com/python/cpython/commits?author=nascheme
41e54e1https://github.com/python/cpython/pull/133177/commits/41e54e11fe92821ff1985ea1564f98c1f5a1b752
https://github.com/python/cpython/tree/41e54e11fe92821ff1985ea1564f98c1f5a1b752
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.