René's URL Explorer Experiment


Title: [2.7] bpo-30458: Disallow control chars in http URLs. (GH-12755) (GH-13154) by vstinner · Pull Request #13315 · python/cpython · GitHub

Open Graph Title: [2.7] bpo-30458: Disallow control chars in http URLs. (GH-12755) (GH-13154) by vstinner · Pull Request #13315 · python/cpython

X Title: [2.7] bpo-30458: Disallow control chars in http URLs. (GH-12755) (GH-13154) by vstinner · Pull Request #13315 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Disallow control chars in http URLs in urllib2.urlopen. This addresses a potential security problem for applications that do not sanity check their URLs where http request headers could be injecte...

X Description: Disallow control chars in http URLs in urllib2.urlopen. This addresses a potential security problem for applications that do not sanity check their URLs where http request headers could be injecte...

Mail addresses
miro@hroncok.cz

Opengraph URL: https://github.com/python/cpython/pull/13315

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fe808088-2a53-47ac-ff19-e1a320fcae23
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA510:B5AA6:1517033:1C8E33E:6A4EFEE1
html-safe-noncebd5e215a428635be97e5b99a1b054aa4b4c043ecb57e14ff294aaf2c523b9304
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTEwOkI1QUE2OjE1MTcwMzM6MUM4RTMzRTo2QTRFRkVFMSIsInZpc2l0b3JfaWQiOiIyNzY0NDAwOTQ5NjEwODcyNTQ1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5093722f695877202222c50f10148f7d9038b793757f92db1f55734adffaa4d1
hovercard-subject-tagpull_request:278726342
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/13315/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/199e90be62a64341d1c89c9afb0451ad37894f2a2a810885a439d4e9c84520d2/python/cpython/pull/13315
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/199e90be62a64341d1c89c9afb0451ad37894f2a2a810885a439d4e9c84520d2/python/cpython/pull/13315
og:image:altDisallow control chars in http URLs in urllib2.urlopen. This addresses a potential security problem for applications that do not sanity check their URLs where http request headers could be injecte...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevstinner
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b8f23afb982271f1b22258a94aede67a6b77760
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/13315#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13315
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13315
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/13315
Reloadhttps://github.com/python/cpython/pull/13315
Reloadhttps://github.com/python/cpython/pull/13315
Please reload this pagehttps://github.com/python/cpython/pull/13315
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/13315
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
vstinnerhttps://github.com/vstinner
python:2.7https://github.com/python/cpython/tree/2.7
Conversationhttps://github.com/python/cpython/pull/13315
Commits2 (2)https://github.com/python/cpython/pull/13315/commits
Checkshttps://github.com/python/cpython/pull/13315/checks
Files changedhttps://github.com/python/cpython/pull/13315/files
[2.7] bpo-30458: Disallow control chars in http URLs. (GH-12755) (GH-13154)https://github.com/python/cpython/pull/13315#top
vstinnerhttps://github.com/vstinner
python:2.7https://github.com/python/cpython/tree/2.7
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
May 14, 2019https://github.com/python/cpython/pull/13315#issue-443969129
Please reload this pagehttps://github.com/python/cpython/pull/13315
GH-13032https://github.com/python/cpython/pull/13032
GH-13044https://github.com/python/cpython/pull/13044
7e200e0https://github.com/python/cpython/commit/7e200e0763f5b71c199aaf98bd5588f291585619
https://bugs.python.org/issue30458https://bugs.python.org/issue30458
Please reload this pagehttps://github.com/python/cpython/pull/13315
https://github.com/hroncok
https://github.com/vstinner
bpo-30458https://bugs.python.org/issue?@action=redirect&bpo=30458
: Disallow control chars in http URLs. (https://github.com/python/cpython/pull/13315/commits/8af9afdb2938f3d993eaea549c7bc5fbe75bb7e7
GH-12755https://github.com/python/cpython/pull/12755
) (https://github.com/python/cpython/pull/13315/commits/8af9afdb2938f3d993eaea549c7bc5fbe75bb7e7
GH-13154https://github.com/python/cpython/pull/13154
)https://github.com/python/cpython/pull/13315/commits/8af9afdb2938f3d993eaea549c7bc5fbe75bb7e7
8af9afdhttps://github.com/python/cpython/pull/13315/commits/8af9afdb2938f3d993eaea549c7bc5fbe75bb7e7
GH-13032https://github.com/python/cpython/pull/13032
GH-13044https://github.com/python/cpython/pull/13044
7e200e0https://github.com/python/cpython/commit/7e200e0763f5b71c199aaf98bd5588f291585619
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
type-security https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-security
May 14, 2019https://github.com/python/cpython/pull/13315#event-2340450430
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
May 14, 2019https://github.com/python/cpython/pull/13315#event-2340450662
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
May 14, 2019https://github.com/python/cpython/pull/13315#event-2340450731
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 14, 2019https://github.com/python/cpython/pull/13315#event-2340450947
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
May 14, 2019https://github.com/python/cpython/pull/13315#issuecomment-492279511
Please reload this pagehttps://github.com/python/cpython/pull/13315
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
gpsheadhttps://github.com/gpshead
May 14, 2019 15:09https://github.com/python/cpython/pull/13315#event-2340469225
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
May 14, 2019https://github.com/python/cpython/pull/13315#issuecomment-492280072
@orsenthilhttps://github.com/orsenthil
@ned-deilyhttps://github.com/ned-deily
@tirkarthihttps://github.com/tirkarthi
@hroncokhttps://github.com/hroncok
Please reload this pagehttps://github.com/python/cpython/pull/13315
https://github.com/tirkarthi
tirkarthihttps://github.com/tirkarthi
May 14, 2019 https://github.com/python/cpython/pull/13315#pullrequestreview-237333332
View reviewed changes https://github.com/python/cpython/pull/13315/files/8af9afdb2938f3d993eaea549c7bc5fbe75bb7e7
tirkarthihttps://github.com/tirkarthi
https://github.com/python/cpython/pull/13315#pullrequestreview-237333332
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/13315
https://github.com/ned-deily
ned-deilyhttps://github.com/ned-deily
May 15, 2019https://github.com/python/cpython/pull/13315#issuecomment-492675058
Please reload this pagehttps://github.com/python/cpython/pull/13315
@vstinnerhttps://github.com/vstinner
@benjaminphttps://github.com/benjaminp
Please reload this pagehttps://github.com/python/cpython/pull/13315
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
May 15, 2019https://github.com/python/cpython/pull/13315#issuecomment-492680616
@vstinnerhttps://github.com/vstinner
@benjaminphttps://github.com/benjaminp
Please reload this pagehttps://github.com/python/cpython/pull/13315
https://github.com/orsenthil
orsenthilhttps://github.com/orsenthil
May 15, 2019 https://github.com/python/cpython/pull/13315#pullrequestreview-238059103
View reviewed changes https://github.com/python/cpython/pull/13315/files/8af9afdb2938f3d993eaea549c7bc5fbe75bb7e7
orsenthilhttps://github.com/orsenthil
https://github.com/python/cpython/pull/13315#pullrequestreview-238059103
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/13315
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 15, 2019https://github.com/python/cpython/pull/13315#event-2344548334
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
May 15, 2019 https://github.com/python/cpython/pull/13315#pullrequestreview-238073956
View reviewed changes https://github.com/python/cpython/pull/13315/files/8af9afdb2938f3d993eaea549c7bc5fbe75bb7e7
gpsheadhttps://github.com/gpshead
https://github.com/python/cpython/pull/13315#pullrequestreview-238073956
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/13315
Lib/test/test_urllib.pyhttps://github.com/python/cpython/pull/13315/files/8af9afdb2938f3d993eaea549c7bc5fbe75bb7e7#diff-111958b1956c05d043a3da3bcf638cff888dff68cddd71f7eeae257fc6080dcb
gpsheadhttps://github.com/gpshead
May 15, 2019https://github.com/python/cpython/pull/13315#discussion_r284453365
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/13315
vstinnerhttps://github.com/vstinner
May 20, 2019https://github.com/python/cpython/pull/13315#discussion_r285634121
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/13315
Lib/test/test_urllib2.pyhttps://github.com/python/cpython/pull/13315/files/8af9afdb2938f3d993eaea549c7bc5fbe75bb7e7#diff-5dcb1946f2eee26a435ec5f5e005ce2f656c6d375b8cd2c4fa789ebb09e75403
Please reload this pagehttps://github.com/python/cpython/pull/13315
Lib/test/test_urllib2.pyhttps://github.com/python/cpython/pull/13315/files/8af9afdb2938f3d993eaea549c7bc5fbe75bb7e7#diff-5dcb1946f2eee26a435ec5f5e005ce2f656c6d375b8cd2c4fa789ebb09e75403
Please reload this pagehttps://github.com/python/cpython/pull/13315
https://github.com/vstinner
Address Gregory's commentshttps://github.com/python/cpython/pull/13315/commits/9f8ae2a2e4b836fe3136e84e55b8de62cb40904f
9f8ae2ahttps://github.com/python/cpython/pull/13315/commits/9f8ae2a2e4b836fe3136e84e55b8de62cb40904f
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
bb8071ahttps://github.com/python/cpython/commit/bb8071a4cae5ab3fe321481dd3d73662ffb26052
May 21, 2019https://github.com/python/cpython/pull/13315#event-2356113500
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
May 21, 2019https://github.com/python/cpython/pull/13315#event-2356113646
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
May 21, 2019 13:12https://github.com/python/cpython/pull/13315#event-2356114073
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
May 21, 2019https://github.com/python/cpython/pull/13315#issuecomment-494385101
Please reload this pagehttps://github.com/python/cpython/pull/13315
jeff5https://github.com/jeff5
Mar 13, 2022 https://github.com/python/cpython/pull/13315#ref-commit-abad0ff
https://github.com/jeff5
Update stdlib modules related tohttps://github.com/jython/jython/commit/abad0ff3ce99a56a56ff2ddb7ab8eebccdfe8f00
CVE-2019-9740https://github.com/advisories/GHSA-p3j2-v862-h3v3
(https://github.com/jython/jython/commit/abad0ff3ce99a56a56ff2ddb7ab8eebccdfe8f00
fixeshttps://github.com/jython/jython/commit/abad0ff3ce99a56a56ff2ddb7ab8eebccdfe8f00
#98https://github.com/jython/jython/issues/98
)https://github.com/jython/jython/commit/abad0ff3ce99a56a56ff2ddb7ab8eebccdfe8f00
abad0ffhttps://github.com/jython/jython/commit/abad0ff3ce99a56a56ff2ddb7ab8eebccdfe8f00
python/cpython#13315https://github.com/python/cpython/pull/13315
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13315
https://github.com/gpshead
gpshead https://github.com/gpshead
https://github.com/python/cpython/pull/13315/files/8af9afdb2938f3d993eaea549c7bc5fbe75bb7e7
https://github.com/orsenthil
orsenthil https://github.com/orsenthil
https://github.com/python/cpython/pull/13315/files/8af9afdb2938f3d993eaea549c7bc5fbe75bb7e7
https://github.com/tirkarthi
tirkarthi https://github.com/tirkarthi
https://github.com/python/cpython/pull/13315/files/8af9afdb2938f3d993eaea549c7bc5fbe75bb7e7
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
type-security https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-security
Please reload this pagehttps://github.com/python/cpython/pull/13315
https://github.com/vstinner
https://github.com/ned-deily
https://github.com/gpshead
https://github.com/orsenthil
https://github.com/tirkarthi
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com/hroncok
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.