Title: gh-133042: disable HACL* HMAC on Emscripten by picnixz · Pull Request #133064 · python/cpython · GitHub
Open Graph Title: gh-133042: disable HACL* HMAC on Emscripten by picnixz · Pull Request #133064 · python/cpython
X Title: gh-133042: disable HACL* HMAC on Emscripten by picnixz · Pull Request #133064 · python/cpython
Description: I don't want to hold the next beta and I don't know how we can easily make it work. I don't really want to revert #132438 as it solves an issue with freeze.py but we may eventually need to do it. I plan to leave on Monday evening and I won't have access to my dev session until May 8th or something like that. @hugovk Feel free to revert #132438 and #133012. @hoodmane Feel free to take over this branch if you want. Also, please first confirm that disabling HACL* HMAC actually solves the issue (ISTM that it kinda works but I needed to run make manually because I had some issues with my system-wide Python that is too old for emcc & co). Issue: gh-133042
Open Graph Description: I don't want to hold the next beta and I don't know how we can easily make it work. I don't really want to revert #132438 as it solves an issue with freeze.py but we may eventually need...
X Description: I don't want to hold the next beta and I don't know how we can easily make it work. I don't really want to revert #132438 as it solves an issue with freeze.py but we may eve...
Opengraph URL: https://github.com/python/cpython/pull/133064
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:e34fb6cd-772e-0488-3654-fe8d2d8a7706 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AB44:3410DA:C18E2F:FA55CC:696AFE74 |
| html-safe-nonce | d65433685c13bff2fec04d69a2e19094bf4b87f968dd7af0a680f1637444c2c8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQjQ0OjM0MTBEQTpDMThFMkY6RkE1NUNDOjY5NkFGRTc0IiwidmlzaXRvcl9pZCI6IjE4MzU0ODc3MDY0NzczNTkyNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 125f57e0a74e112bb6497509ab2fbd00b3368f7f1b6e774a08d2fd9966982f4e |
| hovercard-subject-tag | pull_request:2484460088 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/133064/files |
| twitter:image | https://avatars.githubusercontent.com/u/10796600?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/10796600?s=400&v=4 |
| og:image:alt | I don't want to hold the next beta and I don't know how we can easily make it work. I don't really want to revert #132438 as it solves an issue with freeze.py but we may eventually need... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width