René's URL Explorer Experiment


Title: gh-133042: disable HACL* HMAC on Emscripten by picnixz · Pull Request #133064 · python/cpython · GitHub

Open Graph Title: gh-133042: disable HACL* HMAC on Emscripten by picnixz · Pull Request #133064 · python/cpython

X Title: gh-133042: disable HACL* HMAC on Emscripten by picnixz · Pull Request #133064 · python/cpython

Description: I don't want to hold the next beta and I don't know how we can easily make it work. I don't really want to revert #132438 as it solves an issue with freeze.py but we may eventually need to do it. I...

Open Graph Description: I don't want to hold the next beta and I don't know how we can easily make it work. I don't really want to revert #132438 as it solves an issue with freeze.py but we may eventually need...

X Description: I don't want to hold the next beta and I don't know how we can easily make it work. I don't really want to revert #132438 as it solves an issue with freeze.py but we may eve...

Opengraph URL: https://github.com/python/cpython/pull/133064

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0540a731-8a42-da4f-76f8-20bbf2334a4a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8BDA:319547:21EBAC:2AD110:696ADA9B
html-safe-nonceb78a885f00bd936f86e9707dc6226aecb15b9e0147aa5afc2435f8e16ac6187d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QkRBOjMxOTU0NzoyMUVCQUM6MkFEMTEwOjY5NkFEQTlCIiwidmlzaXRvcl9pZCI6IjY2ODQ4ODI5MDQ1MjcwNjc4MDMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace244e75237b0b41d94e3d6449679d5f92df5b59f7154d2e3de3cde3425f0eb04
hovercard-subject-tagpull_request:2484460088
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/133064/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1d0c339439dcd469d6b3daab8a82eb54b51f4c31ff2d9845f02cb11e59ee082d/python/cpython/pull/133064
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1d0c339439dcd469d6b3daab8a82eb54b51f4c31ff2d9845f02cb11e59ee082d/python/cpython/pull/133064
og:image:altI don't want to hold the next beta and I don't know how we can easily make it work. I don't really want to revert #132438 as it solves an issue with freeze.py but we may eventually need...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepicnixz
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release524a93f2c1f36522a3b4be4c110467ee4172245d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/133064#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133064
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133064
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/133064
Reloadhttps://github.com/python/cpython/pull/133064
Reloadhttps://github.com/python/cpython/pull/133064
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/133064
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/133064
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/133064#issue-comment-box
picnixzhttps://github.com/picnixz
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/build/hacl-emscripten-133042https://github.com/picnixz/cpython/tree/fix/build/hacl-emscripten-133042
gh-133042: disable HACL* HMAC on Emscripten https://github.com/python/cpython/pull/133064#top
picnixzhttps://github.com/picnixz
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/build/hacl-emscripten-133042https://github.com/picnixz/cpython/tree/fix/build/hacl-emscripten-133042
Conversation 5 https://github.com/python/cpython/pull/133064
Commits 2 https://github.com/python/cpython/pull/133064/commits
Checks 39 https://github.com/python/cpython/pull/133064/checks
Files changed https://github.com/python/cpython/pull/133064/files
Please reload this pagehttps://github.com/python/cpython/pull/133064
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Apr 27, 2025https://github.com/python/cpython/pull/133064#issue-3023376899
Please reload this pagehttps://github.com/python/cpython/pull/133064
#132438https://github.com/python/cpython/pull/132438
@hugovkhttps://github.com/hugovk
#132438https://github.com/python/cpython/pull/132438
#133012https://github.com/python/cpython/pull/133012
@hoodmanehttps://github.com/hoodmane
emscripten cross-compile wasm-ld: error: duplicate symbol _Py_LibHacl_Hacl_Hash_* #133042https://github.com/python/cpython/issues/133042
Please reload this pagehttps://github.com/python/cpython/pull/133064
https://github.com/picnixz
disable HACL* HMAC on Emscriptenhttps://github.com/python/cpython/pull/133064/commits/f649e9a291e8ba2a1a1ec6ccc800846325fbcc8f
f649e9ahttps://github.com/python/cpython/pull/133064/commits/f649e9a291e8ba2a1a1ec6ccc800846325fbcc8f
https://github.com/picnixz
picnixzhttps://github.com/picnixz
corona10https://github.com/corona10
erlend-aaslandhttps://github.com/erlend-aasland
code ownershttps://github.com/python/cpython/blob/cd76eff26e5f700ffb715d9d096d2e28744d0594/.github/CODEOWNERS#L15
April 27, 2025 23:08https://github.com/python/cpython/pull/133064#event-17425195666
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Apr 27, 2025https://github.com/python/cpython/pull/133064#event-17425195771
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Apr 27, 2025 https://github.com/python/cpython/pull/133064#ref-issue-3023038713
emscripten cross-compile wasm-ld: error: duplicate symbol _Py_LibHacl_Hacl_Hash_* #133042 https://github.com/python/cpython/issues/133042
https://github.com/picnixz
picnixzhttps://github.com/picnixz
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Apr 27, 2025https://github.com/python/cpython/pull/133064#event-17425196477
https://github.com/picnixz
picnixzhttps://github.com/picnixz
hoodmanehttps://github.com/hoodmane
April 27, 2025 23:09https://github.com/python/cpython/pull/133064#event-17425196918
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Apr 27, 2025https://github.com/python/cpython/pull/133064#issuecomment-2833685346
@Lukasdoehttps://github.com/Lukasdoe
Please reload this pagehttps://github.com/python/cpython/pull/133064
https://github.com/Lukasdoe
Lukasdoehttps://github.com/Lukasdoe
Apr 28, 2025https://github.com/python/cpython/pull/133064#issuecomment-2834620548
Please reload this pagehttps://github.com/python/cpython/pull/133064
Please reload this pagehttps://github.com/python/cpython/pull/133064
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Apr 28, 2025https://github.com/python/cpython/pull/133064#issuecomment-2834627298
Please reload this pagehttps://github.com/python/cpython/pull/133064
https://github.com/picnixz
Merge branch 'main' into fix/build/hacl-emscripten-133042https://github.com/python/cpython/pull/133064/commits/f8a571b78ca73dcc5116e7d7891c4dc1e4325253
f8a571bhttps://github.com/python/cpython/pull/133064/commits/f8a571b78ca73dcc5116e7d7891c4dc1e4325253
https://github.com/picnixz
picnixzhttps://github.com/picnixz
hugovkhttps://github.com/hugovk
May 4, 2025 17:06https://github.com/python/cpython/pull/133064#event-17511006906
https://github.com/hugovk
hugovkhttps://github.com/hugovk
May 4, 2025 https://github.com/python/cpython/pull/133064#pullrequestreview-2813540110
View reviewed changes https://github.com/python/cpython/pull/133064/files/f8a571b78ca73dcc5116e7d7891c4dc1e4325253
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 4, 2025https://github.com/python/cpython/pull/133064#event-17511279259
https://github.com/picnixz
picnixzhttps://github.com/picnixz
7b96701https://github.com/python/cpython/commit/7b96701cccce2797f88527d6a980dbcfdb0af851
May 4, 2025https://github.com/python/cpython/pull/133064#event-17511374538
Please reload this pagehttps://github.com/python/cpython/pull/133064
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
May 4, 2025https://github.com/python/cpython/pull/133064#event-17511374625
https://github.com/picnixz
picnixzhttps://github.com/picnixz
May 4, 2025 19:55https://github.com/python/cpython/pull/133064#event-17511374716
https://github.com/hoodmane
hoodmanehttps://github.com/hoodmane
May 4, 2025https://github.com/python/cpython/pull/133064#issuecomment-2849457459
@picnixzhttps://github.com/picnixz
Please reload this pagehttps://github.com/python/cpython/pull/133064
https://github.com/hoodmane
hoodmanehttps://github.com/hoodmane
May 4, 2025https://github.com/python/cpython/pull/133064#issuecomment-2849458554
Please reload this pagehttps://github.com/python/cpython/pull/133064
diegorussohttps://github.com/diegorusso
May 4, 2025 https://github.com/python/cpython/pull/133064#ref-commit-c03babc
https://github.com/diegorusso
Merge remote-tracking branch 'origin/main' into call-lenhttps://github.com/diegorusso/cpython/commit/c03babc6a588ef8b05b58f3d31c8bda9b0469760
c03babchttps://github.com/diegorusso/cpython/commit/c03babc6a588ef8b05b58f3d31c8bda9b0469760
pythongh-91048https://github.com/python/cpython/issues/91048
pythonGH-133385https://github.com/python/cpython/pull/133385
pythongh-131178https://github.com/python/cpython/issues/131178
python#133329https://github.com/python/cpython/pull/133329
python#133394https://github.com/python/cpython/pull/133394
pythongh-133042https://github.com/python/cpython/issues/133042
python#133064https://github.com/python/cpython/pull/133064
pythongh-133351https://github.com/python/cpython/issues/133351
python#133387https://github.com/python/cpython/pull/133387
pythongh-109700https://github.com/python/cpython/issues/109700
pythonGH-109946https://github.com/python/cpython/pull/109946
pythongh-81793https://github.com/python/cpython/issues/81793
pythonGH-133388https://github.com/python/cpython/pull/133388
pythongh-126835https://github.com/python/cpython/issues/126835
python#131830https://github.com/python/cpython/pull/131830
pythongh-91048https://github.com/python/cpython/issues/91048
python#133368https://github.com/python/cpython/pull/133368
pythongh-132457https://github.com/python/cpython/issues/132457
python#132460https://github.com/python/cpython/pull/132460
pythongh-132805https://github.com/python/cpython/issues/132805
python#132812https://github.com/python/cpython/pull/132812
pythongh-132426https://github.com/python/cpython/issues/132426
python#132490https://github.com/python/cpython/pull/132490
pythongh-81793https://github.com/python/cpython/issues/81793
pythonGH-132517https://github.com/python/cpython/pull/132517
pythongh-122559https://github.com/python/cpython/issues/122559
pythonGH-122628https://github.com/python/cpython/pull/122628
pythongh-69605https://github.com/python/cpython/issues/69605
python#133358https://github.com/python/cpython/pull/133358
pythonGH-26226https://github.com/python/cpython/pull/26226
pythonGH-133231https://github.com/python/cpython/issues/133231
pythonGH-133287https://github.com/python/cpython/pull/133287
pythongh-133363https://github.com/python/cpython/issues/133363
python#133364https://github.com/python/cpython/pull/133364
pythongh-132983https://github.com/python/cpython/issues/132983
pythonGH-133027https://github.com/python/cpython/pull/133027
pythonGH-91048https://github.com/python/cpython/issues/91048
python#133284https://github.com/python/cpython/pull/133284
Pranjal095https://github.com/Pranjal095
Jul 12, 2025 https://github.com/python/cpython/pull/133064#ref-commit-bcbba36
https://github.com/picnixz
https://github.com/Pranjal095
pythongh-133042https://github.com/python/cpython/issues/133042
: disable HACL* HMAC on Emscripten (https://github.com/Pranjal095/cpython/commit/bcbba36cf8e696b8055aece6075d85603d3bf2c1
python#133064https://github.com/python/cpython/pull/133064
)https://github.com/Pranjal095/cpython/commit/bcbba36cf8e696b8055aece6075d85603d3bf2c1
bcbba36https://github.com/Pranjal095/cpython/commit/bcbba36cf8e696b8055aece6075d85603d3bf2c1
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F133064
https://github.com/hugovk
hugovk https://github.com/hugovk
https://github.com/python/cpython/pull/133064/files/f8a571b78ca73dcc5116e7d7891c4dc1e4325253
https://github.com/erlend-aasland
erlend-aasland https://github.com/erlend-aasland
https://github.com/corona10
corona10 https://github.com/corona10
https://github.com/hoodmane
hoodmane https://github.com/hoodmane
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/133064
https://github.com/picnixz
https://github.com/Lukasdoe
https://github.com/hoodmane
https://github.com/hugovk
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.