René's URL Explorer Experiment


Title: gh-132805 - annotationlib - Fix unions of real types and forward references. by DavidCEllis · Pull Request #132806 · python/cpython · GitHub

Open Graph Title: gh-132805 - annotationlib - Fix unions of real types and forward references. by DavidCEllis · Pull Request #132806 · python/cpython

X Title: gh-132805 - annotationlib - Fix unions of real types and forward references. by DavidCEllis · Pull Request #132806 · python/cpython

Description: Potential fix for #132805 This adds a create_unions parameter to _StringifierDict which - if set to True - creates unions between _Stringifier instances instead of trying to join them with ast meth...

Open Graph Description: Potential fix for #132805 This adds a create_unions parameter to _StringifierDict which - if set to True - creates unions between _Stringifier instances instead of trying to join them with ast meth...

X Description: Potential fix for #132805 This adds a create_unions parameter to _StringifierDict which - if set to True - creates unions between _Stringifier instances instead of trying to join them with ast meth...

Opengraph URL: https://github.com/python/cpython/pull/132806

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:eff5d70e-2c3f-b64c-a296-ad2d7f1ffb5f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id98AC:1672C1:1909C93:20AFAF5:696B2DC3
html-safe-nonce6e8bc4a93cd7de636296198c46ae18281d3ff994b1525b34f531d1f58c60d903
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OEFDOjE2NzJDMToxOTA5QzkzOjIwQUZBRjU6Njk2QjJEQzMiLCJ2aXNpdG9yX2lkIjoiNzU2NDQ2MTMzNDUyMjk2NTQ0MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf706c4018915a1c535d5cd0bd6e314c73c141dcd3a03152c28fa7902bf895b7c
hovercard-subject-tagpull_request:2474132791
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/132806/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2e08e1f83362f6d155d14abd118d747f33a187021613f8787fba255a6a840640/python/cpython/pull/132806
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2e08e1f83362f6d155d14abd118d747f33a187021613f8787fba255a6a840640/python/cpython/pull/132806
og:image:altPotential fix for #132805 This adds a create_unions parameter to _StringifierDict which - if set to True - creates unions between _Stringifier instances instead of trying to join them with ast meth...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameDavidCEllis
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/132806#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F132806
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F132806
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/132806
Reloadhttps://github.com/python/cpython/pull/132806
Reloadhttps://github.com/python/cpython/pull/132806
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/132806
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/132806
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/132806#issue-comment-box
DavidCEllishttps://github.com/DavidCEllis
python:mainhttps://github.com/python/cpython/tree/main
DavidCEllis:fix-union-forwardrefhttps://github.com/DavidCEllis/cpython/tree/fix-union-forwardref
gh-132805 - annotationlib - Fix unions of real types and forward references. https://github.com/python/cpython/pull/132806#top
DavidCEllishttps://github.com/DavidCEllis
python:mainhttps://github.com/python/cpython/tree/main
DavidCEllis:fix-union-forwardrefhttps://github.com/DavidCEllis/cpython/tree/fix-union-forwardref
Conversation 0 https://github.com/python/cpython/pull/132806
Commits 4 https://github.com/python/cpython/pull/132806/commits
Checks 34 https://github.com/python/cpython/pull/132806/checks
Files changed https://github.com/python/cpython/pull/132806/files
Please reload this pagehttps://github.com/python/cpython/pull/132806
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/DavidCEllis
DavidCEllishttps://github.com/DavidCEllis
Apr 22, 2025https://github.com/python/cpython/pull/132806#issue-3011660506
Please reload this pagehttps://github.com/python/cpython/pull/132806
#132805https://github.com/python/cpython/issues/132805
[3.14] annotationlib - Union '|' syntax and typing.Union[...] generate different forward references. #132805https://github.com/python/cpython/issues/132805
Please reload this pagehttps://github.com/python/cpython/pull/132806
DavidCEllishttps://github.com/DavidCEllis
April 22, 2025 16:53https://github.com/python/cpython/pull/132806#commits-pushed-fba5efa
https://github.com/DavidCEllis
Add a test for union forward referenceshttps://github.com/python/cpython/pull/132806/commits/fba5efa2a04871b845403443f85b18a20d303e3a
fba5efahttps://github.com/python/cpython/pull/132806/commits/fba5efa2a04871b845403443f85b18a20d303e3a
https://github.com/DavidCEllis
Make stringifiers create unions if create_unions is Truehttps://github.com/python/cpython/pull/132806/commits/d8109538837278622b4f3809d5ae51af942ad9ac
d810953https://github.com/python/cpython/pull/132806/commits/d8109538837278622b4f3809d5ae51af942ad9ac
https://github.com/DavidCEllis
modify broken test, move test to forwardref format grouphttps://github.com/python/cpython/pull/132806/commits/1908a4a6ca0a70e45128237a07f0e307ff283eef
1908a4ahttps://github.com/python/cpython/pull/132806/commits/1908a4a6ca0a70e45128237a07f0e307ff283eef
https://github.com/DavidCEllis
DavidCEllishttps://github.com/DavidCEllis
JelleZijlstrahttps://github.com/JelleZijlstra
code ownerhttps://github.com/python/cpython/blob/a6a3dbb7db0516a72c5ef149223d904f4e6a31ae/.github/CODEOWNERS#L249
April 22, 2025 17:13https://github.com/python/cpython/pull/132806#event-17357509307
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Apr 22, 2025https://github.com/python/cpython/pull/132806#event-17357509921
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Apr 22, 2025 https://github.com/python/cpython/pull/132806#ref-issue-3011595563
[3.14] annotationlib - Union '|' syntax and typing.Union[...] generate different forward references. #132805 https://github.com/python/cpython/issues/132805
https://github.com/DavidCEllis
Apparently trim trailing whitespace was turned offhttps://github.com/python/cpython/pull/132806/commits/97abdc7f44f17d84d248e4f762d5499e5091cbb7
97abdc7https://github.com/python/cpython/pull/132806/commits/97abdc7f44f17d84d248e4f762d5499e5091cbb7
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Apr 22, 2025 https://github.com/python/cpython/pull/132806#ref-pullrequest-3012090658
gh-132805: annotationlib: Fix handling of non-constant values in FORWARDREF #132812 https://github.com/python/cpython/pull/132812
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
#132812 https://github.com/python/cpython/pull/132812
May 4, 2025https://github.com/python/cpython/pull/132806#event-17510830236
https://github.com/DavidCEllis
DavidCEllishttps://github.com/DavidCEllis
June 9, 2025 10:32https://github.com/python/cpython/pull/132806#event-18053208185
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F132806
https://github.com/JelleZijlstra
JelleZijlstra https://github.com/JelleZijlstra
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Please reload this pagehttps://github.com/python/cpython/pull/132806
https://github.com/DavidCEllis
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.