René's URL Explorer Experiment


Title: gh-132713: Fix typing.Union[index] race condition by vstinner · Pull Request #132802 · python/cpython · GitHub

Open Graph Title: gh-132713: Fix typing.Union[index] race condition by vstinner · Pull Request #132802 · python/cpython

X Title: gh-132713: Fix typing.Union[index] race condition by vstinner · Pull Request #132802 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Use a critical section in union_getitem() to initialize the 'parameters' member. Issue: Segfault in union_repr from list_repr_impl in free-threaded build #132713

X Description: Use a critical section in union_getitem() to initialize the 'parameters' member. Issue: Segfault in union_repr from list_repr_impl in free-threaded build #132713

Opengraph URL: https://github.com/python/cpython/pull/132802

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1800a089-b295-2e0e-f464-ba25474b3993
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9420:E9D16:3EC0DA8:4F74ED0:6B0248F5
html-safe-noncec574c55cf10e8e3a4ac83c77845a618a6d6312aaf8228912a9ea361faf6409e1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDIwOkU5RDE2OjNFQzBEQTg6NEY3NEVEMDo2QjAyNDhGNSIsInZpc2l0b3JfaWQiOiIxMTI4NDI0ODgxMjU2NTQ4NTk3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacbf4d7ddd48d7957239e41a524c51cc41716bf37775e79e284a63d565a6d7ebbc
hovercard-subject-tagpull_request:2473852932
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/132802/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ef09139598a1b8b787ea227b5a106b2c3a33d78e37340376b4bb32e32246eaf0/python/cpython/pull/132802
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ef09139598a1b8b787ea227b5a106b2c3a33d78e37340376b4bb32e32246eaf0/python/cpython/pull/132802
og:image:altUse a critical section in union_getitem() to initialize the 'parameters' member. Issue: Segfault in union_repr from list_repr_impl in free-threaded build #132713
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevstinner
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/132802#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F132802
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F132802
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/132802
Reloadhttps://github.com/python/cpython/pull/132802
Reloadhttps://github.com/python/cpython/pull/132802
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
vstinner:union_getitemhttps://github.com/vstinner/cpython/tree/union_getitem
Conversationhttps://github.com/python/cpython/pull/132802
Commits8 (8)https://github.com/python/cpython/pull/132802/commits
Checkshttps://github.com/python/cpython/pull/132802/checks
Files changedhttps://github.com/python/cpython/pull/132802/files
gh-132713: Fix typing.Union[index] race conditionhttps://github.com/python/cpython/pull/132802#top
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
vstinner:union_getitemhttps://github.com/vstinner/cpython/tree/union_getitem
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 22, 2025https://github.com/python/cpython/pull/132802#issue-3011341463
Please reload this pagehttps://github.com/python/cpython/pull/132802
Segfault in union_repr from list_repr_impl in free-threaded build #132713https://github.com/python/cpython/issues/132713
Please reload this pagehttps://github.com/python/cpython/pull/132802
https://github.com/vstinner
pythongh-132713https://github.com/python/cpython/issues/132713
: Fix typing.Union[index] race conditionhttps://github.com/python/cpython/pull/132802/commits/208f247bdc57e1e2282538a59427edf66e26042e
208f247https://github.com/python/cpython/pull/132802/commits/208f247bdc57e1e2282538a59427edf66e26042e
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Apr 22, 2025https://github.com/python/cpython/pull/132802#event-17355507239
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Apr 22, 2025https://github.com/python/cpython/pull/132802#event-17355508484
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Apr 22, 2025 https://github.com/python/cpython/pull/132802#ref-issue-3005995834
Segfault in union_repr from list_repr_impl in free-threaded build #132713 https://github.com/python/cpython/issues/132713
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Apr 22, 2025 https://github.com/python/cpython/pull/132802#pullrequestreview-2784474467
View reviewed changes https://github.com/python/cpython/pull/132802/files/208f247bdc57e1e2282538a59427edf66e26042e
Objects/unionobject.chttps://github.com/python/cpython/pull/132802/files/208f247bdc57e1e2282538a59427edf66e26042e#diff-380ad8dc72d152f90f027b1f271fb79abbeeb7d683f48e5eb21f33e477456bd0
Please reload this pagehttps://github.com/python/cpython/pull/132802
vstinnerhttps://github.com/vstinner
April 22, 2025 17:19https://github.com/python/cpython/pull/132802#commits-pushed-d81ec9b
https://github.com/vstinner
Add commenthttps://github.com/python/cpython/pull/132802/commits/d81ec9b042be619c55706b77c264cd57c5f56020
d81ec9bhttps://github.com/python/cpython/pull/132802/commits/d81ec9b042be619c55706b77c264cd57c5f56020
https://github.com/vstinner
Add comment about the micro-optimizationhttps://github.com/python/cpython/pull/132802/commits/d93396a177296fe55ff67fbf525b4c607fdddfcf
d93396ahttps://github.com/python/cpython/pull/132802/commits/d93396a177296fe55ff67fbf525b4c607fdddfcf
https://github.com/vstinner
Fix also union_parameters()https://github.com/python/cpython/pull/132802/commits/f12f9055167a09701a964406c98bdaa1ee202b19
f12f905https://github.com/python/cpython/pull/132802/commits/f12f9055167a09701a964406c98bdaa1ee202b19
https://github.com/vstinner
Use FT_ATOMIC to load/store the pointerhttps://github.com/python/cpython/pull/132802/commits/a7b74a36b9a339d11bd103aa94e963234aec5a5c
a7b74a3https://github.com/python/cpython/pull/132802/commits/a7b74a36b9a339d11bd103aa94e963234aec5a5c
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 23, 2025https://github.com/python/cpython/pull/132802#issuecomment-2823273924
Please reload this pagehttps://github.com/python/cpython/pull/132802
vstinnerhttps://github.com/vstinner
April 23, 2025 09:12https://github.com/python/cpython/pull/132802#commits-pushed-27da04d
https://github.com/vstinner
Remove the optimizationhttps://github.com/python/cpython/pull/132802/commits/27da04dec50994f2a2a2b57b258d4c8d9d5ed414
27da04dhttps://github.com/python/cpython/pull/132802/commits/27da04dec50994f2a2a2b57b258d4c8d9d5ed414
https://github.com/vstinner
Remove empty linehttps://github.com/python/cpython/pull/132802/commits/26c9a3298484fcebcf636b10ac5803cdf08be270
26c9a32https://github.com/python/cpython/pull/132802/commits/26c9a3298484fcebcf636b10ac5803cdf08be270
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
Apr 23, 2025 https://github.com/python/cpython/pull/132802#pullrequestreview-2786493876
View reviewed changes https://github.com/python/cpython/pull/132802/files/8eb3cbda6a6069ff04ac397f3d1a7c17b93583ee
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Apr 23, 2025https://github.com/python/cpython/pull/132802#event-17366676087
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Apr 23, 2025 https://github.com/python/cpython/pull/132802#pullrequestreview-2786603104
View reviewed changes https://github.com/python/cpython/pull/132802/files/8eb3cbda6a6069ff04ac397f3d1a7c17b93583ee
https://github.com/vstinner
Merge branch 'main' into union_getitemhttps://github.com/python/cpython/pull/132802/commits/8eb3cbda6a6069ff04ac397f3d1a7c17b93583ee
8eb3cbdhttps://github.com/python/cpython/pull/132802/commits/8eb3cbda6a6069ff04ac397f3d1a7c17b93583ee
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 23, 2025https://github.com/python/cpython/pull/132802#issuecomment-2823840943
Please reload this pagehttps://github.com/python/cpython/pull/132802
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
dc3e963https://github.com/python/cpython/commit/dc3e9638c22fc1fa807a88c32316ac2558a4b879
Apr 23, 2025https://github.com/python/cpython/pull/132802#event-17371589082
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
April 23, 2025 13:45https://github.com/python/cpython/pull/132802#event-17371589645
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Apr 23, 2025https://github.com/python/cpython/pull/132802#event-17371590152
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 23, 2025https://github.com/python/cpython/pull/132802#issuecomment-2824364086
Please reload this pagehttps://github.com/python/cpython/pull/132802
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
Apr 23, 2025https://github.com/python/cpython/pull/132802#event-17371651337
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Apr 23, 2025https://github.com/python/cpython/pull/132802#issuecomment-2824373022
@vstinnerhttps://github.com/vstinner
Please reload this pagehttps://github.com/python/cpython/pull/132802
miss-islingtonhttps://github.com/miss-islington
Apr 23, 2025 https://github.com/python/cpython/pull/132802#ref-commit-4c52ddf
https://github.com/vstinner
https://github.com/miss-islington
pythongh-132713https://github.com/python/cpython/issues/132713
: Fix typing.Union[index] race condition (https://github.com/miss-islington/cpython/commit/4c52ddff6afd1596e8fe8c623252c85a3bbf2c00
pythonGH-132802https://github.com/python/cpython/pull/132802
4c52ddfhttps://github.com/miss-islington/cpython/commit/4c52ddff6afd1596e8fe8c623252c85a3bbf2c00
https://github.com/python/cpython/pull/132802
dc3e963https://github.com/miss-islington/cpython/commit/dc3e9638c22fc1fa807a88c32316ac2558a4b879
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Apr 23, 2025https://github.com/python/cpython/pull/132802#issuecomment-2824373676
GH-132839https://github.com/python/cpython/pull/132839
3.13 branchhttps://github.com/python/cpython/tree/3.13
Please reload this pagehttps://github.com/python/cpython/pull/132802
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
Apr 23, 2025https://github.com/python/cpython/pull/132802#event-17371657262
vstinnerhttps://github.com/vstinner
Apr 23, 2025 https://github.com/python/cpython/pull/132802#ref-commit-341b86e
https://github.com/miss-islington
https://github.com/vstinner
[3.13]https://github.com/python/cpython/commit/341b86e095e59f849c80312ccdb5b70e00fa5216
gh-132713https://github.com/python/cpython/issues/132713
: Fix typing.Union[index] race condition (https://github.com/python/cpython/commit/341b86e095e59f849c80312ccdb5b70e00fa5216
GH-132802https://github.com/python/cpython/pull/132802
) (https://github.com/python/cpython/commit/341b86e095e59f849c80312ccdb5b70e00fa5216
#…https://github.com/python/cpython/pull/132839
341b86ehttps://github.com/python/cpython/commit/341b86e095e59f849c80312ccdb5b70e00fa5216
…132839https://github.com/python/cpython/pull/132839
gh-132713https://github.com/python/cpython/issues/132713
GH-132802https://github.com/python/cpython/pull/132802
dc3e963https://github.com/python/cpython/commit/dc3e9638c22fc1fa807a88c32316ac2558a4b879
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F132802
https://github.com/colesbury
colesbury https://github.com/colesbury
https://github.com/python/cpython/pull/132802/files/d93396a177296fe55ff67fbf525b4c607fdddfcf
https://github.com/JelleZijlstra
JelleZijlstra https://github.com/JelleZijlstra
https://github.com/python/cpython/pull/132802/files/d93396a177296fe55ff67fbf525b4c607fdddfcf
https://github.com/sobolevn
sobolevn https://github.com/sobolevn
https://github.com/python/cpython/pull/132802/files/8eb3cbda6a6069ff04ac397f3d1a7c17b93583ee
https://github.com/kumaraditya303
kumaraditya303 https://github.com/kumaraditya303
https://github.com/python/cpython/pull/132802/files/8eb3cbda6a6069ff04ac397f3d1a7c17b93583ee
Please reload this pagehttps://github.com/python/cpython/pull/132802
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/132802
https://github.com/vstinner
https://github.com/colesbury
https://github.com/JelleZijlstra
https://github.com/sobolevn
https://github.com/kumaraditya303
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.