René's URL Explorer Experiment


Title: gh-132551: make BytesIO object free-thread safe by tom-pytel · Pull Request #132616 · python/cpython · GitHub

Open Graph Title: gh-132551: make BytesIO object free-thread safe by tom-pytel · Pull Request #132616 · python/cpython

X Title: gh-132551: make BytesIO object free-thread safe by tom-pytel · Pull Request #132616 · python/cpython

Description: Full pyperformance suite times (can anyone can suggest better benchmark for BytesIO?): time diff mean stdev GIL -0.01% +- 2.31% noGIL +0.22% +- 2.93% Changes, * functions had critical section added, - not. Atomics were added for exports field: static PyGetSetDef bytesio_getsetlist[] = { * {"closed", bytesio_get_closed, NULL, // @critical_section to avoid make `buf` atomic many places static struct PyMethodDef bytesio_methods[] = { - _IO_BYTESIO_READABLE_METHODDEF - _IO_BYTESIO_SEEKABLE_METHODDEF - _IO_BYTESIO_WRITABLE_METHODDEF * _IO_BYTESIO_CLOSE_METHODDEF - _IO_BYTESIO_FLUSH_METHODDEF - _IO_BYTESIO_ISATTY_METHODDEF * _IO_BYTESIO_TELL_METHODDEF // @critical_section to avoid make `pos` atomic many places * _IO_BYTESIO_WRITE_METHODDEF * _IO_BYTESIO_WRITELINES_METHODDEF * _IO_BYTESIO_READ1_METHODDEF * _IO_BYTESIO_READINTO_METHODDEF * _IO_BYTESIO_READLINE_METHODDEF * _IO_BYTESIO_READLINES_METHODDEF * _IO_BYTESIO_READ_METHODDEF * _IO_BYTESIO_GETBUFFER_METHODDEF * _IO_BYTESIO_GETVALUE_METHODDEF * _IO_BYTESIO_SEEK_METHODDEF // @critical_section to avoid make `pos` atomic many places * _IO_BYTESIO_TRUNCATE_METHODDEF * {"__getstate__", bytesio_getstate, METH_NOARGS, NULL}, * {"__setstate__", bytesio_setstate, METH_O, NULL}, * {"__sizeof__", bytesio_sizeof, METH_NOARGS, NULL}, static PyType_Slot bytesio_slots[] = { - {Py_tp_dealloc, bytesio_dealloc}, - {Py_tp_traverse, bytesio_traverse}, - {Py_tp_clear, bytesio_clear}, - {Py_tp_iter, PyObject_SelfIter}, * {Py_tp_iternext, bytesio_iternext}, * {Py_tp_init, _io_BytesIO___init__}, - {Py_tp_new, bytesio_new}, static PyType_Slot bytesiobuf_slots[] = { - {Py_tp_dealloc, bytesiobuf_dealloc}, - {Py_tp_traverse, bytesiobuf_traverse}, - {Py_bf_getbuffer, bytesiobuf_getbuffer}, - {Py_bf_releasebuffer, bytesiobuf_releasebuffer}, Notes: Opted for critical sections in three functions instead of making buf and or pos atomic everywhere. New test test_free_threading.test_io.TestBytesIO clean under --parallel-threads TSAN. bytesiobuf_getbuffer doesn't need critical sections because as far as I see its only used for BytesIO in bytesio.c where its use is protected by a critical section in _io_BytesIO_getbuffer_impl (its also used for a random non-BytesIO-related test in _testcapimodule.c). Issue: gh-132551

Open Graph Description: Full pyperformance suite times (can anyone can suggest better benchmark for BytesIO?): time diff mean stdev GIL -0.01% +- 2.31% noGIL +0.22% +- 2.93% Changes, * functi...

X Description: Full pyperformance suite times (can anyone can suggest better benchmark for BytesIO?): time diff mean stdev GIL -0.01% +- 2.31% noGIL +0.22% +- 2.93% Changes, * functi...

Opengraph URL: https://github.com/python/cpython/pull/132616

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:374c1e4e-2b4a-f6a2-ba3b-fe344b37eea8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8352:1DC0B7:1285C0F:1940FCF:6A53C74A
html-safe-nonce9031d664e0e1eda5722240d38e6fb8419080968d598cfaa119dba964c576b4e0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MzUyOjFEQzBCNzoxMjg1QzBGOjE5NDBGQ0Y6NkE1M0M3NEEiLCJ2aXNpdG9yX2lkIjoiODM2MzU4NDE3MzY5NzY0ODQ1OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaccddcf4b98b7cb6f161dcc8589efa013cd8dfd8da618ad50fc858706ba07a2960
hovercard-subject-tagpull_request:2464541358
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/132616/files
twitter:imagehttps://avatars.githubusercontent.com/u/51921719?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/51921719?s=400&v=4
og:image:altFull pyperformance suite times (can anyone can suggest better benchmark for BytesIO?): time diff mean stdev GIL -0.01% +- 2.31% noGIL +0.22% +- 2.93% Changes, * functi...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/132616/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F132616%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F132616%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/132616/files
Reloadhttps://github.com/python/cpython/pull/132616/files
Reloadhttps://github.com/python/cpython/pull/132616/files
Please reload this pagehttps://github.com/python/cpython/pull/132616/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/132616/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
kumaraditya303https://github.com/kumaraditya303
python:mainhttps://github.com/python/cpython/tree/main
tom-pytel:fix-issue-132551https://github.com/tom-pytel/cpython/tree/fix-issue-132551
Conversation 38 https://github.com/python/cpython/pull/132616
Commits 13 https://github.com/python/cpython/pull/132616/commits
Checks 4 https://github.com/python/cpython/pull/132616/checks
Files changed https://github.com/python/cpython/pull/132616/files
Please reload this pagehttps://github.com/python/cpython/pull/132616/files
gh-132551: make BytesIO object free-thread safe https://github.com/python/cpython/pull/132616/files#top
Show all changes 13 commits https://github.com/python/cpython/pull/132616/files
a822478 gh-132551: make BytesIO object free-thread safe tom-pytel Apr 16, 2025 https://github.com/python/cpython/pull/132616/commits/a822478132db54427877f6ac3b052acc3558e7a6
b384a71 📜🤖 Added by blurb_it. blurb-it[bot] Apr 16, 2025 https://github.com/python/cpython/pull/132616/commits/b384a71620b3505d8837c23634d8e55b97a3c338
3aa68a4 fix duplicate func in test tom-pytel Apr 16, 2025 https://github.com/python/cpython/pull/132616/commits/3aa68a4c88aaf487625743596c0d31dc6a623d92
e5cd6e9 change SHARED_BUF() to use _PyObject_IsUniquelyReferenced() tom-pytel Apr 17, 2025 https://github.com/python/cpython/pull/132616/commits/e5cd6e9d89564afaca136b96c1249bf8e2dfe18a
605c2ad remove dummies from _lock_held functions tom-pytel Apr 17, 2025 https://github.com/python/cpython/pull/132616/commits/605c2adb41d81b7050a183d3088fa9e486c8c7f4
a4105c9 Merge branch 'main' into fix-issue-132551 tom-pytel Apr 23, 2025 https://github.com/python/cpython/pull/132616/commits/a4105c9523a628a5a6056c5027fedc9d77f02c20
061aa02 Merge branch 'main' into fix-issue-132551 tom-pytel May 2, 2025 https://github.com/python/cpython/pull/132616/commits/061aa025f3b0015b1313874a9f7e3482f2a80f17
af5b63c add lock held assertions tom-pytel May 8, 2025 https://github.com/python/cpython/pull/132616/commits/af5b63cece90020de8efdb14e7592dba8caf5378
858b668 add critical section to bytesiobuf_getbuffer() tom-pytel May 8, 2025 https://github.com/python/cpython/pull/132616/commits/858b668fad8d1b56b3122ed616cdc7bbfbf07c4a
35f3b8e fix GIL build, add lock held assertions tom-pytel May 8, 2025 https://github.com/python/cpython/pull/132616/commits/35f3b8eb0bed46eb6120c55b06958459ed5d5d47
f88e436 add (void)b to shut up warning as error tom-pytel May 8, 2025 https://github.com/python/cpython/pull/132616/commits/f88e43610437b6ce77aa2e04f0f1e11f0c690a5c
215687f Update Modules/_io/bytesio.c kumaraditya303 May 8, 2025 https://github.com/python/cpython/pull/132616/commits/215687f0720ff32d8d90d9b6abbb373b99b8e14b
9a16845 Update Modules/_io/bytesio.c kumaraditya303 May 8, 2025 https://github.com/python/cpython/pull/132616/commits/9a168450a0aea519b95e5cb8135bdc48d3654a94
Clear filters https://github.com/python/cpython/pull/132616/files
Please reload this pagehttps://github.com/python/cpython/pull/132616/files
Please reload this pagehttps://github.com/python/cpython/pull/132616/files
test_io.py https://github.com/python/cpython/pull/132616/files#diff-bf1f83ccd2a3dfa0660824e2d685f4980d59e08e094ea0d88d08b074b70bd52d
2025-04-16-21-02-57.gh-issue-132551.Psa7pL.rst https://github.com/python/cpython/pull/132616/files#diff-4d9292ed3e941d442654e3eda805a9694a5d622c61952b54f7665de51bba51fc
bytesio.c https://github.com/python/cpython/pull/132616/files#diff-fbdbc4e9c4c46bb4d0afb3927ea0ba919e62c1a79c390aa695a50fc317e48e09
bytesio.c.h https://github.com/python/cpython/pull/132616/files#diff-911b08697dbf4065002832267252cc88474bf15e45fbe5d8464fcdf1ae566f86
Lib/test/test_free_threading/test_io.pyhttps://github.com/python/cpython/pull/132616/files#diff-bf1f83ccd2a3dfa0660824e2d685f4980d59e08e094ea0d88d08b074b70bd52d
View file https://github.com/tom-pytel/cpython/blob/9a168450a0aea519b95e5cb8135bdc48d3654a94/Lib/test/test_free_threading/test_io.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/132616/{{ revealButtonHref }}
Misc/NEWS.d/next/Library/2025-04-16-21-02-57.gh-issue-132551.Psa7pL.rsthttps://github.com/python/cpython/pull/132616/files#diff-4d9292ed3e941d442654e3eda805a9694a5d622c61952b54f7665de51bba51fc
View file https://github.com/tom-pytel/cpython/blob/9a168450a0aea519b95e5cb8135bdc48d3654a94/Misc/NEWS.d/next/Library/2025-04-16-21-02-57.gh-issue-132551.Psa7pL.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/132616/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/132616/files
Please reload this pagehttps://github.com/python/cpython/pull/132616/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.