| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:c09bdd2e-7c92-6c24-a1fe-1f0b103791a4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9BD0:115F21:469E83:5DAB1F:696B6C19 |
| html-safe-nonce | 268e9a7289e5d98ca4dd83bb380d8f7a54eea478e29a7930ef5627ccce6a88c1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QkQwOjExNUYyMTo0NjlFODM6NURBQjFGOjY5NkI2QzE5IiwidmlzaXRvcl9pZCI6IjI4ODg0MTkxNjUzNTUwNzY2MzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | d29afe33a6e29d92074680d6e6429fa3726a92412726844aac616ecb5c8f703b |
| hovercard-subject-tag | pull_request:2456552764 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/132490/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c307479bebd632d8ba04b7c22ee27ee00ad19ccf28410fe315a80649622f9b9a/python/cpython/pull/132490 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c307479bebd632d8ba04b7c22ee27ee00ad19ccf28410fe315a80649622f9b9a/python/cpython/pull/132490 |
| og:image:alt | As noted on the issue, making get_annotate_function() support both types and
mappings is problematic because one object may be both. So let's add a new one
that works with any mapping.
This lea... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | JelleZijlstra |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/132490#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F132490 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F132490 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/132490 |
| Reload | https://github.com/python/cpython/pull/132490 |
| Reload | https://github.com/python/cpython/pull/132490 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/132490 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/132490 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/132490#issue-comment-box |
| JelleZijlstra | https://github.com/JelleZijlstra |
| python:main | https://github.com/python/cpython/tree/main |
| JelleZijlstra:getannofunc | https://github.com/JelleZijlstra/cpython/tree/getannofunc |
|
gh-132426: Add get_annotate_from_class_namespace replacing get_annotate_function
| https://github.com/python/cpython/pull/132490#top |
| JelleZijlstra | https://github.com/JelleZijlstra |
| python:main | https://github.com/python/cpython/tree/main |
| JelleZijlstra:getannofunc | https://github.com/JelleZijlstra/cpython/tree/getannofunc |
|
Conversation
6
| https://github.com/python/cpython/pull/132490 |
|
Commits
4
| https://github.com/python/cpython/pull/132490/commits |
|
Checks
37
| https://github.com/python/cpython/pull/132490/checks |
|
Files changed
| https://github.com/python/cpython/pull/132490/files |
| Please reload this page | https://github.com/python/cpython/pull/132490 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
| Apr 14, 2025 | https://github.com/python/cpython/pull/132490#issue-2991827755 |
| Please reload this page | https://github.com/python/cpython/pull/132490 |
| annotationlib: namespace can be non-dict #132426 | https://github.com/python/cpython/issues/132426 |
| https://cpython-previews--132490.org.readthedocs.build/ | https://cpython-previews--132490.org.readthedocs.build/ |
| Please reload this page | https://github.com/python/cpython/pull/132490 |
|
| https://github.com/JelleZijlstra |
| pythongh-132426 | https://github.com/python/cpython/issues/132426 |
| : Add get_annotate_from_class_namespace replacing get_… | https://github.com/python/cpython/pull/132490/commits/c320bce6b332bca6f124a53478bb3fd456566d58 |
| c320bce | https://github.com/python/cpython/pull/132490/commits/c320bce6b332bca6f124a53478bb3fd456566d58 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
| AA-Turner | https://github.com/AA-Turner |
| AlexWaygood | https://github.com/AlexWaygood |
| willingc | https://github.com/willingc |
| code owners | https://github.com/python/cpython/blob/ccad61e35d240972d14f993507566706fbf419f1/.github/CODEOWNERS#L309 |
| April 14, 2025 04:12 | https://github.com/python/cpython/pull/132490#event-17241532581 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Apr 14, 2025 | https://github.com/python/cpython/pull/132490#event-17241532863 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
Apr 14, 2025
| https://github.com/python/cpython/pull/132490#ref-issue-2990344359 |
|
annotationlib: namespace can be non-dict
#132426
| https://github.com/python/cpython/issues/132426 |
| JelleZijlstra | https://github.com/JelleZijlstra |
| April 13, 2025 21:15 | https://github.com/python/cpython/pull/132490#commits-pushed-cddee44 |
|
| https://github.com/JelleZijlstra |
| update more docs | https://github.com/python/cpython/pull/132490/commits/cddee44a8005343817a89d9ffe2ec543b4551ec2 |
| cddee44 | https://github.com/python/cpython/pull/132490/commits/cddee44a8005343817a89d9ffe2ec543b4551ec2 |
|
| https://github.com/JelleZijlstra |
| Merge branch 'main' into getannofunc | https://github.com/python/cpython/pull/132490/commits/730daa15909e1522cba95536c4baaea2d750a537 |
| 730daa1 | https://github.com/python/cpython/pull/132490/commits/730daa15909e1522cba95536c4baaea2d750a537 |
| https://github.com/AA-Turner |
| AA-Turner | https://github.com/AA-Turner |
|
Apr 17, 2025
| https://github.com/python/cpython/pull/132490#pullrequestreview-2774382606 |
|
View reviewed changes
| https://github.com/python/cpython/pull/132490/files/730daa15909e1522cba95536c4baaea2d750a537 |
| AA-Turner | https://github.com/AA-Turner |
| https://github.com/python/cpython/pull/132490#pullrequestreview-2774382606 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/132490 |
| Doc/reference/datamodel.rst | https://github.com/python/cpython/pull/132490/files/730daa15909e1522cba95536c4baaea2d750a537#diff-9125871b063a1ef80aa4bd3e46d7060921032c8437160c7cb8c1497756b02d61 |
| Please reload this page | https://github.com/python/cpython/pull/132490 |
| Doc/library/annotationlib.rst | https://github.com/python/cpython/pull/132490/files/730daa15909e1522cba95536c4baaea2d750a537#diff-550a080d8f99ab6fe327e9db925c4515e3cbda2d008bc528634c850c61059ed8 |
| AA-Turner | https://github.com/AA-Turner |
| Apr 17, 2025 | https://github.com/python/cpython/pull/132490#discussion_r2048108277 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/132490 |
| JelleZijlstra | https://github.com/JelleZijlstra |
| Apr 17, 2025 | https://github.com/python/cpython/pull/132490#discussion_r2049325301 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/132490 |
| AA-Turner | https://github.com/AA-Turner |
| May 4, 2025 | https://github.com/python/cpython/pull/132490#discussion_r2072650108 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/132490 |
| Doc/library/annotationlib.rst | https://github.com/python/cpython/pull/132490/files/730daa15909e1522cba95536c4baaea2d750a537#diff-550a080d8f99ab6fe327e9db925c4515e3cbda2d008bc528634c850c61059ed8 |
| Please reload this page | https://github.com/python/cpython/pull/132490 |
|
| https://github.com/JelleZijlstra |
| reword docs, thanks Adam | https://github.com/python/cpython/pull/132490/commits/e9fd0ebaaeed6721e65536b08b2b70a6f28f805e |
| e9fd0eb | https://github.com/python/cpython/pull/132490/commits/e9fd0ebaaeed6721e65536b08b2b70a6f28f805e |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
| 7cb86c5 | https://github.com/python/cpython/commit/7cb86c5defa17147c67b56c4227e74e4c5968686 |
| May 4, 2025 | https://github.com/python/cpython/pull/132490#event-17510633407 |
| Please reload this page | https://github.com/python/cpython/pull/132490 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| May 4, 2025 | https://github.com/python/cpython/pull/132490#event-17510633505 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
| May 4, 2025 14:26 | https://github.com/python/cpython/pull/132490#event-17510633625 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
|
May 4, 2025
| https://github.com/python/cpython/pull/132490#ref-pullrequest-2990346435 |
|
gh-132426: get_annotate_function vs. mapping namespaces
#132427
| https://github.com/python/cpython/pull/132427 |
| diegorusso | https://github.com/diegorusso |
|
May 4, 2025
| https://github.com/python/cpython/pull/132490#ref-commit-c03babc |
|
| https://github.com/diegorusso |
| Merge remote-tracking branch 'origin/main' into call-len | https://github.com/diegorusso/cpython/commit/c03babc6a588ef8b05b58f3d31c8bda9b0469760 |
| c03babc | https://github.com/diegorusso/cpython/commit/c03babc6a588ef8b05b58f3d31c8bda9b0469760 |
| pythongh-91048 | https://github.com/python/cpython/issues/91048 |
| pythonGH-133385 | https://github.com/python/cpython/pull/133385 |
| pythongh-131178 | https://github.com/python/cpython/issues/131178 |
| python#133329 | https://github.com/python/cpython/pull/133329 |
| python#133394 | https://github.com/python/cpython/pull/133394 |
| pythongh-133042 | https://github.com/python/cpython/issues/133042 |
| python#133064 | https://github.com/python/cpython/pull/133064 |
| pythongh-133351 | https://github.com/python/cpython/issues/133351 |
| python#133387 | https://github.com/python/cpython/pull/133387 |
| pythongh-109700 | https://github.com/python/cpython/issues/109700 |
| pythonGH-109946 | https://github.com/python/cpython/pull/109946 |
| pythongh-81793 | https://github.com/python/cpython/issues/81793 |
| pythonGH-133388 | https://github.com/python/cpython/pull/133388 |
| pythongh-126835 | https://github.com/python/cpython/issues/126835 |
| python#131830 | https://github.com/python/cpython/pull/131830 |
| pythongh-91048 | https://github.com/python/cpython/issues/91048 |
| python#133368 | https://github.com/python/cpython/pull/133368 |
| pythongh-132457 | https://github.com/python/cpython/issues/132457 |
| python#132460 | https://github.com/python/cpython/pull/132460 |
| pythongh-132805 | https://github.com/python/cpython/issues/132805 |
| python#132812 | https://github.com/python/cpython/pull/132812 |
| pythongh-132426 | https://github.com/python/cpython/issues/132426 |
| python#132490 | https://github.com/python/cpython/pull/132490 |
| pythongh-81793 | https://github.com/python/cpython/issues/81793 |
| pythonGH-132517 | https://github.com/python/cpython/pull/132517 |
| pythongh-122559 | https://github.com/python/cpython/issues/122559 |
| pythonGH-122628 | https://github.com/python/cpython/pull/122628 |
| pythongh-69605 | https://github.com/python/cpython/issues/69605 |
| python#133358 | https://github.com/python/cpython/pull/133358 |
| pythonGH-26226 | https://github.com/python/cpython/pull/26226 |
| pythonGH-133231 | https://github.com/python/cpython/issues/133231 |
| pythonGH-133287 | https://github.com/python/cpython/pull/133287 |
| pythongh-133363 | https://github.com/python/cpython/issues/133363 |
| python#133364 | https://github.com/python/cpython/pull/133364 |
| pythongh-132983 | https://github.com/python/cpython/issues/132983 |
| pythonGH-133027 | https://github.com/python/cpython/pull/133027 |
| pythonGH-91048 | https://github.com/python/cpython/issues/91048 |
| python#133284 | https://github.com/python/cpython/pull/133284 |
| Pranjal095 | https://github.com/Pranjal095 |
|
Jul 12, 2025
| https://github.com/python/cpython/pull/132490#ref-commit-1b84635 |
|
| https://github.com/JelleZijlstra |
|
| https://github.com/Pranjal095 |
| pythongh-132426 | https://github.com/python/cpython/issues/132426 |
| : Add get_annotate_from_class_namespace replacing get_… | https://github.com/Pranjal095/cpython/commit/1b84635f5deb53a6bf7fdd05e048b7a899a4eab3 |
| 1b84635 | https://github.com/Pranjal095/cpython/commit/1b84635f5deb53a6bf7fdd05e048b7a899a4eab3 |
| python#132490 | https://github.com/python/cpython/pull/132490 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F132490 |
|
| https://github.com/AA-Turner |
|
AA-Turner
| https://github.com/AA-Turner |
|
| https://github.com/python/cpython/pull/132490/files/e9fd0ebaaeed6721e65536b08b2b70a6f28f805e |
|
| https://github.com/willingc |
|
willingc
| https://github.com/willingc |
|
| https://github.com/AlexWaygood |
|
AlexWaygood
| https://github.com/AlexWaygood |
| Please reload this page | https://github.com/python/cpython/pull/132490 |
|
| https://github.com/JelleZijlstra |
|
| https://github.com/AA-Turner |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |