René's URL Explorer Experiment


Title: gh-91153: Fix bytearray holding a reference to its internal buffer when calling into potentially mutating __index__ methods by bast0006 · Pull Request #132379 · python/cpython · GitHub

Open Graph Title: gh-91153: Fix bytearray holding a reference to its internal buffer when calling into potentially mutating __index__ methods by bast0006 · Pull Request #132379 · python/cpython

X Title: gh-91153: Fix bytearray holding a reference to its internal buffer when calling into potentially mutating __index__ methods by bast0006 · Pull Request #132379 · python/cpython

Description: bytearray's __setitem__ implementation currently grabs a reference to its internal buffer before calling _getbyvalue to determine the index that needs assignment. _getbyvalue can call into arbitrary python code via __index__ dunders, which could alter the internal buffer and leave said reference dangling. A prior fix for this issue ensures that bounds checking occurs after _getbyvalue is called. However, python code is capable of resizing the bytearray, resulting in limited but still broken behavior. This patch ensures that the reference to the internal buffer is fetched only after _getbyvalue is called to prevent it from being held while any python code is run. Issue: gh-91153

Open Graph Description: bytearray's __setitem__ implementation currently grabs a reference to its internal buffer before calling _getbyvalue to determine the index that needs assignment. _getbyvalue can call into arbi...

X Description: bytearray's __setitem__ implementation currently grabs a reference to its internal buffer before calling _getbyvalue to determine the index that needs assignment. _getbyvalue can call into ...

Opengraph URL: https://github.com/python/cpython/pull/132379

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7ccca230-db6e-9e73-272a-9edc23d9600f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id903C:224815:3D4766:500C30:6B025862
html-safe-noncee47f962f11c9b426dbbd3cc909cb83b610ea523b1b53a004662f16a965f634f4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDNDOjIyNDgxNTozRDQ3NjY6NTAwQzMwOjZCMDI1ODYyIiwidmlzaXRvcl9pZCI6IjQ2MTM1ODk2NjEzOTc0NDA2MTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacae6e33893ccc82e0f22a33fa78182326ddddda8aa980a73b409819a48b1de2c4
hovercard-subject-tagpull_request:2452217170
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/132379/files
twitter:imagehttps://avatars.githubusercontent.com/u/52266665?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/52266665?s=400&v=4
og:image:altbytearray's __setitem__ implementation currently grabs a reference to its internal buffer before calling _getbyvalue to determine the index that needs assignment. _getbyvalue can call into arbi...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/132379/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F132379%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F132379%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/132379/files
Reloadhttps://github.com/python/cpython/pull/132379/files
Reloadhttps://github.com/python/cpython/pull/132379/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
picnixzhttps://github.com/picnixz
python:mainhttps://github.com/python/cpython/tree/main
bast0006:bast0006/gh-91153https://github.com/bast0006/cpython/tree/bast0006/gh-91153
Conversation 27 https://github.com/python/cpython/pull/132379
Commits 9 https://github.com/python/cpython/pull/132379/commits
Checks 0 https://github.com/python/cpython/pull/132379/checks
Files changed https://github.com/python/cpython/pull/132379/files
Please reload this pagehttps://github.com/python/cpython/pull/132379/files
gh-91153: Fix bytearray holding a reference to its internal buffer when calling into potentially mutating __index__ methods https://github.com/python/cpython/pull/132379/files#top
Show all changes 9 commits https://github.com/python/cpython/pull/132379/files
71ae212 GH-91153: Handle _getbytevalue potentially invalidating bytearray all… bast0006 Mar 29, 2025 https://github.com/python/cpython/pull/132379/commits/71ae2125197bcc791c7d6e7b45c097dd4bd81618
b2f7df5 GH-91153: Add additional cases to `test_mutating_index` bast0006 Apr 10, 2025 https://github.com/python/cpython/pull/132379/commits/b2f7df50850f78e3f6bdbe6dbdb7f93f71661acf
bb96c2a GH-91153: Move mutating index bytearray test to it's own separate test bast0006 May 17, 2025 https://github.com/python/cpython/pull/132379/commits/bb96c2a57ea7132c170b306c84bc9bbbb0307610
d29422b GH-91153: add news entry bast0006 May 17, 2025 https://github.com/python/cpython/pull/132379/commits/d29422b98873355cbf601e772a95f3ff516c062c
d3d1974 Nit cleanup bast0006 May 18, 2025 https://github.com/python/cpython/pull/132379/commits/d3d19747e5257f4d8406270361951ec57a89fa48
18e6597 GH-91153: Fixup comments and NEWS entry bast0006 Jun 3, 2025 https://github.com/python/cpython/pull/132379/commits/18e6597b9eac8d8f0e9ef1bbd617a68e0bd777b3
4b7ec9c GH-91153: Add short clarifying comments to test bast0006 Jun 3, 2025 https://github.com/python/cpython/pull/132379/commits/4b7ec9cb909770251e28ecf851dbad5a6b2fa351
9b28503 Merge branch 'main' into bast0006/gh-91153 picnixz Jul 12, 2025 https://github.com/python/cpython/pull/132379/commits/9b285036d64204160f883f5339adf8ae7405f599
970c1ad Apply suggestions from code review picnixz Jul 12, 2025 https://github.com/python/cpython/pull/132379/commits/970c1ad51e85523917e898e147dcce738e161157
Clear filters https://github.com/python/cpython/pull/132379/files
Please reload this pagehttps://github.com/python/cpython/pull/132379/files
Please reload this pagehttps://github.com/python/cpython/pull/132379/files
test_bytes.py https://github.com/python/cpython/pull/132379/files#diff-58df2535f64e3dcfb0677a7f543924d976fd982b595f8e34902a73f3deae40eb
2025-05-17-20-56-05.gh-issue-91153.afgtG2.rst https://github.com/python/cpython/pull/132379/files#diff-512e597f198487e9eecd84f70175c069e46a9bcf991cabf0c4c6c23849b95466
bytearrayobject.c https://github.com/python/cpython/pull/132379/files#diff-6878f29bbfb711dc7cd2a89b2b2941b1f900b6367d30181a2ff45460b591b04c
Lib/test/test_bytes.pyhttps://github.com/python/cpython/pull/132379/files#diff-58df2535f64e3dcfb0677a7f543924d976fd982b595f8e34902a73f3deae40eb
View file https://github.com/bast0006/cpython/blob/970c1ad51e85523917e898e147dcce738e161157/Lib/test/test_bytes.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/132379/{{ revealButtonHref }}
https://github.com/python/cpython/pull/132379/files#diff-58df2535f64e3dcfb0677a7f543924d976fd982b595f8e34902a73f3deae40eb
https://github.com/python/cpython/pull/132379/files#diff-58df2535f64e3dcfb0677a7f543924d976fd982b595f8e34902a73f3deae40eb
Please reload this pagehttps://github.com/python/cpython/pull/132379/files
https://github.com/python/cpython/pull/132379/files#diff-58df2535f64e3dcfb0677a7f543924d976fd982b595f8e34902a73f3deae40eb
Misc/NEWS.d/next/Core_and_Builtins/2025-05-17-20-56-05.gh-issue-91153.afgtG2.rsthttps://github.com/python/cpython/pull/132379/files#diff-512e597f198487e9eecd84f70175c069e46a9bcf991cabf0c4c6c23849b95466
View file https://github.com/bast0006/cpython/blob/970c1ad51e85523917e898e147dcce738e161157/Misc/NEWS.d/next/Core_and_Builtins/2025-05-17-20-56-05.gh-issue-91153.afgtG2.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/132379/{{ revealButtonHref }}
Objects/bytearrayobject.chttps://github.com/python/cpython/pull/132379/files#diff-6878f29bbfb711dc7cd2a89b2b2941b1f900b6367d30181a2ff45460b591b04c
View file https://github.com/bast0006/cpython/blob/970c1ad51e85523917e898e147dcce738e161157/Objects/bytearrayobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/132379/{{ revealButtonHref }}
https://github.com/python/cpython/pull/132379/files#diff-6878f29bbfb711dc7cd2a89b2b2941b1f900b6367d30181a2ff45460b591b04c
Please reload this pagehttps://github.com/python/cpython/pull/132379/files
https://github.com/python/cpython/pull/132379/files#diff-6878f29bbfb711dc7cd2a89b2b2941b1f900b6367d30181a2ff45460b591b04c
https://github.com/python/cpython/pull/132379/files#diff-6878f29bbfb711dc7cd2a89b2b2941b1f900b6367d30181a2ff45460b591b04c
https://github.com/python/cpython/pull/132379/files#diff-6878f29bbfb711dc7cd2a89b2b2941b1f900b6367d30181a2ff45460b591b04c
https://github.com/python/cpython/pull/132379/files#diff-6878f29bbfb711dc7cd2a89b2b2941b1f900b6367d30181a2ff45460b591b04c
https://github.com/python/cpython/pull/132379/files#diff-6878f29bbfb711dc7cd2a89b2b2941b1f900b6367d30181a2ff45460b591b04c
https://github.com/python/cpython/pull/132379/files#diff-6878f29bbfb711dc7cd2a89b2b2941b1f900b6367d30181a2ff45460b591b04c
https://github.com/python/cpython/pull/132379/files#diff-6878f29bbfb711dc7cd2a89b2b2941b1f900b6367d30181a2ff45460b591b04c
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.