René's URL Explorer Experiment


Title: gh-129987: Disable GCC SLP autovectorization for the interpreter loop on x86-64 by mpage · Pull Request #132295 · python/cpython · GitHub

Open Graph Title: gh-129987: Disable GCC SLP autovectorization for the interpreter loop on x86-64 by mpage · Pull Request #132295 · python/cpython

X Title: gh-129987: Disable GCC SLP autovectorization for the interpreter loop on x86-64 by mpage · Pull Request #132295 · python/cpython

Description: #131750 mysteriously caused a ~6% regression for the free-threaded build. The cause was poor code generation of opcode dispatch in the interpreter loop. Before the change the dispatch code looked like: /root/src/cpython/Python/generated_cases.c.h:8808 [LOAD_FAST_BORROW] DISPATCH(); 19cd0a: mov -0x268(%rbp),%rsi 19cd11: movzbl %ah,�x 19cd14: movzbl %al,�x 19cd17: mov �x,%r10d 19cd1a: jmp *(%rsi,%rax,8) After the change, the dispatch code looked like: # Shared dispatch code /root/src/cpython/Python/generated_cases.c.h:81 [BINARY_OP] DISPATCH(); 19dd67: mov -0x280(%rbp),%r10 19dd6e: movzbl %ah,�x 19dd71: movzbl %al,�x 19dd74: mov �x,%r14d 19dd77: mov -0x270(%rbp),%rcx 19dd7e: mov (%rcx,%rax,8),%rdx 19dd82: nopw 0x0(%rax,%rax,1) 19dd88: movq -0x258(%rbp),%xmm0 19dd90: movq %r12,%xmm4 19dd95: punpcklqdq %xmm4,%xmm0 19dd99: movhlps %xmm0,%xmm3 19dd9c: movq %xmm0,%r15 19dda1: movq %xmm3,%r11 19dda6: mov %r11,%rcx 19dda9: jmp *%rdx # Duplicated dispatch code /root/src/cpython/Python/generated_cases.c.h:8808 [LOAD_FAST_BORROW] DISPATCH(); 19dde4: movzbl %ah,�x 19dde7: movzbl %al,�x 19ddea: mov �x,%r14d 19dded: mov -0x270(%rbp),%rcx 19ddf4: mov (%rcx,%rax,8),%rdx 19ddf8: jmp 19dd99 <_PyEval_EvalFrameDefault+0x289> There are two problems: We now have two jumps (one direct jump to the shared dispatch logic and one indirect jump to the next opcode handler) instead of one (the indirect jump to the opcode handler). There's a significant amount of register shuffling in the shared dispatch code. Both of these problems appear to be caused by GCC's SLP autovectorizer. After the change, it decides to store both the next_instr pointer and the stack_pointer in a single 128 bit register in the shared basic block that contains the opcode dispatch. This is introduced in the slp1 pass (tree dump below): _24061 = VIEW_CONVERT_EXPR(stack_pointer_14587); _24062 = VIEW_CONVERT_EXPR(next_instr_14097); _24063 = {_24062, _24061}; [count: 1658034300]: # frame_2363(ab) = PHI # oparg_1245(ab) = PHI # next_instr_1246(ab) = PHI # stack_pointer_2976(ab) = PHI # _3209 = PHI <_20217(4258), _20681(18)> # # Combination of next_instr and stack_pointer: # # vect_next_instr_1246.7061_24064 = PHI _24067 = BIT_FIELD_REF ; _24068(ab) = (union _PyStackRef *) _24067; _24065 = BIT_FIELD_REF ; _24066(ab) = (union _Py_CODEUNIT *) _24065; # DEBUG stack_pointer => stack_pointer_2976(ab) # DEBUG next_instr => next_instr_1246(ab) # DEBUG oparg => oparg_1245(ab) # DEBUG frame => frame_2363(ab) goto _3209; Disabling the SLP autovectorization pass for the interpreter loop fixes both problems. After this change the opcode dispatch code looks like: /root/src/cpython/Python/generated_cases.c.h:8808 [LOAD_FAST_BORROW] DISPATCH(); 19aa37: mov -0x260(%rbp),%rsi 19aa3e: movzbl %ah,�x 19aa41: movzbl %al,�x 19aa44: movslq �x,%r15 19aa47: jmp *(%rsi,%rax,8) Performance improves by ~8% for the free-threaded build. Surprisingly, this also seems to improve performance for the default build by ~4%. I don't understand why and I don't fully trust the result. The generated dispatch code for the default build looks unaffected by this change. Additionally, measuring instructions retired using fastbench shows a negligible change, whereas it shows a ~8% reduction for the free-threaded build. Issue: gh-129987

Open Graph Description: #131750 mysteriously caused a ~6% regression for the free-threaded build. The cause was poor code generation of opcode dispatch in the interpreter loop. Before the change the dispatch code looked l...

X Description: #131750 mysteriously caused a ~6% regression for the free-threaded build. The cause was poor code generation of opcode dispatch in the interpreter loop. Before the change the dispatch code looked l...

Opengraph URL: https://github.com/python/cpython/pull/132295

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d6ade225-68bd-90fc-c61b-fa6b91e59b27
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8134:38E318:3D80305:4DB093A:6B0241E2
html-safe-nonce082b54054ca547633c11452319b2ae9f4b987f644887ab11df209946ec49c095
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTM0OjM4RTMxODozRDgwMzA1OjREQjA5M0E6NkIwMjQxRTIiLCJ2aXNpdG9yX2lkIjoiMTUzOTU4NDIxNjg5OTQyNDk4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4d4523da4dd375a8846d7a536bae08fee8cb3be74bc4aaa10455ec6cff48ba41
hovercard-subject-tagpull_request:2447154180
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/132295/files
twitter:imagehttps://avatars.githubusercontent.com/u/577841?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/577841?s=400&v=4
og:image:alt#131750 mysteriously caused a ~6% regression for the free-threaded build. The cause was poor code generation of opcode dispatch in the interpreter loop. Before the change the dispatch code looked l...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/132295/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F132295%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F132295%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/132295/files
Reloadhttps://github.com/python/cpython/pull/132295/files
Reloadhttps://github.com/python/cpython/pull/132295/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
mpagehttps://github.com/mpage
python:mainhttps://github.com/python/cpython/tree/main
mpage:gh-129987-no-slp-vectorizehttps://github.com/mpage/cpython/tree/gh-129987-no-slp-vectorize
Conversation 3 https://github.com/python/cpython/pull/132295
Commits 1 https://github.com/python/cpython/pull/132295/commits
Checks 0 https://github.com/python/cpython/pull/132295/checks
Files changed https://github.com/python/cpython/pull/132295/files
Please reload this pagehttps://github.com/python/cpython/pull/132295/files
gh-129987: Disable GCC SLP autovectorization for the interpreter loop on x86-64 https://github.com/python/cpython/pull/132295/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/132295/files
45cd786 Disable GCC SLP autovectorization for the interpreter loop on x86-64 mpage Apr 8, 2025 https://github.com/python/cpython/pull/132295/commits/45cd78643d8a874fb30047ea2448c979638d8ed8
Clear filters https://github.com/python/cpython/pull/132295/files
Please reload this pagehttps://github.com/python/cpython/pull/132295/files
Please reload this pagehttps://github.com/python/cpython/pull/132295/files
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L223
Python/ceval.chttps://github.com/python/cpython/pull/132295/files#diff-c22186367cbe20233e843261998dc027ae5f1f8c0d2e778abfa454ae74cc59de
View file https://github.com/mpage/cpython/blob/45cd78643d8a874fb30047ea2448c979638d8ed8/Python/ceval.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/132295/{{ revealButtonHref }}
https://github.com/python/cpython/pull/132295/files#diff-c22186367cbe20233e843261998dc027ae5f1f8c0d2e778abfa454ae74cc59de
https://github.com/python/cpython/pull/132295/files#diff-c22186367cbe20233e843261998dc027ae5f1f8c0d2e778abfa454ae74cc59de
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.