René's URL Explorer Experiment


Title: bpo-36865: allow 'rt' mode in FileInput by natgaertner · Pull Request #13221 · python/cpython · GitHub

Open Graph Title: bpo-36865: allow 'rt' mode in FileInput by natgaertner · Pull Request #13221 · python/cpython

X Title: bpo-36865: allow 'rt' mode in FileInput by natgaertner · Pull Request #13221 · python/cpython

Description: The FileInput class (https://github.com/python/cpython/blob/master/Lib/fileinput.py) delegates to the open function, gzip, or bz2. Each of these delegates supports the 'rt' mode flag, so FileInput can probably support it as well. This might clear up some confusion as in https://bugs.python.org/issue5758, which, in accordance with the FileInput docs, assumes all files opened with the 'r' flag will be opened in text mode. For gzip and bz2 this is not the case, they will be opened in binary 'rb' mode. This pull request adds the 'rt' mode to the allowed modes, expands the unit test for FileInput to test opening with all allowed modes, and makes the documentation in FileInput about the behavior of the 'r' flag more accurate. https://bugs.python.org/issue36865

Open Graph Description: The FileInput class (https://github.com/python/cpython/blob/master/Lib/fileinput.py) delegates to the open function, gzip, or bz2. Each of these delegates supports the 'rt' mode flag, so Fi...

X Description: The FileInput class (https://github.com/python/cpython/blob/master/Lib/fileinput.py) delegates to the open function, gzip, or bz2. Each of these delegates supports the 'rt' mode fla...

Opengraph URL: https://github.com/python/cpython/pull/13221

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ee5e6379-765f-ce6d-e03b-301fd91e0f9d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCE2A:2BC60D:E46D47:148B593:6A58B6BF
html-safe-nonce85ce89ec70bd87e059c530f146959dd10c7ddb4883141680ea95e30cc3321755
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRTJBOjJCQzYwRDpFNDZENDc6MTQ4QjU5Mzo2QTU4QjZCRiIsInZpc2l0b3JfaWQiOiI0NjkwMjUyODU2MjI5OTM0NzgzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac54e47acc058781389ae79fe1337f8eb27c4ffb64c965eb6bb1b3b14fe0cc45ed
hovercard-subject-tagpull_request:277479309
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/13221/files
twitter:imagehttps://avatars.githubusercontent.com/u/1240870?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1240870?s=400&v=4
og:image:altThe FileInput class (https://github.com/python/cpython/blob/master/Lib/fileinput.py) delegates to the open function, gzip, or bz2. Each of these delegates supports the 'rt' mode flag, so Fi...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f2a0c7865178af3d91dd9f13b0cdfc3c73a2529c873d2780bb4c01271a57ec6
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8aae7b8d6caacacf5c66eaeb2702d8dc88d85b4a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/13221/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13221%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13221%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/13221/files
Reloadhttps://github.com/python/cpython/pull/13221/files
Reloadhttps://github.com/python/cpython/pull/13221/files
Please reload this pagehttps://github.com/python/cpython/pull/13221/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/13221/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
natgaertnerhttps://github.com/natgaertner
python:masterhttps://github.com/python/cpython/tree/master
natgaertner:add-rt-to-fileinputhttps://github.com/natgaertner/cpython/tree/add-rt-to-fileinput
Conversation 4 https://github.com/python/cpython/pull/13221
Commits 1 https://github.com/python/cpython/pull/13221/commits
Checks 0 https://github.com/python/cpython/pull/13221/checks
Files changed https://github.com/python/cpython/pull/13221/files
Please reload this pagehttps://github.com/python/cpython/pull/13221/files
bpo-36865: allow 'rt' mode in FileInput https://github.com/python/cpython/pull/13221/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/13221/files
6cd1ae7 bpo-36865: allow 'rt' mode in FileInput natgaertner May 9, 2019 https://github.com/python/cpython/pull/13221/commits/6cd1ae72f1c4a13da913f0c1c1de9759243adb31
Clear filters https://github.com/python/cpython/pull/13221/files
Please reload this pagehttps://github.com/python/cpython/pull/13221/files
Please reload this pagehttps://github.com/python/cpython/pull/13221/files
fileinput.rst https://github.com/python/cpython/pull/13221/files#diff-614040aa0aa44d250bec985f117dde17adffb8d47c176784e0cc775e48d004a5
fileinput.py https://github.com/python/cpython/pull/13221/files#diff-12e480fbf7f53af3020ff003894175735fffdc263ba9680dde66de17c6abcdff
test_fileinput.py https://github.com/python/cpython/pull/13221/files#diff-2da06245ca0365d3e54acc241032eb0292ec13577f7384a1dfed8ec414531b6c
2019-05-09-13-18-09.bpo-36865.sCr099.rst https://github.com/python/cpython/pull/13221/files#diff-9913209f0328eaf82357f1176ce46debfa4350f84461562eacb2552476796ff7
Doc/library/fileinput.rsthttps://github.com/python/cpython/pull/13221/files#diff-614040aa0aa44d250bec985f117dde17adffb8d47c176784e0cc775e48d004a5
View file https://github.com/natgaertner/cpython/blob/6cd1ae72f1c4a13da913f0c1c1de9759243adb31/Doc/library/fileinput.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/13221/{{ revealButtonHref }}
https://github.com/python/cpython/pull/13221/files#diff-614040aa0aa44d250bec985f117dde17adffb8d47c176784e0cc775e48d004a5
https://github.com/python/cpython/pull/13221/files#diff-614040aa0aa44d250bec985f117dde17adffb8d47c176784e0cc775e48d004a5
Lib/fileinput.pyhttps://github.com/python/cpython/pull/13221/files#diff-12e480fbf7f53af3020ff003894175735fffdc263ba9680dde66de17c6abcdff
View file https://github.com/natgaertner/cpython/blob/6cd1ae72f1c4a13da913f0c1c1de9759243adb31/Lib/fileinput.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/13221/{{ revealButtonHref }}
https://github.com/python/cpython/pull/13221/files#diff-12e480fbf7f53af3020ff003894175735fffdc263ba9680dde66de17c6abcdff
https://github.com/python/cpython/pull/13221/files#diff-12e480fbf7f53af3020ff003894175735fffdc263ba9680dde66de17c6abcdff
https://github.com/python/cpython/pull/13221/files#diff-12e480fbf7f53af3020ff003894175735fffdc263ba9680dde66de17c6abcdff
https://github.com/python/cpython/pull/13221/files#diff-12e480fbf7f53af3020ff003894175735fffdc263ba9680dde66de17c6abcdff
https://github.com/python/cpython/pull/13221/files#diff-12e480fbf7f53af3020ff003894175735fffdc263ba9680dde66de17c6abcdff
Lib/test/test_fileinput.pyhttps://github.com/python/cpython/pull/13221/files#diff-2da06245ca0365d3e54acc241032eb0292ec13577f7384a1dfed8ec414531b6c
View file https://github.com/natgaertner/cpython/blob/6cd1ae72f1c4a13da913f0c1c1de9759243adb31/Lib/test/test_fileinput.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/13221/{{ revealButtonHref }}
https://github.com/python/cpython/pull/13221/files#diff-2da06245ca0365d3e54acc241032eb0292ec13577f7384a1dfed8ec414531b6c
https://github.com/python/cpython/pull/13221/files#diff-2da06245ca0365d3e54acc241032eb0292ec13577f7384a1dfed8ec414531b6c
https://github.com/python/cpython/pull/13221/files#diff-2da06245ca0365d3e54acc241032eb0292ec13577f7384a1dfed8ec414531b6c
https://github.com/python/cpython/pull/13221/files#diff-2da06245ca0365d3e54acc241032eb0292ec13577f7384a1dfed8ec414531b6c
Misc/NEWS.d/next/Library/2019-05-09-13-18-09.bpo-36865.sCr099.rsthttps://github.com/python/cpython/pull/13221/files#diff-9913209f0328eaf82357f1176ce46debfa4350f84461562eacb2552476796ff7
View file https://github.com/natgaertner/cpython/blob/6cd1ae72f1c4a13da913f0c1c1de9759243adb31/Misc/NEWS.d/next/Library/2019-05-09-13-18-09.bpo-36865.sCr099.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/13221/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.