René's URL Explorer Experiment


Title: bpo-36859: Use sqlite3_stmt_readonly API when possible to determine if statement is DML.K by coleifer · Pull Request #13216 · python/cpython · GitHub

Open Graph Title: bpo-36859: Use sqlite3_stmt_readonly API when possible to determine if statement is DML.K by coleifer · Pull Request #13216 · python/cpython

X Title: bpo-36859: Use sqlite3_stmt_readonly API when possible to determine if statement is DML.K by coleifer · Pull Request #13216 · python/cpython

Description: Implements fix for https://bugs.python.org/issue36859 The stdlib sqlite3 module attempts to detect if a statement is data-modifying, which it currently does by stripping whitespace and looking at the start of the SQL string. There are numerous issues with this approach: If the sql string starts with a comment it is marked as not DML, even though it may be. Common table expressions can be used with INSERT/UPDATE/DELETE queries and will not be caught using the current logic. Possibly other stuff? In sqlite 3.7.11, the sqlite3_stmt_readonly API was added which implements this logic correctly. pysqlite has weeeird quirks with how it handles DDL (create/drop), which the above api correctly identifies as writing to the db, but for our purposes should not be considered DML. Same for begin exclusive and begin immediate transaction controls. So this patch: for old sqlite (prior to 3.7.11) the current behavior is retained, else use sqlite3_stmt_readonly instead and then be sure that we don't mark create/drop/begin as being data-modifying. adds tests. is backwards-compatible but more robust Sqlite docs for sqlite3_stmt_readonly. https://bugs.python.org/issue36859

Open Graph Description: Implements fix for https://bugs.python.org/issue36859 The stdlib sqlite3 module attempts to detect if a statement is data-modifying, which it currently does by stripping whitespace and looking at t...

X Description: Implements fix for https://bugs.python.org/issue36859 The stdlib sqlite3 module attempts to detect if a statement is data-modifying, which it currently does by stripping whitespace and looking at t...

Opengraph URL: https://github.com/python/cpython/pull/13216

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:08f8b5b0-e130-b7de-cb09-18bada1d3819
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBA64:E3F0D:C3E66B:FF00C8:696AFE4B
html-safe-nonceff7d8c809fe06562b16b9db1ee83211408b68b9bd88649f156fe0538e4e85448
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTY0OkUzRjBEOkMzRTY2QjpGRjAwQzg6Njk2QUZFNEIiLCJ2aXNpdG9yX2lkIjoiNjgxMjAxOTA1NjA4OTY5Mzc3MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacfd30365ea00750782d2f64367c56d800bcd8358ca0c3d75595b70af5b4ac78b9
hovercard-subject-tagpull_request:277244283
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/13216/files
twitter:imagehttps://avatars.githubusercontent.com/u/119974?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/119974?s=400&v=4
og:image:altImplements fix for https://bugs.python.org/issue36859 The stdlib sqlite3 module attempts to detect if a statement is data-modifying, which it currently does by stripping whitespace and looking at t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/13216/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13216%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13216%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/13216/files
Reloadhttps://github.com/python/cpython/pull/13216/files
Reloadhttps://github.com/python/cpython/pull/13216/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/13216/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/13216/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
coleiferhttps://github.com/coleifer
python:masterhttps://github.com/python/cpython/tree/master
Conversation 41 https://github.com/python/cpython/pull/13216
Commits 9 https://github.com/python/cpython/pull/13216/commits
Checks 0 https://github.com/python/cpython/pull/13216/checks
Files changed https://github.com/python/cpython/pull/13216/files
Please reload this pagehttps://github.com/python/cpython/pull/13216/files
bpo-36859: Use sqlite3_stmt_readonly API when possible to determine if statement is DML.K https://github.com/python/cpython/pull/13216/files#top
Show all changes 9 commits https://github.com/python/cpython/pull/13216/files
c51aab0 Use sqlite3_stmt_readonly API to determine is statement is DML. coleifer May 9, 2019 https://github.com/python/cpython/pull/13216/commits/c51aab0baa236e15dd01aba9633200106b37f1ad
aa42615 Skip dml detection + sql comment for old sqlite. coleifer May 9, 2019 https://github.com/python/cpython/pull/13216/commits/aa42615e137da81f22160e167b20813192e37993
56dc71b Add news item. coleifer May 9, 2019 https://github.com/python/cpython/pull/13216/commits/56dc71bf71640787f13be190039a0c656fc61092
d54ce97 Address review comments, additional regression test. coleifer May 9, 2019 https://github.com/python/cpython/pull/13216/commits/d54ce97f34d2a6c59a8997d602cc8f1e15e8def1
afb7b6c Fix rest markup berkerpeksag May 9, 2019 https://github.com/python/cpython/pull/13216/commits/afb7b6cb3e09e0a46cdc97a75f11653373e2a3da
cc49a97 cosmetic fixes berkerpeksag May 9, 2019 https://github.com/python/cpython/pull/13216/commits/cc49a97449ad7fb6475e5af2da5681690e5b619f
8b1cced Ensure all non-DML statements that write are covered. coleifer May 9, 2019 https://github.com/python/cpython/pull/13216/commits/8b1cceda1f92723f749da4e79632f163859416e5
3ab2ba8 Move DML detection tests into transactions test module. coleifer May 10, 2019 https://github.com/python/cpython/pull/13216/commits/3ab2ba86f55426374f2781654d34317882025240
6667caa Fix version-check for sqlite3_stmt_readonly availability. coleifer May 11, 2019 https://github.com/python/cpython/pull/13216/commits/6667caa2903b7c531d1846f9db6e19a20432b913
Clear filters https://github.com/python/cpython/pull/13216/files
Please reload this pagehttps://github.com/python/cpython/pull/13216/files
Please reload this pagehttps://github.com/python/cpython/pull/13216/files
transactions.py https://github.com/python/cpython/pull/13216/files#diff-a0a1684650b6b9670b19c658d50a3dd72a3c905a17e03debfeb04d3877eb34ed
2019-05-09-09-54-00.bpo-36859.CuCkEd.rst https://github.com/python/cpython/pull/13216/files#diff-b23e2964d70ce2d3722b8ea6e692c027ae8e968010603dcde1514dd21b7f1c41
statement.c https://github.com/python/cpython/pull/13216/files#diff-517a9c73ccad12dd55f0beb930416fee87cade1b2abbb84a73ed8e39cc696c39
Lib/sqlite3/test/transactions.pyhttps://github.com/python/cpython/pull/13216/files#diff-a0a1684650b6b9670b19c658d50a3dd72a3c905a17e03debfeb04d3877eb34ed
View file https://github.com/python/cpython/blob/6667caa2903b7c531d1846f9db6e19a20432b913/Lib/sqlite3/test/transactions.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/13216/{{ revealButtonHref }}
https://github.com/python/cpython/pull/13216/files#diff-a0a1684650b6b9670b19c658d50a3dd72a3c905a17e03debfeb04d3877eb34ed
https://github.com/python/cpython/pull/13216/files#diff-a0a1684650b6b9670b19c658d50a3dd72a3c905a17e03debfeb04d3877eb34ed
https://github.com/python/cpython/pull/13216/files#diff-a0a1684650b6b9670b19c658d50a3dd72a3c905a17e03debfeb04d3877eb34ed
Misc/NEWS.d/next/Library/2019-05-09-09-54-00.bpo-36859.CuCkEd.rsthttps://github.com/python/cpython/pull/13216/files#diff-b23e2964d70ce2d3722b8ea6e692c027ae8e968010603dcde1514dd21b7f1c41
View file https://github.com/python/cpython/blob/6667caa2903b7c531d1846f9db6e19a20432b913/Misc/NEWS.d/next/Library/2019-05-09-09-54-00.bpo-36859.CuCkEd.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/13216/{{ revealButtonHref }}
Modules/_sqlite/statement.chttps://github.com/python/cpython/pull/13216/files#diff-517a9c73ccad12dd55f0beb930416fee87cade1b2abbb84a73ed8e39cc696c39
View file https://github.com/python/cpython/blob/6667caa2903b7c531d1846f9db6e19a20432b913/Modules/_sqlite/statement.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/13216/{{ revealButtonHref }}
https://github.com/python/cpython/pull/13216/files#diff-517a9c73ccad12dd55f0beb930416fee87cade1b2abbb84a73ed8e39cc696c39
https://github.com/python/cpython/pull/13216/files#diff-517a9c73ccad12dd55f0beb930416fee87cade1b2abbb84a73ed8e39cc696c39
Please reload this pagehttps://github.com/python/cpython/pull/13216/files
https://github.com/python/cpython/pull/13216/files#diff-517a9c73ccad12dd55f0beb930416fee87cade1b2abbb84a73ed8e39cc696c39
https://github.com/python/cpython/pull/13216/files#diff-517a9c73ccad12dd55f0beb930416fee87cade1b2abbb84a73ed8e39cc696c39
https://github.com/python/cpython/pull/13216/files#diff-517a9c73ccad12dd55f0beb930416fee87cade1b2abbb84a73ed8e39cc696c39
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.