René's URL Explorer Experiment


Title: gh-128182: Switch `ctypes` to solely critical sections by ZeroIntensity · Pull Request #132133 · python/cpython · GitHub

Open Graph Title: gh-128182: Switch `ctypes` to solely critical sections by ZeroIntensity · Pull Request #132133 · python/cpython

X Title: gh-128182: Switch `ctypes` to solely critical sections by ZeroIntensity · Pull Request #132133 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Removes the LOCK_PTR/UNLOCK_PTR macros, and fixes two races related to missing locks. Issue: ctypes pointer writes are not thread safe #128182

X Description: Removes the LOCK_PTR/UNLOCK_PTR macros, and fixes two races related to missing locks. Issue: ctypes pointer writes are not thread safe #128182

Opengraph URL: https://github.com/python/cpython/pull/132133

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c4eb482e-569b-f245-a39a-e8699617d578
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBA8E:2A98A:A64E59:D16531:6B023182
html-safe-nonce341a88ffa7f3d4bbef4f978578243f6bfc1c0ed643f32cfde8c6d4accee6f011
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQThFOjJBOThBOkE2NEU1OTpEMTY1MzE6NkIwMjMxODIiLCJ2aXNpdG9yX2lkIjoiODk2NzgyMjE4NDYxNzc1MDkxNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca742d6f49148c88665192eeb42aadc204cacd3dc6694a7ae43bed63da31bdc3e
hovercard-subject-tagpull_request:2441229462
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/132133/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7fb714af01fbee8e1fd5e30037b16f9ceaf924c1846ec9554f78bf0e6ac31d48/python/cpython/pull/132133
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7fb714af01fbee8e1fd5e30037b16f9ceaf924c1846ec9554f78bf0e6ac31d48/python/cpython/pull/132133
og:image:altRemoves the LOCK_PTR/UNLOCK_PTR macros, and fixes two races related to missing locks. Issue: ctypes pointer writes are not thread safe #128182
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameZeroIntensity
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/132133#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F132133
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F132133
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/132133
Reloadhttps://github.com/python/cpython/pull/132133
Reloadhttps://github.com/python/cpython/pull/132133
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
kumaraditya303https://github.com/kumaraditya303
python:mainhttps://github.com/python/cpython/tree/main
ZeroIntensity:ctypes-critical-sectionshttps://github.com/ZeroIntensity/cpython/tree/ctypes-critical-sections
Conversationhttps://github.com/python/cpython/pull/132133
Commits11 (11)https://github.com/python/cpython/pull/132133/commits
Checkshttps://github.com/python/cpython/pull/132133/checks
Files changedhttps://github.com/python/cpython/pull/132133/files
gh-128182: Switch ctypes to solely critical sectionshttps://github.com/python/cpython/pull/132133#top
kumaraditya303https://github.com/kumaraditya303
python:mainhttps://github.com/python/cpython/tree/main
ZeroIntensity:ctypes-critical-sectionshttps://github.com/ZeroIntensity/cpython/tree/ctypes-critical-sections
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
Apr 5, 2025https://github.com/python/cpython/pull/132133#issue-2974320309
Please reload this pagehttps://github.com/python/cpython/pull/132133
ctypes pointer writes are not thread safe #128182https://github.com/python/cpython/issues/128182
Please reload this pagehttps://github.com/python/cpython/pull/132133
ZeroIntensityhttps://github.com/ZeroIntensity
April 5, 2025 12:02https://github.com/python/cpython/pull/132133#commits-pushed-81f2e2b
https://github.com/ZeroIntensity
Remove LOCK_PTR()/UNLOCK_PTR() macros and fix data races.https://github.com/python/cpython/pull/132133/commits/81f2e2b1dba93336a6be3425e41dbacb2a0352bd
81f2e2bhttps://github.com/python/cpython/pull/132133/commits/81f2e2b1dba93336a6be3425e41dbacb2a0352bd
https://github.com/ZeroIntensity
Fix typos.https://github.com/python/cpython/pull/132133/commits/7457b2816af90b26503c979268b2c66521b62e80
7457b28https://github.com/python/cpython/pull/132133/commits/7457b2816af90b26503c979268b2c66521b62e80
https://github.com/ZeroIntensity
Fix build warnings.https://github.com/python/cpython/pull/132133/commits/30fdda39e215bc128fc1e3072b179c385486b841
30fdda3https://github.com/python/cpython/pull/132133/commits/30fdda39e215bc128fc1e3072b179c385486b841
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
topic-ctypes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-ctypes
topic-free-threading https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-free-threading
Apr 5, 2025https://github.com/python/cpython/pull/132133#event-17140509784
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
kumaraditya303https://github.com/kumaraditya303
April 5, 2025 16:14https://github.com/python/cpython/pull/132133#event-17140509796
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Apr 5, 2025https://github.com/python/cpython/pull/132133#event-17140509922
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Apr 5, 2025 https://github.com/python/cpython/pull/132133#ref-issue-2754722630
ctypes pointer writes are not thread safe #128182 https://github.com/python/cpython/issues/128182
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Apr 5, 2025 https://github.com/python/cpython/pull/132133#pullrequestreview-2744956485
View reviewed changes https://github.com/python/cpython/pull/132133/files/30fdda39e215bc128fc1e3072b179c385486b841
Modules/_ctypes/_ctypes.chttps://github.com/python/cpython/pull/132133/files/30fdda39e215bc128fc1e3072b179c385486b841#diff-402bc51df93eaaca2e2f2551ec0206d8af190722ae4703c178554b565d7c14b4
picnixzhttps://github.com/picnixz
Apr 5, 2025https://github.com/python/cpython/pull/132133#discussion_r2029934606
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/132133
kumaraditya303https://github.com/kumaraditya303
Apr 6, 2025https://github.com/python/cpython/pull/132133#discussion_r2030097556
Please reload this pagehttps://github.com/python/cpython/pull/132133
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/132133
Modules/_ctypes/_ctypes.chttps://github.com/python/cpython/pull/132133/files/30fdda39e215bc128fc1e3072b179c385486b841#diff-402bc51df93eaaca2e2f2551ec0206d8af190722ae4703c178554b565d7c14b4
picnixzhttps://github.com/picnixz
Apr 5, 2025https://github.com/python/cpython/pull/132133#discussion_r2029934868
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/132133
ZeroIntensityhttps://github.com/ZeroIntensity
Apr 7, 2025https://github.com/python/cpython/pull/132133#discussion_r2031018420
Please reload this pagehttps://github.com/python/cpython/pull/132133
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/132133
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
Apr 6, 2025https://github.com/python/cpython/pull/132133#issuecomment-2781355404
cpython/Modules/_ctypes/_ctypes.chttps://github.com/python/cpython/blob/0a10b45dd16a8c971363d917b9ebd1266e65f710/Modules/_ctypes/_ctypes.c#L2218
0a10b45https://github.com/python/cpython/commit/0a10b45dd16a8c971363d917b9ebd1266e65f710
Please reload this pagehttps://github.com/python/cpython/pull/132133
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
Apr 6, 2025https://github.com/python/cpython/pull/132133#issuecomment-2781362974
Please reload this pagehttps://github.com/python/cpython/pull/132133
https://github.com/apps/python-cla-bot
python-cla-bothttps://github.com/apps/python-cla-bot
Apr 6, 2025https://github.com/python/cpython/pull/132133#issuecomment-2781436612
https://cla.python.org/
Please reload this pagehttps://github.com/python/cpython/pull/132133
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
Apr 7, 2025 https://github.com/python/cpython/pull/132133#pullrequestreview-2746388564
View reviewed changes https://github.com/python/cpython/pull/132133/files/30fdda39e215bc128fc1e3072b179c385486b841
kumaraditya303https://github.com/kumaraditya303
https://github.com/python/cpython/pull/132133#pullrequestreview-2746388564
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/132133
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Apr 7, 2025https://github.com/python/cpython/pull/132133#event-17151309310
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Apr 7, 2025https://github.com/python/cpython/pull/132133#issuecomment-2782903959
Please reload this pagehttps://github.com/python/cpython/pull/132133
ZeroIntensityhttps://github.com/ZeroIntensity
April 7, 2025 06:59https://github.com/python/cpython/pull/132133#commits-pushed-4c773dd
https://github.com/ZeroIntensity
Fix merge conflicts.https://github.com/python/cpython/pull/132133/commits/4c773dd06faa57630383797c58fcf47f3e73da49
4c773ddhttps://github.com/python/cpython/pull/132133/commits/4c773dd06faa57630383797c58fcf47f3e73da49
https://github.com/ZeroIntensity
Add a lock to StructUnionType_paramfunchttps://github.com/python/cpython/pull/132133/commits/cdeb279fc15ac1db236e4e6e4640dc1f2c0c5eb9
cdeb279https://github.com/python/cpython/pull/132133/commits/cdeb279fc15ac1db236e4e6e4640dc1f2c0c5eb9
https://github.com/ZeroIntensity
Lock not needed.https://github.com/python/cpython/pull/132133/commits/7b5120151e6d18236b17147bfd7a42c3835112b0
7b51201https://github.com/python/cpython/pull/132133/commits/7b5120151e6d18236b17147bfd7a42c3835112b0
https://github.com/ZeroIntensity
Remove some more locked_memcpy()https://github.com/python/cpython/pull/132133/commits/a17024c0d8c7ef0aaf5ee705f58da97f0345497e
a17024chttps://github.com/python/cpython/pull/132133/commits/a17024c0d8c7ef0aaf5ee705f58da97f0345497e
https://github.com/ZeroIntensity
Remove usage of locked_deref_assign()https://github.com/python/cpython/pull/132133/commits/2652de2b78ab25ad71945d523b07a773a0895e43
2652de2https://github.com/python/cpython/pull/132133/commits/2652de2b78ab25ad71945d523b07a773a0895e43
https://github.com/ZeroIntensity
Remove AC-replaced function.https://github.com/python/cpython/pull/132133/commits/95231de6e221d22f4a9abbf44aba8c901e4657b0
95231dehttps://github.com/python/cpython/pull/132133/commits/95231de6e221d22f4a9abbf44aba8c901e4657b0
https://github.com/ZeroIntensity
Add _Py_CRITICAL_SECTION_ASSERT_OBJECT_LOCKED()https://github.com/python/cpython/pull/132133/commits/3af4f9e043d7855c71ad40543ccabb5ecb1f68a3
3af4f9ehttps://github.com/python/cpython/pull/132133/commits/3af4f9e043d7855c71ad40543ccabb5ecb1f68a3
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
Apr 7, 2025https://github.com/python/cpython/pull/132133#issuecomment-2782990130
Please reload this pagehttps://github.com/python/cpython/pull/132133
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting change review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20change%20review%22
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
Apr 7, 2025https://github.com/python/cpython/pull/132133#event-17151806192
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Apr 7, 2025https://github.com/python/cpython/pull/132133#issuecomment-2782990305
@kumaraditya303https://github.com/kumaraditya303
Please reload this pagehttps://github.com/python/cpython/pull/132133
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
kumaraditya303https://github.com/kumaraditya303
April 7, 2025 11:24https://github.com/python/cpython/pull/132133#event-17151806788
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
Apr 7, 2025 https://github.com/python/cpython/pull/132133#pullrequestreview-2746510335
View reviewed changes https://github.com/python/cpython/pull/132133/files/3af4f9e043d7855c71ad40543ccabb5ecb1f68a3
Modules/_ctypes/_ctypes.chttps://github.com/python/cpython/pull/132133/files/3af4f9e043d7855c71ad40543ccabb5ecb1f68a3#diff-402bc51df93eaaca2e2f2551ec0206d8af190722ae4703c178554b565d7c14b4
Please reload this pagehttps://github.com/python/cpython/pull/132133
https://github.com/kumaraditya303
remove lock from get containerhttps://github.com/python/cpython/pull/132133/commits/dcdc517c85b8ca33295dc9e6033925917a92d3d9
dcdc517https://github.com/python/cpython/pull/132133/commits/dcdc517c85b8ca33295dc9e6033925917a92d3d9
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
Apr 7, 2025 https://github.com/python/cpython/pull/132133#pullrequestreview-2746932108
View reviewed changes https://github.com/python/cpython/pull/132133/files/dcdc517c85b8ca33295dc9e6033925917a92d3d9
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting change review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20change%20review%22
Apr 7, 2025https://github.com/python/cpython/pull/132133#event-17154320377
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
8e260b3https://github.com/python/cpython/commit/8e260b384aad1910e12b68981cd8390919184d5d
Apr 7, 2025https://github.com/python/cpython/pull/132133#event-17156979649
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Apr 7, 2025https://github.com/python/cpython/pull/132133#event-17156980577
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F132133
https://github.com/picnixz
picnixz https://github.com/picnixz
https://github.com/python/cpython/pull/132133/files/30fdda39e215bc128fc1e3072b179c385486b841
https://github.com/kumaraditya303
kumaraditya303 https://github.com/kumaraditya303
https://github.com/python/cpython/pull/132133/files/3af4f9e043d7855c71ad40543ccabb5ecb1f68a3
Please reload this pagehttps://github.com/python/cpython/pull/132133
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
topic-ctypes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-ctypes
topic-free-threading https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-free-threading
Please reload this pagehttps://github.com/python/cpython/pull/132133
https://github.com/ZeroIntensity
https://github.com/kumaraditya303
https://github.com/picnixz
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.